{"id":2198116,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2198116/?format=json","project":{"id":8,"url":"http://patchwork.ozlabs.org/api/1.0/projects/8/?format=json","name":"Linux ext4 filesystem development","link_name":"linux-ext4","list_id":"linux-ext4.vger.kernel.org","list_email":"linux-ext4@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260219114645.778338-4-me@linux.beauty>","date":"2026-02-19T11:46:44","name":"[v2,3/3] ocfs2: use READ_ONCE for lockless jinode reads","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ec516e6e8fe00867d7494e3de861cdbc99423e69","submitter":{"id":84264,"url":"http://patchwork.ozlabs.org/api/1.0/people/84264/?format=json","name":"Li Chen","email":"me@linux.beauty"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ext4/patch/20260219114645.778338-4-me@linux.beauty/mbox/","series":[{"id":492665,"url":"http://patchwork.ozlabs.org/api/1.0/series/492665/?format=json","date":"2026-02-19T11:46:41","name":"jbd2/ext4/ocfs2: lockless jinode dirty range","version":2,"mbox":"http://patchwork.ozlabs.org/series/492665/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2198116/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ext4@vger.kernel.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","patchwork-incoming@ozlabs.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.beauty header.i=me@linux.beauty\n header.a=rsa-sha256 header.s=zmail header.b=uHjDFTJC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org;\n envelope-from=srs0=mizj=ax=vger.kernel.org=linux-ext4+bounces-13746-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)","gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=172.232.135.74\n arc.chain=\"subspace.kernel.org:zohomail.com\"","gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.beauty","gandalf.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.beauty header.i=me@linux.beauty\n header.a=rsa-sha256 header.s=zmail header.b=uHjDFTJC;\n\tdkim-atps=neutral","gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-13746-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=linux.beauty header.i=me@linux.beauty\n header.b=\"uHjDFTJC\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=136.143.188.15","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.beauty","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.beauty"],"Received":["from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGs902cbrz1xvg\n\tfor ; Thu, 19 Feb 2026 22:48:52 +1100 (AEDT)","from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4fGs9027S5z4w1v\n\tfor ; Thu, 19 Feb 2026 22:48:52 +1100 (AEDT)","by gandalf.ozlabs.org (Postfix)\n\tid 4fGs901zNnz4w8w; Thu, 19 Feb 2026 22:48:52 +1100 (AEDT)","from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4fGs8w44H6z4w1v\n\tfor ; Thu, 19 Feb 2026 22:48:48 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id F31FD300C033\n\tfor ; Thu, 19 Feb 2026 11:48:45 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B7FE4309F0E;\n\tThu, 19 Feb 2026 11:48:44 +0000 (UTC)","from sender4-op-o15.zoho.com (sender4-op-o15.zoho.com\n [136.143.188.15])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 78A0C2EFD86;\n\tThu, 19 Feb 2026 11:48:43 +0000 (UTC)","by mx.zohomail.com with SMTPS id 1771501631889417.86051371374174;\n\tThu, 19 Feb 2026 03:47:11 -0800 (PST)"],"ARC-Seal":["i=3; a=rsa-sha256; d=ozlabs.org; s=201707; t=1771501732; cv=pass;\n\tb=CK4gAC6sc3bWFvJZJwMYA9N+mdb+GUNcUdcOb9fNaYgYu9wUe+anNcuplnWRn/iP88HdiakXqQWD4Z2RV2rq4yV1v5zhECNBnS7GFexAmGtr69tLxBHakac16jl+pnJDj1/+84baZKH4+91lNDVJPuLKkd2k1yzJcv1n/CspR4MW3FnXNsOfqqup1I32pkzXChS+oSvQS7gKFOK18XQOE6nHNKgh/vvyVD95O+fmZPHdu+ag57TbyqYhhhklvQ4VavyLm4Hk5cBxr2XlDAa0L1Gh6xmAmzMjPdLV2T700F6EJbHdSq8DP0itD+uY+jI1E0z4Z+1lsJFN2xurZ0IwNg==","i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1771501724; cv=pass;\n b=Q+Noz7E4w/JxaIN2btNhfiL2Iqt9mPMfNM56LfqjfT73QU5aRyWs2kwnJLZb5e/MQWkawpXL5Nh1FBqcaGPwWYbaMGwdEgyIvaGHVAfsOMqO9+WEogpuqSzGWfdGSWAnWxGt+UX7Zbz+I0Jjkny/g+cD4T+eZvUA00fPDFYoAw8=","i=1; a=rsa-sha256; t=1771501635; cv=none;\n\td=zohomail.com; s=zohoarc;\n\tb=gFmDLIurtCV9KCk1gesLCuIsfht03Sw5CnA1yZ8FRF7/uTK5V8FfgE/IarrGSowqoCDFFKFum7Rn3GwWsH1IWlI5Rgi2RE7MDa08Lm9BGeLpSDed9UBwD6xQP4ik+GhcJNK0TGJ6YOMUK2je91RwPs4a/ilnAHq36dIZee8UQpQ="],"ARC-Message-Signature":["i=3; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1771501732; c=relaxed/relaxed;\n\tbh=jHr6qDvYQBYJ6pu78kQ622LP38rOaq+qs2VRyLTnZ1Q=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=d1yJ5eXBffblSJKvOg5aQPaviuHg4pUSQra0ES68cOFp/gRUQ4caYq8TGTct92PVFrnrd8GBeFnlsUt/z8sufN2zQd3/atljBba85usW+6OkNLsS01Ek1ONdwaIPiAjETUjdzZE7lJ1aYXAbevmzwB3e3KkHpFpW+g2YEDNpHjEwiQFgZqgkDKg2BbFjLpZCf+4QzbhU437aqw3vrWelT7TVYR5xckMMMNAzbetsy0Epb5pRdsesaev2qODhx86xWBvd1SnGiy26s2XDEn3kKVaNi3APSI39x+VbG4ZkVL80iJ1KNDTwZAxoFmo/r4dxzf1WWbz3El4kbs284ycPmg==","i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1771501724; c=relaxed/simple;\n\tbh=7uauTrROlWykBC94taT0BGToFqvysHQ/njaCYo9qwM4=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=sntOvZKOnzdDUgFaiBpp/R9JG+hzVPpNK18nXTmyXZgIdcDB5AfdtHNgajbzDuKv6RtJvegz6vit0wT0mRK25Ys2MrVBYiAUf08QlP5hlJgX+t3kkHB6pvBXzZlziWUWFDb0E9jI0vwyZXj3oZBOEt+hNwxctmSwWq7GpOikTNM=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;\n s=zohoarc;\n\tt=1771501635;\n h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=jHr6qDvYQBYJ6pu78kQ622LP38rOaq+qs2VRyLTnZ1Q=;\n\tb=BFhpBeBvBQgy1uhUWIkEutQVn5cADLyHcs+YSafSKYC0JXd9hJzItpCfr1LYCdA3TeKxBlOi4/Vb8K3qOg5s8FgVFIRDu6brIAP2aspfdQPXzuoSrxUmjLGl7CmzYJklUxJz3XOWHtMk2jtnv1u8AQCGYHeIh/Hhgt8GNRdTCog="],"ARC-Authentication-Results":["i=3; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.beauty;\n dkim=pass (1024-bit key;\n unprotected) header.d=linux.beauty header.i=me@linux.beauty\n header.a=rsa-sha256 header.s=zmail header.b=uHjDFTJC; dkim-atps=neutral;\n spf=pass (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-ext4+bounces-13746-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org","i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.beauty;\n spf=pass smtp.mailfrom=linux.beauty;\n dkim=pass (1024-bit key) header.d=linux.beauty header.i=me@linux.beauty\n header.b=uHjDFTJC; arc=pass smtp.client-ip=136.143.188.15","i=1; mx.zohomail.com;\n\tdkim=pass header.i=linux.beauty;\n\tspf=pass smtp.mailfrom=me@linux.beauty;\n\tdmarc=pass header.from="],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1771501635;\n\ts=zmail; d=linux.beauty; i=me@linux.beauty;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=jHr6qDvYQBYJ6pu78kQ622LP38rOaq+qs2VRyLTnZ1Q=;\n\tb=uHjDFTJCD4QJ8SLZNMU1nUwd7V9rE4qSi7/EsyBl7rZ3O8lWs9d6KI781BPGBiYE\n\tFkbxsELUgy9DZY2i1ny2m3AjpWLgaJikES4f6MvqzF6sIhRVbZIkfy148Cr+PMdmxo/\n\tiKw7+TIGwkfVdqC/gmsEl/fxbideshZ9VkiJkr2I=","From":"Li Chen ","To":"Theodore Ts'o ,\n\tJan Kara ,\n\tMark Fasheh ,\n\tlinux-ext4@vger.kernel.org,\n\tocfs2-devel@lists.linux.dev,\n\tMatthew Wilcox ,\n\tJoel Becker ,\n\tJoseph Qi ,\n\tlinux-kernel@vger.kernel.org","Cc":"Li Chen ","Subject":"[PATCH v2 3/3] ocfs2: use READ_ONCE for lockless jinode reads","Date":"Thu, 19 Feb 2026 19:46:44 +0800","Message-ID":"<20260219114645.778338-4-me@linux.beauty>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260219114645.778338-1-me@linux.beauty>","References":"<20260219114645.778338-1-me@linux.beauty>","Precedence":"bulk","X-Mailing-List":"linux-ext4@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-ZohoMailClient":"External","X-Spam-Status":"No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tHEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org"},"content":"ocfs2 journal commit callback reads jbd2_inode dirty range fields without\nholding journal->j_list_lock.\n\nUse READ_ONCE() for these reads to match the lockless access pattern.\nConvert the dirty range from PAGE_SIZE units back to byte offsets before\npassing it to writeback.\n\nSuggested-by: Jan Kara \nSigned-off-by: Li Chen \n---\nChanges since v1:\n- Convert the jinode dirty range from PAGE_SIZE units (pgoff_t) back to byte\n offsets before passing it to writeback.\n\n fs/ocfs2/journal.c | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)","diff":"diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c\nindex 85239807dec7..0b40383ebcdf 100644\n--- a/fs/ocfs2/journal.c\n+++ b/fs/ocfs2/journal.c\n@@ -902,8 +902,17 @@ int ocfs2_journal_alloc(struct ocfs2_super *osb)\n \n static int ocfs2_journal_submit_inode_data_buffers(struct jbd2_inode *jinode)\n {\n-\treturn filemap_fdatawrite_range(jinode->i_vfs_inode->i_mapping,\n-\t\t\tjinode->i_dirty_start, jinode->i_dirty_end);\n+\tstruct address_space *mapping = jinode->i_vfs_inode->i_mapping;\n+\tpgoff_t dirty_start = READ_ONCE(jinode->i_dirty_start);\n+\tpgoff_t dirty_end = READ_ONCE(jinode->i_dirty_end);\n+\tloff_t start_byte, end_byte;\n+\n+\tif (dirty_end == JBD2_INODE_DIRTY_RANGE_NONE)\n+\t\treturn 0;\n+\tstart_byte = (loff_t)dirty_start << PAGE_SHIFT;\n+\tend_byte = ((loff_t)dirty_end << PAGE_SHIFT) + PAGE_SIZE - 1;\n+\n+\treturn filemap_fdatawrite_range(mapping, start_byte, end_byte);\n }\n \n int ocfs2_journal_init(struct ocfs2_super *osb, int *dirty)\n","prefixes":["v2","3/3"]}