{"id":2198034,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2198034/?format=json","project":{"id":13,"url":"http://patchwork.ozlabs.org/api/1.0/projects/13/?format=json","name":"Linux IDE development","link_name":"linux-ide","list_id":"linux-ide.vger.kernel.org","list_email":"linux-ide@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260219062312.1030867-4-dlemoal@kernel.org>","date":"2026-02-19T06:23:10","name":"[3/5] ata: libata-scsi: simplify ata_scsi_schedule_deferred_qc()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8487602185797a13fd6ef848ff53ff5402f6f165","submitter":{"id":86188,"url":"http://patchwork.ozlabs.org/api/1.0/people/86188/?format=json","name":"Damien Le Moal","email":"dlemoal@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ide/patch/20260219062312.1030867-4-dlemoal@kernel.org/mbox/","series":[{"id":492640,"url":"http://patchwork.ozlabs.org/api/1.0/series/492640/?format=json","date":"2026-02-19T06:23:07","name":"libata cleanups","version":1,"mbox":"http://patchwork.ozlabs.org/series/492640/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2198034/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=I+oKBC0G;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ide+bounces-5018-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"I+oKBC0G\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGk3N20rwz1xpl\n\tfor ; Thu, 19 Feb 2026 17:28:32 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 87DEC300ECAD\n\tfor ; Thu, 19 Feb 2026 06:28:29 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 423522DC339;\n\tThu, 19 Feb 2026 06:28:29 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 200F42F3C0A\n\tfor ; Thu, 19 Feb 2026 06:28:29 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 91763C2BC86;\n\tThu, 19 Feb 2026 06:28:28 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1771482509; cv=none;\n b=lLLDEW96/eFYKDqR86mReyZPl0pMAMJ5r9CoCCVm1Wx8VyA0HqnkiKSoYaqhHldfpmtbXQlcsqDXmLZKgyWixmKCdiD5ZdPqbk0IYWX6Ga0CEsAH+CX45XbyWI7/v3OONPLhOKP5vXOJ9EkDBfn9clhkoBBIYoVHjhMff9aa9ZI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1771482509; c=relaxed/simple;\n\tbh=RHNmtSOYEKIgjrmT8zS//+DLM1oTVW1fC9n5Q+tTpog=;\n\th=From:To:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=fJ/ccnBG6C+qOqeKdLmY/MW0s+FfFflizhtl1FUgIf2yfCcT0/5mrQWJnhjmWin/xqCaesEC4sVmkdDXbzAsAQvCsoXfGZWAzlEh3XTpuJmPmAP98qVfg8kNR7Q86FzFiryJ2CcjPdpKht+8UcpTse0SKCnXWXJ0fzXI91j5b0E=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=I+oKBC0G; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1771482508;\n\tbh=RHNmtSOYEKIgjrmT8zS//+DLM1oTVW1fC9n5Q+tTpog=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=I+oKBC0G5yuw7fA5Wsj4yHyH8yMAvIGerPkXdpyu/D3pbgDSPEFCl3qI0ZjyMMNgv\n\t t4kc6+3JKMiooc3XaNhD1TrH6X2g3k5wupgPlblIaOwR+LQXnwWUpD4w4q5nHN6Pi0\n\t sWxehC40plEciiz1HiyN5+bd7PgyVS8p5bF0IFHsyKrzEq43Pln/Qum7fm9JJF/KyL\n\t jYh9gPW7RrB7oYQrQq7y0A15RAQ+BL5qb2+X1SbFVncfFnksvZrVJ4lSw6wG1HRaEG\n\t 7pgC7+eKlWtITakFmwtbhW9TV4OCX6qewNnbh0svfwGX5jTxtP9+SAFmYen8kggKOd\n\t iuQCazrDou8yA==","From":"Damien Le Moal ","To":"linux-ide@vger.kernel.org,\n\tNiklas Cassel ","Subject":"[PATCH 3/5] ata: libata-scsi: simplify\n ata_scsi_schedule_deferred_qc()","Date":"Thu, 19 Feb 2026 15:23:10 +0900","Message-ID":"<20260219062312.1030867-4-dlemoal@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260219062312.1030867-1-dlemoal@kernel.org>","References":"<20260219062312.1030867-1-dlemoal@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Use ata_qc_done() instead of calling ata_qc_free() and scsi_done()\ndirectly.\n\nSigned-off-by: Damien Le Moal \n---\n drivers/ata/libata-scsi.c | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)","diff":"diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c\nindex c0dd75a0287c..41918e21d0f8 100644\n--- a/drivers/ata/libata-scsi.c\n+++ b/drivers/ata/libata-scsi.c\n@@ -1685,7 +1685,6 @@ void ata_scsi_deferred_qc_work(struct work_struct *work)\n void ata_scsi_requeue_deferred_qc(struct ata_port *ap)\n {\n \tstruct ata_queued_cmd *qc = ap->deferred_qc;\n-\tstruct scsi_cmnd *scmd;\n \n \tlockdep_assert_held(ap->lock);\n \n@@ -1697,11 +1696,9 @@ void ata_scsi_requeue_deferred_qc(struct ata_port *ap)\n \tif (!qc)\n \t\treturn;\n \n-\tscmd = qc->scsicmd;\n \tap->deferred_qc = NULL;\n-\tata_qc_free(qc);\n-\tscmd->result = (DID_SOFT_ERROR << 16);\n-\tscsi_done(scmd);\n+\tqc->scsicmd->result = (DID_SOFT_ERROR << 16);\n+\tata_qc_done(qc);\n }\n \n static void ata_scsi_schedule_deferred_qc(struct ata_port *ap)\n","prefixes":["3/5"]}