{"id":2198032,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2198032/?format=json","project":{"id":13,"url":"http://patchwork.ozlabs.org/api/1.0/projects/13/?format=json","name":"Linux IDE development","link_name":"linux-ide","list_id":"linux-ide.vger.kernel.org","list_email":"linux-ide@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260219062312.1030867-3-dlemoal@kernel.org>","date":"2026-02-19T06:23:09","name":"[2/5] ata: libata-sata: simplify ata_sas_queuecmd()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cde26755151bcff6c85cfce996d22d1728ff1aa2","submitter":{"id":86188,"url":"http://patchwork.ozlabs.org/api/1.0/people/86188/?format=json","name":"Damien Le Moal","email":"dlemoal@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-ide/patch/20260219062312.1030867-3-dlemoal@kernel.org/mbox/","series":[{"id":492640,"url":"http://patchwork.ozlabs.org/api/1.0/series/492640/?format=json","date":"2026-02-19T06:23:07","name":"libata cleanups","version":1,"mbox":"http://patchwork.ozlabs.org/series/492640/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2198032/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=C8sT8j3g;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ide+bounces-5017-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"C8sT8j3g\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGk3M54fvz1xxQ\n\tfor ; Thu, 19 Feb 2026 17:28:31 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id D56303025297\n\tfor ; Thu, 19 Feb 2026 06:28:28 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id AB52C2F547F;\n\tThu, 19 Feb 2026 06:28:28 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 898AE2F3C37\n\tfor ; Thu, 19 Feb 2026 06:28:28 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id EAAB9C4CEF7;\n\tThu, 19 Feb 2026 06:28:27 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1771482508; cv=none;\n b=aflAG7gT0TkzuA9MIY2XcDN1u4jPpLH1lAA4i4tsjJ3SIxKuhkmWMXtVypjYGMK44KHe3GgbyIH373HKOlPCgSLRWN4Jb/VDByzam67WFCkhooYwbRKxdfEoS6WlRGPCDCCgJ7FMqEe5ENBew0ol61O2o6DMzXU2JhWh2TE8Nj0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1771482508; c=relaxed/simple;\n\tbh=IMPCA4kaMMH/o8PU4a3UoKwUomBxVwvmz5ibV9rN3I4=;\n\th=From:To:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=J6lDlHpCMS19T0lQD4a3R03hlMcugMYZPV21e/XZpLv6rMoM+87xvSQMf1Kr3tSJq0llB8f5BvCb9BfUNxteMzeKxBS3nEnpWji9JubQfhl18KKHPGbXbTPr9KNXwj/S/SdjJMadwXh3qduuanw4/p84jhlmXbnxSgI+1GKRb+M=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=C8sT8j3g; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1771482508;\n\tbh=IMPCA4kaMMH/o8PU4a3UoKwUomBxVwvmz5ibV9rN3I4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=C8sT8j3g+a+JmmPgWVa0lWA9TLNSkQngI1HYsYKE+A+0le3Tga2C17TGeFofz3TLX\n\t W0AnVVr4HUUfzfBnxYwwASgYHYYuR7MhGnIzesSuzno0rqSyt9V0pa2oWilacpriir\n\t PymD8McKU64KHElB9l/JM0iXYXTnWsd1QvdN332mgx6p2pRqYwstSNHUlv/HOrAlC7\n\t ZxFpZy1O1pwDe6I0MYsoigHz7npcWVXzHooVkZnVb848zz/GDIUNxJ09+4EWUgED0V\n\t CbDSDHgBiAP6pO8+2chRyO6AQLhtIVOqnNAbd6LAQ0e0NgRhv9fy9NLNuaQKYgW6mK\n\t tQo+NfiHzmI6A==","From":"Damien Le Moal ","To":"linux-ide@vger.kernel.org,\n\tNiklas Cassel ","Subject":"[PATCH 2/5] ata: libata-sata: simplify ata_sas_queuecmd()","Date":"Thu, 19 Feb 2026 15:23:09 +0900","Message-ID":"<20260219062312.1030867-3-dlemoal@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260219062312.1030867-1-dlemoal@kernel.org>","References":"<20260219062312.1030867-1-dlemoal@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Change ata_sas_queuecmd() to return early the result of\n__ata_scsi_queuecmd() and remove the rc local variable.\nThis simplifies the code without any functional change.\n\nSigned-off-by: Damien Le Moal \n---\n drivers/ata/libata-sata.c | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c\nindex 04e1e774645e..00f7e5443e3d 100644\n--- a/drivers/ata/libata-sata.c\n+++ b/drivers/ata/libata-sata.c\n@@ -1378,15 +1378,13 @@ EXPORT_SYMBOL_GPL(ata_sas_sdev_configure);\n \n int ata_sas_queuecmd(struct scsi_cmnd *cmd, struct ata_port *ap)\n {\n-\tint rc = 0;\n-\n \tif (likely(ata_dev_enabled(ap->link.device)))\n-\t\trc = __ata_scsi_queuecmd(cmd, ap->link.device);\n-\telse {\n-\t\tcmd->result = (DID_BAD_TARGET << 16);\n-\t\tscsi_done(cmd);\n-\t}\n-\treturn rc;\n+\t\treturn __ata_scsi_queuecmd(cmd, ap->link.device);\n+\n+\tcmd->result = (DID_BAD_TARGET << 16);\n+\tscsi_done(cmd);\n+\n+\treturn 0;\n }\n EXPORT_SYMBOL_GPL(ata_sas_queuecmd);\n \n","prefixes":["2/5"]}