{"id":2197995,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197995/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219040150.2098396-8-pierrick.bouvier@linaro.org>","date":"2026-02-19T04:01:43","name":"[v4,07/14] tcg: move tcg_use_softmmu to tcg/tcg-internal.h","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"523c85649f27e9ba62133f6637faa40944dac45a","submitter":{"id":85798,"url":"http://patchwork.ozlabs.org/api/1.0/people/85798/?format=json","name":"Pierrick Bouvier","email":"pierrick.bouvier@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219040150.2098396-8-pierrick.bouvier@linaro.org/mbox/","series":[{"id":492635,"url":"http://patchwork.ozlabs.org/api/1.0/series/492635/?format=json","date":"2026-02-19T04:01:36","name":"target/arm: single-binary","version":4,"mbox":"http://patchwork.ozlabs.org/series/492635/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197995/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ysYNwZXv;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGfsJ2HJlz1xpY\n\tfor ; Thu, 19 Feb 2026 15:04:36 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsvFL-0008U2-6I; Wed, 18 Feb 2026 23:02:35 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsvF6-0008OR-R4\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 23:02:20 -0500","from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1vsvF3-0001EU-D4\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 23:02:20 -0500","by mail-pl1-x636.google.com with SMTP id\n d9443c01a7336-2a963f49234so1761725ad.1\n for ; Wed, 18 Feb 2026 20:02:17 -0800 (PST)","from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2ad1a73200asm147636225ad.36.2026.02.18.20.02.15\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 18 Feb 2026 20:02:15 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771473736; x=1772078536; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=VA/qlQJvE8uq8B0wfP8QzURuC1Jx2blScgULUKFJUFo=;\n b=ysYNwZXvvUkAVLpk3NZdUulGXdczpr4CgAxgzvWik42ehTAoOXBFATpyXZjhHWEWAg\n bSLCPrf9F30qbTTrnGvi4VxzbxYzVDoRLuEvH2qbmxdfnc8H4Y818Bkl1J53XoN0hAhz\n Gj1xR9cG3Bd7R+UdgA86aVF2VQvHP7aDKe5wavLEdH6Q05AOaJvOONmu+YWyvwTKBpN+\n HBJbvCQzOT7bL9eQEsKPvGfmqe7B2TxHWWPNndyMTRQAUSlY5HmloDrQOMNgscBqSpQm\n z0x3gSQEv298tgUZBbKIo4WzlaWUZTwXfKFZYrm27/7IREUXtEY6V682QK1clqW0WXGG\n Ku1Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771473736; x=1772078536;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=VA/qlQJvE8uq8B0wfP8QzURuC1Jx2blScgULUKFJUFo=;\n b=XR7VSQij8w/yaDu1kTJKaORcohvkPwffWCt03+4dlgL14nffhmP1uEch8LWfhQWqtD\n 5uuAyRGoJhBOyzNgImmH5ngIPDV7SRhXCPC06DRL3LJTW6Iy+ryla4A89tUemkmEt0DD\n pI9/aJKYA5Fm92tNGKnp5qGbgVgc4fwUFEFndXM7gPT7ymd9YEGBag4TqGbSV8dfhFw8\n VtvpLYRWBiZ2c1i8XZBg8Z0hTJ+TR+hw3vSmlKDkP9vxfTj73pvI/tFp9qg2bJuUY1Fx\n NjK5alGjIuZk0hQgUcdfvJYinpkvn/HHbp+PgW3Am8/JXGlH3rZAhAeOJo68cIKocs/l\n j3gQ==","X-Gm-Message-State":"AOJu0Yz7rRN2N0sZrGPmtwjcbDjUhVKXfIh5MBIJ+M3315bCrfyistat\n NIqWeERIYWQuteG7u8hzdPDmqlFF7aAsZunxjTO0gm/UOkHGUOkwVEXdJS6SVvdWIJbHVGio1k3\n T/YKL","X-Gm-Gg":"AZuq6aL0T+LOv9eFgjcm64Lm6lbcDJRCueK7YtUO8q+UE0TGKDmRqil2TtLLgmJHwBD\n usL/0Ccb5VF3MSNwU+5ooqivjvYu/plR79tlJk0EwBA4BPLvFqtLNdEILjdtIx4JnVyVUL0fWMo\n KEc7wCaM/HDzGaQo4n4WR4enRj09DL3mVjxv9RtuLPKED0B6SC7zUFWhsV1tkHAFdCLCjYa2uPK\n g3C3LQ87aS3yFvR9M3zSwIrUE+qvhnV2ZzoIS523n9Fw1CkoCRGOdI8ksM4dVnUc3+3E4cr/R+m\n u98KtZdTcTSaM6a5icN31J8pjWNX2pCPK3NF7UKSu9e+/P+Q0yeZjUp4/6JHm0zhqD9wpR29AbS\n lpFtobfjm+KyBpP/aoXh3exh7Z7E9jdATYGRGpXGA03/dLZKQzds0+Q5aaEesSLtChLenoQB67f\n XTyc8IUcFS0OnsoVU+M75IfW4HUnPfKkXKFPdJZd6ILqS8qoAVspNyqlENaFxSIE5Ufi49bHPIJ\n RIz","X-Received":"by 2002:a17:903:320e:b0:2a9:5c0b:e5f4 with SMTP id\n d9443c01a7336-2ab505c0e87mr162715635ad.28.1771473735974;\n Wed, 18 Feb 2026 20:02:15 -0800 (PST)","From":"Pierrick Bouvier ","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Pierrick Bouvier ,\n Paolo Bonzini , qemu-arm@nongnu.org,\n kvm@vger.kernel.org, Richard Henderson ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , anjo@rev.ng,\n Peter Maydell ,\n Jim MacArthur ","Subject":"[PATCH v4 07/14] tcg: move tcg_use_softmmu to tcg/tcg-internal.h","Date":"Wed, 18 Feb 2026 20:01:43 -0800","Message-ID":"<20260219040150.2098396-8-pierrick.bouvier@linaro.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260219040150.2098396-1-pierrick.bouvier@linaro.org>","References":"<20260219040150.2098396-1-pierrick.bouvier@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::636;\n envelope-from=pierrick.bouvier@linaro.org; helo=mail-pl1-x636.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"In next commit, we'll apply same helper pattern for base helpers\nremaining.\n\nOur new helper pattern always include helper-*-common.h, which ends up\nincluding include/tcg/tcg.h, which contains one occurrence of\nCONFIG_USER_ONLY.\nThus, common files not being duplicated between system and target\nrelying on helpers will fail to compile. Existing occurrences are:\n- target/arm/tcg/arith_helper.c\n- target/arm/tcg/crypto_helper.c\n\nThis occurrence of CONFIG_USER_ONLY is for defining variable\ntcg_use_softmmu, and we rely on dead code elimination with it in various\ntcg-target.c.inc.\n\nThus, move its definition to tcg/tcg-internal.h, so helpers can be\nincluded by common files. Also, change it to a define, as it has fixed\nvalues for now.\n\nReviewed-by: Richard Henderson \nSigned-off-by: Pierrick Bouvier \n---\n include/tcg/tcg.h | 6 ------\n tcg/tcg-internal.h | 6 ++++++\n tcg/tcg.c | 4 ----\n 3 files changed, 6 insertions(+), 10 deletions(-)","diff":"diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h\nindex 60942ce05c2..45c7e118c3d 100644\n--- a/include/tcg/tcg.h\n+++ b/include/tcg/tcg.h\n@@ -445,12 +445,6 @@ static inline bool temp_readonly(TCGTemp *ts)\n return ts->kind >= TEMP_FIXED;\n }\n \n-#ifdef CONFIG_USER_ONLY\n-extern bool tcg_use_softmmu;\n-#else\n-#define tcg_use_softmmu true\n-#endif\n-\n extern __thread TCGContext *tcg_ctx;\n extern const void *tcg_code_gen_epilogue;\n extern uintptr_t tcg_splitwx_diff;\ndiff --git a/tcg/tcg-internal.h b/tcg/tcg-internal.h\nindex 2cbfb5d5caa..26156846120 100644\n--- a/tcg/tcg-internal.h\n+++ b/tcg/tcg-internal.h\n@@ -34,6 +34,12 @@ extern TCGContext **tcg_ctxs;\n extern unsigned int tcg_cur_ctxs;\n extern unsigned int tcg_max_ctxs;\n \n+#ifdef CONFIG_USER_ONLY\n+#define tcg_use_softmmu false\n+#else\n+#define tcg_use_softmmu true\n+#endif\n+\n void tcg_region_init(size_t tb_size, int splitwx, unsigned max_threads);\n bool tcg_region_alloc(TCGContext *s);\n void tcg_region_initial_alloc(TCGContext *s);\ndiff --git a/tcg/tcg.c b/tcg/tcg.c\nindex e7bf4dad4ee..3111e1f4265 100644\n--- a/tcg/tcg.c\n+++ b/tcg/tcg.c\n@@ -236,10 +236,6 @@ static TCGAtomAlign atom_and_align_for_opc(TCGContext *s, MemOp opc,\n MemOp host_atom, bool allow_two_ops)\n __attribute__((unused));\n \n-#ifdef CONFIG_USER_ONLY\n-bool tcg_use_softmmu;\n-#endif\n-\n TCGContext tcg_init_ctx;\n __thread TCGContext *tcg_ctx;\n \n","prefixes":["v4","07/14"]}