{"id":2197991,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197991/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219040150.2098396-4-pierrick.bouvier@linaro.org>","date":"2026-02-19T04:01:39","name":"[v4,03/14] target/arm: extract helper-mve.h from helper.h","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"39ae45344bc2b89be9b9a9c0a0ff1bffb6249863","submitter":{"id":85798,"url":"http://patchwork.ozlabs.org/api/1.0/people/85798/?format=json","name":"Pierrick Bouvier","email":"pierrick.bouvier@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260219040150.2098396-4-pierrick.bouvier@linaro.org/mbox/","series":[{"id":492635,"url":"http://patchwork.ozlabs.org/api/1.0/series/492635/?format=json","date":"2026-02-19T04:01:36","name":"target/arm: single-binary","version":4,"mbox":"http://patchwork.ozlabs.org/series/492635/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197991/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=jubqbz5C;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGfr51wcBz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 19 Feb 2026 15:03:33 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vsvFD-0008R2-OZ; Wed, 18 Feb 2026 23:02:27 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1vsvF4-0008MA-6q\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 23:02:18 -0500","from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>)\n id 1vsvEz-0001DO-8B\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 23:02:17 -0500","by mail-pl1-x62b.google.com with SMTP id\n d9443c01a7336-2a7a9b8ed69so4162255ad.2\n for <qemu-devel@nongnu.org>; Wed, 18 Feb 2026 20:02:12 -0800 (PST)","from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2ad1a73200asm147636225ad.36.2026.02.18.20.02.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 18 Feb 2026 20:02:11 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771473732; x=1772078532; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ZBh+fW1mApPtLG6aGnrKPAIWmAmzNuN5929rjSWR418=;\n b=jubqbz5CatuhHK8bQ74J/CFroNI+AdO0ysG2eVHg7AxEvc30juLYDAgp6YlaaLt0SE\n RRNs3oenEIdaMccQmLIvPYsd0L2mkwgPbn/v4arTkuoM6h8uCvbyPfVT5NHv3ZGcCvsx\n BZbUTD5Cotdw58oHoLuEDzMDuQ6jbCFWiRlFqpsmx9VBXbmmc/Y4LYqhTic8x7xwmH7Y\n J0NC+VFl3yUxO772wLZ+HhytVNBdqSFuiNPekgCesG/wV0yJMph2gwqv74F3q3jkghWY\n xGPGUWYrIrZVn2RdaQYf7QvYnr5Xczo6W4inhslfoAckq0WddPe8/DanMg6ZLZK6n6pN\n Ytpw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771473732; x=1772078532;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ZBh+fW1mApPtLG6aGnrKPAIWmAmzNuN5929rjSWR418=;\n b=Z2xslFMdTd3h2kNIlOtsDlC2ekl7gxqnzKfq8n1ZYTiHiSj8snX6MHU8HOBbKq8n4V\n 95wB2Pau6MPIsTisgcb8oJ+efn37ErAv3HLu1dPuqvbPI3UVAfUwfsRvtr6EpQGXLp5p\n ifgdI9yC1yBeOTr4ckwjYu0lAXIyfBJ+/R4xviMKGjYPo1HB/C5y9zeJ172zqxA9RXWZ\n vaCsC9924sYXq8WSGhfS8LyLUsQ0PlIXM39AgeuZ9KGLSCKGPjUzoxLZNxd37VmYieFm\n rcfo6bwDM8uBUkmpeyZlCjWslC960wbkJob3fcKlNHD71lPZc+CGLK7v6XT5BgQ1ElOx\n fjxQ==","X-Gm-Message-State":"AOJu0YzAlPGDd1B4r7Mdf/MQ4ujsSDE8GUFjjhMMSOnVebbXe3x3A/6/\n Klne9pDXusHGHV2aN2Lf7ZUBBK8KMPFh4LDbsVLIzdU0Oz/cvr6SIkAs36lcyYbD2fJW1lBNut4\n LXO3O","X-Gm-Gg":"AZuq6aKBx2FxUcL9WB6ru+ZvtaBUImTW9O4M/mx/AiEIX2dnonPPO8/X4tVcsGgUT5f\n i7N9E6CQtZhT085tTI1+o9doSv/abiKP0nIq1yVEyQMlcbj/ZaPGDn5rOcrh1YYsZjuUH9GI7n7\n G0hmAN86k5uoChMLIuR1lFulKny7BlF4uN/3043aaeDPJPzp4GSK0nthwPaLy/fvtntv9rGZMhz\n 6PrZEPTS+cwCopWetJu4TuN4ovYzlOuEdr84U1NL2kawYm61czwq3GIrB1V1jUE42VerJRpLMTS\n saqFuaVDaupoT8YXAnpuvgSYCz/7YIQ/b8Bw+ZmnVTBp6pxWXSpq4ObTsXnVMZy9zAL1Bsq2qNM\n UvM6IumfWsDkSyFiru+NnWqpV0NF/Jt6dcKr8/tyY3qlx9PQHCTfwCegbnDeZ6If5QV6Dm85AE0\n 1LuSKxVOW+K+xZg6DaNBv4kevS76Vi0jo+i8ZJMWrx2JcxN4YbvLQsBacWjaPhz+LUhf53JyTy3\n jvM","X-Received":"by 2002:a17:903:46cc:b0:2a9:48ce:b5f5 with SMTP id\n d9443c01a7336-2ad50f8e23cmr33186185ad.51.1771473731894;\n Wed, 18 Feb 2026 20:02:11 -0800 (PST)","From":"Pierrick Bouvier <pierrick.bouvier@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Paolo Bonzini <pbonzini@redhat.com>, qemu-arm@nongnu.org,\n kvm@vger.kernel.org, Richard Henderson <richard.henderson@linaro.org>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>, anjo@rev.ng,\n Peter Maydell <peter.maydell@linaro.org>,\n Jim MacArthur <jim.macarthur@linaro.org>","Subject":"[PATCH v4 03/14] target/arm: extract helper-mve.h from helper.h","Date":"Wed, 18 Feb 2026 20:01:39 -0800","Message-ID":"<20260219040150.2098396-4-pierrick.bouvier@linaro.org>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260219040150.2098396-1-pierrick.bouvier@linaro.org>","References":"<20260219040150.2098396-1-pierrick.bouvier@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::62b;\n envelope-from=pierrick.bouvier@linaro.org; helo=mail-pl1-x62b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"A few points to mention:\n- We mix helper prototypes and gen_helper definitions in a single header\nfor convenience and to avoid headers boilerplate.\n- We rename existing tcg/helper-mve.h to helper-mve-defs.h to avoid\nconflict when including helper-mve.h.\n- We move mve helper_info definitions to tcg/mve_helper.c\n\nWe'll repeat the same for other helpers.\nThis allow to get rid of TARGET_AARCH64 in target/arm/helper.h.\n\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\n---\n target/arm/helper-mve.h                            | 14 ++++++++++++++\n target/arm/helper.h                                |  2 --\n target/arm/tcg/{helper-mve.h => helper-mve-defs.h} |  0\n target/arm/tcg/mve_helper.c                        |  4 ++++\n target/arm/tcg/translate-mve.c                     |  1 +\n target/arm/tcg/translate.c                         |  1 +\n 6 files changed, 20 insertions(+), 2 deletions(-)\n create mode 100644 target/arm/helper-mve.h\n rename target/arm/tcg/{helper-mve.h => helper-mve-defs.h} (100%)","diff":"diff --git a/target/arm/helper-mve.h b/target/arm/helper-mve.h\nnew file mode 100644\nindex 00000000000..32ef3f64661\n--- /dev/null\n+++ b/target/arm/helper-mve.h\n@@ -0,0 +1,14 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+\n+#ifndef HELPER_MVE_H\n+#define HELPER_MVE_H\n+\n+#include \"exec/helper-proto-common.h\"\n+#include \"exec/helper-gen-common.h\"\n+\n+#define HELPER_H \"tcg/helper-mve-defs.h\"\n+#include \"exec/helper-proto.h.inc\"\n+#include \"exec/helper-gen.h.inc\"\n+#undef HELPER_H\n+\n+#endif /* HELPER_MVE_H */\ndiff --git a/target/arm/helper.h b/target/arm/helper.h\nindex f340a49a28a..44c7f3ed751 100644\n--- a/target/arm/helper.h\n+++ b/target/arm/helper.h\n@@ -7,5 +7,3 @@\n #include \"tcg/helper-sve.h\"\n #include \"tcg/helper-sme.h\"\n #endif\n-\n-#include \"tcg/helper-mve.h\"\ndiff --git a/target/arm/tcg/helper-mve.h b/target/arm/tcg/helper-mve-defs.h\nsimilarity index 100%\nrename from target/arm/tcg/helper-mve.h\nrename to target/arm/tcg/helper-mve-defs.h\ndiff --git a/target/arm/tcg/mve_helper.c b/target/arm/tcg/mve_helper.c\nindex 63ddcf3fecf..f33642df1f9 100644\n--- a/target/arm/tcg/mve_helper.c\n+++ b/target/arm/tcg/mve_helper.c\n@@ -19,6 +19,7 @@\n \n #include \"qemu/osdep.h\"\n #include \"cpu.h\"\n+#include \"helper-mve.h\"\n #include \"internals.h\"\n #include \"vec_internal.h\"\n #include \"exec/helper-proto.h\"\n@@ -27,6 +28,9 @@\n #include \"fpu/softfloat.h\"\n #include \"crypto/clmul.h\"\n \n+#define HELPER_H \"tcg/helper-mve-defs.h\"\n+#include \"exec/helper-info.c.inc\"\n+\n static uint16_t mve_eci_mask(CPUARMState *env)\n {\n     /*\ndiff --git a/target/arm/tcg/translate-mve.c b/target/arm/tcg/translate-mve.c\nindex b1a8d6a65c0..4ca88f4d3a3 100644\n--- a/target/arm/tcg/translate-mve.c\n+++ b/target/arm/tcg/translate-mve.c\n@@ -18,6 +18,7 @@\n  */\n \n #include \"qemu/osdep.h\"\n+#include \"helper-mve.h\"\n #include \"translate.h\"\n #include \"translate-a32.h\"\n \ndiff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c\nindex c90b0106f75..580ec86c68c 100644\n--- a/target/arm/tcg/translate.c\n+++ b/target/arm/tcg/translate.c\n@@ -28,6 +28,7 @@\n #include \"cpregs.h\"\n #include \"exec/helper-proto.h\"\n #include \"exec/target_page.h\"\n+#include \"helper-mve.h\"\n \n #define HELPER_H \"helper.h\"\n #include \"exec/helper-info.c.inc\"\n","prefixes":["v4","03/14"]}