{"id":2197953,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197953/?format=json","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.0/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260218213501.136844-4-ebiggers@kernel.org>","date":"2026-02-18T21:34:49","name":"[03/15] crypto: arm64/aes - Fix 32-bit aes_mac_update() arg treated as 64-bit","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"240f224ac87cae41c79f96396e4f0218d4487149","submitter":{"id":74690,"url":"http://patchwork.ozlabs.org/api/1.0/people/74690/?format=json","name":"Eric Biggers","email":"ebiggers@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260218213501.136844-4-ebiggers@kernel.org/mbox/","series":[{"id":492621,"url":"http://patchwork.ozlabs.org/api/1.0/series/492621/?format=json","date":"2026-02-18T21:34:46","name":"AES-CMAC library","version":1,"mbox":"http://patchwork.ozlabs.org/series/492621/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197953/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ROUaJ6P8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-9444-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"ROUaJ6P8\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGVHJ2jQbz1xvS\n\tfor ; Thu, 19 Feb 2026 08:38:04 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id B75FD304F21A\n\tfor ; Wed, 18 Feb 2026 21:36:57 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E751831A572;\n\tWed, 18 Feb 2026 21:36:51 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C23ED314A76;\n\tWed, 18 Feb 2026 21:36:51 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 3932CC2BC9E;\n\tWed, 18 Feb 2026 21:36:51 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1771450611; cv=none;\n b=P/5o7hyBeHBA0As4ctVjIvNBv9pH/csJJw6ReMi3nWFBco57oXnPH9QEiZ8m+bH+S7HfcAX99CAyPYBkg0ia4LOKmF03NiESybtCUP/b9UzwdQesmmVitnNt8gvbHvjgjq40G6X67WYxJRWjjfKKN8W1VMFqaFJI+0daSnrvKsc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1771450611; c=relaxed/simple;\n\tbh=FLhIcGYigj/cYDh5+twKKz5F+F3mi/gUG7aJ/XLLfTA=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=esQhbKfweICcKC9mY7K9t0lrpnSKw0UjvntadSkvPjA6ZeL4clyKOUtgU1b3hZmYn4o+CdsXY8j/JJyhpSO/lMHpEHB70e4AqF9SsnQZL4zLTogGIFTKWPtw2Keexjwz4t/M6QIUE8JxvFSuYglzCtTrAsZAiJRSI0XaQxofFro=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=ROUaJ6P8; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1771450611;\n\tbh=FLhIcGYigj/cYDh5+twKKz5F+F3mi/gUG7aJ/XLLfTA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ROUaJ6P8UlCMN4JmpFGGTRSlivUcHoJGRc+eVoE6kP/DW5Y7YMNqs+roqftoa/gnV\n\t ZwDlrMQ693KOcLjlRIMUfS1y7sKUTH1zO1nkVWuEMZY2k2/91AidpDrJw9bPtC3dmR\n\t 5Udw//bK+DsZUsShJM42cHcB/ciYFKBaq2P+7hNLQSW+D7AVPNldf1i7qhy3dpdD7f\n\t gLSPjy1VBwRBR4kssZcgjCV6zH7OxxUqehvbY1cjcC50JWrcPh/ob9W6VyJ0qM73EB\n\t cdLoS5E4mBCqNz6ShijoHyLhAfTFL7bE0hPtEeWfjDZw/Kdnkwl8XU9BjxHr6DAXvp\n\t iH+hy7FYJaUYg==","From":"Eric Biggers ","To":"linux-crypto@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org,\n\tArd Biesheuvel ,\n\t\"Jason A . Donenfeld\" ,\n\tHerbert Xu ,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tlinux-wireless@vger.kernel.org,\n\tEric Biggers ,\n\tstable@vger.kernel.org","Subject":"[PATCH 03/15] crypto: arm64/aes - Fix 32-bit aes_mac_update() arg\n treated as 64-bit","Date":"Wed, 18 Feb 2026 13:34:49 -0800","Message-ID":"<20260218213501.136844-4-ebiggers@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260218213501.136844-1-ebiggers@kernel.org>","References":"<20260218213501.136844-1-ebiggers@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Since the 'enc_after' argument to neon_aes_mac_update() and\nce_aes_mac_update() has type 'int', it needs to be accessed using the\ncorresponding 32-bit register, not the 64-bit register. The upper half\nof the corresponding 64-bit register may contain garbage.\n\nFixes: 4860620da7e5 (\"crypto: arm64/aes - add NEON/Crypto Extensions CBCMAC/CMAC/XCBC driver\")\nCc: stable@vger.kernel.org\nSigned-off-by: Eric Biggers \n---\n arch/arm64/crypto/aes-modes.S | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/arch/arm64/crypto/aes-modes.S b/arch/arm64/crypto/aes-modes.S\nindex 0e834a2c062c..e793478f37c1 100644\n--- a/arch/arm64/crypto/aes-modes.S\n+++ b/arch/arm64/crypto/aes-modes.S\n@@ -836,11 +836,11 @@ AES_FUNC_START(aes_mac_update)\n \tencrypt_block\tv0, w2, x1, x7, w8\n \teor\t\tv0.16b, v0.16b, v3.16b\n \tencrypt_block\tv0, w2, x1, x7, w8\n \teor\t\tv0.16b, v0.16b, v4.16b\n \tcmp\t\tw3, wzr\n-\tcsinv\t\tx5, x6, xzr, eq\n+\tcsinv\t\tw5, w6, wzr, eq\n \tcbz\t\tw5, .Lmacout\n \tencrypt_block\tv0, w2, x1, x7, w8\n \tst1\t\t{v0.16b}, [x4]\t\t\t/* return dg */\n \tcond_yield\t.Lmacout, x7, x8\n \tb\t\t.Lmacloop4x\n@@ -850,11 +850,11 @@ AES_FUNC_START(aes_mac_update)\n \tcbz\t\tw3, .Lmacout\n \tld1\t\t{v1.16b}, [x0], #16\t\t/* get next pt block */\n \teor\t\tv0.16b, v0.16b, v1.16b\t\t/* ..and xor with dg */\n \n \tsubs\t\tw3, w3, #1\n-\tcsinv\t\tx5, x6, xzr, eq\n+\tcsinv\t\tw5, w6, wzr, eq\n \tcbz\t\tw5, .Lmacout\n \n .Lmacenc:\n \tencrypt_block\tv0, w2, x1, x7, w8\n \tb\t\t.Lmacloop\n","prefixes":["03/15"]}