{"id":2197939,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197939/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260218213416.674483-10-jsnow@redhat.com>","date":"2026-02-18T21:34:04","name":"[v8,09/20] tests: use \"run\" script to execute device-crash-test","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"032383f868c5d5476752436c52c95f52420ec189","submitter":{"id":64343,"url":"http://patchwork.ozlabs.org/api/1.0/people/64343/?format=json","name":"John Snow","email":"jsnow@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218213416.674483-10-jsnow@redhat.com/mbox/","series":[{"id":492619,"url":"http://patchwork.ozlabs.org/api/1.0/series/492619/?format=json","date":"2026-02-18T21:33:55","name":"python: drop qemu.qmp from qemu.git tree","version":8,"mbox":"http://patchwork.ozlabs.org/series/492619/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197939/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=SKRBuGl2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGVFN6vFJz1xvS\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 19 Feb 2026 08:36:24 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vspCt-0007wE-3T; Wed, 18 Feb 2026 16:35:39 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jsnow@redhat.com>) id 1vspCq-0007n9-Tt\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 16:35:36 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jsnow@redhat.com>) id 1vspCo-0002EQ-Gw\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 16:35:35 -0500","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-213-hL9NoCcqO5Cy3xeZBGRrKw-1; Wed,\n 18 Feb 2026 16:35:30 -0500","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 2B4F0195FDD5; Wed, 18 Feb 2026 21:35:28 +0000 (UTC)","from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.65.233])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 9E59E19560B5; Wed, 18 Feb 2026 21:35:21 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771450533;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=svwUZmFcXrxAz0z+6CagrgvUzVmfiLjUGUqEXIJFjak=;\n b=SKRBuGl2WlftNZ1SKI+P/lL0P8Oq7yViugZViv2cEUDrm4cQcUBZk+bYmnpTX43SJmTSvj\n GCgtYARv2OqJ0D+Pn96FOOK1dNwVDI8ZbKk4r371GvIlbgm37ZyoyHRkwj45bIys58k9p3\n odp9heJFzdIH6IvVUPqD11tpB7Kma6g=","X-MC-Unique":"hL9NoCcqO5Cy3xeZBGRrKw-1","X-Mimecast-MFC-AGG-ID":"hL9NoCcqO5Cy3xeZBGRrKw_1771450528","From":"John Snow <jsnow@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Kevin Wolf <kwolf@redhat.com>, Warner Losh <imp@bsdimp.com>,\n Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, =?utf-8?q?Marc-Andr?=\n\t=?utf-8?q?=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n qemu-block@nongnu.org,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>,\n Fabiano Rosas <farosas@suse.de>, John Snow <jsnow@redhat.com>,\n Michael Roth <michael.roth@amd.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>,\n Markus Armbruster <armbru@redhat.com>, Peter Xu <peterx@redhat.com>,\n Yonggang Luo <luoyonggang@gmail.com>, Hanna Reitz <hreitz@redhat.com>,\n Maksim Davydov <davydov-max@yandex-team.ru>, Thomas Huth <thuth@redhat.com>,\n Ed Maste <emaste@freebsd.org>, Alexandre Iooss <erdnaxe@crans.org>,\n Cleber Rosa <crosa@redhat.com>, Li-Wen Hsu <lwhsu@freebsd.org>,\n Mahmoud Mandour <ma.mandourr@gmail.com>, Kyle Evans <kevans@freebsd.org>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>","Subject":"[PATCH v8 09/20] tests: use \"run\" script to execute device-crash-test","Date":"Wed, 18 Feb 2026 16:34:04 -0500","Message-ID":"<20260218213416.674483-10-jsnow@redhat.com>","In-Reply-To":"<20260218213416.674483-1-jsnow@redhat.com>","References":"<20260218213416.674483-1-jsnow@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Instead of invoking python from the configure venv manually, instruct\ndevelopers to use the \"run\" script instead. Change the test invocation\nto be a good example going forward.\n\nSigned-off-by: John Snow <jsnow@redhat.com>\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nReviewed-by: Thomas Huth <thuth@redhat.com>\n---\n .gitlab-ci.d/buildtest.yml | 6 +++---\n scripts/device-crash-test  | 2 +-\n 2 files changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml\nindex 4c280dd29bc..b2db70ff904 100644\n--- a/.gitlab-ci.d/buildtest.yml\n+++ b/.gitlab-ci.d/buildtest.yml\n@@ -102,7 +102,7 @@ crash-test-debian:\n   script:\n     - cd build\n     - make NINJA=\":\" check-venv\n-    - pyvenv/bin/python3 scripts/device-crash-test -q --tcg-only ./qemu-system-i386\n+    - ./run scripts/device-crash-test -q --tcg-only ./qemu-system-i386\n \n build-system-fedora:\n   extends:\n@@ -159,8 +159,8 @@ crash-test-fedora:\n   script:\n     - cd build\n     - make NINJA=\":\" check-venv\n-    - pyvenv/bin/python3 scripts/device-crash-test -q ./qemu-system-ppc\n-    - pyvenv/bin/python3 scripts/device-crash-test -q ./qemu-system-riscv32\n+    - ./run scripts/device-crash-test -q ./qemu-system-ppc\n+    - ./run scripts/device-crash-test -q ./qemu-system-riscv32\n \n build-system-centos:\n   extends:\ndiff --git a/scripts/device-crash-test b/scripts/device-crash-test\nindex f97d9909c05..8a91dcaee31 100755\n--- a/scripts/device-crash-test\n+++ b/scripts/device-crash-test\n@@ -42,7 +42,7 @@ except ModuleNotFoundError as exc:\n     print(f\"Module '{exc.name}' not found.\")\n     print(\"  Try 'make check-venv' from your build directory,\")\n     print(\"  and then one way to run this script is like so:\")\n-    print(f'  > $builddir/pyvenv/bin/python3 \"{path}\"')\n+    print(f'  > $builddir/run \"{path}\"')\n     sys.exit(1)\n \n logger = logging.getLogger('device-crash-test')\n","prefixes":["v8","09/20"]}