{"id":2197890,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197890/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260218202829.1322088-13-vsementsov@yandex-team.ru>","date":"2026-02-18T20:28:28","name":"[v3,12/12] net/tap: net_init_tap(): relax QEMU hubs check","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d9db7f76ee7ca3750c9df8ff1877e055abffe9bf","submitter":{"id":84116,"url":"http://patchwork.ozlabs.org/api/1.0/people/84116/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@yandex-team.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218202829.1322088-13-vsementsov@yandex-team.ru/mbox/","series":[{"id":492602,"url":"http://patchwork.ozlabs.org/api/1.0/series/492602/?format=json","date":"2026-02-18T20:28:20","name":"net: refactoring and fixes","version":3,"mbox":"http://patchwork.ozlabs.org/series/492602/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197890/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=m4aUnT4f;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGSmz5cVHz1xwC\n\tfor ; Thu, 19 Feb 2026 07:30:11 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsoAV-0007Ga-3k; Wed, 18 Feb 2026 15:29:07 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsoA8-00075p-Vu\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 15:28:45 -0500","from forwardcorp1a.mail.yandex.net\n ([2a02:6b8:c0e:500:1:45:d181:df01])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsoA7-0007tj-Bl\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 15:28:44 -0500","from mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net\n [IPv6:2a02:6b8:c2d:3530:0:640:eca4:0])\n by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id 2292BC038D;\n Wed, 18 Feb 2026 23:28:42 +0300 (MSK)","from vsementsov-lin (unknown [2a02:6bf:8080:53d::1:1b])\n by mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net (smtpcorp/Yandex) with\n ESMTPSA id VShB144A8iE0-NPmEUsve; Wed, 18 Feb 2026 23:28:41 +0300"],"Precedence":"bulk","X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1771446521;\n bh=1uN4WvXdRNNARpB5HjLnfN38lT4cspiFjdLpr7Detyk=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=m4aUnT4fF6x8KBJBFEJBfsIm8ag45cX0CvMHgP6dNMawhMnCJF4sbJqmhS+PwXB7/\n V5Ok09yGN+/aqRgMxEXiFJoimX3qbzhy2zmK4Kvn442sv/U4ag6TXyprvS1G7kjVxk\n 6K0kdFuHf0JFHdZj5XmgLwbGK0qdqs8ZylGw378w=","From":"Vladimir Sementsov-Ogievskiy ","To":"jasowang@redhat.com","Cc":"qemu-devel@nongnu.org, bchaney@akamai.com, yc-core@yandex-team.ru,\n d-tatianin@yandex-team.ru, davydov-max@yandex-team.ru,\n vsementsov@yandex-team.ru","Subject":"[PATCH v3 12/12] net/tap: net_init_tap(): relax QEMU hubs check","Date":"Wed, 18 Feb 2026 23:28:28 +0300","Message-ID":"<20260218202829.1322088-13-vsementsov@yandex-team.ru>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260218202829.1322088-1-vsementsov@yandex-team.ru>","References":"<20260218202829.1322088-1-vsementsov@yandex-team.ru>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a02:6b8:c0e:500:1:45:d181:df01;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"queues may be set to 1, as well as fds may contain only one fd.\nNo reason to block such cases. Let's check exactly number of queues.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \n---\n net/tap.c | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)","diff":"diff --git a/net/tap.c b/net/tap.c\nindex 2318158adc..1623ddff5f 100644\n--- a/net/tap.c\n+++ b/net/tap.c\n@@ -868,13 +868,6 @@ int net_init_tap(const Netdev *netdev, const char *name,\n assert(netdev->type == NET_CLIENT_DRIVER_TAP);\n tap = &netdev->u.tap;\n \n- /* QEMU hubs do not support multiqueue tap, in this case peer is set.\n- * For -netdev, peer is always NULL. */\n- if (peer && (tap->has_queues || tap->fds || tap->vhostfds)) {\n- error_setg(errp, \"Multiqueue tap cannot be used with hubs\");\n- return -1;\n- }\n-\n if (tap->has_vhost && !tap->vhost && (tap->vhostfds || tap->vhostfd)) {\n error_setg(errp, \"vhostfd(s)= is not valid without vhost\");\n return -1;\n@@ -898,6 +891,15 @@ int net_init_tap(const Netdev *netdev, const char *name,\n return -1;\n }\n \n+ /*\n+ * QEMU hubs do not support multiqueue tap, in this case peer is set.\n+ * For -netdev, peer is always NULL.\n+ */\n+ if (peer && queues > 1) {\n+ error_setg(errp, \"Multiqueue tap cannot be used with hubs\");\n+ goto fail;\n+ }\n+\n if (!tap_parse_vhost_fds(tap, &vhost_fds, queues, errp)) {\n goto fail;\n }\n","prefixes":["v3","12/12"]}