{"id":2197885,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197885/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260218202829.1322088-8-vsementsov@yandex-team.ru>","date":"2026-02-18T20:28:23","name":"[v3,07/12] net/tap: net_init_tap_one(): drop model parameter","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"824f3df6753fdcc4e796f58a418fc84f6d845949","submitter":{"id":84116,"url":"http://patchwork.ozlabs.org/api/1.0/people/84116/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@yandex-team.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218202829.1322088-8-vsementsov@yandex-team.ru/mbox/","series":[{"id":492602,"url":"http://patchwork.ozlabs.org/api/1.0/series/492602/?format=json","date":"2026-02-18T20:28:20","name":"net: refactoring and fixes","version":3,"mbox":"http://patchwork.ozlabs.org/series/492602/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197885/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=OeGzIX65;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGSmR6RsFz1xwC\n\tfor ; Thu, 19 Feb 2026 07:29:43 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsoAL-00077C-4V; Wed, 18 Feb 2026 15:29:00 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsoA5-00075A-5v\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 15:28:42 -0500","from forwardcorp1a.mail.yandex.net\n ([2a02:6b8:c0e:500:1:45:d181:df01])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsoA3-0007sK-Mt\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 15:28:40 -0500","from mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net\n [IPv6:2a02:6b8:c2d:3530:0:640:eca4:0])\n by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id 3A22EC0390;\n Wed, 18 Feb 2026 23:28:38 +0300 (MSK)","from vsementsov-lin (unknown [2a02:6bf:8080:53d::1:1b])\n by mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net (smtpcorp/Yandex) with\n ESMTPSA id VShB144A8iE0-BTqabyzq; Wed, 18 Feb 2026 23:28:37 +0300"],"Precedence":"bulk","X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1771446517;\n bh=BDiEM5hFQxkhlp+sUNQkEBGuisXIqaX1d5OB08sKy8A=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=OeGzIX65okFHOG82icbCPBwoLhXTPft/ODqmFKVSiQP/vMdc6qigxu4CW1xyJV6vR\n b+na6eRXldrDyQlF4mHvI0P9OHJlrGSRXy1Bn3we6qlB4OGPooIgbFxsYlJji5wYhu\n /xcs5RLpQJjmHCwTdaIjnOuhsekgMe+jMgUQJ9pE=","From":"Vladimir Sementsov-Ogievskiy ","To":"jasowang@redhat.com","Cc":"qemu-devel@nongnu.org, bchaney@akamai.com, yc-core@yandex-team.ru,\n d-tatianin@yandex-team.ru, davydov-max@yandex-team.ru,\n vsementsov@yandex-team.ru","Subject":"[PATCH v3 07/12] net/tap: net_init_tap_one(): drop model parameter","Date":"Wed, 18 Feb 2026 23:28:23 +0300","Message-ID":"<20260218202829.1322088-8-vsementsov@yandex-team.ru>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260218202829.1322088-1-vsementsov@yandex-team.ru>","References":"<20260218202829.1322088-1-vsementsov@yandex-team.ru>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a02:6b8:c0e:500:1:45:d181:df01;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"It could be simply derived from tap parameter. And this change\nsimplifies further refactoring.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \n---\n net/tap.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/net/tap.c b/net/tap.c\nindex 2c5f8e73fe..db3fe380a4 100644\n--- a/net/tap.c\n+++ b/net/tap.c\n@@ -704,12 +704,13 @@ static int net_tap_init(const NetdevTapOptions *tap, int *vnet_hdr,\n #define MAX_TAP_QUEUES 1024\n \n static bool net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,\n- const char *model, const char *name,\n+ const char *name,\n const char *ifname, const char *script,\n const char *downscript, int vhostfd,\n int vnet_hdr, int fd, Error **errp)\n {\n- TAPState *s = net_tap_fd_init(peer, model, name, fd, vnet_hdr);\n+ TAPState *s = net_tap_fd_init(peer, tap->helper ? \"bridge\" : \"tap\",\n+ name, fd, vnet_hdr);\n bool sndbuf_required = tap->has_sndbuf;\n int sndbuf =\n (tap->has_sndbuf && tap->sndbuf) ? MIN(tap->sndbuf, INT_MAX) : INT_MAX;\n@@ -883,7 +884,7 @@ int net_init_tap(const Netdev *netdev, const char *name,\n goto fail;\n }\n \n- if (!net_init_tap_one(tap, peer, \"tap\", name, NULL,\n+ if (!net_init_tap_one(tap, peer, name, NULL,\n NULL, NULL,\n vhostfd, vnet_hdr, fd, errp)) {\n goto fail;\n@@ -934,7 +935,7 @@ int net_init_tap(const Netdev *netdev, const char *name,\n goto fail;\n }\n \n- if (!net_init_tap_one(tap, peer, \"tap\", name, ifname,\n+ if (!net_init_tap_one(tap, peer, name, ifname,\n NULL, NULL,\n vhostfd,\n vnet_hdr, fd, errp)) {\n@@ -957,7 +958,7 @@ int net_init_tap(const Netdev *netdev, const char *name,\n goto fail;\n }\n \n- if (!net_init_tap_one(tap, peer, \"bridge\", name, ifname,\n+ if (!net_init_tap_one(tap, peer, name, ifname,\n NULL, NULL, vhostfd,\n vnet_hdr, fd, errp)) {\n goto fail;\n@@ -988,7 +989,7 @@ int net_init_tap(const Netdev *netdev, const char *name,\n }\n }\n \n- if (!net_init_tap_one(tap, peer, \"tap\", name, ifname,\n+ if (!net_init_tap_one(tap, peer, name, ifname,\n i >= 1 ? NULL : script,\n i >= 1 ? NULL : downscript,\n vhostfd, vnet_hdr, fd, errp)) {\n","prefixes":["v3","07/12"]}