{"id":2197882,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197882/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260218202829.1322088-12-vsementsov@yandex-team.ru>","date":"2026-02-18T20:28:27","name":"[v3,11/12] net/tap: net_init_tap(): merge fd=, fds= and helper= cases into one","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"27f9dcf92be4f294cf8f1e424ca4bfad88cd04fe","submitter":{"id":84116,"url":"http://patchwork.ozlabs.org/api/1.0/people/84116/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@yandex-team.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218202829.1322088-12-vsementsov@yandex-team.ru/mbox/","series":[{"id":492602,"url":"http://patchwork.ozlabs.org/api/1.0/series/492602/?format=json","date":"2026-02-18T20:28:20","name":"net: refactoring and fixes","version":3,"mbox":"http://patchwork.ozlabs.org/series/492602/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197882/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=MZ3L/2Ge;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGSm36lkjz1xwC\n\tfor ; Thu, 19 Feb 2026 07:29:23 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsoAU-0007GP-EU; Wed, 18 Feb 2026 15:29:06 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsoA8-00075g-5d\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 15:28:45 -0500","from forwardcorp1a.mail.yandex.net ([178.154.239.72])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsoA6-0007tY-MR\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 15:28:43 -0500","from mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net\n [IPv6:2a02:6b8:c2d:3530:0:640:eca4:0])\n by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id 6C8E9C038C;\n Wed, 18 Feb 2026 23:28:41 +0300 (MSK)","from vsementsov-lin (unknown [2a02:6bf:8080:53d::1:1b])\n by mail-nwsmtp-smtp-corp-main-83.vla.yp-c.yandex.net (smtpcorp/Yandex) with\n ESMTPSA id VShB144A8iE0-4IIiAMgl; Wed, 18 Feb 2026 23:28:41 +0300"],"Precedence":"bulk","X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1771446521;\n bh=tdVLrrht22AdazOVmFV4FQPo+VPPK0JuvaulnDvvKJQ=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=MZ3L/2GeHBxmyGcUBxwxqMLfAj9D4dfSYr55jCEKdXgOhPLc8cE6Go17Bs+75DXnF\n Lfa42Wz/7Q3J6ZcU/Y/xivneVsVXzJtKJrFd3brx72CV6yYh4k9ZgrdjfvMia26CEn\n ENJX5pDqyf374TUb9hC0K+UNZAwiIN2Et+yxmSBI=","From":"Vladimir Sementsov-Ogievskiy ","To":"jasowang@redhat.com","Cc":"qemu-devel@nongnu.org, bchaney@akamai.com, yc-core@yandex-team.ru,\n d-tatianin@yandex-team.ru, davydov-max@yandex-team.ru,\n vsementsov@yandex-team.ru","Subject":"[PATCH v3 11/12] net/tap: net_init_tap(): merge fd=,\n fds= and helper= cases into one","Date":"Wed, 18 Feb 2026 23:28:27 +0300","Message-ID":"<20260218202829.1322088-12-vsementsov@yandex-team.ru>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260218202829.1322088-1-vsementsov@yandex-team.ru>","References":"<20260218202829.1322088-1-vsementsov@yandex-team.ru>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=178.154.239.72;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Now fd= and helper= cases are just a duplication of fds= case with\nqueues=1. Let's merge them all.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \n---\n net/tap.c | 26 +-------------------------\n 1 file changed, 1 insertion(+), 25 deletions(-)","diff":"diff --git a/net/tap.c b/net/tap.c\nindex 64164643d2..2318158adc 100644\n--- a/net/tap.c\n+++ b/net/tap.c\n@@ -902,19 +902,7 @@ int net_init_tap(const Netdev *netdev, const char *name,\n goto fail;\n }\n \n- if (tap->fd) {\n- vnet_hdr = tap_probe_vnet_hdr(fds[0], errp);\n- if (vnet_hdr < 0) {\n- goto fail;\n- }\n-\n- if (!net_init_tap_one(tap, peer, name, NULL,\n- NULL, NULL,\n- vhost_fds ? vhost_fds[0] : -1,\n- vnet_hdr, fds[0], errp)) {\n- goto fail;\n- }\n- } else if (tap->fds) {\n+ if (fds) {\n for (i = 0; i < queues; i++) {\n if (i == 0) {\n vnet_hdr = tap_probe_vnet_hdr(fds[i], errp);\n@@ -934,18 +922,6 @@ int net_init_tap(const Netdev *netdev, const char *name,\n goto fail;\n }\n }\n- } else if (tap->helper) {\n- vnet_hdr = tap_probe_vnet_hdr(fds[0], errp);\n- if (vnet_hdr < 0) {\n- goto fail;\n- }\n-\n- if (!net_init_tap_one(tap, peer, name, ifname,\n- NULL, NULL,\n- vhost_fds ? vhost_fds[0] : -1,\n- vnet_hdr, fds[0], errp)) {\n- goto fail;\n- }\n } else {\n g_autofree char *script =\n tap_parse_script(tap->script, DEFAULT_NETWORK_SCRIPT);\n","prefixes":["v3","11/12"]}