{"id":2197855,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197855/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260218192444.658046-2-jsnow@redhat.com>","date":"2026-02-18T19:24:44","name":"[1/1] rust: use checked_div to make clippy happy","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cc3327a7d21fd3d2c90b489371be8d828d3e6f39","submitter":{"id":64343,"url":"http://patchwork.ozlabs.org/api/1.0/people/64343/?format=json","name":"John Snow","email":"jsnow@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218192444.658046-2-jsnow@redhat.com/mbox/","series":[{"id":492592,"url":"http://patchwork.ozlabs.org/api/1.0/series/492592/?format=json","date":"2026-02-18T19:24:44","name":"rust: use checked_div()","version":1,"mbox":"http://patchwork.ozlabs.org/series/492592/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197855/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=clxHzqC4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGRLf1BPWz1xwC\n\tfor ; Thu, 19 Feb 2026 06:25:46 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsnAi-0007SY-Le; Wed, 18 Feb 2026 14:25:16 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vsnAd-0007RE-SJ\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 14:25:12 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vsnAY-0006R0-B8\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 14:25:09 -0500","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-l0ow3qLBN1e3TupRo-MnFA-1; Wed,\n 18 Feb 2026 14:25:02 -0500","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E669D1956067; Wed, 18 Feb 2026 19:25:00 +0000 (UTC)","from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.65.233])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 6B6021956095; Wed, 18 Feb 2026 19:24:59 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771442704;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7czD35fBIZStNgK+aI8OpctqWGH8PRx3Y4SqgjrnPwg=;\n b=clxHzqC4CAilKolJoqY96d5YxNeaXe79vhp3w49tqVZ0M5MY399pacHabWIGjZw+m9sOEb\n MK4lRq1mTNsrxc+VwQIYC+LJM3y4KgxdrbUkm0x4PN+dIP7eTEOoY04Y/Hh/UjWR92Kpyk\n achkpfVCmJ5LyZ7KfDZtds8Kwi1Y9Oc=","X-MC-Unique":"l0ow3qLBN1e3TupRo-MnFA-1","X-Mimecast-MFC-AGG-ID":"l0ow3qLBN1e3TupRo-MnFA_1771442701","From":"John Snow ","To":"qemu-devel@nongnu.org","Cc":"qemu-rust@nongnu.org,\n Manos Pitsidianakis ,\n John Snow ","Subject":"[PATCH 1/1] rust: use checked_div to make clippy happy","Date":"Wed, 18 Feb 2026 14:24:44 -0500","Message-ID":"<20260218192444.658046-2-jsnow@redhat.com>","In-Reply-To":"<20260218192444.658046-1-jsnow@redhat.com>","References":"<20260218192444.658046-1-jsnow@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When upgrading from Fedora 41 to Fedora 43 for CI tests, clippy begins\ncomplaining about not using checked_div instead of manually checking\ndivisors. Make clippy happy and use checked_div() instead.\n\nSigned-off-by: John Snow \n---\n rust/hw/core/src/qdev.rs | 14 ++++++--------\n 1 file changed, 6 insertions(+), 8 deletions(-)","diff":"diff --git a/rust/hw/core/src/qdev.rs b/rust/hw/core/src/qdev.rs\nindex 145e20a984f..c4a7312168f 100644\n--- a/rust/hw/core/src/qdev.rs\n+++ b/rust/hw/core/src/qdev.rs\n@@ -425,18 +425,16 @@ pub const fn period_from_ns(ns: u64) -> u64 {\n }\n \n pub const fn period_from_hz(hz: u64) -> u64 {\n- if hz == 0 {\n- 0\n- } else {\n- Self::PERIOD_1SEC / hz\n+ match Self::PERIOD_1SEC.checked_div(hz) {\n+ Some(value) => value,\n+ None => 0,\n }\n }\n \n pub const fn period_to_hz(period: u64) -> u64 {\n- if period == 0 {\n- 0\n- } else {\n- Self::PERIOD_1SEC / period\n+ match period.checked_div(Self::PERIOD_1SEC) {\n+ Some(value) => value,\n+ None => 0,\n }\n }\n \n","prefixes":["1/1"]}