{"id":2197774,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197774/?format=json","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.0/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260218134633.461181-6-Simon.Richter@hogyros.de>","date":"2026-02-18T13:46:33","name":"[v2,5/5] pci: mark return value of pci_set_vga_state as __must_check","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e81ee87512e262e9996e22862a9c1c8935a412a6","submitter":{"id":91044,"url":"http://patchwork.ozlabs.org/api/1.0/people/91044/?format=json","name":"Simon Richter","email":"Simon.Richter@hogyros.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260218134633.461181-6-Simon.Richter@hogyros.de/mbox/","series":[{"id":492553,"url":"http://patchwork.ozlabs.org/api/1.0/series/492553/?format=json","date":"2026-02-18T13:46:28","name":"Bridges without VGA support","version":2,"mbox":"http://patchwork.ozlabs.org/series/492553/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197774/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-47567-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=185.187.169.70","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=hogyros.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=hogyros.de"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGHrW6YTWz1xvq\n\tfor ; Thu, 19 Feb 2026 00:47:39 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id C9C7A3011501\n\tfor ; Wed, 18 Feb 2026 13:47:14 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 381A028B4FA;\n\tWed, 18 Feb 2026 13:47:09 +0000 (UTC)","from psionic.psi5.com (psionic.psi5.com [185.187.169.70])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 07468328B44\n\tfor ; Wed, 18 Feb 2026 13:47:07 +0000 (UTC)","from localhost.localdomain (unknown\n [IPv6:2400:2410:b120:f200:2e09:4dff:fe00:2e9])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(Client did not present a certificate)\n\tby psionic.psi5.com (Postfix) with ESMTPSA id 0E3C83F204;\n\tWed, 18 Feb 2026 14:47:04 +0100 (CET)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1771422429; cv=none;\n b=cF8UR2/yXFlZnVQVpnmsE1xSUZ2Cxf+0id27Rqqk/LunQXyCUvE4SmM7DEW1PTgqwngoulxf44/IfQu7fyIRFTScbA6/YpywO2q/u0STrLkUKIyeEga8SRjcfozX4rs3VC9+Fz2KvGi54uTb4ojfQxi1o8bSOpEKUZdjU4EGB8c=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1771422429; c=relaxed/simple;\n\tbh=YqtN64zjt6WcjFBZVypSO7UTvisvmqOTiwfZumwNiIs=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=hAUyihXP369NcYJmGoSXxBcd0C27dkiM6rKtHiieNJyiM7Vm0bBRF4YyZv+mKUQ3IH85lNB2vJZdLz72M0srbMWSlwrY0JXZhh8dU+YWaA0xfWu/gekX/nsNPOxz30Bdlo/DgjqpD/TxhiY17mB6HmLKzJ0QzvCOMDeB67EldA0=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=hogyros.de;\n spf=pass smtp.mailfrom=hogyros.de; arc=none smtp.client-ip=185.187.169.70","From":"Simon Richter ","To":"linux-pci@vger.kernel.org","Cc":"intel-xe@lists.freedesktop.org,\n\tdri-devel@lists.freedesktop.org,\n\tSimon Richter ","Subject":"[PATCH v2 5/5] pci: mark return value of pci_set_vga_state as\n __must_check","Date":"Wed, 18 Feb 2026 22:46:33 +0900","Message-ID":"<20260218134633.461181-6-Simon.Richter@hogyros.de>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260218134633.461181-1-Simon.Richter@hogyros.de>","References":"<20260217170419.236739-1-Simon.Richter@hogyros.de>\n <20260218134633.461181-1-Simon.Richter@hogyros.de>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"This function can return an error, which should be checked.\n\nThe only caller so far is __vga_tryget in vgaarb, which did not check.\n\nSigned-off-by: Simon Richter \n---\n include/linux/pci.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/include/linux/pci.h b/include/linux/pci.h\nindex 1c270f1d5123..aa1451d402d1 100644\n--- a/include/linux/pci.h\n+++ b/include/linux/pci.h\n@@ -1720,8 +1720,8 @@ resource_size_t pcibios_window_alignment(struct pci_bus *bus,\n #define PCI_VGA_STATE_CHANGE_BRIDGE (1 << 0)\n #define PCI_VGA_STATE_CHANGE_DECODES (1 << 1)\n \n-int pci_set_vga_state(struct pci_dev *pdev, bool decode,\n-\t\t unsigned int command_bits, u32 flags);\n+int __must_check pci_set_vga_state(struct pci_dev *pdev, bool decode,\n+\t\t\t\t unsigned int command_bits, u32 flags);\n \n /*\n * Virtual interrupts allow for more interrupts to be allocated\n","prefixes":["v2","5/5"]}