{"id":2197761,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197761/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260218132633.29748-3-hreitz@redhat.com>","date":"2026-02-18T13:26:11","name":"[v4,02/24] fuse: Ensure init clean-up even with error_fatal","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a8b9b709bb97d46a10229cd10d25e8d83f055111","submitter":{"id":82279,"url":"http://patchwork.ozlabs.org/api/1.0/people/82279/?format=json","name":"Hanna Czenczek","email":"hreitz@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218132633.29748-3-hreitz@redhat.com/mbox/","series":[{"id":492547,"url":"http://patchwork.ozlabs.org/api/1.0/series/492547/?format=json","date":"2026-02-18T13:26:09","name":"export/fuse: Use coroutines and multi-threading","version":4,"mbox":"http://patchwork.ozlabs.org/series/492547/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197761/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Z/q3DZLP;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=D/SHPUPp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGHbL6N3Wz1xpY\n\tfor ; Thu, 19 Feb 2026 00:36:14 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vshfA-0003pD-Ox; Wed, 18 Feb 2026 08:32:20 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vshf6-0003oI-Ti\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 08:32:18 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vshf2-000546-3i\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 08:32:16 -0500","from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-31-LUVopu8ZPdmRCbCTfR509w-1; Wed, 18 Feb 2026 08:26:49 -0500","by mail-wr1-f70.google.com with SMTP id\n ffacd0b85a97d-4368060a5e5so5642639f8f.3\n for ; Wed, 18 Feb 2026 05:26:48 -0800 (PST)","from localhost\n (p200300cfd737d029edef7b8da7441ac2.dip0.t-ipconnect.de.\n [2003:cf:d737:d029:edef:7b8d:a744:1ac2])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43796a6c1bfsm43078466f8f.13.2026.02.18.05.26.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 18 Feb 2026 05:26:45 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771421521;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=yWcGLprdpXgo2UanWZOxr3c/Uu5d1zE+FoOX3fFgguc=;\n b=Z/q3DZLPHhWwTJW3iiigHPCMCPOdcl43XdFKEeiS+nWqAHgxWPZASjCnLHjcprb6jFHz3q\n gc/doRaKCneGz/NAQOd1m7mVnMU16SnSfRKoNcLAaokDhOBbPKF5zw2Gr3WLx2Cnelym1A\n GNa8RN0wVKQsw4qRj7Nln4mueGCff1o=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1771421208; x=1772026008; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=yWcGLprdpXgo2UanWZOxr3c/Uu5d1zE+FoOX3fFgguc=;\n b=D/SHPUPpG5gE9D+pwLeTDU4Pcbvx0/1d0c10AYgfWNSlefQi4Z9ilxgtJnFWnLFxTp\n Mq7r9Jc3neeX+aJmhr3a6g9svaUxihI+5PMPk6SQBX4/ASpphfYchJj042rGFzrl3Atw\n QuAORszsT4fPLpuOZWhuV9pHLb6sLETl+/jEsQ8Cfn/YMfJSwAQeV9qlR5fqvLQcH4vf\n DcWCXCcHfPcIqlifaFS44VoKybBBiMEhHHbhr1VTErrjEF0nzEm6qMvB1q2c/B4lq3bL\n Mg3s8j5FGWNBIo8P/B+EwpmYJ/6gtExyU1kc3QgU5/vt32pQEOBKr1LFygC71G719YUx\n 6C6g=="],"X-MC-Unique":"LUVopu8ZPdmRCbCTfR509w-1","X-Mimecast-MFC-AGG-ID":"LUVopu8ZPdmRCbCTfR509w_1771421208","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771421208; x=1772026008;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=yWcGLprdpXgo2UanWZOxr3c/Uu5d1zE+FoOX3fFgguc=;\n b=bus7eGLILJtx7aW4SBZ3yHTYNkQWk/78lSMxheSB5Ir5bhX4CTEoGgi1pLV7CTOeKx\n +8P2zbpIpJ24Wl35YOMtRBZKBcVS8mb7h3hklLNyRBWuG6b28eja/3NB/u/gHFreRern\n DHD7oAF2a3kI3SEDOLIm4YpibyVWNXYoxwb1a0TQF2E1BpSD7BiXCrJb4WXNVbN9B5i2\n fj55bxTXeTXIkQklS6DlqakZWmcWAcw4dhl2QM1vUmxG2NjsrQ92Wi+hMiHxF9rtrFof\n AF0x5UIvW5SlK2zwmq0VZbfmbFF179FSZt8+fzdRfLWvYBvtSy+xGZoqC3oUg+cM6C7/\n /gnw==","X-Gm-Message-State":"AOJu0YyRy5tRT+aFcQyeKGdiKI0rBy6viVxUuOaYxPAlFG3kf/vlvxhx\n r4ItnPglI1DHPENozdq4JS/P/ha1oW6j1m0bg2EXwgZqgSI4Rfs4/TI5Og85+FXz+vplB2upKO2\n 1wQgE4CvyZIDU07abqMqUfJ5+NK0uqgp2jtEfW4uN5gclNCQRC9VcvyTk","X-Gm-Gg":"AZuq6aLXi5CiUTLOd8sJXdKCdlOrbL+oBV+p7mfNmPbsNLYIk+zeIlSSyeqbiclSr8o\n 2LSetFOfMYsKPjd3wZq01D1wm9XSNwyP8X0wl4P6dRkr/YOA17m0gD6Z4AQkb5EDO99A1+dsfv3\n /m78nTLzO5XV2ca8/z4++nHzcq+f8ohDzulyPQKlFRiGx3a0NprAcLewEV0nHxvoK6sHAX55tnf\n G/4Zmu1n8oBmUrKtVVR6bcR4ve6fL6Q8yDSmYut/CR3IlsTDnlen0waA/k0fr0q1AHTmM+FI9xT\n olfU1WgmU4HFL7hLVg5gjWbkIFQiRg5p8clEE7EoBUJ0anxSdy/u2s4iMsbGbKJCggVl5ueo5SR\n ZFlJbo72sX0n0A0MfqjZhgf6eUQ6hDKB/khfvu/Ouu/CboxS3k2ufuBaB6rr1x39ASMIDYeXJOJ\n v8U5t4","X-Received":["by 2002:a05:6000:2508:b0:435:8e14:9877 with SMTP id\n ffacd0b85a97d-4379dbae484mr23152421f8f.60.1771421207816;\n Wed, 18 Feb 2026 05:26:47 -0800 (PST)","by 2002:a05:6000:2508:b0:435:8e14:9877 with SMTP id\n ffacd0b85a97d-4379dbae484mr23152382f8f.60.1771421207355;\n Wed, 18 Feb 2026 05:26:47 -0800 (PST)"],"From":"Hanna Czenczek ","To":"qemu-block@nongnu.org","Cc":"qemu-devel@nongnu.org, Hanna Czenczek ,\n Kevin Wolf , Brian Song ","Subject":"[PATCH v4 02/24] fuse: Ensure init clean-up even with error_fatal","Date":"Wed, 18 Feb 2026 14:26:11 +0100","Message-ID":"<20260218132633.29748-3-hreitz@redhat.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260218132633.29748-1-hreitz@redhat.com>","References":"<20260218132633.29748-1-hreitz@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=hreitz@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When exports are created on the command line (with the storage daemon),\nerrp is going to point to error_fatal. Without ERRP_GUARD, we would\nexit immediately when *errp is set, i.e. skip the clean-up code under\nthe `fail` label. Use ERRP_GUARD so we always run that code.\n\nAs far as I know, this has no actual impact right now[1], but it is\nstill better to make this right.\n\n[1] Not cleaning up the mount point is the only thing I can imagine\n would be problematic, but that is the last thing we attempt, so if\n it fails, it will clean itself up.\n\nReviewed-by: Stefan Hajnoczi \nSigned-off-by: Hanna Czenczek \n---\n block/export/fuse.c | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/block/export/fuse.c b/block/export/fuse.c\nindex cea9de61f1..2ed22c6b2f 100644\n--- a/block/export/fuse.c\n+++ b/block/export/fuse.c\n@@ -119,6 +119,7 @@ static int fuse_export_create(BlockExport *blk_exp,\n BlockExportOptions *blk_exp_args,\n Error **errp)\n {\n+ ERRP_GUARD(); /* ensure clean-up even with error_fatal */\n FuseExport *exp = container_of(blk_exp, FuseExport, common);\n BlockExportOptionsFuse *args = &blk_exp_args->u.fuse;\n int ret;\n","prefixes":["v4","02/24"]}