{"id":2197753,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197753/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260218132633.29748-10-hreitz@redhat.com>","date":"2026-02-18T13:26:18","name":"[v4,09/24] fuse: Introduce fuse_{at,de}tach_handlers()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"22d37a11ea80b087f046824e1d8a6fc5b934da77","submitter":{"id":82279,"url":"http://patchwork.ozlabs.org/api/1.0/people/82279/?format=json","name":"Hanna Czenczek","email":"hreitz@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218132633.29748-10-hreitz@redhat.com/mbox/","series":[{"id":492547,"url":"http://patchwork.ozlabs.org/api/1.0/series/492547/?format=json","date":"2026-02-18T13:26:09","name":"export/fuse: Use coroutines and multi-threading","version":4,"mbox":"http://patchwork.ozlabs.org/series/492547/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197753/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=e02Y8LjI;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=Z3nfce7L;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGHZ55YMfz1xpl\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 19 Feb 2026 00:35:09 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vshfW-00040A-SS; Wed, 18 Feb 2026 08:32:42 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <hreitz@redhat.com>) id 1vshfQ-0003xa-9z\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 08:32:36 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <hreitz@redhat.com>) id 1vshfA-0005J8-Gs\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 08:32:32 -0500","from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-25-BybK5eeIODuikDuU6cejDw-1; Wed, 18 Feb 2026 08:27:08 -0500","by mail-wm1-f72.google.com with SMTP id\n 5b1f17b1804b1-4836bf1a920so61261805e9.3\n for <qemu-devel@nongnu.org>; Wed, 18 Feb 2026 05:27:07 -0800 (PST)","from localhost\n (p200300cfd737d029edef7b8da7441ac2.dip0.t-ipconnect.de.\n [2003:cf:d737:d029:edef:7b8d:a744:1ac2])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4839839d960sm29902525e9.3.2026.02.18.05.27.04\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 18 Feb 2026 05:27:04 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771421532;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=muqu2YymWMHLeGtaHW7SS1VV742IfcBS+uS47ikVE8o=;\n b=e02Y8LjI2RxtKD85DIy+v56MLqQ4+ZnO7q7U0OxnB3kqUYzxe7kSO7DEPk9qi0Ygqgn3Vo\n xxd4SPQ4BYkwnoO7I3o4MAYhwD0MxXeYoqq/Rb07GqYIRRcfklZYQcHcW5fmcLpH0nYAAr\n MNltzX8cEA1FQ1ckUuAQtjziAFp3jEw=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1771421226; x=1772026026; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=muqu2YymWMHLeGtaHW7SS1VV742IfcBS+uS47ikVE8o=;\n b=Z3nfce7LEJ3MDE7lLXvSOEmOAxIE8Kp0vC6j2SLx+iTSG5onfaI2YijdKMHvYfMBjI\n lPF2Iw0vfaDO5T/9Bh+yD4kdOGpkKthIjKT5l5hk67inTFtE2rRo6OIC44CcR9+wqWso\n qfCk7VrROKcFALYc2D/ZVRktsYltA3Q5TlzDuxrUOoT3HxyrE2DoEOgX1r7P3vmoL6g1\n 3hLIL+MpGyWqNt1d2XBJgJR9SOseoTfU4sxn4rZs8C6XfXjSeN//kFblw7MXTlDSJ+IL\n HVEUjmt99VdZiVgPgfXMN0CTLbrOlu4ZDg3Oe2etMLjaXu3G50PBFCSZykt3ZxZExDHN\n uZ2w=="],"X-MC-Unique":"BybK5eeIODuikDuU6cejDw-1","X-Mimecast-MFC-AGG-ID":"BybK5eeIODuikDuU6cejDw_1771421227","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771421226; x=1772026026;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=muqu2YymWMHLeGtaHW7SS1VV742IfcBS+uS47ikVE8o=;\n b=TW+VAMgbdQg78oskHUDodt8gngfCmerl0id+XBqMOtFWovNWMq6GWuMa9NgcazCB2E\n gq0A65RmwkXkcxWt1TijJb6VuGSuRxSIBXYyiTwdNjSbr5UAJbdDiDk0LhNOzORdPfrl\n ol71kxlq8JbVxZULNWxsqOkUZzJUeXCbikpHFGqm3dMK547CBlm3wx0EuJnV6s4HMnRH\n 5ClB/bhkPTVtDbXJzGqAfzfSMWgJMyjUhzwOY91XDCEgKtekIpU5ZiBisol73bSP72wX\n iVGRPGJ4xP0NXDJXVFhq355CLY8OU4jc6Rxsl8g83+t2RCRgPHW+uaqmpJJSm6J3PqbP\n iOKQ==","X-Gm-Message-State":"AOJu0YyJL+s9GDpmim/NNihMw0G2X+du626k7WCjx2HezsElBmXigMFQ\n UikAD+yOgOKn/ttsL32qfNiHWjIxGm/xK+5M8/T1qSbfA3j/bKxXVIZLaeI45Q+kb1h8XJ5SCG9\n WUJ+nFkS0EXmm5AESUQ8thi+T74y0iGMHY9nxBJjMuvbN5BElWxqj5R7A2CAHdF+k","X-Gm-Gg":"AZuq6aLMe43z4SBU9OA5L7a2uDA2vfxHWYQRcRLLotfJzXGhJsHO0UkuTIwFI9DKA4g\n o/yqfzSHeyWlYnIlrLKFq39G1JUHDeXIAqRPw6E39r30kGoj2iMbDCW3iJ4HgBPqJCWus12qOhd\n kWRf+BPAXJQwla7riFGgw12DBZVkC465PlFHMHcpYLmzpzPMtgKkknPCcUOiBSsCH/3qE617cIN\n vemcEJcgQIa9VP27XOgNXkw7AFpgmVSd/ZjNchASiWcZ007omlRANBdUfTQZUo2r1VxaaTc3WQ2\n SFw4ihybjkUYZJhviwHYKa8/bhOVkORGsFm1cU53HZy7fN2FTZqmayb3WaJwi3kVH/n8sH4Qtfo\n mNsfYGWrdFKCecZyKeN2rGMAsZ1yW1bT7PYRJFABvVmFLn3yPAP+rjbHWajMQkuDeKslmM4bktW\n uH6wJf","X-Received":["by 2002:a05:600c:4744:b0:482:f564:d613 with SMTP id\n 5b1f17b1804b1-48379ba8f46mr247682125e9.15.1771421226446;\n Wed, 18 Feb 2026 05:27:06 -0800 (PST)","by 2002:a05:600c:4744:b0:482:f564:d613 with SMTP id\n 5b1f17b1804b1-48379ba8f46mr247681715e9.15.1771421226021;\n Wed, 18 Feb 2026 05:27:06 -0800 (PST)"],"From":"Hanna Czenczek <hreitz@redhat.com>","To":"qemu-block@nongnu.org","Cc":"qemu-devel@nongnu.org, Hanna Czenczek <hreitz@redhat.com>,\n Kevin Wolf <kwolf@redhat.com>, Brian Song <hibriansong@gmail.com>","Subject":"[PATCH v4 09/24] fuse: Introduce fuse_{at,de}tach_handlers()","Date":"Wed, 18 Feb 2026 14:26:18 +0100","Message-ID":"<20260218132633.29748-10-hreitz@redhat.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260218132633.29748-1-hreitz@redhat.com>","References":"<20260218132633.29748-1-hreitz@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=hreitz@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Pull setting up and tearing down the AIO context handlers into two\ndedicated functions.\n\nReviewed-by: Stefan Hajnoczi <stefanha@redhat.com>\nSigned-off-by: Hanna Czenczek <hreitz@redhat.com>\n---\n block/export/fuse.c | 32 ++++++++++++++++----------------\n 1 file changed, 16 insertions(+), 16 deletions(-)","diff":"diff --git a/block/export/fuse.c b/block/export/fuse.c\nindex d0e3c6bf61..5953407f20 100644\n--- a/block/export/fuse.c\n+++ b/block/export/fuse.c\n@@ -78,27 +78,34 @@ static void read_from_fuse_export(void *opaque);\n static bool is_regular_file(const char *path, Error **errp);\n \n \n-static void fuse_export_drained_begin(void *opaque)\n+static void fuse_attach_handlers(FuseExport *exp)\n {\n-    FuseExport *exp = opaque;\n+    aio_set_fd_handler(exp->common.ctx,\n+                       fuse_session_fd(exp->fuse_session),\n+                       read_from_fuse_export, NULL, NULL, NULL, exp);\n+    exp->fd_handler_set_up = true;\n+}\n \n+static void fuse_detach_handlers(FuseExport *exp)\n+{\n     aio_set_fd_handler(exp->common.ctx,\n                        fuse_session_fd(exp->fuse_session),\n                        NULL, NULL, NULL, NULL, NULL);\n     exp->fd_handler_set_up = false;\n }\n \n+static void fuse_export_drained_begin(void *opaque)\n+{\n+    fuse_detach_handlers(opaque);\n+}\n+\n static void fuse_export_drained_end(void *opaque)\n {\n     FuseExport *exp = opaque;\n \n     /* Refresh AioContext in case it changed */\n     exp->common.ctx = blk_get_aio_context(exp->common.blk);\n-\n-    aio_set_fd_handler(exp->common.ctx,\n-                       fuse_session_fd(exp->fuse_session),\n-                       read_from_fuse_export, NULL, NULL, NULL, exp);\n-    exp->fd_handler_set_up = true;\n+    fuse_attach_handlers(exp);\n }\n \n static bool fuse_export_drained_poll(void *opaque)\n@@ -209,11 +216,7 @@ static int fuse_export_create(BlockExport *blk_exp,\n \n     g_hash_table_insert(exports, g_strdup(exp->mountpoint), NULL);\n \n-    aio_set_fd_handler(exp->common.ctx,\n-                       fuse_session_fd(exp->fuse_session),\n-                       read_from_fuse_export, NULL, NULL, NULL, exp);\n-    exp->fd_handler_set_up = true;\n-\n+    fuse_attach_handlers(exp);\n     return 0;\n \n fail:\n@@ -335,10 +338,7 @@ static void fuse_export_shutdown(BlockExport *blk_exp)\n         fuse_session_exit(exp->fuse_session);\n \n         if (exp->fd_handler_set_up) {\n-            aio_set_fd_handler(exp->common.ctx,\n-                               fuse_session_fd(exp->fuse_session),\n-                               NULL, NULL, NULL, NULL, NULL);\n-            exp->fd_handler_set_up = false;\n+            fuse_detach_handlers(exp);\n         }\n     }\n \n","prefixes":["v4","09/24"]}