{"id":2197746,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197746/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260218132633.29748-7-hreitz@redhat.com>","date":"2026-02-18T13:26:15","name":"[v4,06/24] fuse: Destroy session on mount_fuse_export() fail","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"794d3b9299e3c7526187eb2eb2582db88959e406","submitter":{"id":82279,"url":"http://patchwork.ozlabs.org/api/1.0/people/82279/?format=json","name":"Hanna Czenczek","email":"hreitz@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218132633.29748-7-hreitz@redhat.com/mbox/","series":[{"id":492547,"url":"http://patchwork.ozlabs.org/api/1.0/series/492547/?format=json","date":"2026-02-18T13:26:09","name":"export/fuse: Use coroutines and multi-threading","version":4,"mbox":"http://patchwork.ozlabs.org/series/492547/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197746/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=brFqyAmE;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=WaZ6f8Mh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGHYY0d9tz1xvq\n\tfor ; Thu, 19 Feb 2026 00:34:41 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vshfD-0003tl-Pi; Wed, 18 Feb 2026 08:32:23 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vshfB-0003po-K8\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 08:32:21 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vshf4-00059P-Ir\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 08:32:21 -0500","from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-153-xlGEiBKjNoq4TlYgOF-C1Q-1; Wed, 18 Feb 2026 08:26:59 -0500","by mail-wr1-f70.google.com with SMTP id\n ffacd0b85a97d-435af2d3144so3820864f8f.3\n for ; Wed, 18 Feb 2026 05:26:59 -0800 (PST)","from localhost\n (p200300cfd737d029edef7b8da7441ac2.dip0.t-ipconnect.de.\n [2003:cf:d737:d029:edef:7b8d:a744:1ac2])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43796abc9b2sm39075481f8f.21.2026.02.18.05.26.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 18 Feb 2026 05:26:56 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771421524;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=FfndHSyArVwAQZsbpd1CUY8UJ74t3/0SFuGSjOnWRHI=;\n b=brFqyAmEuT7Nmd2vgCuqJZLWdttdgIe+6DvEb+n4t/pnmfLsd0RCoZrdLMHKr3zEWougt+\n ave2rZ1I1ceC+fMdCKlyRVatD8Vti8e58zMtq6Uj+qnhXRrRB0k2JVDEv0dAKEGZgMH0xi\n /E1fPdLvttFncmLc4lVpoT6j5OE/9GY=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1771421218; x=1772026018; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=FfndHSyArVwAQZsbpd1CUY8UJ74t3/0SFuGSjOnWRHI=;\n b=WaZ6f8MhkBLaE4tqIpqNUYmYBehM+x/KALuPbiZYOLhs2bkhSZpO+Uw9eDS1Gd1B6h\n vaGk4EBmdf/Qf9TJSSnp/jv0/NusH/yIa2mArI6ezNasZXb+GYYdGlK3Q5DwO/wjmVIG\n lnyjcd/3UJNqvIg5xKQTHjdr8rGhxEHt4oZMUOhmwxtp3wk4+rFxmuvISossCDS4AyLi\n 4/UFqCTLFzG459UxmtsYQqFGHRiuUZl9fP2KPyyV4puTVBOJ/jrpi1v2y75SEYL55YT/\n NAXXy4ex4dl/it13ZwimCUVZyvIrZfHx7s1nqecNoo3//2TAt2U7Sl6o9LRqXmx7w2bE\n PwLg=="],"X-MC-Unique":"xlGEiBKjNoq4TlYgOF-C1Q-1","X-Mimecast-MFC-AGG-ID":"xlGEiBKjNoq4TlYgOF-C1Q_1771421219","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771421218; x=1772026018;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=FfndHSyArVwAQZsbpd1CUY8UJ74t3/0SFuGSjOnWRHI=;\n b=JasgSR6HEKXUUTtbax4+6AhYT0ezaLNTBpbaGArYzSOj/9ROBcoKXJw76h6Ywff9fG\n ckaO0xaOX+Jmg2gRlEL+CmANcKgQaouk0V8JvK5arbvNUxCTH2fRG3TDxDUPcBTZSbH4\n gXjpzla32SYUv9l9AUQ4wNqtyueRABnZFL7Cl2evzmADSnFvlMAAreXkdsZyP+tNegjh\n pO1SxkLPl/R2y3Zlj/5WlG+aZuV6DEw+VJ8oSHpg0GnCn9qSYmuPKa9DsLKZ0qmbDox5\n 1lpnNtglm2SCIhYSrOP8WObtYEKgevPTMYKSsDXcAGNYRXMlEfCwpVGM8OAjn+7w23To\n EDVQ==","X-Gm-Message-State":"AOJu0Yxpsaq1itP5+b18MshIb4Q9fHzi/SyeTaMmCHrbVdVuAjfygZpG\n 9ThGu+7zI7nuNU06t26A2g40YQ9wXM0RulsAdGPBDDfr9eDVytu4WN14XWpk73HcHI1ZipBf2PO\n B5/2JMLkKSi3M7MBOQtbspU6an19SA36Nn8ph/j8ZMQ/fUUZ8pSL6rfcG","X-Gm-Gg":"AZuq6aLtKpTg0h4GoZgRQ5IM5iRVjWI73sdchPM/uWgjQ1uxCcaE3W+h71IGfEi58vh\n zo1Bt1GuGYVWBCEkG4TSSBsjsIz/Z6f0uOQRmfqw8WMpStdmF8HhlMXxf0ZBxJeuHUb14h8lzZv\n d+qEY6N73akcelFxIM2pDaX8V80WgAvZ+VfnUoCX58W7VeFkj44yqnPDpVNsnRbNHH4ffSnfQzb\n FSgXyerOJ4wZytcoxNIg0+jUUjrGyPJ9O9NYgBl6NqqWtNW8iFaimtqmjxtzNKxzF6AF2YB+UG5\n bdUKRn7PNsprQ8VvA6EtR7d1il2rx8x2e2ya3OUZ0/b5rBPn/527/VXnmkHDYkkD3vRi+7ncBZt\n Fly2jXFVxvYLI1kGQRkrKDMD5087eoplLCDcu9Et4uHGbpKsaLCtE6y6OUwpUAgzkaYArw42xV9\n w/7JYM","X-Received":["by 2002:a05:6000:248a:b0:436:38a4:2423 with SMTP id\n ffacd0b85a97d-4379db66905mr26130217f8f.22.1771421218532;\n Wed, 18 Feb 2026 05:26:58 -0800 (PST)","by 2002:a05:6000:248a:b0:436:38a4:2423 with SMTP id\n ffacd0b85a97d-4379db66905mr26130174f8f.22.1771421218078;\n Wed, 18 Feb 2026 05:26:58 -0800 (PST)"],"From":"Hanna Czenczek ","To":"qemu-block@nongnu.org","Cc":"qemu-devel@nongnu.org, Hanna Czenczek ,\n Kevin Wolf , Brian Song ","Subject":"[PATCH v4 06/24] fuse: Destroy session on mount_fuse_export() fail","Date":"Wed, 18 Feb 2026 14:26:15 +0100","Message-ID":"<20260218132633.29748-7-hreitz@redhat.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260218132633.29748-1-hreitz@redhat.com>","References":"<20260218132633.29748-1-hreitz@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=hreitz@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"If mount_fuse_export() fails to mount the session, destroy it.\nDepending on the allow_other configuration, fuse_export_create() may\nretry this function on error, which may leak one session instance\notherwise.\n\nSigned-off-by: Hanna Czenczek \n---\n block/export/fuse.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/block/export/fuse.c b/block/export/fuse.c\nindex 00bb2ffee4..82560ca071 100644\n--- a/block/export/fuse.c\n+++ b/block/export/fuse.c\n@@ -270,11 +270,17 @@ static int mount_fuse_export(FuseExport *exp, Error **errp)\n ret = fuse_session_mount(exp->fuse_session, exp->mountpoint);\n if (ret < 0) {\n error_setg(errp, \"Failed to mount FUSE session to export\");\n- return -EIO;\n+ ret = -EIO;\n+ goto fail;\n }\n exp->mounted = true;\n \n return 0;\n+\n+fail:\n+ fuse_session_destroy(exp->fuse_session);\n+ exp->fuse_session = NULL;\n+ return ret;\n }\n \n /**\n","prefixes":["v4","06/24"]}