{"id":2197729,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197729/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260218114233.266178-9-anisinha@redhat.com>","date":"2026-02-18T11:42:01","name":"[v5,08/34] i386/kvm: unregister smram listeners prior to vm file descriptor change","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"807122acddc4530b1e565224167b8cb48f876426","submitter":{"id":86030,"url":"http://patchwork.ozlabs.org/api/1.0/people/86030/?format=json","name":"Ani Sinha","email":"anisinha@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218114233.266178-9-anisinha@redhat.com/mbox/","series":[{"id":492541,"url":"http://patchwork.ozlabs.org/api/1.0/series/492541/?format=json","date":"2026-02-18T11:41:56","name":"Introduce support for confidential guest reset (x86)","version":5,"mbox":"http://patchwork.ozlabs.org/series/492541/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197729/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=L6yQ8cRn;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=sHcApYw1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGF836dm4z1xvq\n\tfor ; Wed, 18 Feb 2026 22:45:55 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsfxs-0003JT-A9; Wed, 18 Feb 2026 06:43:32 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsfxf-0003Cs-8W\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 06:43:19 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsfxa-0007pN-2b\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 06:43:16 -0500","from mail-pl1-f199.google.com (mail-pl1-f199.google.com\n [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-351-VRY-ii9fN16fNuk305Fr5w-1; Wed, 18 Feb 2026 06:43:11 -0500","by mail-pl1-f199.google.com with SMTP id\n d9443c01a7336-2aadeb3dee4so311578665ad.2\n for ; Wed, 18 Feb 2026 03:43:11 -0800 (PST)","from rhel9-box.lan ([117.99.83.54])\n by smtp.googlemail.com with ESMTPSA id\n d9443c01a7336-2ad1aaeab38sm127803425ad.82.2026.02.18.03.43.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 18 Feb 2026 03:43:10 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771414993;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=eq6qLXbyXLJc54ZDJbb9jP08uxtrOMIUIN9nTu5R5VE=;\n b=L6yQ8cRnnTzIMP24fhwHyAUuq97qo7Xmk7MJ0vLzZrSLUrfCh6uUChlD5tbC3wKefCSU5g\n LwyMCTT6nRSmCIsJNpdFRDKOxYneGd1ANr6M4hGwlwXkS9lGu7sob1Aif5sW6m9iam/0BQ\n 05+Ha8JMU3Ke/QzdNMHaq58lHeZaFgA=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1771414991; x=1772019791; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=eq6qLXbyXLJc54ZDJbb9jP08uxtrOMIUIN9nTu5R5VE=;\n b=sHcApYw1MH48Dd4bVvJcrvb6+yIc9ixK3eJMHpDZXSdhBssNu5SANyLuiu0kxSvOBi\n gij1sfq8vE3ubOmaJILFJzRispD8EZutZAFnYa7ih1pzTdclo6dLQMBAZw7G4tA6+3Az\n 61okT4LNTogjI5i+Xs09Ed28xsVeVu1nWZ+8Nad+qbDYuldJXD4AP5XINRj2Y7Pnnqx3\n UepmtA56nynLAIiorGWU2NaObqOKhsjdSl1HilwKlOtw8dFvPtPSL5gjyOnDb/t/VKA8\n lV0eFjVguBPZ8Wd4M7Ku8z7o3AQSDw0zaZXFr5S5ZhRkL4URLylJ+hCETEVxJXlA5+8s\n ig9A=="],"X-MC-Unique":"VRY-ii9fN16fNuk305Fr5w-1","X-Mimecast-MFC-AGG-ID":"VRY-ii9fN16fNuk305Fr5w_1771414991","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771414991; x=1772019791;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=eq6qLXbyXLJc54ZDJbb9jP08uxtrOMIUIN9nTu5R5VE=;\n b=OqUYEosz3iK3f7mg4tLbLJEM7IXNV6e21zE8KlFeoe8iHUSvM8wz8W53oG697nFVqT\n Hu1fBbQYXQ8vtDHdxu8goE0debZXCXaTNK+6jMfgIsYifKnhz3VeWOUCCKEZ8JIySz7/\n PHl4yu66prVzjTfZbWC1ycmvxh96SVyB9u2tcTGkY8oBRCVm82hUM92MnhINZoQ1tBDh\n 1tZAU4opNV7VIqFkT/wITHit0xS3mNnuxJ7QMruGzhpLrXABeHGD7jpGYqHMSst3Agbt\n Q3mUlqvx/hMwX27AfcNJnt8V1esiJ+7ICY4ZGx4YD1hSBAD6sxLKng8T8QsaiPy9g7f/\n 8mfA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUh2SQkPenQTDzazBmZRK/PygqRfg5ABbrSjBuoBsqFPUtl8IHyBRKGt6EM5bdRibELgiFIfzkWV6Zf@nongnu.org","X-Gm-Message-State":"AOJu0YxXsTurTZ/7eH+PLRF/LAHwYe9aTkNY+b1pL20hugXiLmFHye+s\n XbSP9NOAS4vN5azvN7Px0myBOcUAUr2GPJy9h6bgCdcXjj00oRxA+WQXJaQbAgxCto9oXiPZMjL\n XjSXdXUH/U60ICNbmybCufK8um0pPt5edRr/ohzvezXJCb9VPl0QeOtn3","X-Gm-Gg":"AZuq6aJhWv9hzluaJB1h+FHa/iTd4CtxPH/eQbGcgAVn9uonBgu41Lq7KEXHcHs/4Bx\n 6c7Bxb/WFwVqpiBK+5BXjAKBOK7t0jcPEwL1gORZ81kIG7pPS+sqJDKtbAn/HbH7CLUCmQP6oTn\n QkObFkupyWG2EHCZhpvUKRllyUKXQHx3rUxxhL1d7MQMQJua1RaKk0Gs9IO6k4TmTHeEs0tInYH\n eflFPAJvWjJEBbvE+Yteta4eP9t8K/NCK7s2wm0z5KxJSso5XAmIXOyKku4835Sxd7BZnVVFFxE\n mW657wdAAldc3QeF/KzkwWc4XKbVErLpbNAwkpcU4j+DEj52SQmARbW8+xTRumAiIhXwQ0KCWRY\n Xnw1Tdf2biKUE00rJwy/zCHZ2cNLgqfIK+tBbPwRGcJYt9F87kDWz","X-Received":["by 2002:a17:903:2282:b0:2aa:e238:e219 with SMTP id\n d9443c01a7336-2ab4d0b2e48mr167750695ad.58.1771414990741;\n Wed, 18 Feb 2026 03:43:10 -0800 (PST)","by 2002:a17:903:2282:b0:2aa:e238:e219 with SMTP id\n d9443c01a7336-2ab4d0b2e48mr167750475ad.58.1771414990343;\n Wed, 18 Feb 2026 03:43:10 -0800 (PST)"],"From":"Ani Sinha ","To":"Paolo Bonzini , Marcelo Tosatti ","Cc":"Ani Sinha , kraxel@redhat.com, kvm@vger.kernel.org,\n qemu-devel@nongnu.org","Subject":"[PATCH v5 08/34] i386/kvm: unregister smram listeners prior to vm\n file descriptor change","Date":"Wed, 18 Feb 2026 17:12:01 +0530","Message-ID":"<20260218114233.266178-9-anisinha@redhat.com>","X-Mailer":"git-send-email 2.42.0","In-Reply-To":"<20260218114233.266178-1-anisinha@redhat.com>","References":"<20260218114233.266178-1-anisinha@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=anisinha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"We will re-register smram listeners after the VM file descriptors has changed.\nWe need to unregister them first to make sure addresses and reference counters\nwork properly.\n\nSigned-off-by: Ani Sinha \n---\n target/i386/kvm/kvm.c | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)","diff":"diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c\nindex a4e18734b1..83657fe832 100644\n--- a/target/i386/kvm/kvm.c\n+++ b/target/i386/kvm/kvm.c\n@@ -112,6 +112,11 @@ typedef struct {\n static void kvm_init_msrs(X86CPU *cpu);\n static int kvm_filter_msr(KVMState *s, uint32_t msr, QEMURDMSRHandler *rdmsr,\n QEMUWRMSRHandler *wrmsr);\n+static int unregister_smram_listener(NotifierWithReturn *notifier,\n+ void *data, Error** errp);\n+NotifierWithReturn kvm_vmfd_change_notifier = {\n+ .notify = unregister_smram_listener,\n+};\n \n const KVMCapabilityInfo kvm_arch_required_capabilities[] = {\n KVM_CAP_INFO(SET_TSS_ADDR),\n@@ -2885,6 +2890,17 @@ static void register_smram_listener(Notifier *n, void *unused)\n }\n }\n \n+static int unregister_smram_listener(NotifierWithReturn *notifier,\n+ void *data, Error** errp)\n+{\n+ if (!((VmfdChangeNotifier *)data)->pre) {\n+ return 0;\n+ }\n+\n+ memory_listener_unregister(&smram_listener.listener);\n+ return 0;\n+}\n+\n /* It should only be called in cpu's hotplug callback */\n void kvm_smm_cpu_address_space_init(X86CPU *cpu)\n {\n@@ -3538,6 +3554,7 @@ int kvm_arch_init(MachineState *ms, KVMState *s)\n }\n \n pmu_cap = kvm_check_extension(s, KVM_CAP_PMU_CAPABILITY);\n+ kvm_vmfd_add_change_notifier(&kvm_vmfd_change_notifier);\n \n return 0;\n }\n","prefixes":["v5","08/34"]}