{"id":2197720,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197720/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260218114233.266178-24-anisinha@redhat.com>","date":"2026-02-18T11:42:16","name":"[v5,23/34] kvm/i8254: refactor pit initialization into a helper","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ca8a8f898fb5567f4e8d77f8027235c00636a4d2","submitter":{"id":86030,"url":"http://patchwork.ozlabs.org/api/1.0/people/86030/?format=json","name":"Ani Sinha","email":"anisinha@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218114233.266178-24-anisinha@redhat.com/mbox/","series":[{"id":492541,"url":"http://patchwork.ozlabs.org/api/1.0/series/492541/?format=json","date":"2026-02-18T11:41:56","name":"Introduce support for confidential guest reset (x86)","version":5,"mbox":"http://patchwork.ozlabs.org/series/492541/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197720/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=cJd3QDPI;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=VtclvY6k;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGF7R5xX3z1xvq\n\tfor ; Wed, 18 Feb 2026 22:45:23 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsfyt-0004LQ-Vu; Wed, 18 Feb 2026 06:44:40 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsfyW-0003wP-Ex\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 06:44:14 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsfyL-0007vm-Hi\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 06:44:03 -0500","from mail-pl1-f198.google.com (mail-pl1-f198.google.com\n [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-2-8bIRKhbWONy_pQKH8W0pog-1; Wed, 18 Feb 2026 06:43:59 -0500","by mail-pl1-f198.google.com with SMTP id\n d9443c01a7336-2a75ed2f89dso62619615ad.1\n for ; Wed, 18 Feb 2026 03:43:58 -0800 (PST)","from rhel9-box.lan ([117.99.83.54])\n by smtp.googlemail.com with ESMTPSA id\n d9443c01a7336-2ad1aaeab38sm127803425ad.82.2026.02.18.03.43.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 18 Feb 2026 03:43:56 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771415040;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=UZjupKNTcRQ4mvrXCw54dQwnzt6+1apWExSeFIvKWxA=;\n b=cJd3QDPI+z2LNGyGGg9SpHt1WQBUeKSqxkuqKLklrYnW2p4t/3I0lcjCM6XMIdANmF6e60\n hhuyf2iFoHJ/5NG9FUeHt9u5VfUU4R3+tjzNXzaQhod7lQ9RzkjQAzEXwqmC+3SOynQwMS\n v3zsip3fFj0CiTRV/Zk9DHw1AOETBrU=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1771415037; x=1772019837; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=UZjupKNTcRQ4mvrXCw54dQwnzt6+1apWExSeFIvKWxA=;\n b=VtclvY6ku6uV86kbsEpz5BPBcPpvQxvNgHMPVMjDZYp8d3Y1gOzNMxNeIx3BAhjbpe\n 11rMVnwWEe5lFXbFDnzzDQxkjlDQ0UBVQ6Zanwx2UpaS+yiA+UfudbFyKCTZchABDPmt\n KEd3ufj516DmK7wl1Er1mkcqEw49K3I6mklvkFj25My11E2EuJX27WIXJN5Wx/yU5rsV\n PPLEY9Rrqlu4dAL+vg6bOlwqp4HJ2hGgrlrZs4tL889VXMGv4BAhIjHUJttZ3xMHA2M0\n n3dG3a81q49dcLZTGUfBFfi22Nii9ffzY56/9k7+bYdH4OBn1NBbcGPEqmczJIt+8JoW\n UqxA=="],"X-MC-Unique":"8bIRKhbWONy_pQKH8W0pog-1","X-Mimecast-MFC-AGG-ID":"8bIRKhbWONy_pQKH8W0pog_1771415037","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771415037; x=1772019837;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=UZjupKNTcRQ4mvrXCw54dQwnzt6+1apWExSeFIvKWxA=;\n b=L2fFifnqS/K9vUmAX1gfrTnloOXxOl9dLro1hSzVuDibry0DOAP/yD9ptpgpYDLBbG\n H2DEKBvCtQtaEX8ODA0SUd0voKbAiswnfR82zGnSqEZRtGTgmMLl2+YCACSQscdf1Izt\n 7pj/RmIX5KNsnKZCaR3Tncg/tuixQXl6qt8kn+uirpv4APtNgJfIuSzZjonPaLE5V4KN\n zlQhnP/BQq1j+JHYwv0fSe6Ykf2gfDRyT6wVxA088kPg6ILHrWxTYNprPhXGHPyb2WYj\n d4hMPPZn1ecBQy7a3KErQaXcirwunDHuep+bzG8no8pYd/T43Yt6g4wIll+/AI/E3Z5t\n f9lw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWZFAKGzFL7E539x+5JEezvvG8/iIkf36tDYlTG/VYsINGvbCCnEqcGjI7Tm/FZ9EW31CbeL/Ot+83S@nongnu.org","X-Gm-Message-State":"AOJu0YzjaEyw95SMAdyMxGGs3VGk+tjm5ffVYhZ22RLn4awWPxt2cd4r\n LjASVFg7Dt+4/W452fXjQuivHQPIz4awUwAq61fkHitYMrDe7YebEPp5v5pQOewpl0DJVkRPB0R\n vuLONG2UyayEijQvKwcyiLsQVEEuwMW230dfWJntGN2bZ1YrlvlwpFduBxX1Kl/0H","X-Gm-Gg":"AZuq6aLBpygQN0XwFP3IieBw0cMjLijoXJZofvRenlYmkw4mkdyOe0JTrxoO4keZZZr\n S66wn1xTud5EreDVq234efqXc8q+uHE2ZaBdbsiVCNjPfNhwtf7zXHwhDVuBVgRe6g17G02VRtU\n bSUpgv8BpDJIYW4YY/HWjQ99viayKh4OJvQ/2cY4sImdpYTmPM1uf8XSVM3hgBzJRwZrCMFN+XD\n v5TcyQy4ftG1ocXgXQNTb+4coDscm6RUzjW4Qzq/VVNAW6oAqCjCdKgeSdFYD4PkQ3agzsvjBlX\n MRn7g5RGcoZ68btEa8hBXwPSTgrmCluaH6lNSDEwLGfkXMyLQsXKpr0TKeeW58qLF2ylCnrG5lJ\n AXQRKjPOa3NrDUkJrLZrVFVTRuwM75Ned1Gdx7u1rH/4wmkWtSUX/","X-Received":["by 2002:a17:903:11d0:b0:2a9:4369:940c with SMTP id\n d9443c01a7336-2ad175366bfmr143509085ad.53.1771415037088;\n Wed, 18 Feb 2026 03:43:57 -0800 (PST)","by 2002:a17:903:11d0:b0:2a9:4369:940c with SMTP id\n d9443c01a7336-2ad175366bfmr143508945ad.53.1771415036685;\n Wed, 18 Feb 2026 03:43:56 -0800 (PST)"],"From":"Ani Sinha ","To":"Paolo Bonzini ,\n Richard Henderson ,\n Eduardo Habkost ,\n \"Michael S. Tsirkin\" ,\n Marcel Apfelbaum ","Cc":"Ani Sinha , kraxel@redhat.com, qemu-devel@nongnu.org","Subject":"[PATCH v5 23/34] kvm/i8254: refactor pit initialization into a helper","Date":"Wed, 18 Feb 2026 17:12:16 +0530","Message-ID":"<20260218114233.266178-24-anisinha@redhat.com>","X-Mailer":"git-send-email 2.42.0","In-Reply-To":"<20260218114233.266178-1-anisinha@redhat.com>","References":"<20260218114233.266178-1-anisinha@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=anisinha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The initialization code will be used again by VM file descriptor change\nnotifier callback in a subsequent change. So refactor common code into a new\nhelper function.\n\nSigned-off-by: Ani Sinha \n---\n hw/i386/kvm/i8254.c | 68 +++++++++++++++++++++++++--------------------\n 1 file changed, 38 insertions(+), 30 deletions(-)","diff":"diff --git a/hw/i386/kvm/i8254.c b/hw/i386/kvm/i8254.c\nindex 81e742f866..255047458a 100644\n--- a/hw/i386/kvm/i8254.c\n+++ b/hw/i386/kvm/i8254.c\n@@ -60,6 +60,43 @@ struct KVMPITClass {\n DeviceRealize parent_realize;\n };\n \n+static void do_pit_initialize(KVMPITState *s, Error **errp)\n+{\n+ struct kvm_pit_config config = {\n+ .flags = 0,\n+ };\n+ int ret;\n+\n+ ret = kvm_vm_ioctl(kvm_state, KVM_CREATE_PIT2, &config);\n+ if (ret < 0) {\n+ error_setg(errp, \"Create kernel PIC irqchip failed: %s\",\n+ strerror(-ret));\n+ return;\n+ }\n+ switch (s->lost_tick_policy) {\n+ case LOST_TICK_POLICY_DELAY:\n+ break; /* enabled by default */\n+ case LOST_TICK_POLICY_DISCARD:\n+ if (kvm_check_extension(kvm_state, KVM_CAP_REINJECT_CONTROL)) {\n+ struct kvm_reinject_control control = { .pit_reinject = 0 };\n+\n+ ret = kvm_vm_ioctl(kvm_state, KVM_REINJECT_CONTROL, &control);\n+ if (ret < 0) {\n+ error_setg(errp,\n+ \"Can't disable in-kernel PIT reinjection: %s\",\n+ strerror(-ret));\n+ return;\n+ }\n+ }\n+ break;\n+ default:\n+ error_setg(errp, \"Lost tick policy not supported.\");\n+ return;\n+ }\n+\n+ return;\n+}\n+\n static void kvm_pit_update_clock_offset(KVMPITState *s)\n {\n int64_t offset, clock_offset;\n@@ -241,42 +278,13 @@ static void kvm_pit_realizefn(DeviceState *dev, Error **errp)\n PITCommonState *pit = PIT_COMMON(dev);\n KVMPITClass *kpc = KVM_PIT_GET_CLASS(dev);\n KVMPITState *s = KVM_PIT(pit);\n- struct kvm_pit_config config = {\n- .flags = 0,\n- };\n- int ret;\n \n if (!kvm_check_extension(kvm_state, KVM_CAP_PIT_STATE2) ||\n !kvm_check_extension(kvm_state, KVM_CAP_PIT2)) {\n error_setg(errp, \"In-kernel PIT not available\");\n }\n \n- ret = kvm_vm_ioctl(kvm_state, KVM_CREATE_PIT2, &config);\n- if (ret < 0) {\n- error_setg(errp, \"Create kernel PIC irqchip failed: %s\",\n- strerror(-ret));\n- return;\n- }\n- switch (s->lost_tick_policy) {\n- case LOST_TICK_POLICY_DELAY:\n- break; /* enabled by default */\n- case LOST_TICK_POLICY_DISCARD:\n- if (kvm_check_extension(kvm_state, KVM_CAP_REINJECT_CONTROL)) {\n- struct kvm_reinject_control control = { .pit_reinject = 0 };\n-\n- ret = kvm_vm_ioctl(kvm_state, KVM_REINJECT_CONTROL, &control);\n- if (ret < 0) {\n- error_setg(errp,\n- \"Can't disable in-kernel PIT reinjection: %s\",\n- strerror(-ret));\n- return;\n- }\n- }\n- break;\n- default:\n- error_setg(errp, \"Lost tick policy not supported.\");\n- return;\n- }\n+ do_pit_initialize(s, errp);\n \n memory_region_init_io(&pit->ioports, OBJECT(dev), NULL, NULL, \"kvm-pit\", 4);\n \n","prefixes":["v5","23/34"]}