{"id":2197712,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197712/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260218114233.266178-10-anisinha@redhat.com>","date":"2026-02-18T11:42:02","name":"[v5,09/34] kvm/i386: implement architecture support for kvm file descriptor change","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e297d731ef7d71648eb9647be64373ad7b67ca58","submitter":{"id":86030,"url":"http://patchwork.ozlabs.org/api/1.0/people/86030/?format=json","name":"Ani Sinha","email":"anisinha@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218114233.266178-10-anisinha@redhat.com/mbox/","series":[{"id":492541,"url":"http://patchwork.ozlabs.org/api/1.0/series/492541/?format=json","date":"2026-02-18T11:41:56","name":"Introduce support for confidential guest reset (x86)","version":5,"mbox":"http://patchwork.ozlabs.org/series/492541/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197712/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=XjtOglj0;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=Q+C3vlNj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGF7F5Rpwz1xvq\n\tfor ; Wed, 18 Feb 2026 22:45:13 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsfxp-0003I0-Vn; Wed, 18 Feb 2026 06:43:30 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsfxg-0003E9-Nn\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 06:43:20 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsfxd-0007qV-QU\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 06:43:20 -0500","from mail-pl1-f197.google.com (mail-pl1-f197.google.com\n [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-509-1UQV6CdpPhiwupY3X3yUzQ-1; Wed, 18 Feb 2026 06:43:14 -0500","by mail-pl1-f197.google.com with SMTP id\n d9443c01a7336-2aad3380076so4965915ad.1\n for ; Wed, 18 Feb 2026 03:43:14 -0800 (PST)","from rhel9-box.lan ([117.99.83.54])\n by smtp.googlemail.com with ESMTPSA id\n d9443c01a7336-2ad1aaeab38sm127803425ad.82.2026.02.18.03.43.10\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 18 Feb 2026 03:43:12 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771414996;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=8EBAMm0+61u9Fn6aJibmSGLnXTBDJJJE91zdBC7Xh+k=;\n b=XjtOglj0GG7wlbQttPqWLfnAvNQaGBXsvNulnLJ1P3/6FPNA+1QkjR2LGBz/VeV10cNQPw\n GwG3L7FVulAeK2DzxCaPmvb8X1RmkBJVMjU0GSuvkXMc+G7ibIxiy4E3dxWq3ufR5W9vfB\n gYR62MM/gVlYdC78eKtS8asmKCOHfbM=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1771414994; x=1772019794; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8EBAMm0+61u9Fn6aJibmSGLnXTBDJJJE91zdBC7Xh+k=;\n b=Q+C3vlNjS28b5ncwrthqBTeF1OZk4bHHM7i7iNRmN8M39auOw5O6OjgsE10mhTwRrJ\n aLyzPkRjzmahBdiefbYW0bSm8QoXQP7EU61Qwa1L4603ueu8bDGCitkY2D7xy320vqtr\n 8lTUU3A5jvs+gl7XIB33XXgJwkTr0tE1hrjO5d2ECtO5eDf8BSL8zVBJcNF752lo95RI\n +MFgZKimABYcOTvbZt4LpRTqU86ihDJ9wSCQQeK0PlN3JKqZDIZVGlon1lU3A7IuSDsf\n nvvrpQ3jXL9g5q5kzGu9nh52BN3eLnCxRhVmiH3736Rnyi6EwfMEPrW8Cufa75BQy5Oc\n wAuQ=="],"X-MC-Unique":"1UQV6CdpPhiwupY3X3yUzQ-1","X-Mimecast-MFC-AGG-ID":"1UQV6CdpPhiwupY3X3yUzQ_1771414994","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771414994; x=1772019794;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=8EBAMm0+61u9Fn6aJibmSGLnXTBDJJJE91zdBC7Xh+k=;\n b=YafyuyOsrEEVmRC8uG7AxkDxrgkpoasyjUrioK/5LE9ymGsmrbFEOoQLwtViCZNdXV\n /+E1SP3lM1GwFyRLUdQoe6bljnvl2R1eRBx4oOJzX4LC533KXwqitz/NVgxSN6ItJZiu\n z9RFsYKMrNgC3SqTuPyAJZEz0/gzFlM5YbhG47soydQUD1td1DP7KXfB41N2T1vWCSmK\n ESOnkn8Z/DLV9hAFjlRgmp7ki169a+o7StZOsabgnvZsDvWEyd1O66i5aRbyedf088Md\n vL73I5/nA7i6sP1LSwhRRN4QH+aMio5ApI6rO/jdNq8J47NLf/P0i3s7se1WgXxe/Hsk\n gg6Q==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXthwwQ7zev1N8pf3E5vok3x5k1BNjIlyFlAh6KuXcc0HUdDJzyBtPCPihdIxXZq1Rw3dxnjhs7w1rX@nongnu.org","X-Gm-Message-State":"AOJu0YzE1EzTlhTgran0fmclNWgw0LyIknwwdN9fzdlPTmwLFmzZLtr9\n ar3lwG2sSShLqeDVDKDogIYN0lNxIfQrzrmCtFDvQYePoqa1ZcLfC94FyeJT6UC5zkHfQjHnHXT\n gU63ORsyeCXaTh/0AQzbLy8w/IrkrRYae0ypO5U2bECL3hXRQ1Bu9YzZr","X-Gm-Gg":"AZuq6aIV2NQBDC7aDuVBQ3ECwyhDZ+ZS85GlsihS+UfKm4NRWEQlvRyTxEEWsc9tLff\n peFXLgBXWOtoXtDjZWK13MDGcpizYV/JOfQBZY58N7LksEddtW7iFkGwC3mBhtKaEjYpDZvzPeM\n kPBxg4fYylu+64NCddrOf6QTaRgshEtwuY9cJ1eDmRo9PEqp/6Tc9YcI72JKST9WM1LyLQVGFjb\n D9CI1+wNsf7564lutX5NFJF0r/GJdZ18/XXZ+eXDTYEuPZXc+t07RVsAGGekMZbfSOOTXMlGTtq\n hv1yoqNyu4fp+yBh7We61zIwISfUEixXdrXLtPUHbL/H34+oihO3mVNKgk5qf+XNvbAaaEJC60y\n DDlQU73lqjhnOiDbMJ4344gggHer6tOoQ6AkZZ0QkKneFmXCob6R0","X-Received":["by 2002:a17:902:d4d0:b0:2aa:e817:1bda with SMTP id\n d9443c01a7336-2ad50b980dcmr15409665ad.12.1771414993680;\n Wed, 18 Feb 2026 03:43:13 -0800 (PST)","by 2002:a17:902:d4d0:b0:2aa:e817:1bda with SMTP id\n d9443c01a7336-2ad50b980dcmr15409535ad.12.1771414993250;\n Wed, 18 Feb 2026 03:43:13 -0800 (PST)"],"From":"Ani Sinha ","To":"Paolo Bonzini , Marcelo Tosatti ","Cc":"Ani Sinha , kraxel@redhat.com, kvm@vger.kernel.org,\n qemu-devel@nongnu.org","Subject":"[PATCH v5 09/34] kvm/i386: implement architecture support for kvm\n file descriptor change","Date":"Wed, 18 Feb 2026 17:12:02 +0530","Message-ID":"<20260218114233.266178-10-anisinha@redhat.com>","X-Mailer":"git-send-email 2.42.0","In-Reply-To":"<20260218114233.266178-1-anisinha@redhat.com>","References":"<20260218114233.266178-1-anisinha@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=anisinha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When the kvm file descriptor changes as a part of confidential guest reset,\nsome architecture specific setups including SEV/SEV-SNP/TDX specific setups\nneeds to be redone. These changes are implemented as a part of the\nkvm_arch_on_vmfd_change() callback which was introduced previously.\n\nSigned-off-by: Ani Sinha \n---\n target/i386/kvm/kvm.c | 49 ++++++++++++++++++++++++++++--------\n target/i386/kvm/trace-events | 1 +\n 2 files changed, 39 insertions(+), 11 deletions(-)","diff":"diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c\nindex 83657fe832..8679e7d3fa 100644\n--- a/target/i386/kvm/kvm.c\n+++ b/target/i386/kvm/kvm.c\n@@ -3407,12 +3407,30 @@ static int kvm_vm_enable_energy_msrs(KVMState *s)\n \n int kvm_arch_on_vmfd_change(MachineState *ms, KVMState *s)\n {\n- abort();\n+ int ret;\n+\n+ ret = kvm_arch_init(ms, s);\n+ if (ret < 0) {\n+ return ret;\n+ }\n+\n+ if (object_dynamic_cast(OBJECT(ms), TYPE_X86_MACHINE)) {\n+ X86MachineState *x86ms = X86_MACHINE(ms);\n+\n+ if (x86_machine_is_smm_enabled(x86ms)) {\n+ memory_listener_register(&smram_listener.listener,\n+ &smram_address_space);\n+ }\n+ kvm_set_max_apic_id(x86ms->apic_id_limit);\n+ }\n+\n+ trace_kvm_arch_on_vmfd_change();\n+ return 0;\n }\n \n bool kvm_arch_supports_vmfd_change(void)\n {\n- return false;\n+ return true;\n }\n \n int kvm_arch_init(MachineState *ms, KVMState *s)\n@@ -3420,6 +3438,7 @@ int kvm_arch_init(MachineState *ms, KVMState *s)\n int ret;\n struct utsname utsname;\n Error *local_err = NULL;\n+ static bool first = true;\n \n /*\n * Initialize confidential guest (SEV/TDX) context, if required\n@@ -3489,16 +3508,17 @@ int kvm_arch_init(MachineState *ms, KVMState *s)\n return ret;\n }\n \n- /* Tell fw_cfg to notify the BIOS to reserve the range. */\n- e820_add_entry(KVM_IDENTITY_BASE, 0x4000, E820_RESERVED);\n-\n+ if (first) {\n+ /* Tell fw_cfg to notify the BIOS to reserve the range. */\n+ e820_add_entry(KVM_IDENTITY_BASE, 0x4000, E820_RESERVED);\n+ }\n ret = kvm_vm_set_nr_mmu_pages(s);\n if (ret < 0) {\n return ret;\n }\n \n if (object_dynamic_cast(OBJECT(ms), TYPE_X86_MACHINE) &&\n- x86_machine_is_smm_enabled(X86_MACHINE(ms))) {\n+ x86_machine_is_smm_enabled(X86_MACHINE(ms)) && first) {\n smram_machine_done.notify = register_smram_listener;\n qemu_add_machine_init_done_notifier(&smram_machine_done);\n }\n@@ -3545,16 +3565,23 @@ int kvm_arch_init(MachineState *ms, KVMState *s)\n return ret;\n }\n \n- ret = kvm_msr_energy_thread_init(s, ms);\n- if (ret < 0) {\n- error_report(\"kvm : error RAPL feature requirement not met\");\n- return ret;\n+ if (first) {\n+ ret = kvm_msr_energy_thread_init(s, ms);\n+ if (ret < 0) {\n+ error_report(\"kvm : \"\n+ \"error RAPL feature requirement not met\");\n+ return ret;\n+ }\n }\n }\n }\n \n pmu_cap = kvm_check_extension(s, KVM_CAP_PMU_CAPABILITY);\n- kvm_vmfd_add_change_notifier(&kvm_vmfd_change_notifier);\n+\n+ if (first) {\n+ kvm_vmfd_add_change_notifier(&kvm_vmfd_change_notifier);\n+ }\n+ first = false;\n \n return 0;\n }\ndiff --git a/target/i386/kvm/trace-events b/target/i386/kvm/trace-events\nindex 74a6234ff7..2d213c9f9b 100644\n--- a/target/i386/kvm/trace-events\n+++ b/target/i386/kvm/trace-events\n@@ -6,6 +6,7 @@ kvm_x86_add_msi_route(int virq) \"Adding route entry for virq %d\"\n kvm_x86_remove_msi_route(int virq) \"Removing route entry for virq %d\"\n kvm_x86_update_msi_routes(int num) \"Updated %d MSI routes\"\n kvm_hc_map_gpa_range(uint64_t gpa, uint64_t size, uint64_t attributes, uint64_t flags) \"gpa 0x%\" PRIx64 \" size 0x%\" PRIx64 \" attributes 0x%\" PRIx64 \" flags 0x%\" PRIx64\n+kvm_arch_on_vmfd_change(void) \"\"\n \n # xen-emu.c\n kvm_xen_hypercall(int cpu, uint8_t cpl, uint64_t input, uint64_t a0, uint64_t a1, uint64_t a2, uint64_t ret) \"xen_hypercall: cpu %d cpl %d input %\" PRIu64 \" a0 0x%\" PRIx64 \" a1 0x%\" PRIx64 \" a2 0x%\" PRIx64\" ret 0x%\" PRIx64\n","prefixes":["v5","09/34"]}