{"id":2197706,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197706/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260218114233.266178-16-anisinha@redhat.com>","date":"2026-02-18T11:42:08","name":"[v5,15/34] i386/tdx: refactor TDX firmware memory initialization code into a new function","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"217a6e0c47d57a55f17e811feb40c99844a5b313","submitter":{"id":86030,"url":"http://patchwork.ozlabs.org/api/1.0/people/86030/?format=json","name":"Ani Sinha","email":"anisinha@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260218114233.266178-16-anisinha@redhat.com/mbox/","series":[{"id":492541,"url":"http://patchwork.ozlabs.org/api/1.0/series/492541/?format=json","date":"2026-02-18T11:41:56","name":"Introduce support for confidential guest reset (x86)","version":5,"mbox":"http://patchwork.ozlabs.org/series/492541/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197706/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=jBqEkMFf;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=rDKSbxf4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGF6p5fXnz1xpl\n\tfor ; Wed, 18 Feb 2026 22:44:50 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsfy5-0003R2-3q; Wed, 18 Feb 2026 06:43:45 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsfxy-0003LI-Gj\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 06:43:38 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsfxw-0007t6-19\n for qemu-devel@nongnu.org; Wed, 18 Feb 2026 06:43:37 -0500","from mail-pl1-f199.google.com (mail-pl1-f199.google.com\n [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-695-gFap8oolNgqNKVoPtH-IeQ-1; Wed, 18 Feb 2026 06:43:33 -0500","by mail-pl1-f199.google.com with SMTP id\n d9443c01a7336-2aad3380076so4967325ad.1\n for ; Wed, 18 Feb 2026 03:43:33 -0800 (PST)","from rhel9-box.lan ([117.99.83.54])\n by smtp.googlemail.com with ESMTPSA id\n d9443c01a7336-2ad1aaeab38sm127803425ad.82.2026.02.18.03.43.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 18 Feb 2026 03:43:31 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771415014;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=r0oM0RRyjLelkT0G5RoaNy8SGcq/Mnkz7KKwnwr3WCA=;\n b=jBqEkMFfW1KkuypqYwZfruMXljPAcnfx/s8zaG2We72ZnpYBxYyPimOlBL6Kw5zvY4lXIU\n RrTRXX7cSb9CfHQ++nmbyImmTDiLIcqBdpMSprjNp4OqCO/kFoHVImBSlM9b2qTbUhk7is\n FSBQCLAFy639Sd5p0osWTN9GEUVEVXY=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1771415012; x=1772019812; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=r0oM0RRyjLelkT0G5RoaNy8SGcq/Mnkz7KKwnwr3WCA=;\n b=rDKSbxf4C5BJZwwp/nljkU0qQ6Df414Z7MFHRQG1ly8bAJMbUN/iyqDxQlVUarDF70\n AT2Wk4lCyRIYJMlPohlqXYP1uIXZKxSHrSX9eeUp1VV1Jl/tX3GlJ4TLZ+1QCdAFxy9y\n Mb4Pg5xocNT3Ii4UAIMkqUr8NxATkwIl8lhX9OdsAXECGl7NSschG7J0rMi+7zoxZbVX\n +29Eoue+24f/Vl13r9TbWRKznM9cqO3nJu1Bw66CJUCutxVZ5tncCZbdknCeqVkc92uW\n rokPMmsyrsxCJKyqG5NqboYwh81eUGMlv1wnKj+S/ikRshz7iDpFLyL0iX2sL1fhiToT\n VPrg=="],"X-MC-Unique":"gFap8oolNgqNKVoPtH-IeQ-1","X-Mimecast-MFC-AGG-ID":"gFap8oolNgqNKVoPtH-IeQ_1771415012","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771415012; x=1772019812;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=r0oM0RRyjLelkT0G5RoaNy8SGcq/Mnkz7KKwnwr3WCA=;\n b=MWxP4BECco4ja+Hcr+alXppmPFFsjza9puPMatWKTbkwPHzCuyrFg9fh/qK6k2lCb5\n gUYpKxG/XkBL+zUfaX4esl5FBcgf2UNfESCEs2BeiOf2eiEx0rZ15J3Bn59qyJN5nGsz\n QK8y+XbmFIBTGgv2voE0AvVJYdzrJevYJQpBH/sGcTzZn1B1MeV2z8MbEZgOhy+dDawU\n E7KvTGcrUeuAPQsv/1ilpxNYl7qBc9WQmsmAyLDTyHFDhutLqY7bCExB7+/JJAZ2z5fa\n Lw1RwTlcf9Ekk1W5AZJoiQm56HJn2W1bPyXkgLzasU9LCqhPxWdtptAgQJUC6eywjUPg\n s7Mw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWmfzti2P1uLLnxjkVjiEjZvV9LWSnf9Rgv0DsRwLGuW9BMoKzeaR64Z9ruP5TpgDg6FgsZgl1LxQPl@nongnu.org","X-Gm-Message-State":"AOJu0YyLB6CKrc8Zuh6stdoFlD194o0I/Bvmcig2ZdHhxJLi26WWfYkL\n expxKxIgt2LUfysjsnSF9P20w/6cezlBKJ1dwk4UuowZ/nT9jvJCFSRxIWUJCz1MicYcL3g2K1p\n L059idAC2H9uk7BCSuEvFd58ZgxD0mFZ54zYRdeBNVlJMY7I/APtaBzunAjKl2W95","X-Gm-Gg":"AZuq6aLTBWvdzOccV70wwpU6fyFwCQPXtk2rHgCB8HOxoXoR3No04TKQ2aIQQ7dHaYs\n j4hWsXhXgBz7jpZVMEYDPtWTNNhgOt42+3zTRinKhs7rp6oVzRqB5Q3UW6aStGqlJQJtLonWjgw\n gGGvllzyBQjLX+uKFjNC2876ExHyWKx/1gJ5o+U/3T/dF+yFsZWd+XveeUoMdxZWz8/MHRpgiZa\n n96YE5dFOdldpAxtm9Rp5E2f7AIOugFUGPV7J0D+xiuaLpm4Myo3ytGAeUY0t9Y/R2gTFqRbYPw\n xeVYsAlQTOhUgiZFo/zxOTcCdhp/6npwQcg21yuKn6rLjdBJnOHhjcUzVz/3temmkP3etdOxjlA\n AJ0QBjUwUBYsOZyyYWFKd8CCHiMQrtU08d7DQ8bM3bUAXjagsznFp","X-Received":["by 2002:a17:903:3ba5:b0:2a7:aac1:7201 with SMTP id\n d9443c01a7336-2ad50b5a062mr13233305ad.3.1771415012231;\n Wed, 18 Feb 2026 03:43:32 -0800 (PST)","by 2002:a17:903:3ba5:b0:2a7:aac1:7201 with SMTP id\n d9443c01a7336-2ad50b5a062mr13233165ad.3.1771415011824;\n Wed, 18 Feb 2026 03:43:31 -0800 (PST)"],"From":"Ani Sinha ","To":"Paolo Bonzini , Marcelo Tosatti ","Cc":"Ani Sinha , kraxel@redhat.com, kvm@vger.kernel.org,\n qemu-devel@nongnu.org","Subject":"[PATCH v5 15/34] i386/tdx: refactor TDX firmware memory\n initialization code into a new function","Date":"Wed, 18 Feb 2026 17:12:08 +0530","Message-ID":"<20260218114233.266178-16-anisinha@redhat.com>","X-Mailer":"git-send-email 2.42.0","In-Reply-To":"<20260218114233.266178-1-anisinha@redhat.com>","References":"<20260218114233.266178-1-anisinha@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=anisinha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"A new helper function is introduced that refactors all firmware memory\ninitialization code into a separate function. No functional change.\n\nSigned-off-by: Ani Sinha \n---\n target/i386/kvm/tdx.c | 73 ++++++++++++++++++++++++-------------------\n 1 file changed, 40 insertions(+), 33 deletions(-)","diff":"diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c\nindex a3e81e1c0c..fd8e3de969 100644\n--- a/target/i386/kvm/tdx.c\n+++ b/target/i386/kvm/tdx.c\n@@ -295,14 +295,51 @@ static void tdx_post_init_vcpus(void)\n }\n }\n \n-static void tdx_finalize_vm(Notifier *notifier, void *unused)\n+static void tdx_init_fw_mem_region(void)\n {\n TdxFirmware *tdvf = &tdx_guest->tdvf;\n TdxFirmwareEntry *entry;\n- RAMBlock *ram_block;\n Error *local_err = NULL;\n int r;\n \n+ for_each_tdx_fw_entry(tdvf, entry) {\n+ struct kvm_tdx_init_mem_region region;\n+ uint32_t flags;\n+\n+ region = (struct kvm_tdx_init_mem_region) {\n+ .source_addr = (uintptr_t)entry->mem_ptr,\n+ .gpa = entry->address,\n+ .nr_pages = entry->size >> 12,\n+ };\n+\n+ flags = entry->attributes & TDVF_SECTION_ATTRIBUTES_MR_EXTEND ?\n+ KVM_TDX_MEASURE_MEMORY_REGION : 0;\n+\n+ do {\n+ error_free(local_err);\n+ local_err = NULL;\n+ r = tdx_vcpu_ioctl(first_cpu, KVM_TDX_INIT_MEM_REGION, flags,\n+ ®ion, &local_err);\n+ } while (r == -EAGAIN || r == -EINTR);\n+ if (r < 0) {\n+ error_report_err(local_err);\n+ exit(1);\n+ }\n+\n+ if (entry->type == TDVF_SECTION_TYPE_TD_HOB ||\n+ entry->type == TDVF_SECTION_TYPE_TEMP_MEM) {\n+ qemu_ram_munmap(-1, entry->mem_ptr, entry->size);\n+ entry->mem_ptr = NULL;\n+ }\n+ }\n+}\n+\n+static void tdx_finalize_vm(Notifier *notifier, void *unused)\n+{\n+ TdxFirmware *tdvf = &tdx_guest->tdvf;\n+ TdxFirmwareEntry *entry;\n+ RAMBlock *ram_block;\n+\n tdx_init_ram_entries();\n \n for_each_tdx_fw_entry(tdvf, entry) {\n@@ -339,37 +376,7 @@ static void tdx_finalize_vm(Notifier *notifier, void *unused)\n tdvf_hob_create(tdx_guest, tdx_get_hob_entry(tdx_guest));\n \n tdx_post_init_vcpus();\n-\n- for_each_tdx_fw_entry(tdvf, entry) {\n- struct kvm_tdx_init_mem_region region;\n- uint32_t flags;\n-\n- region = (struct kvm_tdx_init_mem_region) {\n- .source_addr = (uintptr_t)entry->mem_ptr,\n- .gpa = entry->address,\n- .nr_pages = entry->size >> 12,\n- };\n-\n- flags = entry->attributes & TDVF_SECTION_ATTRIBUTES_MR_EXTEND ?\n- KVM_TDX_MEASURE_MEMORY_REGION : 0;\n-\n- do {\n- error_free(local_err);\n- local_err = NULL;\n- r = tdx_vcpu_ioctl(first_cpu, KVM_TDX_INIT_MEM_REGION, flags,\n- ®ion, &local_err);\n- } while (r == -EAGAIN || r == -EINTR);\n- if (r < 0) {\n- error_report_err(local_err);\n- exit(1);\n- }\n-\n- if (entry->type == TDVF_SECTION_TYPE_TD_HOB ||\n- entry->type == TDVF_SECTION_TYPE_TEMP_MEM) {\n- qemu_ram_munmap(-1, entry->mem_ptr, entry->size);\n- entry->mem_ptr = NULL;\n- }\n- }\n+ tdx_init_fw_mem_region();\n \n /*\n * TDVF image has been copied into private region above via\n","prefixes":["v5","15/34"]}