{"id":2197664,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197664/?format=json","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.0/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"","date":"2026-02-18T10:12:52","name":"[22/38] docs: kdoc_re: fix a parse bug on struct page_pool_params","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"1a3f44e70b3a63e139db474d1462b151edfaa07f","submitter":{"id":78235,"url":"http://patchwork.ozlabs.org/api/1.0/people/78235/?format=json","name":"Mauro Carvalho Chehab","email":"mchehab+huawei@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/db9a6339a339b203a474acc2ee9f56da1227a186.1771408406.git.mchehab+huawei@kernel.org/mbox/","series":[{"id":492532,"url":"http://patchwork.ozlabs.org/api/1.0/series/492532/?format=json","date":"2026-02-18T10:12:30","name":"docs: several improvements to kernel-doc","version":1,"mbox":"http://patchwork.ozlabs.org/series/492532/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197664/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=wTHxtFi4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGC5Z0xhCz1xwr\n\tfor ; Wed, 18 Feb 2026 21:13:38 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id B2886607FD;\n\tWed, 18 Feb 2026 10:13:36 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id fa9EFq2-LyE5; Wed, 18 Feb 2026 10:13:35 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 58BEB607DB;\n\tWed, 18 Feb 2026 10:13:35 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 642E371A\n for ; Wed, 18 Feb 2026 10:13:27 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 49C148109F\n for ; Wed, 18 Feb 2026 10:13:27 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id n4-GP3i8024s for ;\n Wed, 18 Feb 2026 10:13:26 +0000 (UTC)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n by smtp1.osuosl.org (Postfix) with ESMTPS id ABF6F810A0\n for ; Wed, 18 Feb 2026 10:13:26 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by sea.source.kernel.org (Postfix) with ESMTP id 71F5944578;\n Wed, 18 Feb 2026 10:13:26 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 4EC54C19421;\n Wed, 18 Feb 2026 10:13:26 +0000 (UTC)","from mchehab by mail.kernel.org with local (Exim 4.99.1)\n (envelope-from )\n id 1vseYe-00000000Lkk-2R7d; Wed, 18 Feb 2026 11:13:24 +0100"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 58BEB607DB","OpenDKIM Filter v2.11.0 smtp1.osuosl.org ABF6F810A0"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1771409615;\n\tbh=39GdJGyOvS/cxrKN4fNqdfA6j4Cc6KRIX/QkB2f4X9k=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=wTHxtFi4GjUeJSFqFGgJf8gPqKbXPcz0aBHRqi69UznSm6A14pJXBwe/gTEbJqedz\n\t BZI9qEgGIgDZq98m0M8HQPrcPEDOUCMS84FETep/Aspd8Q0DGhse4V9zCMOVyP07cZ\n\t PAkQ5GwKWtwJ7HpNL3ncFmf5c8vRHNpz1FR50tiNqPWng5RRb+rZfzAvcOOj+Y5CP3\n\t +DT/8mxUTeegwqKKUxOw+6WNp8k7tK6DAZX4LTBm0AOCPOppi0msQS2Q3YC6xTldyh\n\t /NYKYYJb2yssuyAuAa6G2QvTRNCZUPZFfmJoaEJEg6j1HL9H0x0zeMU4w2b8J7rd1f\n\t FInKgEJmrLRXg==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31;\n helo=sea.source.kernel.org; envelope-from=mchehab+huawei@kernel.org;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org ABF6F810A0","From":"Mauro Carvalho Chehab ","To":"Jonathan Corbet ,\n Linux Doc Mailing List ","Cc":"Mauro Carvalho Chehab ,\n intel-wired-lan@lists.osuosl.org, linux-hardening@vger.kernel.org,\n linux-kernel@vger.kernel.org, netdev@vger.kernel.org,\n Aleksandr Loktionov ,\n Randy Dunlap ","Date":"Wed, 18 Feb 2026 11:12:52 +0100","Message-ID":"\n ","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1771409606;\n bh=HfA9d8T9A4lV+0318XofpC8IU2OubqTIaLYGnkL8N/E=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ppwqRnrjYO15gyib+5lOd1ODAKoyy3cbzAvuXAwJPFrtNqICxs3RAC8jYSWdmmMdZ\n ql7Usz87PIjZt1BVES3WLc1Jj4pNfTEZLv8XV5SqztnYc1eHRTBn4hx2uB4NEoXCdg\n BAl0ju2sz5gzWXVg6z9PQRha+zgKsZDZ6sAQG6u9Ey+DiUc4x8kzFfKnqpsBmK34Uc\n 7Boeesp9dD3r8quVIBzIUTC08TavKn/9m0lzBTcLixRwha1kN2HTwjcbroCcCJWJg8\n ZNDQWYA2OvsPR++OMK/uvlCU2VWvEb5VNKhUXqp6CFfZSgDFp2yG43H10+9pxnrtx6\n 8+c6fmRkMdKNQ==","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.a=rsa-sha256 header.s=k20201202 header.b=ppwqRnrj"],"Subject":"[Intel-wired-lan] [PATCH 22/38] docs: kdoc_re: fix a parse bug on\n struct page_pool_params","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"The struct page_pool_params definition has a private\ndefinition on it:\n\n struct page_pool_params {\n\tstruct_group_tagged(page_pool_params_fast, fast,\n\t\tunsigned int\torder;\n\t\tunsigned int\tpool_size;\n\t\tint\t\tnid;\n\t\tstruct device\t*dev;\n\t\tstruct napi_struct *napi;\n\t\tenum dma_data_direction dma_dir;\n\t\tunsigned int\tmax_len;\n\t\tunsigned int\toffset;\n\t);\n\tstruct_group_tagged(page_pool_params_slow, slow,\n\t\tstruct net_device *netdev;\n\t\tunsigned int queue_idx;\n\t\tunsigned int\tflags;\n /* private: used by test code only */\n\t\tvoid (*init_callback)(netmem_ref netmem, void *arg);\n\t\tvoid *init_arg;\n\t);\n };\n\nThis makes kernel-doc parser to miss the end parenthesis of\nthe second struct_group_tagged, causing documentation issues.\n\nAddress it by ensuring that, if are there anything at the stack,\nit will be placed as the last part of the argument.\n\nSigned-off-by: Mauro Carvalho Chehab \nReviewed-by: Aleksandr Loktionov \n---\n tools/lib/python/kdoc/kdoc_re.py | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/tools/lib/python/kdoc/kdoc_re.py b/tools/lib/python/kdoc/kdoc_re.py\nindex 05f36d665b70..cdc842f5fc8f 100644\n--- a/tools/lib/python/kdoc/kdoc_re.py\n+++ b/tools/lib/python/kdoc/kdoc_re.py\n@@ -201,6 +201,9 @@ class NestedMatch:\n \"\"\"\n \n stack = []\n+ start = 0\n+ offset = 0\n+ pos = 0\n \n for match_re in self.regex.finditer(line):\n start = match_re.start()\n@@ -250,6 +253,11 @@ class NestedMatch:\n yield start, offset, pos + 1\n break\n \n+ # When /* private */ is used, it may end the end delimiterq\n+ if stack:\n+ stack.pop()\n+ yield start, offset, len(line) + 1\n+\n def search(self, line):\n \"\"\"\n This is similar to re.search:\n","prefixes":["22/38"]}