{"id":2197659,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197659/?format=json","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.0/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<6141a2f9378a79c76b3a8e860b82c46bc8bfb048.1771408406.git.mchehab+huawei@kernel.org>","date":"2026-02-18T10:12:38","name":"[08/38] docs: kdoc_parser: fix the default_value logic for variables","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"ea4d045c98c2363e86164cdc64ff4d92e86dab75","submitter":{"id":78235,"url":"http://patchwork.ozlabs.org/api/1.0/people/78235/?format=json","name":"Mauro Carvalho Chehab","email":"mchehab+huawei@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/6141a2f9378a79c76b3a8e860b82c46bc8bfb048.1771408406.git.mchehab+huawei@kernel.org/mbox/","series":[{"id":492532,"url":"http://patchwork.ozlabs.org/api/1.0/series/492532/?format=json","date":"2026-02-18T10:12:30","name":"docs: several improvements to kernel-doc","version":1,"mbox":"http://patchwork.ozlabs.org/series/492532/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197659/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=rNKxMJyf;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fGC5T2q05z1xpl\n\tfor ; Wed, 18 Feb 2026 21:13:33 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id AED66407E4;\n\tWed, 18 Feb 2026 10:13:27 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id j2Mb5o_YqtXo; Wed, 18 Feb 2026 10:13:27 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 040F4407CA;\n\tWed, 18 Feb 2026 10:13:27 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id 007D035B\n for ; Wed, 18 Feb 2026 10:13:22 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id DA71C4009A\n for ; Wed, 18 Feb 2026 10:13:22 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id f6cxpK3VAK2j for ;\n Wed, 18 Feb 2026 10:13:22 +0000 (UTC)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 2E98440078\n for ; Wed, 18 Feb 2026 10:13:21 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id EF9F56185E;\n Wed, 18 Feb 2026 10:13:20 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id A4AB1C19421;\n Wed, 18 Feb 2026 10:13:20 +0000 (UTC)","from mchehab by mail.kernel.org with local (Exim 4.99.1)\n (envelope-from )\n id 1vseYY-00000000LTL-3hcM; Wed, 18 Feb 2026 11:13:18 +0100"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 040F4407CA","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2E98440078"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1771409607;\n\tbh=i+d3jTIL00faN1OTXFR7H2YyQ1aclavZYQQ0aJ0WgJ0=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=rNKxMJyfZWmP2ldkkJKNkZQpbA5CpWBvc/HV3LrvxrtEXxkrFj7O2NkwqJZ6Q1Mqr\n\t Aaj26XpJdMJNjDQUXjzhvjstrwEdwEI3cPFZzC06DNjvVHCoW9Umm+PYdqQLec6rGU\n\t hB7jBr+mMdNMTNSvVqSCSkKVP4reFTVSrOm00lW1V5AqPsOQvp32RVcxWb+3IPVdxj\n\t /ULNMHmeXUvROsIye8YybYXyH8xy/QYD0O4PQ/l4VX9NqOsGHJnjG8vL2rWzanT4Ta\n\t sEzBSVWsCJgHNS0faUHM7NZYQFutQLvj3LY/N4OCIGj/wXZRmDpn4yUlsP+1KEi0Vq\n\t GXTKXHP0nRQzg==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=mchehab+huawei@kernel.org; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 2E98440078","From":"Mauro Carvalho Chehab ","To":"Jonathan Corbet ,\n Linux Doc Mailing List ","Cc":"Mauro Carvalho Chehab ,\n intel-wired-lan@lists.osuosl.org, linux-hardening@vger.kernel.org,\n linux-kernel@vger.kernel.org, netdev@vger.kernel.org,\n Aleksandr Loktionov ,\n Randy Dunlap ","Date":"Wed, 18 Feb 2026 11:12:38 +0100","Message-ID":"\n <6141a2f9378a79c76b3a8e860b82c46bc8bfb048.1771408406.git.mchehab+huawei@kernel.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1771409600;\n bh=SOaPcpSwL2YOZCy5eFxw6vXlh6YPzp2zJBUs62B0pPk=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=hQKq7jXQAmnA1oi17FdW1WrT9lMnn/BxlrBnoB38O4kWhyj2xlLjtbM5SZFCp+kvw\n nnhJlECeI4ozMfT81rso4oUW/f/vIAHy4h2Vdg/sDz1xSMGvwpmDfcGoe1u+S5NEqN\n tPDK5O8K1r0+wDO/7rOmxS/ODjxxmVsa+CnhhUZpk/lHkJ5Mvr912Oz9Au/8FI8CNk\n s+364r21AxnZXLoAaXjf3bWb1VOqXDdmkeRY2HOKIeehkAy/Od4ZJ0VJ+QRTLoZIkd\n dogFzd2iBPNdPPLWXOkSm/0LZw4ek1MeGsLpDh099eFQsXCJklqXDA0YharYHMa4rw\n gpnjrPPbhFwYw==","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.a=rsa-sha256 header.s=k20201202 header.b=hQKq7jXQ"],"Subject":"[Intel-wired-lan] [PATCH 08/38] docs: kdoc_parser: fix the\n default_value logic for variables","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"The indentation is wrong for the second regex, which causes\nproblems on variables with defaults.\n\nSigned-off-by: Mauro Carvalho Chehab \nAcked-by: Randy Dunlap \nTested-by: Randy Dunlap \nReviewed-by: Aleksandr Loktionov \n---\n tools/lib/python/kdoc/kdoc_parser.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/tools/lib/python/kdoc/kdoc_parser.py b/tools/lib/python/kdoc/kdoc_parser.py\nindex b63d91b7f79e..abfa693051cb 100644\n--- a/tools/lib/python/kdoc/kdoc_parser.py\n+++ b/tools/lib/python/kdoc/kdoc_parser.py\n@@ -1036,9 +1036,9 @@ class KernelDoc:\n default_val = r.group(2)\n else:\n r= KernRe(OPTIONAL_VAR_ATTR + r\"(?:[\\w_]*)?\\s+(?:\\*+)?(?:[\\w_]+)\\s*[\\d\\]\\[]*\\s*(=.*)?\")\n- if r.match(proto):\n- default_val = r.group(1)\n \n+ if r.match(proto):\n+ default_val = r.group(1)\n if not declaration_name:\n self.emit_msg(ln,f\"{proto}: can't parse variable\")\n return\n","prefixes":["08/38"]}