{"id":2197473,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197473/?format=json","project":{"id":9,"url":"http://patchwork.ozlabs.org/api/1.0/projects/9/?format=json","name":"Linux RTC development","link_name":"rtc-linux","list_id":"linux-rtc.vger.kernel.org","list_email":"linux-rtc@vger.kernel.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<95e5af90-ed53-4009-a4ea-19ed04499ecc@kernel.org>","date":"2026-02-17T22:26:26","name":"[RFC,02/10] rtc: prepare for struct device member groups becoming a constant array","commit_ref":null,"pull_url":null,"state":"handled-elsewhere","archived":false,"hash":"7877e16e466ffb5b94d6e92b1f41d41dc22c187d","submitter":{"id":88130,"url":"http://patchwork.ozlabs.org/api/1.0/people/88130/?format=json","name":"Heiner Kallweit","email":"hkall@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/rtc-linux/patch/95e5af90-ed53-4009-a4ea-19ed04499ecc@kernel.org/mbox/","series":[{"id":492492,"url":"http://patchwork.ozlabs.org/api/1.0/series/492492/?format=json","date":"2026-02-17T22:24:26","name":"driver core: constify groups arrays in several structs","version":1,"mbox":"http://patchwork.ozlabs.org/series/492492/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197473/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-rtc@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=iaDc5hRk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-rtc+bounces-5970-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"iaDc5hRk\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFvPk4HzHz1xpl\n\tfor ; Wed, 18 Feb 2026 09:26:34 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 2AC6B30151D5\n\tfor ; Tue, 17 Feb 2026 22:26:32 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 11ADF318EC2;\n\tTue, 17 Feb 2026 22:26:31 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E2A68318B96;\n\tTue, 17 Feb 2026 22:26:30 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 38CA0C4CEF7;\n\tTue, 17 Feb 2026 22:26:28 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1771367191; cv=none;\n b=YJ64JtdqovHBYzqZ4MjHrltAA4WBekliYcbqghslZY2/HgV0bt5oYiM3SkqR5+Zbf/tDHlVnXa5XVRgYqCcXkUclkL5RB5OVvfN0Xt3HLEgDSeJpqMWvI2JK3CFAgKj5WS+P0I3KUET9y16+zCE1lEeH6jcmqQvIx/pmlJUiTcQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1771367191; c=relaxed/simple;\n\tbh=RmsK6mmAsFn3kMOgdOxe8MRr28G1U6zGaOeHBWEMZ9E=;\n\th=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References:\n\t In-Reply-To:Content-Type;\n b=Zi+XA/+pWLVWw2kQ3T8ROjTs0TxSSyQi0I5+TWvoPhj6bEsMCFXxToap7Pynk+KmVHxueVgpoq7q12fd1dxTLJYorBo7uXGxGN2fBy0aeS2bnISZyH+Td0vyQ9fY+nZC9b6uTkMTgtIczKTN1J7mOI5dG0jjKtD2rYmc1TZG8vc=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=iaDc5hRk; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1771367190;\n\tbh=RmsK6mmAsFn3kMOgdOxe8MRr28G1U6zGaOeHBWEMZ9E=;\n\th=Date:Subject:From:To:Cc:References:In-Reply-To:From;\n\tb=iaDc5hRkRXBnBH9OIzZW+YliZvA35wCYxK5I1/lQWeue6oq7nvT7OHFjExbAbDpya\n\t cygBFw+/gQD7Tk83SHM7ELv5wibPxfQ5fY09xq8vV45Dj2zgRT19VEJvqVHAB5J9xg\n\t X/LHLXTXmFbso6sN6pqQSrGw6Npaei70Ci8oBV5IFbGCUQK9afQtA6kGTxxrVEe1e8\n\t hfKy6e4GaL9USZtzPzwK0mlBCpfpEdu0rfFB4TRTrDlkXHJ3BiLMfQIYdsupf4Lt0I\n\t pmUxX8heePlPZhRsZCQaI0RfYndHtVtk4s2UKUzwp5pPgCj4H7YFE6c5OVE9lyMOAB\n\t cLmonA7QfAYJQ==","Message-ID":"<95e5af90-ed53-4009-a4ea-19ed04499ecc@kernel.org>","Date":"Tue, 17 Feb 2026 23:26:26 +0100","Precedence":"bulk","X-Mailing-List":"linux-rtc@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"[PATCH RFC 02/10] rtc: prepare for struct device member groups\n becoming a constant array","From":"Heiner Kallweit ","To":"=?utf-8?q?Thomas_Wei=C3=9Fschuh?= ,\n Greg Kroah-Hartman ,\n \"Rafael J. Wysocki\" , Danilo Krummrich ,\n Jason Gunthorpe , Leon Romanovsky ,\n Alexandre Belloni ","Cc":"driver-core@lists.linux.dev,\n Linux Kernel Mailing List ,\n linux-rdma@vger.kernel.org, linux-rtc@vger.kernel.org","References":"<5d0951ec-42c9-453f-9966-ecca593c4153@kernel.org>","Content-Language":"en-US","In-Reply-To":"<5d0951ec-42c9-453f-9966-ecca593c4153@kernel.org>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit"},"content":"This prepares for making struct device member groups a constant array.\nThe assignment groups = rtc->dev.groups would result in a \"discarding\nconst qualifier\" warning with this change.\nNo functional change intended.\n\nSigned-off-by: Heiner Kallweit \n---\n drivers/rtc/sysfs.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/rtc/sysfs.c b/drivers/rtc/sysfs.c\nindex 4ab05e105a7..ae5e1252b4c 100644\n--- a/drivers/rtc/sysfs.c\n+++ b/drivers/rtc/sysfs.c\n@@ -308,7 +308,7 @@ const struct attribute_group **rtc_get_dev_attribute_groups(void)\n int rtc_add_groups(struct rtc_device *rtc, const struct attribute_group **grps)\n {\n \tsize_t old_cnt = 0, add_cnt = 0, new_cnt;\n-\tconst struct attribute_group **groups, **old;\n+\tconst struct attribute_group **groups, *const *old;\n \n \tif (grps) {\n \t\tfor (groups = grps; *groups; groups++)\n@@ -320,9 +320,9 @@ int rtc_add_groups(struct rtc_device *rtc, const struct attribute_group **grps)\n \t\treturn -EINVAL;\n \t}\n \n-\tgroups = rtc->dev.groups;\n-\tif (groups)\n-\t\tfor (; *groups; groups++)\n+\told = rtc->dev.groups;\n+\tif (old)\n+\t\twhile (*old++)\n \t\t\told_cnt++;\n \n \tnew_cnt = old_cnt + add_cnt + 1;\n","prefixes":["RFC","02/10"]}