{"id":2197457,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197457/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260217214928.2970885-18-dmitry.osipenko@collabora.com>","date":"2026-02-17T21:49:26","name":"[v18,17/19] virtio-gpu: Replace finish_unmapping with mapping_state","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ae11fe1920882cd24941b203923d3eab4aacd76d","submitter":{"id":83453,"url":"http://patchwork.ozlabs.org/api/1.0/people/83453/?format=json","name":"Dmitry Osipenko","email":"dmitry.osipenko@collabora.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217214928.2970885-18-dmitry.osipenko@collabora.com/mbox/","series":[{"id":492488,"url":"http://patchwork.ozlabs.org/api/1.0/series/492488/?format=json","date":"2026-02-17T21:49:09","name":"Support virtio-gpu DRM native context and MAP_FIXED API","version":18,"mbox":"http://patchwork.ozlabs.org/series/492488/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197457/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=collabora.com header.i=dmitry.osipenko@collabora.com\n header.a=rsa-sha256 header.s=zohomail header.b=ZJCEYpdp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFtgT5t2Cz1xwC\n\tfor ; Wed, 18 Feb 2026 08:53:25 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsT0P-0002Vd-U6; Tue, 17 Feb 2026 16:53:18 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsT0N-0001yt-0S\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:53:15 -0500","from sender4-pp-f112.zoho.com ([136.143.188.112])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsT0L-0001ja-6J\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:53:14 -0500","by mx.zohomail.com with SMTPS id 1771365175884339.04789913936406;\n Tue, 17 Feb 2026 13:52:55 -0800 (PST)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1771365178; cv=none;\n d=zohomail.com; s=zohoarc;\n b=hk1Iln0aQprJuGtIvW9k0YTCwwI0hXhgW7uqcHeX+YbayVFzAunc/IjSjHfyEFyACbh44JEiRk017WSZl8yr8hiA74B4kxB3l/0QARg1VQ75glpZjzV26QT56Jrsf18AOWP5fiA9ym38zhHZDOJEm13nvGVj4KeDsoE6GYUvZtU=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;\n s=zohoarc; t=1771365178;\n h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n bh=b2Pgzfrzo1PqN2tXCDt8RGeml0pRrj4thfov8N29dxY=;\n b=IkDuddipniW4bnX/tcSMzDbsMUujKejEqKBToKh4UV3CsTmWgLAxbYA2C8ZHnRIGFxurrGOJVx/6pdKWUvEh7wIm0S6xV3TtZ1FkQ/w3pWUeLuKmqXyN0RvxFZyN/fgVCsL5j4Ffmll5zwY0xj6T927QAeJg86VKEaFHWye1Kdo=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n dkim=pass header.i=collabora.com;\n spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;\n dmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1771365178;\n s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;\n h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n bh=b2Pgzfrzo1PqN2tXCDt8RGeml0pRrj4thfov8N29dxY=;\n b=ZJCEYpdp/yjwRsZnxsaBcDV21Q41x7SoK/MuxnAvuWuRtvn92J72LHreMbl2Y/6k\n 3MWkcIlwg9Xw0l5YczByU2yQ5vUMCKjX8wvZLsOHhPnt0mnV/KeI32Oq346Ctcdt2cD\n Xsc25qQtBSm+KFVR+J/QlQ1aHNGxWlst1/zSTMkc=","From":"Dmitry Osipenko ","To":"Akihiko Odaki ,\n Huang Rui ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Gerd Hoffmann ,\n =?utf-8?q?Alex_Benn=C3=A9e?= ,\n Pierre-Eric Pelloux-Prayer ,\n \"Michael S . Tsirkin\" , Paolo Bonzini ,\n Yiwei Zhang , Sergio Lopez Pascual ","Cc":"Gert Wollny , qemu-devel@nongnu.org,\n Gurchetan Singh , Alyssa Ross ,\n\t=?utf-8?q?Roger_Pau_Monn=C3=A9?= ,\n Alex Deucher ,\n Stefano Stabellini , =?utf-8?q?Christian_K?=\n\t=?utf-8?q?=C3=B6nig?= ,\n Xenia Ragiadakou ,\n Honglei Huang , Julia Zhang ,\n Chen Jiqian , Rob Clark ,\n Robert Beckett ","Subject":"[PATCH v18 17/19] virtio-gpu: Replace finish_unmapping with\n mapping_state","Date":"Wed, 18 Feb 2026 00:49:26 +0300","Message-ID":"<20260217214928.2970885-18-dmitry.osipenko@collabora.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260217214928.2970885-1-dmitry.osipenko@collabora.com>","References":"<20260217214928.2970885-1-dmitry.osipenko@collabora.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-ZohoMailClient":"External","Received-SPF":"pass client-ip=136.143.188.112;\n envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Allow virtio_gpu_virgl_unmap_resource_blob() to be invoked while async\nunmapping is in progress. Do it in preparation to improvement of virtio-gpu\nresetting that will require this change.\n\nSuggested-by: Akihiko Odaki \nSigned-off-by: Dmitry Osipenko \n---\n hw/display/trace-events | 2 +-\n hw/display/virtio-gpu-virgl.c | 28 ++++++++++++++++++++++------\n 2 files changed, 23 insertions(+), 7 deletions(-)","diff":"diff --git a/hw/display/trace-events b/hw/display/trace-events\nindex e323a82cff24..4bfc457fbac1 100644\n--- a/hw/display/trace-events\n+++ b/hw/display/trace-events\n@@ -39,7 +39,7 @@ virtio_gpu_cmd_res_create_2d(uint32_t res, uint32_t fmt, uint32_t w, uint32_t h)\n virtio_gpu_cmd_res_create_3d(uint32_t res, uint32_t fmt, uint32_t w, uint32_t h, uint32_t d) \"res 0x%x, fmt 0x%x, w %d, h %d, d %d\"\n virtio_gpu_cmd_res_create_blob(uint32_t res, uint64_t size) \"res 0x%x, size %\" PRId64\n virtio_gpu_cmd_res_map_blob(uint32_t res, void *vmr, void *mr) \"res 0x%x, vmr %p, mr %p\"\n-virtio_gpu_cmd_res_unmap_blob(uint32_t res, void *mr, bool finish_unmapping) \"res 0x%x, mr %p, finish_unmapping %d\"\n+virtio_gpu_cmd_res_unmap_blob(uint32_t res, void *mr, int mapping_state) \"res 0x%x, mr %p, mapping_state %d\"\n virtio_gpu_cmd_res_unref(uint32_t res) \"res 0x%x\"\n virtio_gpu_cmd_res_back_attach(uint32_t res) \"res 0x%x\"\n virtio_gpu_cmd_res_back_detach(uint32_t res) \"res 0x%x\"\ndiff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c\nindex 77fe5cd4ecd8..8cbbe890d282 100644\n--- a/hw/display/virtio-gpu-virgl.c\n+++ b/hw/display/virtio-gpu-virgl.c\n@@ -68,11 +68,17 @@ virgl_get_egl_display(G_GNUC_UNUSED void *cookie)\n #endif\n \n #if VIRGL_VERSION_MAJOR >= 1\n+enum virtio_gpu_virgl_hostmem_region_mapping_state {\n+ VIRTIO_GPU_MR_MAPPED,\n+ VIRTIO_GPU_MR_UNMAP_STARTED,\n+ VIRTIO_GPU_MR_UNMAP_COMPLETED,\n+};\n+\n struct virtio_gpu_virgl_hostmem_region {\n Object parent_obj;\n MemoryRegion mr;\n struct VirtIOGPU *g;\n- bool finish_unmapping;\n+ enum virtio_gpu_virgl_hostmem_region_mapping_state mapping_state;\n };\n \n #define TYPE_VIRTIO_GPU_VIRGL_HOSTMEM_REGION \"virtio-gpu-virgl-hostmem-region\"\n@@ -109,7 +115,7 @@ static void virtio_gpu_virgl_hostmem_region_finalize(Object *obj)\n return;\n }\n \n- vmr->finish_unmapping = true;\n+ vmr->mapping_state = VIRTIO_GPU_MR_UNMAP_COMPLETED;\n \n b = VIRTIO_GPU_BASE(vmr->g);\n b->renderer_blocked--;\n@@ -167,6 +173,7 @@ virtio_gpu_virgl_map_resource_blob(VirtIOGPU *g,\n object_initialize_child(OBJECT(g), name, vmr,\n TYPE_VIRTIO_GPU_VIRGL_HOSTMEM_REGION);\n vmr->g = g;\n+ vmr->mapping_state = VIRTIO_GPU_MR_MAPPED;\n \n mr = &vmr->mr;\n memory_region_init_ram_ptr(mr, OBJECT(vmr), \"mr\", size, data);\n@@ -195,7 +202,8 @@ virtio_gpu_virgl_unmap_resource_blob(VirtIOGPU *g,\n \n vmr = to_hostmem_region(res->mr);\n \n- trace_virtio_gpu_cmd_res_unmap_blob(res->base.resource_id, mr, vmr->finish_unmapping);\n+ trace_virtio_gpu_cmd_res_unmap_blob(res->base.resource_id, mr,\n+ vmr->mapping_state);\n \n /*\n * Perform async unmapping in 3 steps:\n@@ -206,7 +214,8 @@ virtio_gpu_virgl_unmap_resource_blob(VirtIOGPU *g,\n * asynchronously by virtio_gpu_virgl_hostmem_region_finalize().\n * 3. Finish the unmapping with final virgl_renderer_resource_unmap().\n */\n- if (vmr->finish_unmapping) {\n+ switch (vmr->mapping_state) {\n+ case VIRTIO_GPU_MR_UNMAP_COMPLETED:\n res->mr = NULL;\n g_free(vmr);\n \n@@ -217,15 +226,22 @@ virtio_gpu_virgl_unmap_resource_blob(VirtIOGPU *g,\n __func__, strerror(-ret));\n return ret;\n }\n- } else {\n- *cmd_suspended = true;\n+ break;\n \n+ case VIRTIO_GPU_MR_MAPPED:\n /* render will be unblocked once MR is freed */\n b->renderer_blocked++;\n \n+ vmr->mapping_state = VIRTIO_GPU_MR_UNMAP_STARTED;\n+\n /* memory region owns self res->mr object and frees it by itself */\n memory_region_del_subregion(&b->hostmem, mr);\n object_unparent(OBJECT(vmr));\n+\n+ /* Fallthrough */\n+ case VIRTIO_GPU_MR_UNMAP_STARTED:\n+ *cmd_suspended = true;\n+ break;\n }\n \n return 0;\n","prefixes":["v18","17/19"]}