{"id":2197453,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197453/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260217214928.2970885-16-dmitry.osipenko@collabora.com>","date":"2026-02-17T21:49:24","name":"[v18,15/19] virtio-gpu: Remove superfluous memory_region_set_enabled()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"04ba65e9a4b7d99532ac7fce5994eb1f481693ac","submitter":{"id":83453,"url":"http://patchwork.ozlabs.org/api/1.0/people/83453/?format=json","name":"Dmitry Osipenko","email":"dmitry.osipenko@collabora.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217214928.2970885-16-dmitry.osipenko@collabora.com/mbox/","series":[{"id":492488,"url":"http://patchwork.ozlabs.org/api/1.0/series/492488/?format=json","date":"2026-02-17T21:49:09","name":"Support virtio-gpu DRM native context and MAP_FIXED API","version":18,"mbox":"http://patchwork.ozlabs.org/series/492488/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197453/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=collabora.com header.i=dmitry.osipenko@collabora.com\n header.a=rsa-sha256 header.s=zohomail header.b=eKfVpO5P;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFtgP2NX4z1xwC\n\tfor ; Wed, 18 Feb 2026 08:53:21 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsT0O-0002B0-1F; Tue, 17 Feb 2026 16:53:16 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsT0M-0001lY-0L\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:53:14 -0500","from sender4-pp-f112.zoho.com ([136.143.188.112])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsT0K-0001j5-Cz\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:53:13 -0500","by mx.zohomail.com with SMTPS id 1771365164113810.5349609578999;\n Tue, 17 Feb 2026 13:52:44 -0800 (PST)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1771365166; cv=none;\n d=zohomail.com; s=zohoarc;\n b=g4Moue877n9Ah/TqyJM+CrU3G0+mk1oZEtcyxQQQd3L1N/6Ypib3+sr+9IDwpKL1OZXc1asWwfr7u+jh8vTLLDRWoAgIXFIi8IXBQma/Ck/dWd2nXEMvCtc17ds38lQtyxbJUGMHLbNozD1HRJd8lY2RPZvJwAubDTOB3kbu/TI=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;\n s=zohoarc; t=1771365166;\n h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n bh=MnAWX1/8qWX7crHXkyrA5HmZia37KH19jYO+NvZT20w=;\n b=dvizTZuHVMLYziTF8NJUjdrkjChzdqpkVuGwksx+5DhH26d+jtLoCcj4yyoMb8J/z0vQNliSTNnzcqADWeIHgMv1mPjGo/xeH5DQduAWAVkCmQjrjFNsuVL1EfSFJrwqpbKE0BzLFCX2uqcvvGN+oCWNIta1HU77nZ6ytEikjxc=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n dkim=pass header.i=collabora.com;\n spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;\n dmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1771365166;\n s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;\n h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;\n bh=MnAWX1/8qWX7crHXkyrA5HmZia37KH19jYO+NvZT20w=;\n b=eKfVpO5PD9OGbEMOk+RoQhZ8BhR0hyU3nxVUCPEirDq1aUsuc5CpaBjJluW4jY3M\n AlLM779e8miBFmy4XQf7uOONC+AFWfkdq69OhVseN9D4uh6am0+h0s4c+xV8E6WmLB4\n IeJx5TNXxwbx+1xg/Aw8J0Y6wW+Z0PJ6QvJtWlQs=","From":"Dmitry Osipenko ","To":"Akihiko Odaki ,\n Huang Rui ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Gerd Hoffmann ,\n =?utf-8?q?Alex_Benn=C3=A9e?= ,\n Pierre-Eric Pelloux-Prayer ,\n \"Michael S . Tsirkin\" , Paolo Bonzini ,\n Yiwei Zhang , Sergio Lopez Pascual ","Cc":"Gert Wollny , qemu-devel@nongnu.org,\n Gurchetan Singh , Alyssa Ross ,\n\t=?utf-8?q?Roger_Pau_Monn=C3=A9?= ,\n Alex Deucher ,\n Stefano Stabellini , =?utf-8?q?Christian_K?=\n\t=?utf-8?q?=C3=B6nig?= ,\n Xenia Ragiadakou ,\n Honglei Huang , Julia Zhang ,\n Chen Jiqian , Rob Clark ,\n Robert Beckett ","Subject":"[PATCH v18 15/19] virtio-gpu: Remove superfluous\n memory_region_set_enabled()","Date":"Wed, 18 Feb 2026 00:49:24 +0300","Message-ID":"<20260217214928.2970885-16-dmitry.osipenko@collabora.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260217214928.2970885-1-dmitry.osipenko@collabora.com>","References":"<20260217214928.2970885-1-dmitry.osipenko@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-ZohoMailClient":"External","Received-SPF":"pass client-ip=136.143.188.112;\n envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"There is no need to explicitly enable/disable memory region when it's\nadded or deleted respectively. Remove superfluous set_enabled() calls\nfor consistency.\n\nSuggested-by: Akihiko Odaki \nReviewed-by: Akihiko Odaki \nReviewed-by: Alex Bennée \nSigned-off-by: Dmitry Osipenko \n---\n hw/display/virtio-gpu-virgl.c | 2 --\n 1 file changed, 2 deletions(-)","diff":"diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c\nindex 069408c68644..b8e3c7e9aee9 100644\n--- a/hw/display/virtio-gpu-virgl.c\n+++ b/hw/display/virtio-gpu-virgl.c\n@@ -171,7 +171,6 @@ virtio_gpu_virgl_map_resource_blob(VirtIOGPU *g,\n mr = &vmr->mr;\n memory_region_init_ram_ptr(mr, OBJECT(vmr), \"mr\", size, data);\n memory_region_add_subregion(&b->hostmem, offset, mr);\n- memory_region_set_enabled(mr, true);\n \n res->mr = mr;\n \n@@ -225,7 +224,6 @@ virtio_gpu_virgl_unmap_resource_blob(VirtIOGPU *g,\n b->renderer_blocked++;\n \n /* memory region owns self res->mr object and frees it by itself */\n- memory_region_set_enabled(mr, false);\n memory_region_del_subregion(&b->hostmem, mr);\n object_unparent(OBJECT(vmr));\n }\n","prefixes":["v18","15/19"]}