{"id":2197445,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197445/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260217214928.2970885-6-dmitry.osipenko@collabora.com>","date":"2026-02-17T21:49:14","name":"[v18,05/19] ui/gtk-egl: Unset context after GL operations","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2a1dca37eb92b78424cd03401fb1de503538c829","submitter":{"id":83453,"url":"http://patchwork.ozlabs.org/api/1.0/people/83453/?format=json","name":"Dmitry Osipenko","email":"dmitry.osipenko@collabora.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217214928.2970885-6-dmitry.osipenko@collabora.com/mbox/","series":[{"id":492488,"url":"http://patchwork.ozlabs.org/api/1.0/series/492488/?format=json","date":"2026-02-17T21:49:09","name":"Support virtio-gpu DRM native context and MAP_FIXED API","version":18,"mbox":"http://patchwork.ozlabs.org/series/492488/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197445/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=collabora.com header.i=dmitry.osipenko@collabora.com\n header.a=rsa-sha256 header.s=zohomail header.b=Bnsu5N1B;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFtfn6Zt8z1xwC\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 18 Feb 2026 08:52:49 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vsSzK-0008Jw-En; Tue, 17 Feb 2026 16:52:12 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)\n id 1vsSzD-0008CP-5f\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:52:03 -0500","from sender4-pp-f112.zoho.com ([136.143.188.112])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)\n id 1vsSzB-0001Om-L2\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:52:02 -0500","by mx.zohomail.com with SMTPS id 1771365105744235.661391243264;\n Tue, 17 Feb 2026 13:51:45 -0800 (PST)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1771365108; cv=none;\n d=zohomail.com; s=zohoarc;\n b=UunZLyU4WkyU33ySKWDRuJs27rlxNYznnhMsQ28wyKiBz1EUQXsqNJb7hqUslKOib9I3a2yqE6ZLTY1Ca/LICYLFJxd3Hn+g+AJQKsytfGrHkeAMITqBfCuSUTt428Qt98+CVsT/eb/sg9ObOZZetS6RYbIrqFxBwbvEw8bM/Wc=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;\n s=zohoarc; t=1771365108;\n h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n bh=m2atH/1ReVFvc2mpUW0OG4VIKhYkpV3eeI5xUGoYe60=;\n b=UeF4GCfnAhgMY9x82qimxnkbofH3h2QZu9e/gTWECYX7SRtv/GiXNdXcHkmJA348azvOJmlLQj5WgK01QTWt4wPDJoKJv2CYDrT1cG/Y01xOI4V+qK906zehbd0966GtuvIeBCvXWbR9WOTqvYDFsTfn22EgC3mMe1s5/MoLQNo=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n dkim=pass  header.i=collabora.com;\n spf=pass  smtp.mailfrom=dmitry.osipenko@collabora.com;\n dmarc=pass header.from=<dmitry.osipenko@collabora.com>","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1771365108;\n s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;\n h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n bh=m2atH/1ReVFvc2mpUW0OG4VIKhYkpV3eeI5xUGoYe60=;\n b=Bnsu5N1B1YNXPB+ewwZHKR7YgcJD21j7PsRphX1l9wDTeB8ZPbLzTZN/n7sjESMd\n IS39rCfWHT3ltvi80dl2QSBFaN2Db7rYGbkH7Uqt5AWDYI2NBCZ9sm1urERNn+wmxGI\n sABG4afxdR8FTdM6/fCUTrAR5JomxvuKDFgcQFa0=","From":"Dmitry Osipenko <dmitry.osipenko@collabora.com>","To":"Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Huang Rui <ray.huang@amd.com>,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Gerd Hoffmann <kraxel@redhat.com>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,\n \"Michael S . Tsirkin\" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n Yiwei Zhang <zzyiwei@gmail.com>, Sergio Lopez Pascual <slp@redhat.com>","Cc":"Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,\n Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,\n\t=?utf-8?q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>,\n Alex Deucher <alexander.deucher@amd.com>,\n Stefano Stabellini <stefano.stabellini@amd.com>, =?utf-8?q?Christian_K?=\n\t=?utf-8?q?=C3=B6nig?= <christian.koenig@amd.com>,\n Xenia Ragiadakou <xenia.ragiadakou@amd.com>,\n Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,\n Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,\n Robert Beckett <bob.beckett@collabora.com>","Subject":"[PATCH v18 05/19] ui/gtk-egl: Unset context after GL operations","Date":"Wed, 18 Feb 2026 00:49:14 +0300","Message-ID":"<20260217214928.2970885-6-dmitry.osipenko@collabora.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260217214928.2970885-1-dmitry.osipenko@collabora.com>","References":"<20260217214928.2970885-1-dmitry.osipenko@collabora.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-ZohoMailClient":"External","Received-SPF":"pass client-ip=136.143.188.112;\n envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"VirtIO-GPU commands may be processed outside of main-loop, from a CPU\nthread. This results in GL context switch failure because context is held\nby main-loop thread when GL is invoked from CPU thread. Always release GL\ncontext after performing GL operations such that other threads could take\nover the context.\n\nSigned-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>\n---\n ui/gtk-egl.c | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)","diff":"diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c\nindex 0dbb429958e5..157b000f45fb 100644\n--- a/ui/gtk-egl.c\n+++ b/ui/gtk-egl.c\n@@ -39,6 +39,8 @@ static void gtk_egl_set_scanout_mode(VirtualConsole *vc, bool scanout)\n             surface_gl_destroy_texture(vc->gfx.gls, vc->gfx.ds);\n             surface_gl_create_texture(vc->gfx.gls, vc->gfx.ds);\n         }\n+        eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE,\n+                       EGL_NO_SURFACE, EGL_NO_CONTEXT);\n     }\n }\n \n@@ -125,6 +127,9 @@ void gd_egl_draw(VirtualConsole *vc)\n                         surface_height(vc->gfx.ds));\n \n         glFlush();\n+\n+        eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE,\n+                       EGL_NO_SURFACE, EGL_NO_CONTEXT);\n     }\n }\n \n@@ -261,6 +266,9 @@ void gd_egl_scanout_texture(DisplayChangeListener *dcl,\n     gtk_egl_set_scanout_mode(vc, true);\n     egl_fb_setup_for_tex(&vc->gfx.guest_fb, backing_width, backing_height,\n                          backing_id, false);\n+\n+    eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE,\n+                    EGL_NO_SURFACE, EGL_NO_CONTEXT);\n }\n \n void gd_egl_scanout_dmabuf(DisplayChangeListener *dcl,\n@@ -277,6 +285,8 @@ void gd_egl_scanout_dmabuf(DisplayChangeListener *dcl,\n     egl_dmabuf_import_texture(dmabuf);\n     texture = qemu_dmabuf_get_texture(dmabuf);\n     if (!texture) {\n+        eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE,\n+                       EGL_NO_SURFACE, EGL_NO_CONTEXT);\n         return;\n     }\n \n@@ -294,6 +304,9 @@ void gd_egl_scanout_dmabuf(DisplayChangeListener *dcl,\n     if (qemu_dmabuf_get_allow_fences(dmabuf)) {\n         vc->gfx.guest_fb.dmabuf = dmabuf;\n     }\n+\n+    eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE,\n+                    EGL_NO_SURFACE, EGL_NO_CONTEXT);\n #endif\n }\n \n@@ -397,6 +410,9 @@ void gd_egl_scanout_flush(DisplayChangeListener *dcl,\n #endif\n \n     eglSwapBuffers(qemu_egl_display, vc->gfx.esurface);\n+\n+    eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE,\n+                    EGL_NO_SURFACE, EGL_NO_CONTEXT);\n }\n \n void gd_egl_flush(DisplayChangeListener *dcl,\n","prefixes":["v18","05/19"]}