{"id":2197440,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197440/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260217214928.2970885-4-dmitry.osipenko@collabora.com>","date":"2026-02-17T21:49:12","name":"[v18,03/19] ui/gtk: Don't disable scanout when display is refreshed","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"94265505dfbf1af4df2a8573126fa656cb56e4c0","submitter":{"id":83453,"url":"http://patchwork.ozlabs.org/api/1.0/people/83453/?format=json","name":"Dmitry Osipenko","email":"dmitry.osipenko@collabora.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217214928.2970885-4-dmitry.osipenko@collabora.com/mbox/","series":[{"id":492488,"url":"http://patchwork.ozlabs.org/api/1.0/series/492488/?format=json","date":"2026-02-17T21:49:09","name":"Support virtio-gpu DRM native context and MAP_FIXED API","version":18,"mbox":"http://patchwork.ozlabs.org/series/492488/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197440/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=collabora.com header.i=dmitry.osipenko@collabora.com\n header.a=rsa-sha256 header.s=zohomail header.b=SDffQMUE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFtdy4bLgz1xwC\n\tfor ; Wed, 18 Feb 2026 08:52:06 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsSz1-00087b-KC; Tue, 17 Feb 2026 16:51:51 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsSz0-00086c-MU\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:51:50 -0500","from sender4-pp-f112.zoho.com ([136.143.188.112])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsSyz-0001LZ-03\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:51:50 -0500","by mx.zohomail.com with SMTPS id 1771365094175186.40816534884448;\n Tue, 17 Feb 2026 13:51:34 -0800 (PST)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1771365096; cv=none;\n d=zohomail.com; s=zohoarc;\n b=FtavBoijbHUWVtkWEoVJLlnE/VSZ0NwC2Xw/DjizjG5TkRyG/6BhgsbmyraDzoVRumpTM9LbYMmCqy/yj6SKcC9g+FCv0VjJUJ9VtZ7PFTwqfrote9csi9FtrC6v8qVC8CAS481Ov+JmcTdm1cUUgDEGFMymwn0GZD5jU9V3MKE=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;\n s=zohoarc; t=1771365096;\n h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n bh=ViKEV6K3E34y8YBULDM7wujUiITFIahQHAYDINTR4aQ=;\n b=VRj4qke70I52AERoRWiePoc+NFgMmG4EQUvkmuu1G2ykjd85ivBRXPuxm7oRsgrIsMiV24K2GxXATeG6COleN/JiWmW1mUToamLU1soFH/51Hc4Sko7g9nmHtAosfLmmLLnl8TS45DTKvXHmQierRrfa+eMV27+xSuobGJqz3K0=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n dkim=pass header.i=collabora.com;\n spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;\n dmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1771365096;\n s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;\n h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;\n bh=ViKEV6K3E34y8YBULDM7wujUiITFIahQHAYDINTR4aQ=;\n b=SDffQMUEKey4pCA8J8el11BfKhuYtwh52S0AtIbWB9ksU4DSCcV+wQCZp7RcxD5A\n Fw2MkgNJbxctR1kWMQlGyTGVLAR5SXsB+PMkhov3Ef2/WnoM336JczaNwoY13v+Hf34\n SkK4ATYb/X00Ps6ZVUUzgxbh2cZNp1ByDLYf5/NM=","From":"Dmitry Osipenko ","To":"Akihiko Odaki ,\n Huang Rui ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Gerd Hoffmann ,\n =?utf-8?q?Alex_Benn=C3=A9e?= ,\n Pierre-Eric Pelloux-Prayer ,\n \"Michael S . Tsirkin\" , Paolo Bonzini ,\n Yiwei Zhang , Sergio Lopez Pascual ","Cc":"Gert Wollny , qemu-devel@nongnu.org,\n Gurchetan Singh , Alyssa Ross ,\n\t=?utf-8?q?Roger_Pau_Monn=C3=A9?= ,\n Alex Deucher ,\n Stefano Stabellini , =?utf-8?q?Christian_K?=\n\t=?utf-8?q?=C3=B6nig?= ,\n Xenia Ragiadakou ,\n Honglei Huang , Julia Zhang ,\n Chen Jiqian , Rob Clark ,\n Robert Beckett ","Subject":"[PATCH v18 03/19] ui/gtk: Don't disable scanout when display is\n refreshed","Date":"Wed, 18 Feb 2026 00:49:12 +0300","Message-ID":"<20260217214928.2970885-4-dmitry.osipenko@collabora.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260217214928.2970885-1-dmitry.osipenko@collabora.com>","References":"<20260217214928.2970885-1-dmitry.osipenko@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-ZohoMailClient":"External","Received-SPF":"pass client-ip=136.143.188.112;\n envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Display refreshment is invoked by a timer and it erroneously disables\nthe active scanout if it happens to be invoked after scanout has been\nenabled. This offending scanout-disable race condition with a timer\ncan be easily hit when Qemu runs with a disabled vsync by using SDL or\nGTK displays (with vblank_mode=0 for GTK). Refreshment of display's\ncontent shouldn't disable the active display. Fix it by keeping the\nscanout's state unchanged when display is redrawn.\n\nReviewed-by: Akihiko Odaki \nAcked-by: Michael S. Tsirkin \nTested-by: Alex Bennée \nAcked-by: Pierre-Eric Pelloux-Prayer \nReviewed-by: Yiwei Zhang \nSigned-off-by: Dmitry Osipenko \n---\n ui/gtk-egl.c | 1 -\n ui/gtk-gl-area.c | 1 -\n 2 files changed, 2 deletions(-)","diff":"diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c\nindex ae9239999cdb..0dbb429958e5 100644\n--- a/ui/gtk-egl.c\n+++ b/ui/gtk-egl.c\n@@ -180,7 +180,6 @@ void gd_egl_refresh(DisplayChangeListener *dcl)\n \n if (vc->gfx.glupdates) {\n vc->gfx.glupdates = 0;\n- gtk_egl_set_scanout_mode(vc, false);\n gd_egl_draw(vc);\n }\n }\ndiff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c\nindex cd86022d264a..c709b2ce0f63 100644\n--- a/ui/gtk-gl-area.c\n+++ b/ui/gtk-gl-area.c\n@@ -199,7 +199,6 @@ void gd_gl_area_refresh(DisplayChangeListener *dcl)\n \n if (vc->gfx.glupdates) {\n vc->gfx.glupdates = 0;\n- gtk_gl_area_set_scanout_mode(vc, false);\n gtk_gl_area_queue_render(GTK_GL_AREA(vc->gfx.drawing_area));\n }\n }\n","prefixes":["v18","03/19"]}