{"id":2197438,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197438/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260217214928.2970885-3-dmitry.osipenko@collabora.com>","date":"2026-02-17T21:49:11","name":"[v18,02/19] ui/sdl2: Don't disable scanout when display is refreshed","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b3e232a5ef80b7450451598cfe5196d56999e494","submitter":{"id":83453,"url":"http://patchwork.ozlabs.org/api/1.0/people/83453/?format=json","name":"Dmitry Osipenko","email":"dmitry.osipenko@collabora.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217214928.2970885-3-dmitry.osipenko@collabora.com/mbox/","series":[{"id":492488,"url":"http://patchwork.ozlabs.org/api/1.0/series/492488/?format=json","date":"2026-02-17T21:49:09","name":"Support virtio-gpu DRM native context and MAP_FIXED API","version":18,"mbox":"http://patchwork.ozlabs.org/series/492488/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197438/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=collabora.com header.i=dmitry.osipenko@collabora.com\n header.a=rsa-sha256 header.s=zohomail header.b=aYXsllga;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFtdl71Ggz1xwC\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 18 Feb 2026 08:51:55 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vsSyx-00081D-Nr; Tue, 17 Feb 2026 16:51:48 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)\n id 1vsSyv-0007zY-GA\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:51:45 -0500","from sender4-pp-f112.zoho.com ([136.143.188.112])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <dmitry.osipenko@collabora.com>)\n id 1vsSyu-0001KZ-34\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:51:45 -0500","by mx.zohomail.com with SMTPS id 1771365088324944.8750480876251;\n Tue, 17 Feb 2026 13:51:28 -0800 (PST)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1771365090; cv=none;\n d=zohomail.com; s=zohoarc;\n b=nxCq++OSoJbsJaWTjVAwmS+qQqmOWOQLap5QFfru5Y+DnPfbuCeGj9pDAcqjeYLto0bj2GEGnCqsEHtRHL63WiSAiIGLsbTLVscigEMGHcnJo8xZHwqf5KNvJ/H5kEjV7eAxprksZ8X5Gwak8FUDYiNnmr65lKhavSod79MOW4I=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;\n s=zohoarc; t=1771365090;\n h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n bh=a4Z0PO9JY3U765LZd2ErcQUOa3Sm74gRbcnJ4jJWrbk=;\n b=kAGIU9brBiUXSIN72gOWVNmCKlHiuO6gHBMY7E7oAnVZbt/uCusUoTzQedDQTaPJ1PmvYuX1FXqbXiEfW02ECtP002EkrfR238BhJzOTv6YuEEFLhxOV4XbG9tfVFsC0XxqpKWf09q/Ar0m4d7N5xa0nwpVGYHTF/HxprQVnMgA=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n dkim=pass  header.i=collabora.com;\n spf=pass  smtp.mailfrom=dmitry.osipenko@collabora.com;\n dmarc=pass header.from=<dmitry.osipenko@collabora.com>","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1771365090;\n s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;\n h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;\n bh=a4Z0PO9JY3U765LZd2ErcQUOa3Sm74gRbcnJ4jJWrbk=;\n b=aYXsllga28TlIFubR+WC1lJtOcMNzRYpnqEV3EUQ7kYylVT1vnm/m2W2vGfgtIaL\n 9DqiHdC44lYwdbZVjmZnYpi4zWPyaPA0EEIuWwq4liHMvrGh03H47cOyosbhKxoxng1\n DrDJy1SHLncYu5REAkd6AVMQ6BAl5cY9iKxjnurA=","From":"Dmitry Osipenko <dmitry.osipenko@collabora.com>","To":"Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>,\n Huang Rui <ray.huang@amd.com>,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Gerd Hoffmann <kraxel@redhat.com>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,\n \"Michael S . Tsirkin\" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n Yiwei Zhang <zzyiwei@gmail.com>, Sergio Lopez Pascual <slp@redhat.com>","Cc":"Gert Wollny <gert.wollny@collabora.com>, qemu-devel@nongnu.org,\n Gurchetan Singh <gurchetansingh@chromium.org>, Alyssa Ross <hi@alyssa.is>,\n\t=?utf-8?q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>,\n Alex Deucher <alexander.deucher@amd.com>,\n Stefano Stabellini <stefano.stabellini@amd.com>, =?utf-8?q?Christian_K?=\n\t=?utf-8?q?=C3=B6nig?= <christian.koenig@amd.com>,\n Xenia Ragiadakou <xenia.ragiadakou@amd.com>,\n Honglei Huang <honglei1.huang@amd.com>, Julia Zhang <julia.zhang@amd.com>,\n Chen Jiqian <Jiqian.Chen@amd.com>, Rob Clark <robdclark@gmail.com>,\n Robert Beckett <bob.beckett@collabora.com>","Subject":"[PATCH v18 02/19] ui/sdl2: Don't disable scanout when display is\n refreshed","Date":"Wed, 18 Feb 2026 00:49:11 +0300","Message-ID":"<20260217214928.2970885-3-dmitry.osipenko@collabora.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260217214928.2970885-1-dmitry.osipenko@collabora.com>","References":"<20260217214928.2970885-1-dmitry.osipenko@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-ZohoMailClient":"External","Received-SPF":"pass client-ip=136.143.188.112;\n envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Display refreshment is invoked by a timer and it erroneously disables\nthe active scanout if it happens to be invoked after scanout has been\nenabled. This offending scanout-disable race condition with a timer\ncan be easily hit when Qemu runs with a disabled vsync by using SDL or\nGTK displays (with vblank_mode=0 for GTK). Refreshment of display's\ncontent shouldn't disable the active display. Fix it by keeping the\nscanout's state unchanged when display is redrawn.\n\nReviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>\nAcked-by: Michael S. Tsirkin <mst@redhat.com>\nTested-by: Alex Bennée <alex.bennee@linaro.org>\nAcked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>\nReviewed-by: Yiwei Zhang <zzyiwei@gmail.com>\nSigned-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>\n---\n ui/sdl2-gl.c | 1 -\n 1 file changed, 1 deletion(-)","diff":"diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c\nindex ea2301305d3e..55e22a7a3d59 100644\n--- a/ui/sdl2-gl.c\n+++ b/ui/sdl2-gl.c\n@@ -51,7 +51,6 @@ static void sdl2_gl_render_surface(struct sdl2_console *scon)\n     int ww, wh;\n \n     SDL_GL_MakeCurrent(scon->real_window, scon->winctx);\n-    sdl2_set_scanout_mode(scon, false);\n \n     SDL_GetWindowSize(scon->real_window, &ww, &wh);\n     surface_gl_setup_viewport(scon->gls, scon->surface, ww, wh);\n","prefixes":["v18","02/19"]}