{"id":2197391,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197391/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260217212245.95321-7-ltaylorsimpson@gmail.com>","date":"2026-02-17T21:22:43","name":"[v3,6/8] Hexagon (target/hexagon) Disassembly of invalid packets","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b25074d475855135875429165d1a9ba1451d4f4a","submitter":{"id":86757,"url":"http://patchwork.ozlabs.org/api/1.0/people/86757/?format=json","name":"Taylor Simpson","email":"ltaylorsimpson@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217212245.95321-7-ltaylorsimpson@gmail.com/mbox/","series":[{"id":492479,"url":"http://patchwork.ozlabs.org/api/1.0/series/492479/?format=json","date":"2026-02-17T21:22:40","name":"Hexagon (target/hexagon) Check opcodes versions","version":3,"mbox":"http://patchwork.ozlabs.org/series/492479/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197391/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=AZPB/2Nh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFt204V5Jz1xwC\n\tfor ; Wed, 18 Feb 2026 08:24:24 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsSX6-0002hj-DP; Tue, 17 Feb 2026 16:23:00 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsSX5-0002hH-F9\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:22:59 -0500","from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1vsSX3-0002Ip-N0\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:22:59 -0500","by mail-oi1-x243.google.com with SMTP id\n 5614622812f47-46398742245so1208041b6e.1\n for ; Tue, 17 Feb 2026 13:22:57 -0800 (PST)","from taylor-ubuntu.. (c-67-172-136-152.hsd1.co.comcast.net.\n [67.172.136.152]) by smtp.gmail.com with ESMTPSA id\n 5614622812f47-4636ae8f86fsm12899319b6e.3.2026.02.17.13.22.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 17 Feb 2026 13:22:55 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1771363376; x=1771968176; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=rNHs4Sobj03r02yaX9a9D3Jb/8tlBnii4di7lAr9aUU=;\n b=AZPB/2NhI7eyRNpYn+COF0OcbV8tFX+xIKC43T7RU6Rbj8Pkx38Tw/SrbM7eKr0D0c\n noTIx5pQFrlL+Kv3meVuWhiy92HAR10ptVx/seKQyO3IhIYT43dYEjSa2qEceIG3JVAX\n dO/SYvQloA7AslopsTTX5KeCPsPsLmSbp6Oq4Y7F0PT2uce+AzvOlE4OVfQfTvqvkf1u\n zgdI8sexybn6G6wLDgzN7RgWWF/5+AbvU+DZPbtqDmoDTa6wLygomISHncSiYmfA3w4J\n eUWZKsOalEqBTu/HQ3oliNpGQNd+OPE7U3vHP2k3OvlUe3PGHfL2KcsOjb63UrwH2Eoq\n A+Mg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771363376; x=1771968176;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=rNHs4Sobj03r02yaX9a9D3Jb/8tlBnii4di7lAr9aUU=;\n b=AllnYYvm5+odIoZGJTBgQSJOlzwXn6e62q+1ESEH6uD/hyRygHievVW7+vK9CQkNxo\n PkO21QExlb98tCixOHuaUPLbVmUqTOAamp/zAKPk1qjlPOkszJsGCqo+iCrD4WHrkAiW\n WGFN3L7EqGVuIK/af60Ps5yTJ+zJU9DQZfM0N2i4QHndvnUOUbRdu5ixSvS2O2BGwpM8\n 76jK6wIqAvPDK1Utx4wDjn03P6eus8OM5Kbk8XG/NAHfCMhQiNwp5hWix1LyU7x16XvT\n 9KNe5kTyFMVfg84NXXNzvq9wrZPiihaZz9jxhrjR7JIQEh0t2t/0gcZ9P/ruxpQ3v/17\n pX7w==","X-Gm-Message-State":"AOJu0YwI5CdICNizPz1u8JlTig7PywxLjJOavUHvnrjoZ+f5SZfbdAxg\n hN5kZmZvUt7a+wXQySUlTmzzfKNqKD3eiCCjRC8ic7Tycvw++Ez+eOWA2Vse7DGd","X-Gm-Gg":"AZuq6aIvGmcFJfzdIV5TXUCT8cl7PCZlmXJHHY+oyQp6Kyzs9IC6wZKaxA3BDh3ESLo\n O0u3bpKEG+XuYRc9xVVz/G2SfabRWwWjZS0M+taHY4Fc5gZrvx3m7BPEKjBcp1A0hO9shtSxFo2\n ZuiFnQWfm5EgeKUI5Z1BqTgKPGVN0Wzqd+KrC2je4DDs+zQojsWYt7dYb14I0qfRWXb5slGFlSH\n R9R0oqowZH5A9uZPx1VWiRfP5t3JObk7x3eJgfbAmF2Eu5rFMbFiH5lAhncJDfl/VYG63skV+cd\n LDILZh1R7bRpr+D6mhFqQbyhy1RtPziYukuUe7UD82nHTOTLgaM7lmleBjheiJ3XR4iYtNAMHmJ\n cdk86dnRxx+qFHlV84T9X+zwr2PSHqtZ1HLug5NgPD0TZgYPdhMAK2BSJhZfJtaDahSztUvZOqP\n kvDoRXfVQG2tq63sBLLVvYf9xC8IhljNrva2qcp+MmlJAoo2RnrsnJSxT+ZsaYqKN46740qfxXV\n Eo1mxSvgL2P/lPW","X-Received":"by 2002:a05:6808:158e:b0:45f:210:4dbd with SMTP id\n 5614622812f47-4639ef3137fmr6741119b6e.16.1771363376022;\n Tue, 17 Feb 2026 13:22:56 -0800 (PST)","From":"Taylor Simpson ","To":"qemu-devel@nongnu.org","Cc":"brian.cain@oss.qualcomm.com, matheus.bernardino@oss.qualcomm.com,\n sid.manning@oss.qualcomm.com, marco.liebel@oss.qualcomm.com,\n richard.henderson@linaro.org, philmd@linaro.org, ale@rev.ng, anjo@rev.ng,\n ltaylorsimpson@gmail.com","Subject":"[PATCH v3 6/8] Hexagon (target/hexagon) Disassembly of invalid\n packets","Date":"Tue, 17 Feb 2026 14:22:43 -0700","Message-ID":"<20260217212245.95321-7-ltaylorsimpson@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260217212245.95321-1-ltaylorsimpson@gmail.com>","References":"<20260217212245.95321-1-ltaylorsimpson@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::243;\n envelope-from=ltaylorsimpson@gmail.com; helo=mail-oi1-x243.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"We pass the Hexagon CPU definition to disassemble_hexagon. This allows\ndecode_packet to know if the opcodes are supported.\n\nNote that we print valid instructions in a packet when one or more is\ninvalid. Rather than this\n0x0002128c: 0x1eae4fec\t{\t\n0x00021290: 0x1c434c04\t\t\n0x00021294: 0x1e03edf0\t\t }\n\nWe print this\n0x0002128c: 0x1eae4fec\t{\t\n0x00021290: 0x1c434c04\t\tV4.w = vadd(V12.w,V3.w)\n0x00021294: 0x1e03edf0\t\tV16 = V13 }\n\nCo-authored-by: Matheus Tavares Bernardino \nCo-authored-by: Brian Cain \nSigned-off-by: Taylor Simpson \n---\n target/hexagon/cpu_bits.h | 4 +++-\n target/hexagon/printinsn.h | 3 ++-\n disas/hexagon.c | 3 ++-\n target/hexagon/cpu.c | 2 ++\n target/hexagon/decode.c | 25 +++++++++++++++++++++----\n target/hexagon/printinsn.c | 9 +++++++--\n 6 files changed, 37 insertions(+), 9 deletions(-)","diff":"diff --git a/target/hexagon/cpu_bits.h b/target/hexagon/cpu_bits.h\nindex 19beca81c0..aaac6b9ea6 100644\n--- a/target/hexagon/cpu_bits.h\n+++ b/target/hexagon/cpu_bits.h\n@@ -19,6 +19,7 @@\n #define HEXAGON_CPU_BITS_H\n \n #include \"qemu/bitops.h\"\n+#include \"cpu-qom.h\"\n \n #define PCALIGN 4\n #define PCALIGN_MASK (PCALIGN - 1)\n@@ -65,6 +66,7 @@ static inline bool is_packet_end(uint32_t endocing)\n return ((bits == 0x3) || (bits == 0x0));\n }\n \n-int disassemble_hexagon(uint32_t *words, int nwords, bfd_vma pc, GString *buf);\n+int disassemble_hexagon(uint32_t *words, int nwords, bfd_vma pc, GString *buf,\n+ const HexagonCPUDef *hex_def);\n \n #endif\ndiff --git a/target/hexagon/printinsn.h b/target/hexagon/printinsn.h\nindex 2ecd1731d0..6f84ef93c3 100644\n--- a/target/hexagon/printinsn.h\n+++ b/target/hexagon/printinsn.h\n@@ -18,10 +18,11 @@\n #ifndef HEXAGON_PRINTINSN_H\n #define HEXAGON_PRINTINSN_H\n \n+#include \"cpu-qom.h\"\n #include \"insn.h\"\n \n void snprint_a_pkt_disas(GString *buf, Packet *pkt, uint32_t *words,\n- target_ulong pc);\n+ target_ulong pc, const HexagonCPUDef *hex_def);\n void snprint_a_pkt_debug(GString *buf, Packet *pkt);\n \n #endif\ndiff --git a/disas/hexagon.c b/disas/hexagon.c\nindex c1a4ffc5f6..36b8321c26 100644\n--- a/disas/hexagon.c\n+++ b/disas/hexagon.c\n@@ -31,6 +31,7 @@\n \n int print_insn_hexagon(bfd_vma memaddr, struct disassemble_info *info)\n {\n+ const HexagonCPUDef *hex_def = (const HexagonCPUDef *)info->target_info;\n uint32_t words[PACKET_WORDS_MAX];\n bool found_end = false;\n GString *buf;\n@@ -58,7 +59,7 @@ int print_insn_hexagon(bfd_vma memaddr, struct disassemble_info *info)\n }\n \n buf = g_string_sized_new(PACKET_BUFFER_LEN);\n- len = disassemble_hexagon(words, i, memaddr, buf);\n+ len = disassemble_hexagon(words, i, memaddr, buf, hex_def);\n (*info->fprintf_func)(info->stream, \"%s\", buf->str);\n g_string_free(buf, true);\n \ndiff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c\nindex 949d509a15..001ea3c4ef 100644\n--- a/target/hexagon/cpu.c\n+++ b/target/hexagon/cpu.c\n@@ -297,8 +297,10 @@ static void hexagon_cpu_reset_hold(Object *obj, ResetType type)\n static void hexagon_cpu_disas_set_info(const CPUState *cs,\n disassemble_info *info)\n {\n+ const HexagonCPU *cpu = HEXAGON_CPU(cs);\n info->print_insn = print_insn_hexagon;\n info->endian = BFD_ENDIAN_LITTLE;\n+ info->target_info = HEXAGON_CPU_GET_CLASS(cpu)->hex_def;\n }\n \n static void hexagon_cpu_realize(DeviceState *dev, Error **errp)\ndiff --git a/target/hexagon/decode.c b/target/hexagon/decode.c\nindex b8a1cd5b12..c4cf430e5a 100644\n--- a/target/hexagon/decode.c\n+++ b/target/hexagon/decode.c\n@@ -828,19 +828,36 @@ int decode_packet(DisasContext *ctx, int max_words, const uint32_t *words,\n \n /* Used for \"-d in_asm\" logging */\n int disassemble_hexagon(uint32_t *words, int nwords, bfd_vma pc,\n- GString *buf)\n+ GString *buf, const HexagonCPUDef *hex_def)\n {\n+ HexagonCPUDef any_def = {\n+ .hex_version = HEX_VER_ANY, /* Allow decode to accept anything */\n+ };\n DisasContext ctx;\n Packet pkt;\n \n memset(&ctx, 0, sizeof(DisasContext));\n+ ctx.hex_def = &any_def;\n ctx.pkt = &pkt;\n \n if (decode_packet(&ctx, nwords, words, &pkt, true) > 0) {\n- snprint_a_pkt_disas(buf, &pkt, words, pc);\n+ snprint_a_pkt_disas(buf, &pkt, words, pc, hex_def);\n return pkt.encod_pkt_size_in_bytes;\n } else {\n- g_string_assign(buf, \"\");\n- return 0;\n+ for (int i = 0; i < nwords; i++) {\n+ g_string_append_printf(buf, \"0x\" TARGET_FMT_lx \"\\t\", words[i]);\n+ if (i == 0) {\n+ g_string_append(buf, \"{\");\n+ }\n+ g_string_append(buf, \"\\t\");\n+ g_string_append(buf, \"\");\n+ if (i < nwords - 1) {\n+ pc += 4;\n+ g_string_append_printf(buf, \"\\n0x\" TARGET_FMT_lx \": \",\n+ (target_ulong)pc);\n+ }\n+ }\n+ g_string_append(buf, \" }\");\n+ return nwords * sizeof(uint32_t);\n }\n }\ndiff --git a/target/hexagon/printinsn.c b/target/hexagon/printinsn.c\nindex 4865cdd133..22b305f018 100644\n--- a/target/hexagon/printinsn.c\n+++ b/target/hexagon/printinsn.c\n@@ -21,6 +21,7 @@\n #include \"insn.h\"\n #include \"reg_fields.h\"\n #include \"internal.h\"\n+#include \"decode.h\"\n \n static const char *sreg2str(unsigned int reg)\n {\n@@ -51,7 +52,7 @@ static void snprintinsn(GString *buf, Insn *insn)\n }\n \n void snprint_a_pkt_disas(GString *buf, Packet *pkt, uint32_t *words,\n- target_ulong pc)\n+ target_ulong pc, const HexagonCPUDef *hex_def)\n {\n bool has_endloop0 = false;\n bool has_endloop1 = false;\n@@ -83,7 +84,11 @@ void snprint_a_pkt_disas(GString *buf, Packet *pkt, uint32_t *words,\n }\n \n g_string_append(buf, \"\\t\");\n- snprintinsn(buf, &(pkt->insn[i]));\n+ if (opcode_supported(pkt->insn[i].opcode, hex_def)) {\n+ snprintinsn(buf, &(pkt->insn[i]));\n+ } else {\n+ g_string_append(buf, \"\");\n+ }\n \n if (i < pkt->num_insns - 1) {\n /*\n","prefixes":["v3","6/8"]}