{"id":2197387,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197387/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260217212245.95321-8-ltaylorsimpson@gmail.com>","date":"2026-02-17T21:22:44","name":"[v3,7/8] tests/tcg/hexagon: Add test for revision-gated instruction decoding","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f906c5e91e3ca8ed805d794735d0788f71491533","submitter":{"id":86757,"url":"http://patchwork.ozlabs.org/api/1.0/people/86757/?format=json","name":"Taylor Simpson","email":"ltaylorsimpson@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217212245.95321-8-ltaylorsimpson@gmail.com/mbox/","series":[{"id":492479,"url":"http://patchwork.ozlabs.org/api/1.0/series/492479/?format=json","date":"2026-02-17T21:22:40","name":"Hexagon (target/hexagon) Check opcodes versions","version":3,"mbox":"http://patchwork.ozlabs.org/series/492479/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197387/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=Awm91LYK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFt1J5rtLz1xwC\n\tfor ; Wed, 18 Feb 2026 08:23:48 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsSX9-0002jB-KF; Tue, 17 Feb 2026 16:23:03 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsSX8-0002ih-4e\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:23:02 -0500","from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1vsSX6-0002K8-Df\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:23:01 -0500","by mail-oi1-x229.google.com with SMTP id\n 5614622812f47-463901a0accso1266830b6e.2\n for ; Tue, 17 Feb 2026 13:23:00 -0800 (PST)","from taylor-ubuntu.. (c-67-172-136-152.hsd1.co.comcast.net.\n [67.172.136.152]) by smtp.gmail.com with ESMTPSA id\n 5614622812f47-4636ae8f86fsm12899319b6e.3.2026.02.17.13.22.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 17 Feb 2026 13:22:58 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1771363379; x=1771968179; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=m+qNKUAlpp9a6yuJ0J/t49+0Pl4hNg0jUhpv5P0Iy6I=;\n b=Awm91LYKHwTZhAiJP5+znS5JSUctvP9FMEUk+tt4CElkP7298RErM4bW8500HmjO3Q\n jvjQdJCM+SspdarGHHnlvIu/Z2PGcD2kSYaO50zHyVOUfZmVm5e19eLsKoKyMmPEwh9S\n B+kPzYGt2U9eCxzu7LyaiXMzhS9CEsRlFjxjvQAYukZj8CrzNqiXpG9Z4y01reUCO1g0\n 6vFaLsskEsPXoEGDi+RhXGA75ULFG7rE+gCbMK/p5tQ/RmDzYueHcnUX9g1yqxwRuv4Y\n xkcLKkSiS5TDLd9tJDO4ysSWeuYHPJxvZ+Id5+ehexmsIqbfy//87Xgus0AH4hzot3Ii\n g23Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771363379; x=1771968179;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=m+qNKUAlpp9a6yuJ0J/t49+0Pl4hNg0jUhpv5P0Iy6I=;\n b=c3NPDqc6/tCt/VbmNy8Ybt8sTqfBtnLFN8IXYLIVxgtxoz786G66esB2cFX0yALcIP\n i9MPhu1Wf/MqM0epnMrOZNw231iZRRrEkhCDBsorE7B+7U1e9bfk/jMl3jW8q8p9bmCD\n GUtzXhDBCoW9Kk1rA4my2Wk6NZ/3DJseqN8JGN3iRCP7qUcz/47+4MqxBjuB1ZzP3pjH\n SiA1AL+VapPyGUAFGXmJJKToZ9oEuG4cxdu1iqA0IUSOw01IxLCOhygDpAJY0FRP+ES+\n +hdgmcxYd6+XtBtU+DLaEQ5cETnSHVYasz61B6SoDuw92AflaXhCy2E+PuZkfPf5V/0B\n kQkA==","X-Gm-Message-State":"AOJu0YyqHqwxZdnc4hjE3Uo1J8teAQ20a7pR5kqcw3PC2H+/FdlEmdlI\n 9t7iSfLwPr/mKh/kSoHiHwyGppoInf+l3Ueaey5qZE/C5o1vIBOJx/ais97hdw==","X-Gm-Gg":"AZuq6aKLNpow9NvHV6sg42Xqw4AhfT+NCZ58Rg3VRyzYZqJ/i9rhkEIsNIgKBp8IZXn\n 06j9+ES7gD+qTorPYXhcDjBP0qzKshPdNhabdNMyDOvOjl1D/JQw0gzuIeDk+x1G2q7rFfYF7JB\n 9Fwtvl2nMhiwj7cJ4x/w8aI9uRs+GjgcuL6ULH6ssbhNvzUbsSQUZPzijYvS0o7CvVUfyCeeJRX\n 5omIc5gKB+3opJpKcIl4TOkuQfWqvU81MPFqIQFyiWqCKzZ6oMykDpXSbsCiN8pa1on0rtYoWr4\n pIs2N5W0kI2J8zI2kSXPFGwXawK+uUl1Zyp+GI/Sth7LkRL6+unEHl68LEIRfY3uQgE2O9dEv3Q\n UZUjMS+f6in+hLsRTX2g4mFPYUpG0g6ABL2RyX5gHSgnfCADEvVHe3ICUvikAEtAhv7gXYjA3jw\n VW/tgCFGvML0oeYuAxg47NNy20rhwOl5edypnKrymYRFKtzGht3z8MJulhmiL58ziZpvf3hl0rj\n vUWJ+fjcVc0h1DIjzYNm6JIkcc=","X-Received":"by 2002:a05:6808:1793:b0:45e:fbe0:1bf3 with SMTP id\n 5614622812f47-463b409b4a3mr4845137b6e.52.1771363378953;\n Tue, 17 Feb 2026 13:22:58 -0800 (PST)","From":"Taylor Simpson ","To":"qemu-devel@nongnu.org","Cc":"brian.cain@oss.qualcomm.com, matheus.bernardino@oss.qualcomm.com,\n sid.manning@oss.qualcomm.com, marco.liebel@oss.qualcomm.com,\n richard.henderson@linaro.org, philmd@linaro.org, ale@rev.ng, anjo@rev.ng,\n ltaylorsimpson@gmail.com","Subject":"[PATCH v3 7/8] tests/tcg/hexagon: Add test for revision-gated\n instruction decoding","Date":"Tue, 17 Feb 2026 14:22:44 -0700","Message-ID":"<20260217212245.95321-8-ltaylorsimpson@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260217212245.95321-1-ltaylorsimpson@gmail.com>","References":"<20260217212245.95321-1-ltaylorsimpson@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::229;\n envelope-from=ltaylorsimpson@gmail.com; helo=mail-oi1-x229.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Brian Cain \n\nAdd check_rev_gating, a linux-user test that verifies the decoder\nrejects instructions from a newer CPU revision than the one selected\nby the ELF binary's e_flags.\n\nCo-authored-by: Taylor Simpson \nCo-authored-by: Matheus Tavares Bernardino \nSigned-off-by: Brian Cain \n---\n tests/tcg/hexagon/check_rev_gating.c | 141 +++++++++++++++++++++++++++\n tests/tcg/hexagon/Makefile.target | 6 ++\n 2 files changed, 147 insertions(+)\n create mode 100644 tests/tcg/hexagon/check_rev_gating.c","diff":"diff --git a/tests/tcg/hexagon/check_rev_gating.c b/tests/tcg/hexagon/check_rev_gating.c\nnew file mode 100644\nindex 0000000000..26b66f5455\n--- /dev/null\n+++ b/tests/tcg/hexagon/check_rev_gating.c\n@@ -0,0 +1,141 @@\n+/*\n+ * Test that instructions from a newer revision than the running CPU\n+ * are rejected with SIGILL.\n+ *\n+ * Compiled with -mv66 so that e_flags selects CPU v66. The test embeds\n+ * a v68 instruction (L2_loadw_aq: \"r0 = memw_aq(r0)\") via .word\n+ * encoding. The revision-gated decoder must reject it, and linux-user\n+ * must deliver SIGILL.\n+ *\n+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#include \n+#include \n+#include \n+#include \n+#include \n+#include \n+\n+static void *resume_pc;\n+static int signals_handled;\n+static int expected_signals;\n+\n+static void handle_sigill(int sig, siginfo_t *info, void *puc)\n+{\n+ ucontext_t *uc = (ucontext_t *)puc;\n+\n+ if (sig != SIGILL) {\n+ _exit(EXIT_FAILURE);\n+ }\n+\n+ uc->uc_mcontext.r0 = SIGILL;\n+ uc->uc_mcontext.pc = (unsigned long)resume_pc;\n+ signals_handled++;\n+}\n+\n+/*\n+ * Try to execute an instruction introduced after v66\n+ * On a v66 CPU this must raise SIGILL.\n+ *\n+ * Since we are building for v66, the assembler will reject\n+ * the instructions, so introduce them with .word.\n+ */\n+#define TRY_FUNC(NAME, WORD) \\\n+static int try_##NAME(void) \\\n+{ \\\n+ int sig; \\\n+ expected_signals++; \\\n+ asm volatile( \\\n+ \"r0 = #0\\n\" \\\n+ \"r1 = ##1f\\n\" \\\n+ \"memw(%1) = r1\\n\" \\\n+ WORD \\\n+ \"1:\\n\" \\\n+ \"%0 = r0\\n\" \\\n+ : \"=r\"(sig) \\\n+ : \"r\"(&resume_pc) \\\n+ : \"r0\", \"r1\", \"memory\"); \\\n+ return sig; \\\n+}\n+\n+TRY_FUNC(v68_loadw_aq,\n+ \".word 0x9200c800 /* { r0 = memw_aq(r0) } */\\n\")\n+TRY_FUNC(v68_loadd_aq,\n+ \".word 0x9201d800 /* r1:0 = memd_aq(r1) */\\n\")\n+TRY_FUNC(v68_release_at,\n+ \".word 0xa0e0c00c /* release(r0):at */\\n\")\n+TRY_FUNC(v68_release_st,\n+ \".word 0xa0e0c02c /* release(r0):st */\\n\")\n+TRY_FUNC(v68_storew_rl_at,\n+ \".word 0xa0a0c108 /* memw_rl(r0):at = r1 */\\n\")\n+TRY_FUNC(v68_stored_rl_at,\n+ \".word 0xa0e2c008 /* memd_rl(r2):at = r1:0 */\\n\")\n+TRY_FUNC(v68_storew_rl_st,\n+ \".word 0xa0a0c128 /* memw_rl(r0):st = r1 */\\n\")\n+TRY_FUNC(v68_stored_rl_st,\n+ \".word 0xa0e2c028 /* memd_rl(r2):st = r1:0 */\\n\")\n+\n+TRY_FUNC(v68hvx_v6mpy,\n+ \".word 0x1f42e424 /* v5:4.w = v6mpy(v5:4.ub, v3:2.b, #1):v */\\n\")\n+\n+TRY_FUNC(v69hvx_vasrvuhubrndsat,\n+ \".word 0x1d06c465 /* v5.ub = vasr(v5:4.uh, v6.ub):rnd:sat */\\n\")\n+TRY_FUNC(v69hvx_vasrvuhubsat,\n+ \".word 0x1d06c445 /* v5.ub = vasr(v5:4.uh, v6.ub):sat */\\n\")\n+TRY_FUNC(v69hvx_vasrvwuhrndsat,\n+ \".word 0x1d06c425 /* v5.uh = vasr(v5:4.w, v6.uh):rnd:sat */\\n\")\n+TRY_FUNC(v69hvx_vasrvwuhsat,\n+ \".word 0x1d06c405 /* v5.uh = vasr(v5:4.w, v6.uh):sat */\\n\")\n+TRY_FUNC(v69hvx_vassign_tmp,\n+ \".word 0x1e014dcc /* { v12.tmp = v13 */\\n\"\n+ \".word 0x1c43cc04 /* v4.w = vadd(v12.w, v3.w) } */\\n\")\n+TRY_FUNC(v69hvx_vcombine_tmp,\n+ \".word 0x1eae4fec /* { v13:12.tmp = vcombine(v15, v14) */\\n\"\n+ \".word 0x1c434c04 /* v4.w = vadd(v12.w, v3.w) */\\n\"\n+ \".word 0x1e03edf0 /* v16 = v13 } */\\n\")\n+TRY_FUNC(v69hvx_vmpyuhvs,\n+ \".word 0x1fc5e4e4 /* v4.uh = vmpy(V4.uh, v5.uh):>>16 */\\n\")\n+\n+TRY_FUNC(v73_callrh,\n+ \".word 0x50c5c000 /* callrh r5 */\\n\")\n+TRY_FUNC(v73_jumprh,\n+ \".word 0x52c0c000 /* jumprh r0 */\\n\")\n+\n+int main(void)\n+{\n+ struct sigaction act;\n+\n+ memset(&act, 0, sizeof(act));\n+ act.sa_sigaction = handle_sigill;\n+ act.sa_flags = SA_SIGINFO;\n+ assert(sigaction(SIGILL, &act, NULL) == 0);\n+\n+ assert(try_v68_loadw_aq() == SIGILL);\n+ assert(try_v68_loadd_aq() == SIGILL);\n+ assert(try_v68_release_at() == SIGILL);\n+ assert(try_v68_release_st() == SIGILL);\n+ assert(try_v68_storew_rl_at() == SIGILL);\n+ assert(try_v68_stored_rl_at() == SIGILL);\n+ assert(try_v68_storew_rl_st() == SIGILL);\n+ assert(try_v68_stored_rl_st() == SIGILL);\n+\n+ assert(try_v68hvx_v6mpy() == SIGILL);\n+\n+ assert(try_v69hvx_vasrvuhubrndsat() == SIGILL);\n+ assert(try_v69hvx_vasrvuhubsat() == SIGILL);\n+ assert(try_v69hvx_vasrvwuhrndsat() == SIGILL);\n+ assert(try_v69hvx_vasrvwuhsat() == SIGILL);\n+ assert(try_v69hvx_vassign_tmp() == SIGILL);\n+ assert(try_v69hvx_vcombine_tmp() == SIGILL);\n+ assert(try_v69hvx_vmpyuhvs() == SIGILL);\n+\n+ assert(try_v73_callrh() == SIGILL);\n+ assert(try_v73_jumprh() == SIGILL);\n+\n+ assert(signals_handled == expected_signals);\n+\n+ puts(\"PASS\");\n+ return EXIT_SUCCESS;\n+}\ndiff --git a/tests/tcg/hexagon/Makefile.target b/tests/tcg/hexagon/Makefile.target\nindex f86f02bb31..0050370806 100644\n--- a/tests/tcg/hexagon/Makefile.target\n+++ b/tests/tcg/hexagon/Makefile.target\n@@ -81,6 +81,7 @@ HEX_TESTS += test_vminh\n HEX_TESTS += test_vpmpyh\n HEX_TESTS += test_vspliceb\n \n+HEX_TESTS += check_rev_gating\n HEX_TESTS += v68_scalar\n HEX_TESTS += v68_hvx\n HEX_TESTS += v69_hvx\n@@ -106,6 +107,11 @@ read_write_overlap: read_write_overlap.c hex_test.h\n reg_mut: reg_mut.c hex_test.h\n unaligned_pc: unaligned_pc.c\n \n+# Compile for v66 so that the ELF selects a v66 CPU; the test then\n+# exercises revision gating by executing a v68 .word instruction.\n+check_rev_gating: check_rev_gating.c\n+\t$(CC) $(CFLAGS) -mv66 -O2 $< -o $@ $(LDFLAGS)\n+\n # This test has to be compiled for the -mv67t target\n usr: usr.c hex_test.h\n \t$(CC) $(CFLAGS) -mv67t -O2 -Wno-inline-asm -Wno-expansion-to-defined $< -o $@ $(LDFLAGS)\n","prefixes":["v3","7/8"]}