{"id":2197386,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197386/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260217212245.95321-6-ltaylorsimpson@gmail.com>","date":"2026-02-17T21:22:42","name":"[v3,5/8] Hexagon (target/hexagon) Check each opcode against current CPU definition","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"96ae4a8d0b2d90a7ed0eead47ee187f4a79bdd8b","submitter":{"id":86757,"url":"http://patchwork.ozlabs.org/api/1.0/people/86757/?format=json","name":"Taylor Simpson","email":"ltaylorsimpson@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217212245.95321-6-ltaylorsimpson@gmail.com/mbox/","series":[{"id":492479,"url":"http://patchwork.ozlabs.org/api/1.0/series/492479/?format=json","date":"2026-02-17T21:22:40","name":"Hexagon (target/hexagon) Check opcodes versions","version":3,"mbox":"http://patchwork.ozlabs.org/series/492479/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197386/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=YFWg7zoJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFt0y4Gh4z1xwC\n\tfor ; Wed, 18 Feb 2026 08:23:30 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsSX5-0002hD-EL; Tue, 17 Feb 2026 16:22:59 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsSX3-0002fQ-T2\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:22:57 -0500","from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1vsSX2-0002Ic-Ap\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:22:57 -0500","by mail-oi1-x230.google.com with SMTP id\n 5614622812f47-45f04f1348cso3112265b6e.1\n for ; Tue, 17 Feb 2026 13:22:55 -0800 (PST)","from taylor-ubuntu.. (c-67-172-136-152.hsd1.co.comcast.net.\n [67.172.136.152]) by smtp.gmail.com with ESMTPSA id\n 5614622812f47-4636ae8f86fsm12899319b6e.3.2026.02.17.13.22.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 17 Feb 2026 13:22:54 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1771363375; x=1771968175; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=iVOAx9naukSVP3+UH3cDLb9De+dQpHzBI3+W6aRDKDk=;\n b=YFWg7zoJexfvpgqBwTiHL0MBaCAxvI99zMO8CaZ3WYem2CLIfgbLa/SJC076QC7z63\n lllaqjrqJV+FUhn4iS3DDHfxUl3Q0gpxWepDHSbRS0pyTyUpQ1uBRp1FGdEjOjvxpgiz\n jqa7dclq1poUIaRayoZFSSC352hs/wPy3DSEDE5b1uieiWmszaye054cetHn3UyAEYBg\n VM6POiT749Chnu885I7/fbEV7EwCEA3ftbFlCVNKgt0lcHvd5gGFjzjrHbY1IuZbDfGk\n E6QWsNqBk0m4mjSpmlVmBnGyWEfwlYhmAZ1SQ4lkpE6ZMrxLrwiqGDCVJhSzecIurEZn\n bfEQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771363375; x=1771968175;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=iVOAx9naukSVP3+UH3cDLb9De+dQpHzBI3+W6aRDKDk=;\n b=ot6BCXHOdRk7FG7BlHQXL748E/dS2eOtD2BBbKlaxLLlj4Yil7Qvj+5gBHrI2gs4hH\n MQDamlJfPoOiYd77ZkxzRcUeD6NOJ0D3C2yM1SsJ0s8gSgv6oaZrRVLvzYNrw6J+mtQS\n oBfNxP6JlTxs+GtKJJ51ZsCdTVx3eACxDNYlm4IDmLp31j3R6LIdozmOKFDGkjKEzpJq\n VPTZGsSgIBzz0wZMi+mnvQmKJ1/mfj2msJn+obCI6z2UPYXng2oHujJBQ0oIrIvY7dmA\n qm+WVvV3uJCRx2xM7HgQEePlVyUpiD3mL2FFTo1P28tVihVR+zkuBa/O5hZ0PMTJNv51\n RpDQ==","X-Gm-Message-State":"AOJu0YyUlfQY98PHfAn6UstWlLpSFaQUglkdaGJs8L1kF9eOOL3OQLCo\n hCyMBMIE6r9Mis0wRDvfKHgNDVcGvgfJWONCVSExlD5pfc+3jRKM/2WkfX74wQ==","X-Gm-Gg":"AZuq6aKrkciJDeFr+1coFxPZJ+Jq6Ley4UvsEzyVeJeh1lkh7+QPr/AKNKjxdUpN7Tm\n jdt+20wo4YpOhDWQzsNdjwNgdC9SLqbENOhN/WJ9qOXei7i6z3bcWJHHIfKcRX5wAqggSOK5nKt\n cDeX0pOJgjkV25raCh1NZVX17N4n3KdvyiWWNc6GLNJzF37X0vJDfzechp1MVOie/SZZOzAAMV9\n SaatCq0Tk1Bl5eabw0OlEu4le/sVd1ES97K29hpV/4FkjbESoOMF8QNpmx8X8ovdQWp8RHhlSku\n MdBfeEZuxuBTXHWSZZqV0U9BSeZHDbjd3T5t3fEyv2L0h4mdpYjw3dGmqvzEtR8QjcN5nI5/9x+\n 3CxupoLsQTbZ0lCPdQAbh2flySPjuqSN13/J0SjzBfFnafKer8F2n4AVVJOI5HJ8SNSwp6yY98E\n zM4ZsANLQLmT+s8JnI85ERcwmBcWFNsAcX1485dR0Vd8Kd1DR2iZlBp4EGHCf6Yp467iRKUBI4t\n cnNVfc09joowOMw","X-Received":"by 2002:a05:6808:3a0e:b0:45f:a12:5c88 with SMTP id\n 5614622812f47-463b422c6abmr7256133b6e.49.1771363374987;\n Tue, 17 Feb 2026 13:22:54 -0800 (PST)","From":"Taylor Simpson ","To":"qemu-devel@nongnu.org","Cc":"brian.cain@oss.qualcomm.com, matheus.bernardino@oss.qualcomm.com,\n sid.manning@oss.qualcomm.com, marco.liebel@oss.qualcomm.com,\n richard.henderson@linaro.org, philmd@linaro.org, ale@rev.ng, anjo@rev.ng,\n ltaylorsimpson@gmail.com","Subject":"[PATCH v3 5/8] Hexagon (target/hexagon) Check each opcode against\n current CPU definition","Date":"Tue, 17 Feb 2026 14:22:42 -0700","Message-ID":"<20260217212245.95321-6-ltaylorsimpson@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260217212245.95321-1-ltaylorsimpson@gmail.com>","References":"<20260217212245.95321-1-ltaylorsimpson@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::230;\n envelope-from=ltaylorsimpson@gmail.com; helo=mail-oi1-x230.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"During decoding, check that the opcode is supported in the current\nHexagon CPU definition\n\nCo-authored-by: Matheus Tavares Bernardino \nCo-authored-by: Brian Cain \nSigned-off-by: Taylor Simpson \n---\n target/hexagon/decode.h | 2 ++\n target/hexagon/decode.c | 27 +++++++++++++++++++++++++++\n 2 files changed, 29 insertions(+)","diff":"diff --git a/target/hexagon/decode.h b/target/hexagon/decode.h\nindex 3f3012b978..d4b049961e 100644\n--- a/target/hexagon/decode.h\n+++ b/target/hexagon/decode.h\n@@ -30,4 +30,6 @@ void decode_send_insn_to(Packet *packet, int start, int newloc);\n int decode_packet(DisasContext *ctx, int max_words, const uint32_t *words,\n Packet *pkt, bool disas_only);\n \n+bool opcode_supported(uint16_t opcode, const HexagonCPUDef *hex_def);\n+\n #endif\ndiff --git a/target/hexagon/decode.c b/target/hexagon/decode.c\nindex dbc9c630e8..b8a1cd5b12 100644\n--- a/target/hexagon/decode.c\n+++ b/target/hexagon/decode.c\n@@ -647,6 +647,22 @@ decode_set_slot_number(Packet *pkt)\n return has_valid_slot_assignment(pkt);\n }\n \n+bool opcode_supported(uint16_t opcode, const HexagonCPUDef *hex_def)\n+{\n+ HexagonVersion hex_version = hex_def->hex_version;\n+#include \"tag_rev_info.c.inc\"\n+\n+ struct tag_rev_info info = tag_rev_info[opcode];\n+ if (hex_version == HEX_VER_ANY) {\n+ return true;\n+ }\n+ if ((info.introduced != HEX_VER_NONE && hex_version < info.introduced) ||\n+ (info.removed != HEX_VER_NONE && hex_version >= info.removed)) {\n+ return false;\n+ }\n+ return true;\n+}\n+\n /*\n * Check for GPR write conflicts in the packet.\n * A conflict exists when a register is written by more than one instruction\n@@ -746,6 +762,17 @@ int decode_packet(DisasContext *ctx, int max_words, const uint32_t *words,\n /* Ran out of words! */\n return 0;\n }\n+\n+ /*\n+ * Check that all the opcodes are supported in this Hexagon definition\n+ * If not, return decode error\n+ */\n+ for (i = 0; i < num_insns; i++) {\n+ if (!opcode_supported(pkt->insn[i].opcode, ctx->hex_def)) {\n+ return 0;\n+ }\n+ }\n+\n pkt->encod_pkt_size_in_bytes = words_read * 4;\n pkt->pkt_has_hvx = false;\n for (i = 0; i < num_insns; i++) {\n","prefixes":["v3","5/8"]}