{"id":2197372,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197372/?format=json","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.0/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260217182257.1582-5-alifm@linux.ibm.com>","date":"2026-02-17T18:22:52","name":"[v9,4/9] PCI: Add additional checks for flr reset","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5e00f15bd8e8f841ed82091f45f6d54a9cad5a13","submitter":{"id":73785,"url":"http://patchwork.ozlabs.org/api/1.0/people/73785/?format=json","name":"Farhan Ali","email":"alifm@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260217182257.1582-5-alifm@linux.ibm.com/mbox/","series":[{"id":492470,"url":"http://patchwork.ozlabs.org/api/1.0/series/492470/?format=json","date":"2026-02-17T18:22:49","name":"Error recovery for vfio-pci devices on s390x","version":9,"mbox":"http://patchwork.ozlabs.org/series/492470/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197372/checks/","tags":{},"headers":{"Return-Path":"\n <linux-pci+bounces-47500-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=WU5Fib4I;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-47500-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=\"WU5Fib4I\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=148.163.156.1","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.ibm.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFp420QWMz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 18 Feb 2026 05:25:54 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 15F3230774E0\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 17 Feb 2026 18:23:24 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E36E7374721;\n\tTue, 17 Feb 2026 18:23:18 +0000 (UTC)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A60B232E12D;\n\tTue, 17 Feb 2026 18:23:17 +0000 (UTC)","from pps.filterd (m0353729.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 61H8XSbs3466849;\n\tTue, 17 Feb 2026 18:23:06 GMT","from ppma11.dal12v.mail.ibm.com\n (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4caj6rwjfe-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tTue, 17 Feb 2026 18:23:05 +0000 (GMT)","from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 61HG0QGJ030213;\n\tTue, 17 Feb 2026 18:23:04 GMT","from smtprelay03.wdc07v.mail.ibm.com ([172.16.1.70])\n\tby ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4ccb4543c6-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tTue, 17 Feb 2026 18:23:04 +0000","from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com\n [10.241.53.104])\n\tby smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 61HIMgu618612962\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tTue, 17 Feb 2026 18:22:42 GMT","from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id C9E915805D;\n\tTue, 17 Feb 2026 18:23:02 +0000 (GMT)","from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id E0FF658052;\n\tTue, 17 Feb 2026 18:23:01 +0000 (GMT)","from IBM-D32RQW3.ibm.com (unknown [9.61.242.249])\n\tby smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP;\n\tTue, 17 Feb 2026 18:23:01 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1771352598; cv=none;\n b=bf8jNhadOLUszoKl2xjPlYufnuznPSmgQVZnzFy++nseq1Vfs3gsYGlO2vD0Vqg8rSGstbHQ/K9nSSgDfCkqEHL+OKLDdG14vKFPcHK9ZnYzVo98hKBiRsTu9VMtL7PKvGzvTOCg2EHB/ZT/3MmuG5eTuW3UCj0uf0xC5QpOeQM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1771352598; c=relaxed/simple;\n\tbh=4wglaby+R8snrfD9UzVPP38foDdpaiJrB3YvtnEdI6U=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=BQDOkla7smz1VqmHajNbiq91QzgeLIX6qRZRHAl4qtCCEnTyBCM4Vb6jKhCnIPDCIiTI/8cKDtdW/+Ei0wxQleJ/A/zWSySBy5ERL++nnZH0NNYTKRacBGuyYub2JTvb8D72GDIMyWGcNDCOwTSdk7Pb6JKiCB+8CNwqxnDx5mk=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n spf=pass smtp.mailfrom=linux.ibm.com;\n dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com\n header.b=WU5Fib4I; arc=none smtp.client-ip=148.163.156.1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=pp1; bh=9h1TT/s2NziYpsxx+\n\tDjjI2cbosM+B1a21s+AOqeVmp4=; b=WU5Fib4Iu6AjoHgy/3CqDRev5qagUf8OY\n\tHhe0seMrW/Jp4JqbDBPizJufRAYwzfZJyz333DyVE8ECBHXCxZTTvhzhuBJMsY+3\n\tDavvpeK4S695olRnWpHeqNDaCyb0YunaoU7sQKNqcUj4k1qTjr7XS2NyMRPnhM1D\n\tnSvkp3GtiXtne4W9+xh42MZoEaZKiyHLcanrvHwpIH8mC+zIUPcEsfx09lS0OPT/\n\tg07zZl+TvUY8jFt7UBbJYEk8Qi2exjyBWH/rp4PDtn+9TlNr1EPCPsQkx6OUm6yi\n\tANoDumPAmu5t2ye9alH63+94ixuQT4Zfues64A5szxRuMlCDw505A==","From":"Farhan Ali <alifm@linux.ibm.com>","To":"linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,\n        linux-pci@vger.kernel.org","Cc":"helgaas@kernel.org, lukas@wunner.de, alex@shazbot.org, clg@redhat.com,\n        stable@vger.kernel.org, alifm@linux.ibm.com, schnelle@linux.ibm.com,\n        mjrosato@linux.ibm.com, Benjamin Block <bblock@linux.ibm.com>","Subject":"[PATCH v9 4/9] PCI: Add additional checks for flr reset","Date":"Tue, 17 Feb 2026 10:22:52 -0800","Message-ID":"<20260217182257.1582-5-alifm@linux.ibm.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260217182257.1582-1-alifm@linux.ibm.com>","References":"<20260217182257.1582-1-alifm@linux.ibm.com>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=dvvWylg4 c=1 sm=1 tr=0 ts=6994b209 cx=c_pps\n a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17\n a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8\n a=_COy7Z8VS3VoYlkUqhYA:9","X-Proofpoint-GUID":"kKPV7CYnKBboefQhCBwdR0tGXffE4dwJ","X-Proofpoint-ORIG-GUID":"kKPV7CYnKBboefQhCBwdR0tGXffE4dwJ","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMjE3MDE0OCBTYWx0ZWRfX/uIpRuXbB/Cc\n j40p+vOknCXeBikRypy02x+wGOft/v869YCl9JD3X8NOJwp6U8YMV4ekYnE34WSWt3mdrxFseW/\n 4o+fEJGSBxSunixp3fyK0i3onJg++/0lX0EgO8K1lEgJAsAWSgPPxphVN34R84ay+YZoCvcrwwg\n eSFcuktqGH68MjmXkKcGWnsaywNKE3PbThsxitfJLhwbB/+7r5tXErYtDuyu3L2ODnO7uc05Qwj\n eRP7E2UHPBniDwXlyyesjhlq0IbzUvjzHSeiYs3p9k2a9P6ejU95gX9Yzv5MH2VnecUx6vkntxr\n Er4xjJ1Qq7VHZUqICeT2r5Mc94pZUkxvx+iak7stUPHYiPO2FMTATyDthOfeZvcz4VusXxOTwG6\n ozf6FK1yqKYQwi6+fwHF697SlFt8cgBNu3BlEw17AtjhPnsLuFXfp2qq7GMAM86RkId8GrmHSNz\n /J+2UjmfVTf3UaOwVlw==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-17_03,2026-02-16_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n spamscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0\n priorityscore=1501 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0\n bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602170148"},"content":"If a device is in an error state, then any reads of device registers can\nreturn error value. Add addtional checks to validate if a device is in an\nerror state before doing an flr reset.\n\nCc: stable@vger.kernel.org\nReviewed-by: Benjamin Block <bblock@linux.ibm.com>\nReviewed-by: Niklas Schnelle <schnelle@linux.ibm.com>\nSigned-off-by: Farhan Ali <alifm@linux.ibm.com>\n---\n drivers/pci/pci.c | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c\nindex 2242b97e7d46..d867db7188d0 100644\n--- a/drivers/pci/pci.c\n+++ b/drivers/pci/pci.c\n@@ -4373,12 +4373,19 @@ EXPORT_SYMBOL_GPL(pcie_flr);\n  */\n int pcie_reset_flr(struct pci_dev *dev, bool probe)\n {\n+\tu32 reg;\n+\n \tif (dev->dev_flags & PCI_DEV_FLAGS_NO_FLR_RESET)\n \t\treturn -ENOTTY;\n \n \tif (!(dev->devcap & PCI_EXP_DEVCAP_FLR))\n \t\treturn -ENOTTY;\n \n+\tif (pcie_capability_read_dword(dev, PCI_EXP_DEVCAP, &reg)) {\n+\t\tpci_warn(dev, \"Device unable to do an FLR\\n\");\n+\t\treturn -ENOTTY;\n+\t}\n+\n \tif (probe)\n \t\treturn 0;\n \n","prefixes":["v9","4/9"]}