{"id":2197339,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197339/?format=json","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.0/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260217170419.236739-6-Simon.Richter@hogyros.de>","date":"2026-02-17T17:04:19","name":"[5/5] pci: mark return value of pci_set_vga_state as __must_check","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c93a84ae808ef869ad831254d117e035c5bc5a72","submitter":{"id":91044,"url":"http://patchwork.ozlabs.org/api/1.0/people/91044/?format=json","name":"Simon Richter","email":"Simon.Richter@hogyros.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260217170419.236739-6-Simon.Richter@hogyros.de/mbox/","series":[{"id":492462,"url":"http://patchwork.ozlabs.org/api/1.0/series/492462/?format=json","date":"2026-02-17T17:04:19","name":"bridges without VGA support","version":1,"mbox":"http://patchwork.ozlabs.org/series/492462/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197339/checks/","tags":{},"headers":{"Return-Path":"\n <linux-pci+bounces-47481-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-47481-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=185.187.169.70","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=hogyros.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=hogyros.de"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFmGj20XVz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 18 Feb 2026 04:05:01 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 7EA3C3004078\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 17 Feb 2026 17:04:58 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 18DE6C2FF;\n\tTue, 17 Feb 2026 17:04:56 +0000 (UTC)","from psionic.psi5.com (psionic.psi5.com [185.187.169.70])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 45427283FE2\n\tfor <linux-pci@vger.kernel.org>; Tue, 17 Feb 2026 17:04:52 +0000 (UTC)","from localhost.localdomain (unknown\n [IPv6:2400:2410:b120:f200:2e09:4dff:fe00:2e9])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(Client did not present a certificate)\n\tby psionic.psi5.com (Postfix) with ESMTPSA id B3CBD48ADA;\n\tTue, 17 Feb 2026 18:04:49 +0100 (CET)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1771347896; cv=none;\n b=BOoHeHA7oGUlIYkHHwpwpzKr1F8BAvBrZNVe10LXIKh9UmZkOcFaPMAr2DOnjn5XfuDNN5HCSv+COzl00atJc/FtX/zWi4GVTEakARpD6QJQ8CXIR9sUNxaGj1MXptV674Y50eJqon/sH9lQ9B/1iAYLcWBzrNOvxIa//IKjwLI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1771347896; c=relaxed/simple;\n\tbh=8nbDxdvAQJU8348QsKZkR5J2oULE2YJAZS9e6FfC6+Y=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=bBqB25qvgtf1GLmDcpPOeBOyDuff/6ufNtoKMXcsl3nFc73WytISb9I5kFrktqFUMts8FcofO7Km9dDonmFWgm96cuwlQPkqmtKXPZWT9sN7Gy/3pDNcowvZ66X7VRLXZMU5sGMdBCkoLiXQzUVqKLpB+gY5tIsRy4dsLuCYWk0=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=hogyros.de;\n spf=pass smtp.mailfrom=hogyros.de; arc=none smtp.client-ip=185.187.169.70","From":"Simon Richter <Simon.Richter@hogyros.de>","To":"linux-pci@vger.kernel.org","Cc":"intel-xe@lists.freedesktop.org,\n\tdri-devel@lists.freedesktop.org,\n\tSimon Richter <Simon.Richter@hogyros.de>","Subject":"[PATCH 5/5] pci: mark return value of pci_set_vga_state as\n __must_check","Date":"Wed, 18 Feb 2026 02:04:19 +0900","Message-ID":"<20260217170419.236739-6-Simon.Richter@hogyros.de>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20260217170419.236739-1-Simon.Richter@hogyros.de>","References":"<20260217170419.236739-1-Simon.Richter@hogyros.de>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"This function can return an error, which should be checked.\n\nThe only caller so far is __vga_tryget in vgaarb, which did not check.\n\nSigned-off-by: Simon Richter <Simon.Richter@hogyros.de>\n---\n include/linux/pci.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/include/linux/pci.h b/include/linux/pci.h\nindex 1c270f1d5123..08d7c1ae33b5 100644\n--- a/include/linux/pci.h\n+++ b/include/linux/pci.h\n@@ -1720,7 +1720,7 @@ resource_size_t pcibios_window_alignment(struct pci_bus *bus,\n #define PCI_VGA_STATE_CHANGE_BRIDGE (1 << 0)\n #define PCI_VGA_STATE_CHANGE_DECODES (1 << 1)\n \n-int pci_set_vga_state(struct pci_dev *pdev, bool decode,\n+int __must_check pci_set_vga_state(struct pci_dev *pdev, bool decode,\n \t\t      unsigned int command_bits, u32 flags);\n \n /*\n","prefixes":["5/5"]}