{"id":2197182,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197182/?format=json","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.0/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<20260217-pwrctrl-fixes-7-0-v1-2-b5671e58934f@oss.qualcomm.com>","date":"2026-02-17T10:18:47","name":"[2/2] PCI/pwrctrl: Only create pwrctrl device if the device node is of type \"pci\"","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f8bf63331f1b3fd2e4b25bfcd74d3943604011b3","submitter":{"id":91277,"url":"http://patchwork.ozlabs.org/api/1.0/people/91277/?format=json","name":"Manivannan Sadhasivam via B4 Relay","email":"devnull+manivannan.sadhasivam.oss.qualcomm.com@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260217-pwrctrl-fixes-7-0-v1-2-b5671e58934f@oss.qualcomm.com/mbox/","series":[{"id":492406,"url":"http://patchwork.ozlabs.org/api/1.0/series/492406/?format=json","date":"2026-02-17T10:18:45","name":"PCI/pwrctrl: A couple of fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/492406/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197182/checks/","tags":{},"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=NMf6YQrD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-47437-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"NMf6YQrD\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFbGC0dZ9z1xwF\n\tfor ; Tue, 17 Feb 2026 21:18:59 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 37FB1300C036\n\tfor ; Tue, 17 Feb 2026 10:18:55 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 075E028D8D0;\n\tTue, 17 Feb 2026 10:18:52 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D7542281532;\n\tTue, 17 Feb 2026 10:18:51 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPS id A0AE6C19424;\n\tTue, 17 Feb 2026 10:18:51 +0000 (UTC)","from aws-us-west-2-korg-lkml-1.web.codeaurora.org\n (localhost.localdomain [127.0.0.1])\n\tby smtp.lore.kernel.org (Postfix) with ESMTP id 92A87E68163;\n\tTue, 17 Feb 2026 10:18:51 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1771323531; cv=none;\n b=VmOufF+Ej2QtsjKeTlqxeiNWbjWqEdKydjiaCFeBHvkwogx1et1i88aH9VDpJbnmHKc4yrwGb98s7M1pYf+Cou6ZcoaRfli6y79dX0WwmNHdz0JMGIBQLKLiQ/vm8vo28mmYjV3Y330nMyRNBm+IC3hflzVd/ybHBA2plLTvCT4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1771323531; c=relaxed/simple;\n\tbh=+FvIOo6LaMp1nwA9zSJb2lGx0Ul6585dauW/Ve0I6mk=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=YwG09uTJJOKhluuvbTrZxS1UA8udo6GLHpW8Ss25pDfEK5RFE/JffFSNoJ8mOzrr6aKBGMDthjYL93qmIoD9eKY9ze8RUBlad7y65OEF1uc7RP6LjqVul/71ngacRXEZGmBxg5Fb6dJEq4z2M+KkikK/WjNC2M+yraY2F9mZoy4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=NMf6YQrD; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1771323531;\n\tbh=+FvIOo6LaMp1nwA9zSJb2lGx0Ul6585dauW/Ve0I6mk=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From;\n\tb=NMf6YQrDoQfqmjJ2yZ7fD2NOzKge4aBPHtJkwpiRBEAQsLumo1BGla4kSwq3uvfVK\n\t BFwhdZmf1M7vKA5XMACq0FijQVb0mLFaLQ2j6MqMUrqdsEL+H36Wmkm4A9n1xAIRAW\n\t 4KgaKqVPB2zhNJld75OctGPfe9lRwBtn7AdjzShMOFMDi5eBzxuJ2lkRfrKrDpB2oq\n\t Hla1K1kO4HpGFzov0YWK0phPZz7e7GbRfobLh/jyLZebcxIbRdr5xgpifyoX1dvddc\n\t NVD+cVHBhhBcLo34qAlsUrOQ63Eh674xPE0JtvVP412fT9uv0prZrXAwUhNhH2UUzg\n\t OgnJOEUzPTLHQ==","From":"Manivannan Sadhasivam via B4 Relay\n ","Date":"Tue, 17 Feb 2026 15:48:47 +0530","Subject":"[PATCH 2/2] PCI/pwrctrl: Only create pwrctrl device if the device\n node is of type \"pci\"","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260217-pwrctrl-fixes-7-0-v1-2-b5671e58934f@oss.qualcomm.com>","References":"<20260217-pwrctrl-fixes-7-0-v1-0-b5671e58934f@oss.qualcomm.com>","In-Reply-To":"<20260217-pwrctrl-fixes-7-0-v1-0-b5671e58934f@oss.qualcomm.com>","To":"Bartosz Golaszewski ,\n Manivannan Sadhasivam ,\n Bjorn Helgaas ,\n Krishna Chaitanya Chundru ","Cc":"linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,\n Bartosz Golaszewski ,\n Manivannan Sadhasivam ,\n Bjorn Andersson ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1885;\n i=manivannan.sadhasivam@oss.qualcomm.com; h=from:subject:message-id;\n bh=aNEcD1tWIRurJpHegw9tQESfw9DiViDCcnlJdYscw3w=;\n b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBplECJBvvbUtKjqgm7Y5/W5vm/aHOgtEqONDvkP\n l078hE72uCJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCaZRAiQAKCRBVnxHm/pHO\n 9Y+dB/9qein+EP7oXQE9zMgLPXSx0XxeSLsxXSKneM6oVh6c/ypC+5r3ahlhx1AcvSWrT0Zvl+K\n icHW2vegkchJe2pHv1YYPe5OvJlsn5rmSF5Sk/IoKJs4q5F+WIwlbg+pB9o8rR/HfDsWUM5/S2e\n 8lXc08sUyYAE7x5YsHsL3YNSkx1JQ0hPNIkh21k7Do5LIWyyWb1Xe6N7gwhudu3z+Cp/YIvckva\n NOAbFgNtINUWz28zMIGL317KwMdhZGhyFihxQKbE5BD96/oXxEUzuYgOzLvXdcapIURhJlOnvVS\n IhBA87WxKKlqX8xKU+UsIPszOX+wm1IPF+APCi4jJsRmNLpB","X-Developer-Key":"i=manivannan.sadhasivam@oss.qualcomm.com; a=openpgp;\n fpr=C668AEC3C3188E4C611465E7488550E901166008","X-Endpoint-Received":"by B4 Relay for\n manivannan.sadhasivam@oss.qualcomm.com/default with auth_id=461","X-Original-From":"Manivannan Sadhasivam\n ","Reply-To":"manivannan.sadhasivam@oss.qualcomm.com"},"content":"From: Manivannan Sadhasivam \n\nThe PCI host bridge node can have non-PCI child nodes as well, like OPP\ntables, USB controller node etc... So the pwrctrl core must check for the\npresence of 'device_type' property with value of \"pci\" to ensure that the\npwrctrl device is only created for PCI device nodes.\n\nFixes: 4c4132489201 (\"PCI/pwrctrl: Add APIs to create, destroy pwrctrl devices\")\nReported-by: Bjorn Andersson \nCloses: https://lore.kernel.org/all/20260212-rb3gen2-upd-gl3590-v1-1-18fb04bb32b0@oss.qualcomm.com\nSigned-off-by: Manivannan Sadhasivam \n---\n drivers/pci/pwrctrl/core.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/pci/pwrctrl/core.c b/drivers/pci/pwrctrl/core.c\nindex 8325858cc379..7404d48427ce 100644\n--- a/drivers/pci/pwrctrl/core.c\n+++ b/drivers/pci/pwrctrl/core.c\n@@ -272,8 +272,9 @@ EXPORT_SYMBOL_GPL(pci_pwrctrl_power_on_devices);\n * Check whether the pwrctrl device really needs to be created or not. The\n * pwrctrl device will only be created if the node satisfies below requirements:\n *\n- * 1. Presence of compatible property to match against the pwrctrl driver (AND)\n- * 2. At least one of the power supplies defined in the devicetree node of the\n+ * 1. Presence of 'device_type = \"pci\"' property to identify PCI node (AND)\n+ * 2. Presence of compatible property to match against the pwrctrl driver (AND)\n+ * 3. At least one of the power supplies defined in the devicetree node of the\n * device (OR) in the remote endpoint parent node to indicate pwrctrl\n * requirement.\n */\n@@ -281,6 +282,9 @@ static bool pci_pwrctrl_is_required(struct device_node *np)\n {\n \tstruct device_node *endpoint;\n \n+\tif (!of_node_is_type(np, \"pci\"))\n+\t\treturn false;\n+\n \tif (!of_property_present(np, \"compatible\"))\n \t\treturn false;\n \n","prefixes":["2/2"]}