{"id":2197179,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197179/?format=json","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.0/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs"},"msgid":"<20260217100529.2739141-2-david.marchand@redhat.com>","date":"2026-02-17T10:05:28","name":"[ovs-dev,RFC,v2,1/2] netdev-dpdk: Enhance logging for port hotplug.","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"9c1d010c5c57b407b73b85eab269d0bb297e3898","submitter":{"id":75396,"url":"http://patchwork.ozlabs.org/api/1.0/people/75396/?format=json","name":"David Marchand","email":"david.marchand@redhat.com"},"delegate":{"id":75123,"url":"http://patchwork.ozlabs.org/api/1.0/users/75123/?format=json","username":"echaudron","first_name":"Eelco","last_name":"Chaudron","email":"echaudro@redhat.com"},"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260217100529.2739141-2-david.marchand@redhat.com/mbox/","series":[{"id":492405,"url":"http://patchwork.ozlabs.org/api/1.0/series/492405/?format=json","date":"2026-02-17T10:05:27","name":"Disable initial device probe in DPDK.","version":2,"mbox":"http://patchwork.ozlabs.org/series/492405/mbox/"}],"check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2197179/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=a4aNofpj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp4.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=a4aNofpj","smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFZzD6XZ0z1xpl\n\tfor ; Tue, 17 Feb 2026 21:06:00 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 2588240C99;\n\tTue, 17 Feb 2026 10:05:59 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 5Q_YmWZFKFyh; Tue, 17 Feb 2026 10:05:58 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp4.osuosl.org (Postfix) with ESMTPS id 0E42040CAC;\n\tTue, 17 Feb 2026 10:05:57 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id D540EC0035;\n\tTue, 17 Feb 2026 10:05:57 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 1E713C0033\n for ; Tue, 17 Feb 2026 10:05:57 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 07ABA40C99\n for ; Tue, 17 Feb 2026 10:05:57 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id kIVVmZnWeeDz for ;\n Tue, 17 Feb 2026 10:05:56 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id EC6FC40C81\n for ; Tue, 17 Feb 2026 10:05:55 +0000 (UTC)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-jPKa41L1PqWa9mt2s7j3cw-1; Tue,\n 17 Feb 2026 05:05:51 -0500","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 030FA1955D89; Tue, 17 Feb 2026 10:05:50 +0000 (UTC)","from dmarchan.lan (unknown [10.45.225.11])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 1FF7830001B9; Tue, 17 Feb 2026 10:05:47 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 0E42040CAC","OpenDKIM Filter v2.11.0 smtp4.osuosl.org EC6FC40C81"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com;\n envelope-from=david.marchand@redhat.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org EC6FC40C81","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771322754;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Gyh3qNQBphciNYAgnM/EK0aAERe/sRUTyCxHxTgeK3s=;\n b=a4aNofpjgxHuY9PKHuy5s/aVLgJ3aPzTBoMcZshCf3nvAgKPSocqs6wQ6Betlluiokx+ec\n hDaReS4K9Y35Ki6tcYIrdM1EifKeNQzXX2oB/5I7CQBvCZmoN2g6XGC9lvtT04klL4gnIy\n 94oOApPPSSkpLR3ZvCt1HbQbIk7Vxqo=","X-MC-Unique":"jPKa41L1PqWa9mt2s7j3cw-1","X-Mimecast-MFC-AGG-ID":"jPKa41L1PqWa9mt2s7j3cw_1771322750","To":"dev@openvswitch.org","Date":"Tue, 17 Feb 2026 11:05:28 +0100","Message-ID":"<20260217100529.2739141-2-david.marchand@redhat.com>","In-Reply-To":"<20260217100529.2739141-1-david.marchand@redhat.com>","References":"<20260217100529.2739141-1-david.marchand@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"0kVsEBv7vPY-FDBoz7pjM_8OwoYy9PNPJmWPajbcN44_1771322750","X-Mimecast-Originator":"redhat.com","Subject":"[ovs-dev] [RFC v2 1/2] netdev-dpdk: Enhance logging for port\n hotplug.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"David Marchand via dev ","Reply-To":"David Marchand ","Cc":"elibr@nvidia.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"Currently, if one incorrect mac is set, a first log with little context\nis displayed, followed by a more complete one.\n\nBesides, if no port can be identified with the passed mac, then no\nexplanation is displayed.\n\nReport some details in a single log.\n\nBefore:\nnetdev_dpdk|ERR|invalid mac: 00:00:00:00:00:\nnetdev_dpdk|WARN|Error attaching device 'class=eth,mac=00:00:00:00:00:'\n\tto DPDK\n...\nnetdev_dpdk|WARN|Error attaching device 'class=eth,mac=00:00:00:00:00:00'\n\tto DPDK\n\nAfter:\nnetdev_dpdk|WARN|Error attaching device 'class=eth,mac=00:00:00:00:00:'\n\tto DPDK: invalid mac\n...\nnetdev_dpdk|WARN|Error attaching device 'class=eth,mac=00:00:00:00:00:00'\n\tto DPDK: unknown mac\n\nSigned-off-by: David Marchand \n---\nChanges since RFC v1:\n- removed redundant \"to DPDK\" in netdev-dpdk log messages,\n\n---\n lib/netdev-dpdk.c | 29 ++++++++++++++++++++---------\n 1 file changed, 20 insertions(+), 9 deletions(-)","diff":"diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c\nindex 923191da84..c51fe7c258 100644\n--- a/lib/netdev-dpdk.c\n+++ b/lib/netdev-dpdk.c\n@@ -2028,13 +2028,15 @@ netdev_dpdk_lookup_by_port_id(dpdk_port_t port_id)\n }\n \n static dpdk_port_t\n-netdev_dpdk_get_port_by_mac(const char *mac_str)\n+netdev_dpdk_get_port_by_mac(const char *mac_str, char **extra_err)\n {\n dpdk_port_t port_id;\n struct eth_addr mac, port_mac;\n \n+ *extra_err = NULL;\n+\n if (!eth_addr_from_string(mac_str, &mac)) {\n- VLOG_ERR(\"invalid mac: %s\", mac_str);\n+ *extra_err = xstrdup(\"invalid mac\");\n return DPDK_ETH_PORT_ID_INVALID;\n }\n \n@@ -2048,6 +2050,7 @@ netdev_dpdk_get_port_by_mac(const char *mac_str)\n }\n }\n \n+ *extra_err = xstrdup(\"unknown mac\");\n return DPDK_ETH_PORT_ID_INVALID;\n }\n \n@@ -2084,32 +2087,40 @@ netdev_dpdk_process_devargs(struct netdev_dpdk *dev,\n OVS_REQUIRES(dpdk_mutex)\n {\n dpdk_port_t new_port_id;\n+ char *extra_err = NULL;\n \n if (strncmp(devargs, \"class=eth,mac=\", 14) == 0) {\n- new_port_id = netdev_dpdk_get_port_by_mac(&devargs[14]);\n+ new_port_id = netdev_dpdk_get_port_by_mac(&devargs[14], &extra_err);\n } else {\n new_port_id = netdev_dpdk_get_port_by_devargs(devargs);\n if (!rte_eth_dev_is_valid_port(new_port_id)) {\n- /* Device not found in DPDK, attempt to attach it */\n- if (rte_dev_probe(devargs)) {\n+ int ret;\n+\n+ /* Port not found in DPDK, attempt to attach the device. */\n+ ret = rte_dev_probe(devargs);\n+ if (ret < 0) {\n new_port_id = DPDK_ETH_PORT_ID_INVALID;\n+ extra_err = xstrdup(ovs_strerror(-ret));\n } else {\n new_port_id = netdev_dpdk_get_port_by_devargs(devargs);\n if (rte_eth_dev_is_valid_port(new_port_id)) {\n- /* Attach successful */\n+ /* Port lookup successful. */\n dev->attached = true;\n- VLOG_INFO(\"Device '%s' attached to DPDK\", devargs);\n+ VLOG_INFO(\"Device '%s' attached\", devargs);\n } else {\n- /* Attach unsuccessful */\n+ /* Port lookup unsuccessful. */\n new_port_id = DPDK_ETH_PORT_ID_INVALID;\n+ extra_err = xstrdup(\"port unknown\");\n }\n }\n }\n }\n \n if (new_port_id == DPDK_ETH_PORT_ID_INVALID) {\n- VLOG_WARN_BUF(errp, \"Error attaching device '%s' to DPDK\", devargs);\n+ VLOG_WARN_BUF(errp, \"Error attaching device '%s': %s\", devargs,\n+ extra_err ? extra_err : \"unknown error\");\n }\n+ free(extra_err);\n \n return new_port_id;\n }\n","prefixes":["ovs-dev","RFC","v2","1/2"]}