{"id":2197173,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197173/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260217095106.598486-8-richard.henderson@linaro.org>","date":"2026-02-17T09:51:06","name":"[v2,7/7] target-info: Eliminate TARGET_PAGE_BITS_LEGACY","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7a38313582b74f840efe09dd7692a4e7b1b68522","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.0/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217095106.598486-8-richard.henderson@linaro.org/mbox/","series":[{"id":492403,"url":"http://patchwork.ozlabs.org/api/1.0/series/492403/?format=json","date":"2026-02-17T09:51:04","name":"page-vary: Build once","version":2,"mbox":"http://patchwork.ozlabs.org/series/492403/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197173/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Fko+t9Jj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFZh03BvGz1xpl\n\tfor ; Tue, 17 Feb 2026 20:52:48 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsHkd-0002sk-41; Tue, 17 Feb 2026 04:52:15 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsHkR-0002au-1Y\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 04:52:03 -0500","from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1vsHkO-0006Bg-B8\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 04:52:02 -0500","by mail-pl1-x62b.google.com with SMTP id\n d9443c01a7336-2a962230847so33781885ad.3\n for ; Tue, 17 Feb 2026 01:51:29 -0800 (PST)","from localhost.localdomain\n (2403-580b-742d-0-10a2-dce1-aa4a-dd32.ip6.aussiebb.net.\n [2403:580b:742d:0:10a2:dce1:aa4a:dd32])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2ad1a6fa33esm99108675ad.13.2026.02.17.01.51.26\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 17 Feb 2026 01:51:28 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771321889; x=1771926689; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=MqKGZs0n4DofZPkoSFoT/fTZEG3Fs+4rNgilmKZe4Ic=;\n b=Fko+t9JjwwcBIfCOSpOnIracX+dE2cjLKC3kUzZFQAZT36rbZrQExvdQgXnap8p9ea\n TyiAixdjAzM0Nt9h+MWR26ShnwYH63P5WwEzO302MrCm5+5kwQy2mSTaHtQ1Wp449iaE\n d7hx+74vNxwnDokY1Uox5r0AXjP8xhOTv+DeHDDMWLG8PaFQKq5ZUusZR5A++8cFC4uY\n JYzMAr2FSrD77WrvfmXcT24s06O4ttU6y2HkvfOtkWH+863WqVmCmheDXuIbjus6rJmS\n 5l0p3q0KkdKVcQWgHqC9l6I0UHsDE9VqXRa24yYSzTDVfEZI6/8K/c8fz+OGN9JP3nLf\n aBoA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771321889; x=1771926689;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=MqKGZs0n4DofZPkoSFoT/fTZEG3Fs+4rNgilmKZe4Ic=;\n b=S3Cwv3dt7RHtZc92igYNi9iwX46JWxsDYw/Tu4CuQxP00dBSD0/dFIit/Dc2p74jEw\n lnTpxzjubt0Lr7ktc4LSLZmSopnpfFe8CNDrOzLGlDlDNhkkdFzuJ4MUwJxR1rarDSUM\n J1S8EHdfddLLQkxIb+U4pv/CuwugMvltVQ4JBfoZ1hDnca8adkiS9w2rl5pnmaWW/c/s\n lSPWFZbJzb3x0FOYITdy9RuV0giR8nqZxF033VF2o7F5Tv4HVzvpu+ZXc4nEvnrNbBTp\n 7Hmg5rfMiNNY+tTCgYhZOwRasaCKC6OBxa7uPjzwKSMeH/D8gSmf7VdZq2M9G0j+15tI\n EewA==","X-Gm-Message-State":"AOJu0YykyyoVwgiBvJTNXlONhTG4JdgTr4YhL3DKn0k2R7YLfAd16nE9\n B1NXB2opeZKLSGUuZLGYV7pRCgW1k8xPL4Vfo+PsSQ18P2sGhMuCZEi36P8Y1PUJvOBJpf0xYCH\n TGzv27kA=","X-Gm-Gg":"AZuq6aLHc4Sq9acEswjIu+F36c2R2s0QgDkqWmvhBSHvlsdqOCpVmL6YUtD0midWmVl\n 8/SvtzrQ5N3WltohtrsT6TO183bsgo+M1XoaoU/Zw0z9ReQUWiJPN0zUapv1l+JXuJ14iY88AhX\n njJZrwE5q5oPo43wknXUcK4utmnyarZieHO7kPxJ355dNES0KvPCKYwHww3mRH4Tp7nTMf9TZa+\n wbwL+wNrZHXD0DWXmUQiHq+qM56wzPZHQZremUdsM/wwpqEV1QWQ39qMHgumgRIOxmNmPpC9tae\n 1kv8C7ZxRXen5WSt5AM7FC8qOU6OQWh18flr+TbpXIOYUJkuEhmIBQf46XeUkFSPREpW5V5qQ68\n X9IPyQM73oe579cvD+JCZve2pWRkdgXk/iQjfx4hABaBho8cqU1iXTJSPv4unudsMlmZ4gJxGby\n lr3JKdEqdxgbwitotoKLXVXDDDbqg7pcRsNk4XT8fm7+TJ7yJbcSw8POPSfPqxox6yOG6JDsg+X\n GWgjjYuOWDeH3ctd/2TsrGqezMJaqHihwcEVCnMd4m01thjGw==","X-Received":"by 2002:a17:903:1a44:b0:2a9:5e25:4708 with SMTP id\n d9443c01a7336-2ab504e89fbmr139591365ad.3.1771321888706;\n Tue, 17 Feb 2026 01:51:28 -0800 (PST)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"philmd@linaro.org","Subject":"[PATCH v2 7/7] target-info: Eliminate TARGET_PAGE_BITS_LEGACY","Date":"Tue, 17 Feb 2026 19:51:06 +1000","Message-ID":"<20260217095106.598486-8-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260217095106.598486-1-richard.henderson@linaro.org>","References":"<20260217095106.598486-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::62b;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Expand TARGET_PAGE_BITS_LEGACY directly within the two Arm\nTargetInfo structures; remove it from target/arm/cpu-param.h.\nDo not allow new uses with target-info-stub.c.\n\nSigned-off-by: Richard Henderson \n---\n include/qemu/target-info-impl.h | 2 +-\n target/arm/cpu-param.h | 1 -\n configs/targets/aarch64-softmmu.c | 3 +--\n configs/targets/arm-softmmu.c | 3 +--\n target-info-stub.c | 12 ++++++------\n 5 files changed, 9 insertions(+), 12 deletions(-)","diff":"diff --git a/include/qemu/target-info-impl.h b/include/qemu/target-info-impl.h\nindex c917d546ea..a7c519cd0b 100644\n--- a/include/qemu/target-info-impl.h\n+++ b/include/qemu/target-info-impl.h\n@@ -27,7 +27,7 @@ typedef struct TargetInfo {\n EndianMode endianness;\n /*\n * runtime equivalent of\n- * TARGET_PAGE_BITS_VARY ? TARGET_PAGE_BITS_LEGACY : TARGET_PAGE_BITS\n+ * TARGET_PAGE_BITS_VARY ? minimum for the target : TARGET_PAGE_BITS\n */\n unsigned page_bits_init;\n /* runtime equivalent of TARGET_PAGE_BITS_VARY definition */\ndiff --git a/target/arm/cpu-param.h b/target/arm/cpu-param.h\nindex 8b46c7c570..07af31aa3e 100644\n--- a/target/arm/cpu-param.h\n+++ b/target/arm/cpu-param.h\n@@ -29,7 +29,6 @@\n * have to support 1K tiny pages.\n */\n # define TARGET_PAGE_BITS_VARY\n-# define TARGET_PAGE_BITS_LEGACY 10\n #endif /* !CONFIG_USER_ONLY */\n \n /*\ndiff --git a/configs/targets/aarch64-softmmu.c b/configs/targets/aarch64-softmmu.c\nindex 82ccb57575..561af56e1a 100644\n--- a/configs/targets/aarch64-softmmu.c\n+++ b/configs/targets/aarch64-softmmu.c\n@@ -10,7 +10,6 @@\n #include \"qemu/target-info-impl.h\"\n #include \"hw/arm/machines-qom.h\"\n #include \"target/arm/cpu-qom.h\"\n-#include \"target/arm/cpu-param.h\"\n \n static const TargetInfo target_info_aarch64_system = {\n .target_name = \"aarch64\",\n@@ -20,7 +19,7 @@ static const TargetInfo target_info_aarch64_system = {\n .machine_typename = TYPE_TARGET_AARCH64_MACHINE,\n .endianness = ENDIAN_MODE_LITTLE,\n .page_bits_vary = true,\n- .page_bits_init = TARGET_PAGE_BITS_LEGACY,\n+ .page_bits_init = 10,\n };\n \n const TargetInfo *target_info(void)\ndiff --git a/configs/targets/arm-softmmu.c b/configs/targets/arm-softmmu.c\nindex 18940e51e5..488217c7a0 100644\n--- a/configs/targets/arm-softmmu.c\n+++ b/configs/targets/arm-softmmu.c\n@@ -10,7 +10,6 @@\n #include \"qemu/target-info-impl.h\"\n #include \"hw/arm/machines-qom.h\"\n #include \"target/arm/cpu-qom.h\"\n-#include \"target/arm/cpu-param.h\"\n \n static const TargetInfo target_info_arm_system = {\n .target_name = \"arm\",\n@@ -20,7 +19,7 @@ static const TargetInfo target_info_arm_system = {\n .machine_typename = TYPE_TARGET_ARM_MACHINE,\n .endianness = ENDIAN_MODE_LITTLE,\n .page_bits_vary = true,\n- .page_bits_init = TARGET_PAGE_BITS_LEGACY,\n+ .page_bits_init = 10,\n };\n \n const TargetInfo *target_info(void)\ndiff --git a/target-info-stub.c b/target-info-stub.c\nindex f5896a7262..d948ebef5f 100644\n--- a/target-info-stub.c\n+++ b/target-info-stub.c\n@@ -29,14 +29,14 @@ static const TargetInfo target_info_stub = {\n .cpu_type = CPU_RESOLVING_TYPE,\n .machine_typename = TYPE_MACHINE,\n .endianness = TARGET_BIG_ENDIAN ? ENDIAN_MODE_BIG : ENDIAN_MODE_LITTLE,\n-#ifdef TARGET_PAGE_BITS_VARY\n- .page_bits_vary = true,\n-# ifdef TARGET_PAGE_BITS_LEGACY\n- .page_bits_init = TARGET_PAGE_BITS_LEGACY,\n-# endif\n-#else\n+#ifndef TARGET_PAGE_BITS_VARY\n .page_bits_vary = false,\n .page_bits_init = TARGET_PAGE_BITS,\n+#elif defined(CONFIG_USER_ONLY)\n+ .page_bits_vary = true,\n+ /* page_bits_init is unused; page size always set by main */\n+#else\n+# error \"page_bits_init must be set in configs/target\"\n #endif\n };\n \n","prefixes":["v2","7/7"]}