{"id":2197171,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197171/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260217095106.598486-6-richard.henderson@linaro.org>","date":"2026-02-17T09:51:04","name":"[v2,5/7] page-vary: Build finalize_target_page_bits as common code","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a82c24d2492cfa5162db8c4cd827af17b06b8bd6","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.0/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217095106.598486-6-richard.henderson@linaro.org/mbox/","series":[{"id":492403,"url":"http://patchwork.ozlabs.org/api/1.0/series/492403/?format=json","date":"2026-02-17T09:51:04","name":"page-vary: Build once","version":2,"mbox":"http://patchwork.ozlabs.org/series/492403/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197171/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=kYU7wyxZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFZgN4rP8z1xpl\n\tfor ; Tue, 17 Feb 2026 20:52:16 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsHkV-0002l8-HN; Tue, 17 Feb 2026 04:52:07 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsHkN-0002U0-Jv\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 04:51:59 -0500","from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1vsHkF-0006AL-RO\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 04:51:56 -0500","by mail-pl1-x632.google.com with SMTP id\n d9443c01a7336-2a7a9b8ed69so39554075ad.2\n for ; Tue, 17 Feb 2026 01:51:25 -0800 (PST)","from localhost.localdomain\n (2403-580b-742d-0-10a2-dce1-aa4a-dd32.ip6.aussiebb.net.\n [2403:580b:742d:0:10a2:dce1:aa4a:dd32])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2ad1a6fa33esm99108675ad.13.2026.02.17.01.51.22\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 17 Feb 2026 01:51:23 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771321884; x=1771926684; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=hNM7XgKmeqgrM8/J+m8bKIPPky9vmnlqRq/BAY1KTRs=;\n b=kYU7wyxZwI7PZWJFdLWK31ot/T0HmEt5yqZKvn3nZXC6l4Emdd9EGLPSufk9twnfjR\n hAbXjnODWdbBS+ZFVqa/tkzYRvUbxZTSlvC1LP8iWT9FgNqzPI/UspQUWk4PZNvVRVHQ\n Oq67/Yhtyut4NmB28taS+b8mwdiaF7uEKP555v234Gx0MK54KQICZzPMinVsX91p5urB\n GcSiZztKC48izq5gXubSpvzt2Wr7jKlZnQ8daYFA+FwI1WuVAqv/DH/pXwG8GXn1aoSE\n z3fWGO4IdLG9CLVQAxscia6lUinzVj49wxbUGdwCAvfzmM/1eEOyfpoV41i/SKvIR6Rr\n XF3w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771321884; x=1771926684;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=hNM7XgKmeqgrM8/J+m8bKIPPky9vmnlqRq/BAY1KTRs=;\n b=fIOkFnjZFXKsv/GPjIv9Q79K/+AFIu2hmfy3lXUjKyKSyIqYsjkfWiU19ModMIb37j\n s5J2xNWXXDeiLu/H2GAx4wKMnZ6svwmkJ64J9JzNdydErggML6Yzi8pOSrSXv4/UHXmW\n HNrIt/uSmBU/OcDKAb1+1oftThkiTw1EGNqy7B3QG1+sGGxNX7Uw/QGB1RJvI3/Mt9Lh\n h9eVGlU92i3alee9vHM9L79OCwHQGvGSftAkEyAf10vmNhc2L/7kqwcpnB5fLFwHyOsq\n Raj2rzoRsXqEdPKo6D2sVbGrXXFBwS7YrX2lT46d6c2y5elpQdn5UjZ8dCUiVSoF7sm4\n YYLQ==","X-Gm-Message-State":"AOJu0YybqNpvH0qNjNquMEKvo5R8fA2wOoAYnnqCcw8Z/+GuM5Fja0/i\n hZ2K4dw8KuDpiEJ7a3LCYssvJWYQh++8u50E+GXyUVYTWNb+/fvJeimW9tDV5e5xjWJ2kNjfZ88\n MCc5n8n0=","X-Gm-Gg":"AZuq6aILl3vLY603v9qKU7jFN9/mvNklciI8Le3jCObSGnTBIlOBdCAYOCMWBoWF7CJ\n j/r2nSTZCB7sBEIXllBBaxdO80VARtJQx05caeWpztVMboh/ILyqjj8nIVohN5Q2dfE0exi6ZuA\n UIe8eh8T6XSBswzqI1TK8YLURP424Jil2v694WZ/ivpqYjWGxffWb/jgEOU5bnBmcDMwvUYMg3W\n R5s4gL/0/QY/6UrA734PmMlX1/5VXVQAW0x+XSB5CIEMrg3fPptTp8p/L2XRDwMuPwcqqoZi+1w\n l6gyxo2jw/BtAF5v/RBQCoImKgB/0dAvQuwPfTDbbXQaFjF6vUtEpZHds6Ls5AR/IeCIJxTwyzO\n tlzsaGkX30c0S+EFZn9rlREMnX25RpsOFWEAcGaUQ6ApEpTJnnJXxfC57m1avPzqJNN5VsHjdAR\n xuoNtJeeetz4quMoTnoe572uAAM0irc4DKC/CkUqoU025fwU+j7XR5BOPl1I5xI05CfxuEBayqa\n 0CLqlyB/JrEQZACXDY6XhSEGLIJzyLqdTcXzo4=","X-Received":"by 2002:a17:903:3805:b0:2a1:3cd9:a737 with SMTP id\n d9443c01a7336-2ab50598d8fmr155781675ad.36.1771321883948;\n Tue, 17 Feb 2026 01:51:23 -0800 (PST)","From":"Richard Henderson ","To":"qemu-devel@nongnu.org","Cc":"philmd@linaro.org","Subject":"[PATCH v2 5/7] page-vary: Build finalize_target_page_bits as common\n code","Date":"Tue, 17 Feb 2026 19:51:04 +1000","Message-ID":"<20260217095106.598486-6-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260217095106.598486-1-richard.henderson@linaro.org>","References":"<20260217095106.598486-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::632;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use target_info->page_bits_init to merge\nfinalize_target_page_bits_common into\nfinalize_target_page_bits in page-vary-common.c.\n\nSigned-off-by: Richard Henderson \n---\n include/exec/page-vary.h | 4 ----\n page-vary-common.c | 15 +++++++++++----\n page-vary-target.c | 12 ------------\n 3 files changed, 11 insertions(+), 20 deletions(-)","diff":"diff --git a/include/exec/page-vary.h b/include/exec/page-vary.h\nindex c4dc56634b..f2d735bec2 100644\n--- a/include/exec/page-vary.h\n+++ b/include/exec/page-vary.h\n@@ -40,10 +40,6 @@ typedef struct {\n uint64_t mask;\n } TargetPageBits;\n \n-#ifdef IN_PAGE_VARY\n-void finalize_target_page_bits_common(int min);\n-#endif\n-\n /**\n * set_preferred_target_page_bits:\n * @bits: number of bits needed to represent an address within the page\ndiff --git a/page-vary-common.c b/page-vary-common.c\nindex b41137c644..ddd0863378 100644\n--- a/page-vary-common.c\n+++ b/page-vary-common.c\n@@ -50,11 +50,18 @@ bool set_preferred_target_page_bits(int bits)\n return true;\n }\n \n-void finalize_target_page_bits_common(int min)\n+void finalize_target_page_bits(void)\n {\n- if (target_page.bits == 0) {\n- target_page.bits = min;\n+ int bits = target_page.bits;\n+\n+ if (bits == 0) {\n+ const TargetInfo *ti = target_info();\n+\n+ bits = ti->page_bits_init;\n+ assert(bits != 0);\n+ target_page.bits = bits;\n }\n- target_page.mask = -1ull << target_page.bits;\n+\n+ target_page.mask = -1ull << bits;\n target_page.decided = true;\n }\ndiff --git a/page-vary-target.c b/page-vary-target.c\nindex d388c5c3d6..bc4d8931b6 100644\n--- a/page-vary-target.c\n+++ b/page-vary-target.c\n@@ -38,15 +38,3 @@ int migration_legacy_page_bits(void)\n #endif\n }\n #endif\n-\n-void finalize_target_page_bits(void)\n-{\n-#ifndef TARGET_PAGE_BITS_VARY\n- finalize_target_page_bits_common(TARGET_PAGE_BITS);\n-#elif defined(CONFIG_USER_ONLY)\n- assert(target_page.bits != 0);\n- finalize_target_page_bits_common(target_page.bits);\n-#else\n- finalize_target_page_bits_common(TARGET_PAGE_BITS_LEGACY);\n-#endif\n-}\n","prefixes":["v2","5/7"]}