{"id":2197170,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197170/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260217095106.598486-7-richard.henderson@linaro.org>","date":"2026-02-17T09:51:05","name":"[v2,6/7] page-vary: Build migration_legacy_page_bits as common code","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a9a0407d696b09fcb4ac4e106b37221ac7abc41e","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/1.0/people/72104/?format=json","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217095106.598486-7-richard.henderson@linaro.org/mbox/","series":[{"id":492403,"url":"http://patchwork.ozlabs.org/api/1.0/series/492403/?format=json","date":"2026-02-17T09:51:04","name":"page-vary: Build once","version":2,"mbox":"http://patchwork.ozlabs.org/series/492403/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197170/checks/","tags":{},"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Ram+1Hl7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFZgN54KWz1xwF\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 17 Feb 2026 20:52:16 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vsHkS-0002f2-LT; Tue, 17 Feb 2026 04:52:04 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1vsHk8-0002Ov-5F\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 04:51:47 -0500","from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1vsHk3-0006B2-Qr\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 04:51:43 -0500","by mail-pg1-x531.google.com with SMTP id\n 41be03b00d2f7-c6e191c4b8fso1354505a12.0\n for <qemu-devel@nongnu.org>; Tue, 17 Feb 2026 01:51:27 -0800 (PST)","from localhost.localdomain\n (2403-580b-742d-0-10a2-dce1-aa4a-dd32.ip6.aussiebb.net.\n [2403:580b:742d:0:10a2:dce1:aa4a:dd32])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2ad1a6fa33esm99108675ad.13.2026.02.17.01.51.24\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 17 Feb 2026 01:51:25 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771321886; x=1771926686; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=lH0dnvNM5971XYrImykDmi/zsT4QBP8YuEiiUlIsVhQ=;\n b=Ram+1Hl7of07iGuREUc+nsukug8UaCFxUDAYso7vG+W+1O7pOdCW+D3RO2bwnzFs8m\n b3lZKaOoHP19TABQx8pCtyL77lFdxn0cjSFgsouczDAWr8P/P6mqNM9a3vsbn0XMsnPV\n xv+D+WuQbfTJgMOEgBwdDpB/fD4MVSiuNoctwJqmOuSqKfXirFLz7xISaR8Heb3iEoLS\n 81KrUb3E0oVjna8g6gtgFm/w3jOpy8cxtEtkXKYCYxsn5E/IhMlvHs2ygEp5VgXoFSiU\n bgNiA+3JUVpmoRc9/HRXWOWlkEjs9m3Ra15Nro4oS5mgbMWubbpKMB9qxr/4mh2/oP6M\n MXCg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771321886; x=1771926686;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=lH0dnvNM5971XYrImykDmi/zsT4QBP8YuEiiUlIsVhQ=;\n b=LEWgh/3/b2a9KMHwKihiJbDytcx6/ErTAc3ROQximnTPTT0chLq5qDAiuYRxwC+Hll\n 4335vPGK0NQDDxwKxn3u8LjuIcfPqW9lNZtY53qxjE7Wt+GQbu0xR0tMzoOHoKPze5ig\n SjIsMV/psSbLDZiPM2+MqEh1jn/12eHYu9DzlIelBU2x+xyLIf3lKM+kjrSJghCw9C2C\n EzQp3QkHKzp0Cunyn8WBgaNpgxpdwJ3N8EQIdYkKErbbYecqNHnRxj3OrdtXn16VpGQ7\n ddMWZ52N7+ZZ7RSnsGGR8BSqmdvGf52q3Xg8CuV2LGei36Jtkt6EO+eJOxjlWe5Iaqiq\n saxQ==","X-Gm-Message-State":"AOJu0YzL8VnkuW70zrExnJ/Xd2/BmVtLPutOkcqG8x+hd7Ti08m1B4qG\n egvo3c02MO/nohnWJBf5f6lPZzn4TFX/PeaktrjiQOxg4C+zaLQg0SKrGHtqkP4M6yHxRM2qF2t\n E/rPg1kw=","X-Gm-Gg":"AZuq6aIcBMZWLgg0q7JVtV++3Q5MXB0pgqGocMUJwK0s2KqfE5xIaYB0bOPx/eYXtjQ\n bHuBrjqL2nhUNUfRLCWRfI5kNU0lUbkZ1WniNJE9cfmUDHZr7ybKnyrRWcb0nOWqu5hByw/sWZU\n P1qCUYWLn+xZ5jWFb4QjmE4CqW7d59Bg3fc9/+BKK8gqIvMckicI00ZC1YhXkZ08N5wmvaKG5U6\n ybZn4km2rTwko6JJi0N7XYn1cgnTK/IEjUvPOgzVeUuGR+fNhnda3ivTuBppeb3I0Gv5gMMD0ti\n lI3xXdc06U5vBb1vFYn834XNt/ZOvNzFcatyuyLNSicn65e2FWnSvFZAIfKc064zHZVyFlbepqX\n HB0D7IBGnPT6xc1AM1PDPqlkd5srIJ6X6dPsEzt0o3jiYfJDwn80cGldGQrDXi+7fJ39wSI5wjv\n ZjaTVX+Chjn8kIEhJLuJirbtLFVaw5R1Q3tqYKaqKjJ6xfqMkx/rnjs12yJiMBOarbIbz9nu11c\n FN0tcbC0D+1M+CkCMFzTzbu9qsVUDfi44Jbqbw=","X-Received":"by 2002:a17:903:2a90:b0:2a8:ff32:5f96 with SMTP id\n d9443c01a7336-2ad17430becmr94246895ad.13.1771321886297;\n Tue, 17 Feb 2026 01:51:26 -0800 (PST)","From":"Richard Henderson <richard.henderson@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"philmd@linaro.org","Subject":"[PATCH v2 6/7] page-vary: Build migration_legacy_page_bits as common\n code","Date":"Tue, 17 Feb 2026 19:51:05 +1000","Message-ID":"<20260217095106.598486-7-richard.henderson@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260217095106.598486-1-richard.henderson@linaro.org>","References":"<20260217095106.598486-1-richard.henderson@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::531;\n envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x531.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Use target_info->page_bits_init to implement\nmigration_legacy_page_bits.  Because this is the last\nfunction within the file, rename page-vary-target.c\nto page-vary-system.c and build once for system mode.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n page-vary-target.c => page-vary-system.c | 19 ++++++-------------\n meson.build                              |  2 +-\n 2 files changed, 7 insertions(+), 14 deletions(-)\n rename page-vary-target.c => page-vary-system.c (74%)","diff":"diff --git a/page-vary-target.c b/page-vary-system.c\nsimilarity index 74%\nrename from page-vary-target.c\nrename to page-vary-system.c\nindex bc4d8931b6..6c49c10e23 100644\n--- a/page-vary-target.c\n+++ b/page-vary-system.c\n@@ -1,5 +1,5 @@\n /*\n- * Variable page size handling -- target specific part.\n+ * Variable page size handling -- system specific part.\n  *\n  *  Copyright (c) 2003 Fabrice Bellard\n  *\n@@ -17,24 +17,17 @@\n  * License along with this library; if not, see <http://www.gnu.org/licenses/>.\n  */\n \n-#define IN_PAGE_VARY 1\n-\n #include \"qemu/osdep.h\"\n #include \"exec/page-vary.h\"\n-#include \"exec/target_page.h\"\n-\n-#ifndef CONFIG_USER_ONLY\n #include \"exec/tlb-flags.h\"\n+#include \"qemu/target-info-impl.h\"\n \n QEMU_BUILD_BUG_ON(TLB_FLAGS_MASK & ((1u < TARGET_PAGE_BITS_MIN) - 1));\n \n int migration_legacy_page_bits(void)\n {\n-#ifdef TARGET_PAGE_BITS_VARY\n-    QEMU_BUILD_BUG_ON(TARGET_PAGE_BITS_LEGACY < TARGET_PAGE_BITS_MIN);\n-    return TARGET_PAGE_BITS_LEGACY;\n-#else\n-    return TARGET_PAGE_BITS;\n-#endif\n+    const TargetInfo *ti = target_info();\n+\n+    assert(ti->page_bits_init >= TARGET_PAGE_BITS_MIN);\n+    return ti->page_bits_init;\n }\n-#endif\ndiff --git a/meson.build b/meson.build\nindex 4af32c3e1f..1dc10f144b 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -3835,7 +3835,7 @@ if get_option('b_lto')\n   pagevary = declare_dependency(link_with: pagevary)\n endif\n common_ss.add(pagevary)\n-specific_ss.add(files('page-vary-target.c'))\n+system_ss.add(files('page-vary-system.c'))\n \n common_ss.add(files('target-info.c'))\n system_ss.add(files('target-info-qom.c'))\n","prefixes":["v2","6/7"]}