{"id":2197100,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197100/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260217052740.114117-9-heifetz@yandex-team.com>","date":"2026-02-17T05:27:40","name":"[8/8] meson.build: ignore audio drivers when configured with --disable-audio","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4339d1297142541373a25db9560988a0802ca1ff","submitter":{"id":92578,"url":"http://patchwork.ozlabs.org/api/1.0/people/92578/?format=json","name":"Sergei Heifetz","email":"heifetz@yandex-team.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217052740.114117-9-heifetz@yandex-team.com/mbox/","series":[{"id":492371,"url":"http://patchwork.ozlabs.org/api/1.0/series/492371/?format=json","date":"2026-02-17T05:27:32","name":"add build option to disable audio subsystem","version":1,"mbox":"http://patchwork.ozlabs.org/series/492371/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197100/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.com header.i=@yandex-team.com\n header.a=rsa-sha256 header.s=default header.b=B6yNRU49;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-canary-81.sas.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.com"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFSqj4RMDz1xpl\n\tfor ; Tue, 17 Feb 2026 16:29:05 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsDcs-0002ck-Mo; Tue, 17 Feb 2026 00:27:58 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsDco-0002bI-0e\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 00:27:54 -0500","from forwardcorp1b.mail.yandex.net\n ([2a02:6b8:c02:900:1:45:d181:df01])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsDcm-0006cm-5y\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 00:27:53 -0500","from mail-nwsmtp-smtp-corp-canary-81.sas.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-canary-81.sas.yp-c.yandex.net\n [IPv6:2a02:6b8:c37:8aa5:0:640:e6ae:0])\n by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id E90A78852A;\n Tue, 17 Feb 2026 08:27:50 +0300 (MSK)","from heifetz-lin.yandex-team.ru (unknown [2a02:6bf:8080:b54::1:2f])\n by mail-nwsmtp-smtp-corp-canary-81.sas.yp-c.yandex.net\n (smtpcorp/Yandex) with ESMTPSA id eRRjrX2Ak0U0-BEQR34Gh;\n Tue, 17 Feb 2026 08:27:50 +0300"],"X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.com;\n s=default; t=1771306070;\n bh=cW96GpRtxrwmpHjA3rFfk5LGg/7cNAQbpRSdRXk6Veo=;\n h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=B6yNRU49+hngQyNX40/rrbl+kLZgpYohiOF6T4KqYn4Kr/dXS6Dt1d35WHr/Hqo+c\n VzuEGXtkuNzGCr0rBs//lq4FIblA/mCwQQowuFfnmYh8yOmfSocB30X5HnwaC/WSDk\n UxcVHRtLktGSjaMGckLcigkrHY25zTepq2aq+tww=","From":"Sergei Heifetz ","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?A?=\n\t=?utf-8?q?lex_Benn=C3=A9e?= ,\n Eric Blake ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ,\n Markus Armbruster , Fabiano Rosas ,\n Paolo Bonzini , Thomas Huth ,\n Gerd Hoffmann , Laurent Vivier ","Subject":"[PATCH 8/8] meson.build: ignore audio drivers when configured with\n --disable-audio","Date":"Tue, 17 Feb 2026 10:27:40 +0500","Message-Id":"<20260217052740.114117-9-heifetz@yandex-team.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260217052740.114117-1-heifetz@yandex-team.com>","References":"<20260217052740.114117-1-heifetz@yandex-team.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a02:6b8:c02:900:1:45:d181:df01;\n envelope-from=heifetz@yandex-team.com; helo=forwardcorp1b.mail.yandex.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"When QEMU is configured with `--disable-audio`, we do not need to add the\naudio drivers list to config_host_data. We also do not need to print this\nlist.\n\nSigned-off-by: Sergei Heifetz \n---\n meson.build | 80 ++++++++++++++++++++++++++++++-----------------------\n 1 file changed, 45 insertions(+), 35 deletions(-)","diff":"diff --git a/meson.build b/meson.build\nindex 69aa7cd189..a1224c9695 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -2266,46 +2266,55 @@ endif\n config_host_data = configuration_data()\n \n config_host_data.set('CONFIG_HAVE_RUST', have_rust)\n-audio_drivers_selected = []\n-if have_system\n- audio_drivers_available = {\n- 'alsa': alsa.found(),\n- 'coreaudio': coreaudio.found(),\n- 'dsound': dsound.found(),\n- 'jack': jack.found(),\n- 'oss': oss.found(),\n- 'pa': pulse.found(),\n- 'pipewire': pipewire.found(),\n- 'sdl': sdl.found(),\n- 'sndio': sndio.found(),\n- }\n- foreach k, v: audio_drivers_available\n- config_host_data.set('CONFIG_AUDIO_' + k.to_upper(), v)\n- endforeach\n+config_host_data.set('CONFIG_AUDIO', audio_enabled)\n+if audio_enabled\n+ audio_drivers_selected = []\n+ if have_system\n+ audio_drivers_available = {\n+ 'alsa': alsa.found(),\n+ 'coreaudio': coreaudio.found(),\n+ 'dsound': dsound.found(),\n+ 'jack': jack.found(),\n+ 'oss': oss.found(),\n+ 'pa': pulse.found(),\n+ 'pipewire': pipewire.found(),\n+ 'sdl': sdl.found(),\n+ 'sndio': sndio.found(),\n+ }\n+ foreach k, v: audio_drivers_available\n+ config_host_data.set('CONFIG_AUDIO_' + k.to_upper(), v)\n+ endforeach\n \n- # Default to native drivers first, OSS second, SDL third\n- audio_drivers_priority = \\\n- [ 'pa', 'coreaudio', 'dsound', 'sndio', 'oss' ] + \\\n- (host_os == 'linux' ? [] : [ 'sdl' ])\n- audio_drivers_default = []\n- foreach k: audio_drivers_priority\n- if audio_drivers_available[k]\n- audio_drivers_default += k\n- endif\n- endforeach\n+ # Default to native drivers first, OSS second, SDL third\n+ audio_drivers_priority = \\\n+ [ 'pa', 'coreaudio', 'dsound', 'sndio', 'oss' ] + \\\n+ (host_os == 'linux' ? [] : [ 'sdl' ])\n+ audio_drivers_default = []\n+ foreach k: audio_drivers_priority\n+ if audio_drivers_available[k]\n+ audio_drivers_default += k\n+ endif\n+ endforeach\n \n+ foreach k: get_option('audio_drv_list')\n+ if k == 'default'\n+ audio_drivers_selected += audio_drivers_default\n+ elif not audio_drivers_available[k]\n+ error('Audio driver \"@0@\" not available.'.format(k))\n+ else\n+ audio_drivers_selected += k\n+ endif\n+ endforeach\n+ endif\n+ config_host_data.set('CONFIG_AUDIO_DRIVERS',\n+ '\"' + '\", \"'.join(audio_drivers_selected) + '\", ')\n+else\n foreach k: get_option('audio_drv_list')\n- if k == 'default'\n- audio_drivers_selected += audio_drivers_default\n- elif not audio_drivers_available[k]\n- error('Audio driver \"@0@\" not available.'.format(k))\n- else\n- audio_drivers_selected += k\n+ if k != 'default'\n+ error('Audio drivers are not supported because audio is disabled.')\n endif\n endforeach\n endif\n-config_host_data.set('CONFIG_AUDIO_DRIVERS',\n- '\"' + '\", \"'.join(audio_drivers_selected) + '\", ')\n \n have_host_block_device = (host_os != 'darwin' or\n cc.has_header('IOKit/storage/IOMedia.h'))\n@@ -4660,7 +4669,8 @@ if enable_modules\n summary_info += {'alternative module path': get_option('module_upgrades')}\n endif\n summary_info += {'fuzzing support': get_option('fuzzing')}\n-if have_system\n+summary_info += {'Audio': get_option('audio')}\n+if have_system and audio_enabled\n summary_info += {'Audio drivers': ' '.join(audio_drivers_selected)}\n endif\n summary_info += {'Trace backends': ','.join(get_option('trace_backends'))}\n","prefixes":["8/8"]}