{"id":2197096,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197096/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260217052740.114117-5-heifetz@yandex-team.com>","date":"2026-02-17T05:27:36","name":"[4/8] hw/audio/pcspk: change PCSPK behaviour with --disable-audio","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0ebdc8f8d5151c12a7f6e8a1d72822f1397ded77","submitter":{"id":92578,"url":"http://patchwork.ozlabs.org/api/1.0/people/92578/?format=json","name":"Sergei Heifetz","email":"heifetz@yandex-team.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260217052740.114117-5-heifetz@yandex-team.com/mbox/","series":[{"id":492371,"url":"http://patchwork.ozlabs.org/api/1.0/series/492371/?format=json","date":"2026-02-17T05:27:32","name":"add build option to disable audio subsystem","version":1,"mbox":"http://patchwork.ozlabs.org/series/492371/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197096/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.com header.i=@yandex-team.com\n header.a=rsa-sha256 header.s=default header.b=SURyeHnv;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-canary-81.sas.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.com"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFSqF1QNqz1xwF\n\tfor ; Tue, 17 Feb 2026 16:28:41 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vsDcq-0002c5-KX; Tue, 17 Feb 2026 00:27:56 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsDcm-0002ab-OS\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 00:27:52 -0500","from forwardcorp1b.mail.yandex.net\n ([2a02:6b8:c02:900:1:45:d181:df01])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vsDcj-0006cS-Mc\n for qemu-devel@nongnu.org; Tue, 17 Feb 2026 00:27:52 -0500","from mail-nwsmtp-smtp-corp-canary-81.sas.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-canary-81.sas.yp-c.yandex.net\n [IPv6:2a02:6b8:c37:8aa5:0:640:e6ae:0])\n by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id A73C488503;\n Tue, 17 Feb 2026 08:27:46 +0300 (MSK)","from heifetz-lin.yandex-team.ru (unknown [2a02:6bf:8080:b54::1:2f])\n by mail-nwsmtp-smtp-corp-canary-81.sas.yp-c.yandex.net\n (smtpcorp/Yandex) with ESMTPSA id eRRjrX2Ak0U0-no4eOMdv;\n Tue, 17 Feb 2026 08:27:46 +0300"],"X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.com;\n s=default; t=1771306066;\n bh=af12Emi/cCgStn/UwxBq6KWZOfBbIxl3KK7Jm000Jrw=;\n h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=SURyeHnvSEZV/Cw7htk6hFT91JgzgDqGty7JuzLp0yo23bgQKQ/GC6TSqxHBQa7sW\n 8NErywTjVtw+lamF6sbcnVHOCy1Vv8n9GTxMBHV/4nglxA7OchVUa10oepWVyOicHC\n aXyL7zoWJJn3lV4PJBMIWW+EnK+tMf02IJNihl7k=","From":"Sergei Heifetz ","To":"qemu-devel@nongnu.org","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?A?=\n\t=?utf-8?q?lex_Benn=C3=A9e?= ,\n Eric Blake ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ,\n Markus Armbruster , Fabiano Rosas ,\n Paolo Bonzini , Thomas Huth ,\n Gerd Hoffmann , Laurent Vivier ","Subject":"[PATCH 4/8] hw/audio/pcspk: change PCSPK behaviour with\n --disable-audio","Date":"Tue, 17 Feb 2026 10:27:36 +0500","Message-Id":"<20260217052740.114117-5-heifetz@yandex-team.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260217052740.114117-1-heifetz@yandex-team.com>","References":"<20260217052740.114117-1-heifetz@yandex-team.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a02:6b8:c02:900:1:45:d181:df01;\n envelope-from=heifetz@yandex-team.com; helo=forwardcorp1b.mail.yandex.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"PCSPK (PC Speaker) is an embedded audio device. We don't want it to use audio\nwhen QEMU is configured with `--disable-audio`. This is achieved with minimal,\nnon-invasive changes to the code.\n\nIn essence, the changes ensure that PCSPK does not use the corresponding\naudio backend, while functioning the same way in non-audio aspects.\n\nSigned-off-by: Sergei Heifetz \n---\n hw/audio/pcspk.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)","diff":"diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c\nindex 916c56fa4c..03fe816024 100644\n--- a/hw/audio/pcspk.c\n+++ b/hw/audio/pcspk.c\n@@ -36,10 +36,12 @@\n #include \"qom/object.h\"\n #include \"trace.h\"\n \n+#ifdef CONFIG_AUDIO\n #define PCSPK_BUF_LEN 1792\n #define PCSPK_SAMPLE_RATE 32000\n #define PCSPK_MAX_FREQ (PCSPK_SAMPLE_RATE >> 1)\n #define PCSPK_MIN_COUNT DIV_ROUND_UP(PIT_FREQ, PCSPK_MAX_FREQ)\n+#endif\n \n OBJECT_DECLARE_SIMPLE_TYPE(PCSpkState, PC_SPEAKER)\n \n@@ -48,18 +50,25 @@ struct PCSpkState {\n \n MemoryRegion ioport;\n uint32_t iobase;\n+#ifdef CONFIG_AUDIO\n uint8_t sample_buf[PCSPK_BUF_LEN];\n+#endif\n AudioBackend *audio_be;\n+#ifdef CONFIG_AUDIO\n SWVoiceOut *voice;\n+#endif\n PITCommonState *pit;\n+#ifdef CONFIG_AUDIO\n unsigned int pit_count;\n unsigned int samples;\n unsigned int play_pos;\n+#endif\n uint8_t data_on;\n uint8_t dummy_refresh_clock;\n bool migrate;\n };\n \n+#ifdef CONFIG_AUDIO\n static const char *s_spk = \"pcspk\";\n \n static inline void generate_samples(PCSpkState *s)\n@@ -131,6 +140,7 @@ static int pcspk_audio_init(PCSpkState *s)\n \n return 0;\n }\n+#endif\n \n static uint64_t pcspk_io_read(void *opaque, hwaddr addr,\n unsigned size)\n@@ -161,11 +171,13 @@ static void pcspk_io_write(void *opaque, hwaddr addr, uint64_t val,\n \n s->data_on = (val >> 1) & 1;\n pit_set_gate(s->pit, 2, gate);\n+#ifdef CONFIG_AUDIO\n if (s->voice) {\n if (gate) /* restart */\n s->play_pos = 0;\n AUD_set_active_out(s->voice, gate & s->data_on);\n }\n+#endif\n }\n \n static const MemoryRegionOps pcspk_io_ops = {\n@@ -196,10 +208,12 @@ static void pcspk_realizefn(DeviceState *dev, Error **errp)\n \n isa_register_ioport(isadev, &s->ioport, s->iobase);\n \n+#ifdef CONFIG_AUDIO\n if (s->audio_be && AUD_backend_check(&s->audio_be, errp)) {\n pcspk_audio_init(s);\n return;\n }\n+#endif\n }\n \n static bool migrate_needed(void *opaque)\n","prefixes":["4/8"]}