{"id":2197043,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197043/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216213121.47122-5-philmd@linaro.org>","date":"2026-02-16T21:31:17","name":"[v2,4/8] hw/m68k/q800: Set MACFB_DISPLAY_APPLE_21_COLOR within MacFrameBuffer","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e44d9749af01efa3e9e11bcb3599fde0385606f9","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.0/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216213121.47122-5-philmd@linaro.org/mbox/","series":[{"id":492356,"url":"http://patchwork.ozlabs.org/api/1.0/series/492356/?format=json","date":"2026-02-16T21:31:14","name":"system: Absorb globals-target.c within common globals.c","version":2,"mbox":"http://patchwork.ozlabs.org/series/492356/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197043/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=NuDFnYm+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFGGd0zQfz1xwC\n\tfor ; Tue, 17 Feb 2026 08:33:13 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vs6Cr-00023D-Gc; Mon, 16 Feb 2026 16:32:37 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vs6CE-0000bh-42\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 16:32:01 -0500","from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vs6CB-00041p-Bc\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 16:31:57 -0500","by mail-wm1-x32b.google.com with SMTP id\n 5b1f17b1804b1-483770e0b25so30818145e9.0\n for ; Mon, 16 Feb 2026 13:31:54 -0800 (PST)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48371a3f835sm91270965e9.25.2026.02.16.13.31.52\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 16 Feb 2026 13:31:52 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771277513; x=1771882313; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=4iTYDTjW8oF01EE5U+uJHraTm442v4OtMz2SMPZaJV0=;\n b=NuDFnYm+eVmGOrK4dlTMIP/d3LjUJh8VxOhnhokSVX07Yb/QacVmkEzW3dl0g5KxBn\n irtFKnMbtXUzkXErA17RQsjRDLsVGZVvjt/WSbHTwAh42OKGgFMRoiEiiN1kecXlvXGY\n BEmbHmffCzB62t9BFOLp/Y4mEpe+0fBIf8Dm65VU1zS1YVFmzaqjI+LF1iv8jG05tWuI\n /lCQxsgawTfo7ilGOFI8fvsq8rktMUnH5latOEsX8Zynckvv7BT1Mukeghu+pdEpmexq\n C2GYHuoSCRBLGkh6XRQOLkyKJ4Gz6PT+GhmZqU8ClEMmBvcWZiGC2RowwTVyJY05XZUj\n jbJg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771277513; x=1771882313;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=4iTYDTjW8oF01EE5U+uJHraTm442v4OtMz2SMPZaJV0=;\n b=clNSKiJ2vr1YlzpDwtNcip91P4u9mj21ebm7vidWEawpPbim/tdTKNxLT35gdBUN7B\n uw60tImHkJLD2KjTf0nbmwZwxXdD0EIwxAUMh2Gt8aio/uPR2cI3xNFg9KIbEwTbPkI/\n +eELN8AcuyA7wFnGRe7wE3Qjkt43muYxGEkTugBHhv6sZ45ilbNAwqYvMw7ibr0tpBFW\n kjGn9JblmDI5D6EoDNbIfM3Jib6lxNlVTwEjo7yLqLuS+0I2Tfd9AINKSIQXtw+9cDYH\n QxLWTFPu0EvFWdcbR8HwshZP+rds9s0iAGh3sXmTuqfMSZsw7LJpdN6JZzcLLWFWMc9d\n 1PPg==","X-Gm-Message-State":"AOJu0YxVYjprGmV2ftswLzfrs2zl6Z+ZNItlRZEx1JTbjcTuyjTGOZVZ\n rL682xnbGFTSvsxR45DwiffcmWI+/xci5ECaqxgS8hrr3vTzKwWZ7ldlRWm+KUbBQniQXe8l1Ru\n k56ZdMXI=","X-Gm-Gg":"AZuq6aIr45CTqfqWc+OZrsg7XwwONSWAYTxwUFMLirEDeXKR6mHEhDjKQ4Fwbq7aIQ+\n xCfi/rvpq+43crpoxYuLVB/4TG1X8DwtD54xyMxMS/DWwkDcDcojB2Hb6ea6825cdLy8v/yQZCR\n tRCqgovH/khQDjY/eBYHAodnrNQjQyW4KVtH6zN8Q93IBy3GPC0oElTPqe0OZt5o3ZsE8dHr60R\n pbwovfJUVEzUFfo5xWXp41dpwlO4/ITZYuXFPg0gr5KU/syVz4I/VxkcBzqUAeDuu6OJAqdRqtY\n Lsmu8SmHF0dCwQM1nQGOyr/puplt31HvxXLocnEMWIB9Gm/0/OORJClT4iL4f9NWoGAAHkab+xL\n 8ZXR2TmfVBcLxdF0C2VBuvTa4VohlWCX9XPm/v0WlBth+obhgivHsd3KAK0IBBQX60EA7HH/S7c\n NgYXVqrK2GRi92CcNEyGzznaVFvU3/VFu6IcH+wDOdBBRokwi7QTq9HQZIRZfnqoCJPtpNWI2o","X-Received":"by 2002:a05:600c:620d:b0:480:3bba:1cac with SMTP id\n 5b1f17b1804b1-48371043046mr182491715e9.6.1771277513333;\n Mon, 16 Feb 2026 13:31:53 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Nicholas Piggin ,\n =?utf-8?q?Herv=C3=A9_Poussineau?= ,\n Paolo Bonzini , Chinmay Rath ,\n Artyom Tarasenko ,\n Pierrick Bouvier ,\n Laurent Vivier , qemu-ppc@nongnu.org,\n Harsh Prateek Bora ,\n Mark Cave-Ayland , =?utf-8?q?Philippe_Mathie?=\n\t=?utf-8?q?u-Daud=C3=A9?= ","Subject":"[PATCH v2 4/8] hw/m68k/q800: Set MACFB_DISPLAY_APPLE_21_COLOR within\n MacFrameBuffer","Date":"Mon, 16 Feb 2026 22:31:17 +0100","Message-ID":"<20260216213121.47122-5-philmd@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260216213121.47122-1-philmd@linaro.org>","References":"<20260216213121.47122-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32b;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The MACFB_DISPLAY_APPLE_21_COLOR mode is not specific to the Q800\nmachine. Check and set it once in the MacFB DeviceRealize handler.\n\nNo need to explicitly set the MACFB_DISPLAY_VGA mode since this is\nthe default value.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Pierrick Bouvier \nReviewed-by: Mark Cave-Ayland \n---\n hw/display/macfb.c | 4 ++++\n hw/m68k/q800.c | 5 -----\n 2 files changed, 4 insertions(+), 5 deletions(-)","diff":"diff --git a/hw/display/macfb.c b/hw/display/macfb.c\nindex 8ef174dc6df..b8115c2be13 100644\n--- a/hw/display/macfb.c\n+++ b/hw/display/macfb.c\n@@ -645,6 +645,10 @@ static bool macfb_common_realize(DeviceState *dev, MacfbState *s, Error **errp)\n {\n DisplaySurface *surface;\n \n+ if (s->width == 1152 && s->height == 870) {\n+ s->type = MACFB_DISPLAY_APPLE_21_COLOR;\n+ }\n+\n s->mode = macfb_find_mode(s->type, s->width, s->height, s->depth);\n if (!s->mode) {\n gchar *list;\ndiff --git a/hw/m68k/q800.c b/hw/m68k/q800.c\nindex b55c03a90bf..ba32da2fa45 100644\n--- a/hw/m68k/q800.c\n+++ b/hw/m68k/q800.c\n@@ -563,11 +563,6 @@ static void q800_machine_init(MachineState *machine)\n qdev_prop_set_uint32(dev, \"width\", graphic_width);\n qdev_prop_set_uint32(dev, \"height\", graphic_height);\n qdev_prop_set_uint8(dev, \"depth\", graphic_depth);\n- if (graphic_width == 1152 && graphic_height == 870) {\n- qdev_prop_set_uint8(dev, \"display\", MACFB_DISPLAY_APPLE_21_COLOR);\n- } else {\n- qdev_prop_set_uint8(dev, \"display\", MACFB_DISPLAY_VGA);\n- }\n qdev_realize(dev, BUS(nubus), &error_fatal);\n \n macfb_mode = (NUBUS_MACFB(dev)->macfb).mode;\n","prefixes":["v2","4/8"]}