{"id":2197039,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197039/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216213121.47122-3-philmd@linaro.org>","date":"2026-02-16T21:31:15","name":"[v2,2/8] hw/display/macfb: Constify macfb_mode_table[] array","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2567bd0ec018b87cada49b44b551f6de7a81a747","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.0/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216213121.47122-3-philmd@linaro.org/mbox/","series":[{"id":492356,"url":"http://patchwork.ozlabs.org/api/1.0/series/492356/?format=json","date":"2026-02-16T21:31:14","name":"system: Absorb globals-target.c within common globals.c","version":2,"mbox":"http://patchwork.ozlabs.org/series/492356/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197039/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=rg3pZiOk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFGGH5xRbz1xwC\n\tfor ; Tue, 17 Feb 2026 08:32:55 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vs6Co-0001Zv-WD; Mon, 16 Feb 2026 16:32:35 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vs6Bz-0007tQ-WD\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 16:31:47 -0500","from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vs6Bx-0003zH-9C\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 16:31:43 -0500","by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-4836f363d0dso30672865e9.3\n for ; Mon, 16 Feb 2026 13:31:40 -0800 (PST)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48370a63afesm93274735e9.9.2026.02.16.13.31.37\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 16 Feb 2026 13:31:37 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771277499; x=1771882299; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ryaQ/AkO6jKX0PQ//vdGmEpeMhxdiou+ug6hLMUHQC8=;\n b=rg3pZiOk+YZKTiioXmikROsm1fdkwfEtkUYavO/Ygfq3gowsj/EJWcg5XoSyunk9+X\n +354Ix1IsP7phJ2ycpDxXfFJskP/+bX+z90i6RKDNF9AAV0kbRR0ZAYGlXwrqyRRsWHi\n bwyo3AKJYDyYAw/bxGPzFwOomqDWGfuPnOQxP+F/padpaxD4jKlLZU5eG36tWCjjp2XX\n f71gR8Z3oRyic2EPX7NnE2SptyPvGqx9wk2yKOtCukyszAAkdlVgMLY+tGhzzxRwUKMY\n vcV/eZyNla2L/hUufVJunmRLxJQhbY9m1H3+7FL9wCtmtcT1N0KGqSawPxsDLBo0p+F9\n AVMA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771277499; x=1771882299;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ryaQ/AkO6jKX0PQ//vdGmEpeMhxdiou+ug6hLMUHQC8=;\n b=SmokBjxKvvI7wQ3ia3yPt5YcxU8GQYVhbk/ua90mOIATjUh3q2xYmEp+kQWIjAr5AE\n pwYduTcu73H47YFp28N/ZxVzSuqr6EH7Q3IYHMI1JkbSgefQGIORRvMVOHizYmK4dVg/\n mRu5Qac/edOii2tyY9dznYbtlJbFBGrPILRcIRvparDz8yRu19mtKUZE6xv5vdwt/c1r\n zeW/AnFNMp4V8j9zQrH0eQvakqOirL7lKz0iBglEUYkEGXPyWmPHZG576IYi4yc0y28+\n 0knc3S/VCVWhuJ1dxZoYt27Z9hzB7a/vCJlEgfDlYZH2m9NCXRpdc0MmiLCFFCl9ttAW\n 9Xog==","X-Gm-Message-State":"AOJu0YyIRWwH1NM9FXUPMKNe9aiQJ8PTu48irYYHv4K3Wcs2OhDEsMze\n Odxxvp7fp71D5wa+EatPiYqLH6ROKaNQgGaGlad+bp32OvWUZFSJjOrj02l6IOxOPk+RKXJHpX6\n aMN+ekxE=","X-Gm-Gg":"AZuq6aKxSkX/StN30e+ywqHbh/qv+TmOgD/gxdVgvhsYISVlTLrVR2TNhIE3ZVygDp2\n 48+3uO/vxaVnsd9pMSTewpTCpc75/Xx3tr5bUW2uxyEI7gSZUM8Q8KD+S8B+rKasUPc+69vNODO\n OEKNmQfz/H+WTwGB7qfquBtgg959mym3XJEqyyP6VY7KC5pNTlt2PX6G/a9scLWbOHr6fB4ElBJ\n M2TBze+Ewdt9HiQPy4p3YDNpSxl1KqMTwufcsThrJsGaaNvtQ2gZKqbma0MlwBCN7SskD1ajFZB\n Mt+1wltXKQGghsyKeH7MeCBo1VXehVZYcIWTKU1yamV5i1gZkBRfzKQ3/18gHNWutw3FaLBEKvi\n g+ipfiGo0NQ+3CaoKxy/7IOXEaZmZioNXTskfaSElcrnrBbrpfQS30TX/PVRKZ0AhSZI+Id54Qk\n NqtiXQl5iMLMaZRaala5y5YfJvK/cGn5mtBDBgCfIg4BE2N56oUI3chdqz1MKnwnJqIwgiXg9c","X-Received":"by 2002:a05:600c:8b84:b0:483:4bbc:89ea with SMTP id\n 5b1f17b1804b1-48379c42db1mr156642235e9.37.1771277499064;\n Mon, 16 Feb 2026 13:31:39 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Nicholas Piggin ,\n =?utf-8?q?Herv=C3=A9_Poussineau?= ,\n Paolo Bonzini , Chinmay Rath ,\n Artyom Tarasenko ,\n Pierrick Bouvier ,\n Laurent Vivier , qemu-ppc@nongnu.org,\n Harsh Prateek Bora ,\n Mark Cave-Ayland , =?utf-8?q?Philippe_Mathie?=\n\t=?utf-8?q?u-Daud=C3=A9?= ","Subject":"[PATCH v2 2/8] hw/display/macfb: Constify macfb_mode_table[] array","Date":"Mon, 16 Feb 2026 22:31:15 +0100","Message-ID":"<20260216213121.47122-3-philmd@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260216213121.47122-1-philmd@linaro.org>","References":"<20260216213121.47122-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::331;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"macfb_mode_table[] is only read, never updated, so can be const.\n\nUpdate the call sites accordingly.\nMake the MacfbState::mode pointer to const.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Pierrick Bouvier \nReviewed-by: Mark Cave-Ayland \n---\n include/hw/display/macfb.h | 2 +-\n hw/display/macfb.c | 10 +++++-----\n hw/m68k/q800.c | 2 +-\n 3 files changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/include/hw/display/macfb.h b/include/hw/display/macfb.h\nindex 495dead44b5..cb7aac7a4dd 100644\n--- a/include/hw/display/macfb.h\n+++ b/include/hw/display/macfb.h\n@@ -66,7 +66,7 @@ typedef struct MacfbState {\n uint8_t type;\n \n uint32_t regs[MACFB_NUM_REGS];\n- MacFbMode *mode;\n+ const MacFbMode *mode;\n \n QEMUTimer *vbl_timer;\n qemu_irq irq;\ndiff --git a/hw/display/macfb.c b/hw/display/macfb.c\nindex 57ad8ad5587..8ef174dc6df 100644\n--- a/hw/display/macfb.c\n+++ b/hw/display/macfb.c\n@@ -100,7 +100,7 @@ static const MacFbSense macfb_sense_table[] = {\n { MACFB_DISPLAY_SVGA, 0x7, 0x5 },\n };\n \n-static MacFbMode macfb_mode_table[] = {\n+static const MacFbMode macfb_mode_table[] = {\n { MACFB_DISPLAY_VGA, 1, 0x100, 0x71e, 640, 480, 0x400, 0x1000 },\n { MACFB_DISPLAY_VGA, 2, 0x100, 0x70e, 640, 480, 0x400, 0x1000 },\n { MACFB_DISPLAY_VGA, 4, 0x100, 0x706, 640, 480, 0x400, 0x1000 },\n@@ -397,7 +397,7 @@ static void macfb_update_mode(MacfbState *s)\n \n static void macfb_mode_write(MacfbState *s)\n {\n- MacFbMode *macfb_mode;\n+ const MacFbMode *macfb_mode;\n int i;\n \n for (i = 0; i < ARRAY_SIZE(macfb_mode_table); i++) {\n@@ -418,11 +418,11 @@ static void macfb_mode_write(MacfbState *s)\n }\n }\n \n-static MacFbMode *macfb_find_mode(MacfbDisplayType display_type,\n+static const MacFbMode *macfb_find_mode(MacfbDisplayType display_type,\n uint16_t width, uint16_t height,\n uint8_t depth)\n {\n- MacFbMode *macfb_mode;\n+ const MacFbMode *macfb_mode;\n int i;\n \n for (i = 0; i < ARRAY_SIZE(macfb_mode_table); i++) {\n@@ -440,7 +440,7 @@ static MacFbMode *macfb_find_mode(MacfbDisplayType display_type,\n static gchar *macfb_mode_list(void)\n {\n GString *list = g_string_new(\"\");\n- MacFbMode *macfb_mode;\n+ const MacFbMode *macfb_mode;\n int i;\n \n for (i = 0; i < ARRAY_SIZE(macfb_mode_table); i++) {\ndiff --git a/hw/m68k/q800.c b/hw/m68k/q800.c\nindex 25ddddb5d9f..4767eb4298f 100644\n--- a/hw/m68k/q800.c\n+++ b/hw/m68k/q800.c\n@@ -255,7 +255,7 @@ static void q800_machine_init(MachineState *machine)\n int32_t initrd_size;\n uint8_t *prom;\n int i, checksum;\n- MacFbMode *macfb_mode;\n+ const MacFbMode *macfb_mode;\n ram_addr_t ram_size = machine->ram_size;\n const char *kernel_filename = machine->kernel_filename;\n const char *initrd_filename = machine->initrd_filename;\n","prefixes":["v2","2/8"]}