{"id":2197030,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2197030/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216213121.47122-2-philmd@linaro.org>","date":"2026-02-16T21:31:14","name":"[v2,1/8] hw/display/macfb: Constify macfb_sense_table[] array","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"eb54afc2806a3b89ac6ff90744543683ab48a976","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.0/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216213121.47122-2-philmd@linaro.org/mbox/","series":[{"id":492356,"url":"http://patchwork.ozlabs.org/api/1.0/series/492356/?format=json","date":"2026-02-16T21:31:14","name":"system: Absorb globals-target.c within common globals.c","version":2,"mbox":"http://patchwork.ozlabs.org/series/492356/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2197030/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Vlfm57pG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFGFv3mF1z1xwF\n\tfor ; Tue, 17 Feb 2026 08:32:35 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vs6CB-0000Ji-U6; Mon, 16 Feb 2026 16:31:56 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1vs6Bs-0007Pi-SQ\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 16:31:38 -0500","from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1vs6Bp-0003xq-BT\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 16:31:35 -0500","by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-48375f10628so20541325e9.1\n for ; Mon, 16 Feb 2026 13:31:32 -0800 (PST)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43796a5ac92sm29582865f8f.1.2026.02.16.13.31.29\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 16 Feb 2026 13:31:30 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1771277491; x=1771882291; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=yqLUEfFp4yyvVrqD+DcLUkS33yg5lEUMmYhr1LZOcgw=;\n b=Vlfm57pGSoHFKM9CfDmUOHuG+XjNWUQMA5ZYu/2+WFdpK74oBk3uDcz3rpJ9Rg4/11\n vIArY6xpR6ZvCTA0tVWS7UUBeOQ3LS5dVudE0gFWWo1Y+AOUBCSIL91fuXqfhIRzQmR5\n qm4Q4IbHZaA3HMDW13X+oaliGKeMpfVQi34FA449uPMcsoC3FCiRsl1G0IliNSZwPE1w\n ffOY8qutTAl2e0I7mFPpgNZWoxzXIPAkHYfm06Vj8NUa4OCZdKCJiribxygWgPymAeEg\n O84EnOHRZRU3bYVAWJ+JEl99Cecv+hVj/qOONIQlrksHgJg3R1CKukxtREC4hmCcXFA5\n H68g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1771277491; x=1771882291;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=yqLUEfFp4yyvVrqD+DcLUkS33yg5lEUMmYhr1LZOcgw=;\n b=LLfDhYo3qhZWLKvmGrD10MbpkYlfyVTGktXNPr/qVmPy3JRmvu5oxHge1LP8QP4TRI\n b3OoCd8OIxXhqKL7L8DsRWFlhdrll011yTGUvEE9W5LdmwzufomqITBljiCSHdOgPiRd\n eQePLazYVpuwkH/D1Q3S4PTtB/4K8r6SC8ag9gQD5wN6/k+EgKVXCLMWAoVNsUvRJFHq\n SXL+b8nIJ+WBdI6Xbik7S4fVIScRTfl7EfGr6SmzX/2O8Ah0pH23aV1/nRDqj3kpNSst\n mgYho/TPp1mE2eFrUczE8Y7U6Uq2Do7L2NbTJodOfadVGvdTFFFpJhdj4jxBq9szH833\n ttJg==","X-Gm-Message-State":"AOJu0YzxLysJTm3PxWqBy0ERkwogDho4JCd0DM2AJqxYhkWiEV0ZyU5I\n y8FpcbOM1wN0+TErOtZ1hMN3QRIZG9iRXgSCKcKlayLe9bfB6NUpWUufzOnBLzeYw/Cz1bYOHjW\n 2xfzRYIg=","X-Gm-Gg":"AZuq6aLIDkQy1gq0IKppTBZX8Al/mGgZwYwRwd7CUCdovEO0dfpXy3NUUR7i3XPcKy0\n zLD2szEQGs90GKBnX7YwgmfFvagisDk4C0IDY3H+UtjxUo1E0/xgyIDuym6Ghr8CgEziqD+8YSP\n OmhzkXEz4WkL+7SPmSZmTGDjyknW3D/PYBZVcqDc21ESe9WpshGDNNRsU8oI2R/jne1Vv7ZceEb\n bFSa0xZkA2sfUq3A19D2G7AgKXR+btLl8madgq0TUOmeY96NLkuO+hiUe5phjTkEctsRMQNcyKM\n vpd2FB0+y6fm0uB0qXZFOxxBEEhkqdMG0xgqSlqfIZMVwIugCynjXlYmook7eSSMSrfuxxOFIj3\n 1j2tmtvXqhcoUGKuo2+5h0nCowUjHnB5wZLx1wXnOULK74wVjm1wMNMeggPmLwr+W/C1QsddeiA\n FPIMR6BV0/DhSGPxwRZF2+Fybgc1N9tFuZblMfwKp5oNBpobjZvIklBTa1pQqcfnXfK3w3TMRY","X-Received":"by 2002:a5d:5d06:0:b0:437:6f0c:2ed with SMTP id\n ffacd0b85a97d-4379790f0a9mr20966358f8f.34.1771277491139;\n Mon, 16 Feb 2026 13:31:31 -0800 (PST)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Nicholas Piggin ,\n =?utf-8?q?Herv=C3=A9_Poussineau?= ,\n Paolo Bonzini , Chinmay Rath ,\n Artyom Tarasenko ,\n Pierrick Bouvier ,\n Laurent Vivier , qemu-ppc@nongnu.org,\n Harsh Prateek Bora ,\n Mark Cave-Ayland , =?utf-8?q?Philippe_Mathie?=\n\t=?utf-8?q?u-Daud=C3=A9?= ","Subject":"[PATCH v2 1/8] hw/display/macfb: Constify macfb_sense_table[] array","Date":"Mon, 16 Feb 2026 22:31:14 +0100","Message-ID":"<20260216213121.47122-2-philmd@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260216213121.47122-1-philmd@linaro.org>","References":"<20260216213121.47122-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::334;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"macfb_sense_table[] is only read, never updated, so can be const.\n\nUpdate the single call site, macfb_sense_read().\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Pierrick Bouvier \nReviewed-by: Mark Cave-Ayland \n---\n hw/display/macfb.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/display/macfb.c b/hw/display/macfb.c\nindex 388f8de5070..57ad8ad5587 100644\n--- a/hw/display/macfb.c\n+++ b/hw/display/macfb.c\n@@ -82,7 +82,7 @@ typedef struct MacFbSense {\n uint8_t ext_sense;\n } MacFbSense;\n \n-static MacFbSense macfb_sense_table[] = {\n+static const MacFbSense macfb_sense_table[] = {\n { MACFB_DISPLAY_APPLE_21_COLOR, 0x0, 0 },\n { MACFB_DISPLAY_APPLE_PORTRAIT, 0x1, 0 },\n { MACFB_DISPLAY_APPLE_12_RGB, 0x2, 0 },\n@@ -342,7 +342,7 @@ static void macfb_invalidate_display(void *opaque)\n \n static uint32_t macfb_sense_read(MacfbState *s)\n {\n- MacFbSense *macfb_sense;\n+ const MacFbSense *macfb_sense;\n uint8_t sense;\n \n assert(s->type < ARRAY_SIZE(macfb_sense_table));\n","prefixes":["v2","1/8"]}