{"id":2196999,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196999/?format=json","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.0/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null},"msgid":"<5511a9a0d434c3b69f1625f9f4bfd8e99151bc1a.1771275704.git.daniel@makrotopia.org>","date":"2026-02-16T21:21:58","name":"[RFC,05/20] cmd: ubi: export ubi_find_volume()","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"63e9db430e0af901aa2840712b50ecd8e5747952","submitter":{"id":64091,"url":"http://patchwork.ozlabs.org/api/1.0/people/64091/?format=json","name":"Daniel Golle","email":"daniel@makrotopia.org"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.0/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/5511a9a0d434c3b69f1625f9f4bfd8e99151bc1a.1771275704.git.daniel@makrotopia.org/mbox/","series":[{"id":492351,"url":"http://patchwork.ozlabs.org/api/1.0/series/492351/?format=json","date":"2026-02-16T21:21:14","name":"boot: add OpenWrt boot method and on-demand FIT loading","version":1,"mbox":"http://patchwork.ozlabs.org/series/492351/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196999/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=makrotopia.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=makrotopia.org","phobos.denx.de;\n spf=pass smtp.mailfrom=daniel@makrotopia.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFG3q6w5Fz1xwD\n\tfor ; Tue, 17 Feb 2026 08:23:51 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 3EA7383DDD;\n\tMon, 16 Feb 2026 22:23:03 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id AAB328063E; Mon, 16 Feb 2026 22:22:19 +0100 (CET)","from pidgin.makrotopia.org (pidgin.makrotopia.org\n [IPv6:2a07:2ec0:3002::65])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C38E083AA9\n for ; Mon, 16 Feb 2026 22:22:17 +0100 (CET)","from local\n by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256)\n (Exim 4.99) (envelope-from )\n id 1vs62c-000000002ex-1sVD; Mon, 16 Feb 2026 21:22:02 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","Date":"Mon, 16 Feb 2026 21:21:58 +0000","From":"Daniel Golle ","To":"Tom Rini , Simon Glass ,\n Quentin Schulz ,\n Daniel Golle ,\n Kory Maincent ,\n Mattijs Korpershoek ,\n Martin Schwan , Anshul Dalal ,\n Ilias Apalodimas ,\n Sughosh Ganu , Aristo Chen ,\n\t=?utf-8?b?54mbIOW/l+Wujw==?= ,\n Marek Vasut ,\n Heinrich Schuchardt ,\n Wolfgang Wallner ,\n Frank Wunderlich ,\n David Lechner ,\n Osama Abdelkader ,\n Mikhail Kshevetskiy ,\n Michael Trimarchi ,\n Miquel Raynal ,\n Andrew Goodbody ,\n Yegor Yefremov ,\n Mike Looijmans ,\n Weijie Gao ,\n Alexander Stein ,\n Neil Armstrong ,\n Mayuresh Chitale ,\n Paul HENRYS , u-boot@lists.denx.de","Cc":"John Crispin , Paul Spooren ","Subject":"[RFC PATCH 05/20] cmd: ubi: export ubi_find_volume()","Message-ID":"\n <5511a9a0d434c3b69f1625f9f4bfd8e99151bc1a.1771275704.git.daniel@makrotopia.org>","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","X-Mailman-Approved-At":"Mon, 16 Feb 2026 22:22:55 +0100","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Remove the static qualifier from ubi_find_volume() and add a\ndeclaration to include/ubi_uboot.h so that other translation units\ncan look up a UBI volume by name.\n\nThe function now refers to ubi_devices[0] directly instead of the\nfile-local 'ubi' pointer, and takes a const char * for the volume\nname.\n\nSigned-off-by: Daniel Golle \n---\n cmd/ubi.c | 10 +++++++---\n include/ubi_uboot.h | 1 +\n 2 files changed, 8 insertions(+), 3 deletions(-)","diff":"diff --git a/cmd/ubi.c b/cmd/ubi.c\nindex 93de6f3aea2..ca7d657aa07 100644\n--- a/cmd/ubi.c\n+++ b/cmd/ubi.c\n@@ -247,13 +247,17 @@ static int ubi_create_vol(char *volume, int64_t size, int dynamic, int vol_id,\n \treturn ubi_create_volume(ubi, &req);\n }\n \n-static struct ubi_volume *ubi_find_volume(char *volume)\n+struct ubi_volume *ubi_find_volume(const char *volume)\n {\n+\tstruct ubi_device *dev = ubi_devices[0];\n \tstruct ubi_volume *vol;\n \tint i;\n \n-\tfor (i = 0; i < ubi->vtbl_slots; i++) {\n-\t\tvol = ubi->volumes[i];\n+\tif (!dev)\n+\t\treturn NULL;\n+\n+\tfor (i = 0; i < dev->vtbl_slots; i++) {\n+\t\tvol = dev->volumes[i];\n \t\tif (vol && !strcmp(vol->name, volume))\n \t\t\treturn vol;\n \t}\ndiff --git a/include/ubi_uboot.h b/include/ubi_uboot.h\nindex ea0db69c72a..92892704d0a 100644\n--- a/include/ubi_uboot.h\n+++ b/include/ubi_uboot.h\n@@ -50,6 +50,7 @@ extern void ubi_exit(void);\n extern int ubi_part(char *part_name, const char *vid_header_offset);\n extern int ubi_volume_write(char *volume, void *buf, loff_t offset, size_t size);\n extern int ubi_volume_read(char *volume, char *buf, loff_t offset, size_t size);\n+struct ubi_volume *ubi_find_volume(const char *volume);\n \n extern struct ubi_device *ubi_devices[];\n int cmd_ubifs_mount(char *vol_name);\n","prefixes":["RFC","05/20"]}