{"id":2196982,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196982/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216191213.2556073-5-dmitry.osipenko@collabora.com>","date":"2026-02-16T19:11:59","name":"[v17,04/18] ui/sdl2: Unset context after GL operations","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"092d4c7e581fc9d3f591a8a8e8e398882c9ef029","submitter":{"id":83453,"url":"http://patchwork.ozlabs.org/api/1.0/people/83453/?format=json","name":"Dmitry Osipenko","email":"dmitry.osipenko@collabora.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216191213.2556073-5-dmitry.osipenko@collabora.com/mbox/","series":[{"id":492344,"url":"http://patchwork.ozlabs.org/api/1.0/series/492344/?format=json","date":"2026-02-16T19:11:55","name":"Support virtio-gpu DRM native context and MAP_FIXED API","version":17,"mbox":"http://patchwork.ozlabs.org/series/492344/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196982/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=collabora.com header.i=dmitry.osipenko@collabora.com\n header.a=rsa-sha256 header.s=zohomail header.b=j0fZXqV5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fFCF90D6lz1xtN\n\tfor ; Tue, 17 Feb 2026 06:16:45 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vs42M-0007yc-Og; Mon, 16 Feb 2026 14:13:38 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vs42G-0007yF-Q5\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 14:13:34 -0500","from sender4-pp-g124.zoho.com ([136.143.188.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vs42E-0003Z9-M3\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 14:13:32 -0500","by mx.zohomail.com with SMTPS id 17712691929841008.3265234117447;\n Mon, 16 Feb 2026 11:13:12 -0800 (PST)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1771269194; cv=none;\n d=zohomail.com; s=zohoarc;\n b=ONxJkf0hPvNBovgmzzT8aBZQLfqw62G7Fh/pfZPhh73vSn0UlOUDUC26ELz7l1O4nppL6B7Qm3PaBEfHmRidVNE6iraxLTywt6vB4vKeRbl6pRMqi4gGfxE+ADeyY7O/JVLpbwXNJvCRgyYj2C4XkNxnAGBTjQH0GqHn5bGoxOQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;\n s=zohoarc; t=1771269194;\n h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n bh=aQaG6nS4+RzGmjU/24LUpRpZp6FwJ6sMEExKWN7vBb0=;\n b=mbO1GPBp/otdwdWHEqs5NBSFx9QcunKF/7h3on3scCElR51aj3SwLwHkAMeI65WL9mJuRFJn/aY34B/lxRWlmJslQZuHrRAx23O6H+CPyQmy+5eT2hYc2FpFT3JePdqj3gbVDB3mGEQjuveUoiL9GlJ7IP1AMN9EASwpN9lIbsI=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n dkim=pass header.i=collabora.com;\n spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com;\n dmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1771269194;\n s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com;\n h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n bh=aQaG6nS4+RzGmjU/24LUpRpZp6FwJ6sMEExKWN7vBb0=;\n b=j0fZXqV5YeJ7f2s2dKTOMSPOhCy5Ee01qmRZ5PjnwEqKRmrM9ST2kPooG+wdazUA\n VCG7TxYUo46HkaqCm1wtgbWFvlhxGbtIB1JeEG++SGJ0dX9shrSVOo/NtRrRAg7jkWj\n TXtQ82EdfgBth6PCpTiFyGOzw0+Ttd2W7agHXHzc=","From":"Dmitry Osipenko ","To":"Akihiko Odaki ,\n Huang Rui ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Gerd Hoffmann ,\n =?utf-8?q?Alex_Benn=C3=A9e?= ,\n Pierre-Eric Pelloux-Prayer ,\n \"Michael S . Tsirkin\" , Paolo Bonzini ,\n Yiwei Zhang , Sergio Lopez Pascual ","Cc":"Gert Wollny , qemu-devel@nongnu.org,\n Gurchetan Singh , Alyssa Ross ,\n\t=?utf-8?q?Roger_Pau_Monn=C3=A9?= ,\n Alex Deucher ,\n Stefano Stabellini , =?utf-8?q?Christian_K?=\n\t=?utf-8?q?=C3=B6nig?= ,\n Xenia Ragiadakou ,\n Honglei Huang , Julia Zhang ,\n Chen Jiqian , Rob Clark ,\n Robert Beckett ","Subject":"[PATCH v17 04/18] ui/sdl2: Unset context after GL operations","Date":"Mon, 16 Feb 2026 22:11:59 +0300","Message-ID":"<20260216191213.2556073-5-dmitry.osipenko@collabora.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260216191213.2556073-1-dmitry.osipenko@collabora.com>","References":"<20260216191213.2556073-1-dmitry.osipenko@collabora.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-ZohoMailClient":"External","Received-SPF":"pass client-ip=136.143.188.124;\n envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-g124.zoho.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"VirtIO-GPU commands may be processed outside of main-loop, from a CPU\nthread. This results in GL context switch failure because context is held\nby main-loop thread when GL is invoked from CPU thread. Always release GL\ncontext after performing GL operations such that other threads could take\nover the context.\n\n 0 SDL_GL_MakeCurrent() (libSDL3)\n 1 SDL_GL_MakeCurrent_REAL() (libSDL2)\n 2 sdl2_gl_make_context_current() (ui/sdl2-gl.c:201)\n 3 make_current() (virglrenderer.c:639)\n 4 vrend_finish_context_switch() (vrend_renderer.c:11630)\n 5 vrend_hw_switch_context() (vrend_renderer.c:11613)\n 6 vrend_renderer_force_ctx_0() (vrend_renderer.c:12986)\n 7 virgl_renderer_force_ctx_0() (virglrenderer.c:460)\n 8 virtio_gpu_virgl_process_cmd() (virtio-gpu-virgl.c:1013)\n 9 virtio_gpu_process_cmdq() (virtio-gpu.c:1050)\n 10 virtio_gpu_gl_handle_ctrl() (virtio-gpu-gl.c:86)\n 11 aio_bh_poll() (util/async.c)\n 12 aio_poll() (util/aio-posix.c)\n 13 blk_pwrite() (block/block-gen.c:1985)\n 14 pflash_update() (pflash_cfi01.c:396)\n 15 pflash_write() (pflash_cfi01.c:541)\n 16 memory_region_dispatch_write() (system/memory.c:1554)\n 17 flatview_write() (system/physmem.c:3333)\n 18 address_space_write() (system/physmem.c:3453)\n 19 kvm_cpu_exec() (accel/kvm/kall-all.c:3248)\n 20 kvm_vcpu_thread_fn() (accel/kvm/kaccel-ops.c:53)\n\nSigned-off-by: Dmitry Osipenko \n---\n ui/sdl2-gl.c | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c\nindex 55e22a7a3d59..936b15f737d8 100644\n--- a/ui/sdl2-gl.c\n+++ b/ui/sdl2-gl.c\n@@ -57,6 +57,8 @@ static void sdl2_gl_render_surface(struct sdl2_console *scon)\n \n surface_gl_render_texture(scon->gls, scon->surface);\n SDL_GL_SwapWindow(scon->real_window);\n+\n+ SDL_GL_MakeCurrent(scon->real_window, NULL);\n }\n \n void sdl2_gl_update(DisplayChangeListener *dcl,\n@@ -73,6 +75,8 @@ void sdl2_gl_update(DisplayChangeListener *dcl,\n SDL_GL_MakeCurrent(scon->real_window, scon->winctx);\n surface_gl_update_texture(scon->gls, scon->surface, x, y, w, h);\n scon->updates++;\n+\n+ SDL_GL_MakeCurrent(scon->real_window, NULL);\n }\n \n void sdl2_gl_switch(DisplayChangeListener *dcl,\n@@ -91,6 +95,7 @@ void sdl2_gl_switch(DisplayChangeListener *dcl,\n if (surface_is_placeholder(new_surface) && qemu_console_get_index(dcl->con)) {\n qemu_gl_fini_shader(scon->gls);\n scon->gls = NULL;\n+ SDL_GL_MakeCurrent(scon->real_window, NULL);\n sdl2_window_destroy(scon);\n return;\n }\n@@ -105,6 +110,8 @@ void sdl2_gl_switch(DisplayChangeListener *dcl,\n }\n \n surface_gl_create_texture(scon->gls, scon->surface);\n+\n+ SDL_GL_MakeCurrent(scon->real_window, NULL);\n }\n \n void sdl2_gl_refresh(DisplayChangeListener *dcl)\n","prefixes":["v17","04/18"]}