{"id":2196872,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196872/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-60-e676662e4514@redhat.com>","date":"2026-02-16T11:15:49","name":"[60/85] audio/coreaudio: replace custom logging with error_report","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2c9b29984d3852ff984b61603ecacd33e679295a","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-60-e676662e4514@redhat.com/mbox/","series":[{"id":492294,"url":"http://patchwork.ozlabs.org/api/1.0/series/492294/?format=json","date":"2026-02-16T11:14:52","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492294/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196872/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Z055ss6N;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0sT42Qqz1xwF\n\tfor ; Mon, 16 Feb 2026 22:29:01 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrwfO-0006aR-C8; Mon, 16 Feb 2026 06:21:26 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwce-0006t4-Lt\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:38 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwcc-0008Gb-Ha\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:36 -0500","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-kUpd9RqsO-iJeRoGm3Ma0w-1; Mon,\n 16 Feb 2026 06:18:30 -0500","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 83AB01955D8C; Mon, 16 Feb 2026 11:18:28 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 7AB5618003F5; Mon, 16 Feb 2026 11:18:27 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240713;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=imf3hzI7LKBfMTfzAqdoQfPRWfEP/D7PMD9pqFFwoX4=;\n b=Z055ss6NJck6oBXnWE5f2b2h3EwPEuz6JQO9wslJ8aSsecY41RXOGJKrNlUTfybefXxoGe\n GKN8qyHixfnuRHrbeAeHx8UqNnLNkb0F5l/wUCR1yBakTFXGve40vTyQMpyFzkyHYpg6Xr\n qlCG7NGHnUhdfHd07ibrYvzZhddtkYE=","X-MC-Unique":"kUpd9RqsO-iJeRoGm3Ma0w-1","X-Mimecast-MFC-AGG-ID":"kUpd9RqsO-iJeRoGm3Ma0w_1771240708","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 16 Feb 2026 12:15:49 +0100","Subject":"[PATCH 60/85] audio/coreaudio: replace custom logging with\n error_report","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-60-e676662e4514@redhat.com>","References":"<20260216-audio-v1-0-e676662e4514@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-e676662e4514@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , Eduardo Habkost ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n John Snow , Cleber Rosa ,\n Christian Schoenebeck ,\n Akihiko Odaki ,\n Thomas Huth , Alexandre Ratchov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Manos Pitsidianakis ,\n Alistair Francis ,\n \"Edgar E. Iglesias\" ,\n Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= ,\n Mark Cave-Ayland ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=13433;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=m+PfI40oEtHkORC+s06hkAac6Itn0SlxZ9kz6+PeIgI=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxR8X/TvnCVl+mCda3Iro5ShzHHVVEFfxXl3\n WgWLRikONKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UQAKCRDa6OEJdZac\n 5d0VEACVPK67nF1fF8Nsi2ki/pm5LW/1WcGQ1Fun8hGoVWmFf7OlLXWBwMC1dvAjQi5V/oNd/vu\n /tSI8hcG4RAEPC6CPZy1hAqGcsCvSsduDGqPYUAnjmgLGPqxB3ywNjwS4koXKoAt8u05++Q7wwT\n oZi+633AX9bpJ5q4sn2pVNDZVry1yzeOTjbLeVoN+QuZId3oceNbgLEyIkyW/53jmAT81yGpUEQ\n 2t1hAvIVAp34GpwQfgCinHkC2ADe+Geta6GCbpTavfOjH6BOsQiyukct22hVU7kdrflaiON/Zab\n dCsG4DUCS7NowOVB8MIhni3TZbCw6b4zm72TVgE2biCiu/1K/5yFxUKTcDcAQyJZGykYQFYG2Wo\n 89ENOBDT9Wd0wgDzC2aPbdrjxj9RijbIN8FLV9mTzoITmyS2Q8zTgy5vovBTfhYKkR5zJvIn9ws\n 9ViKXIUJ7ONhlxyd5B3iSyzqTv5MWVu/YjVqmPFrOws4AIAZjMfXTx28H5WOjnCccQyqhQUfCId\n sTPNEzWevUWli3TynbdhxaxflIr4q/H70isdCqkQGAqn8cECAdr8wc9W4mFzPmlQDfVtL3VU3fU\n KOfRA8KLM+gjFQ6ZpP3pAfa+z3XMOzV56ix3jtEFTdpeufyIM3xfp4wQK6eELXNfBYAjC/dh4Rr\n 7lgAccHkUpm9+Kg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The CoreAudio backend uses its own logging infrastructure (AUD_log,\nAUD_vlog, dolog) and the AUDIO_CAP macro. This approach is inconsistent\nwith the rest of QEMU and makes the output harder to filter and\nconfigure.\n\nReplace the custom logging with standard QEMU error reporting:\n- Use error_report() / error_printf() for errors\n- Use warn_report() for non-fatal warnings (buffer frame size\n adjustments)\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Mark Cave-Ayland \nReviewed-by: Akihiko Odaki \n---\n audio/coreaudio.m | 124 ++++++++++++++++++++++++++----------------------------\n 1 file changed, 60 insertions(+), 64 deletions(-)","diff":"diff --git a/audio/coreaudio.m b/audio/coreaudio.m\nindex 561c08f47c1..0c0e8583c89 100644\n--- a/audio/coreaudio.m\n+++ b/audio/coreaudio.m\n@@ -28,10 +28,9 @@\n \n #include \"qemu/main-loop.h\"\n #include \"qemu/module.h\"\n+#include \"qemu/error-report.h\"\n #include \"qemu/audio.h\"\n #include \"qom/object.h\"\n-\n-#define AUDIO_CAP \"coreaudio\"\n #include \"audio_int.h\"\n \n #define TYPE_AUDIO_COREAUDIO \"audio-coreaudio\"\n@@ -157,7 +156,7 @@ static OSStatus coreaudio_get_isrunning(AudioDeviceID id, UInt32 *result)\n result);\n }\n \n-static void coreaudio_logstatus (OSStatus status)\n+static void coreaudio_logstatus(OSStatus status)\n {\n const char *str = \"BUG\";\n \n@@ -207,70 +206,64 @@ static void coreaudio_logstatus (OSStatus status)\n break;\n \n default:\n- AUD_log (AUDIO_CAP, \"Reason: status code %\" PRId32 \"\\n\", (int32_t)status);\n+ error_printf(\" Reason: status code %\" PRId32, (int32_t)status);\n return;\n }\n \n- AUD_log (AUDIO_CAP, \"Reason: %s\\n\", str);\n+ error_printf(\" Reason: %s\", str);\n }\n \n-static void G_GNUC_PRINTF (2, 3) coreaudio_logerr (\n- OSStatus status,\n- const char *fmt,\n- ...\n- )\n+static void G_GNUC_PRINTF(2, 3) coreaudio_logerr(OSStatus status,\n+ const char *fmt, ...)\n {\n va_list ap;\n \n- va_start (ap, fmt);\n- AUD_log (AUDIO_CAP, fmt, ap);\n- va_end (ap);\n-\n- coreaudio_logstatus (status);\n+ error_printf(\"coreaudio: \");\n+ va_start(ap, fmt);\n+ error_vprintf(fmt, ap);\n+ va_end(ap);\n+ coreaudio_logstatus(status);\n+ error_printf(\"\\n\");\n }\n \n-static void G_GNUC_PRINTF (3, 4) coreaudio_logerr2 (\n- OSStatus status,\n- const char *typ,\n- const char *fmt,\n- ...\n- )\n+static void G_GNUC_PRINTF(3, 4) coreaudio_logerr2(OSStatus status,\n+ const char *typ,\n+ const char *fmt, ...)\n {\n va_list ap;\n \n- AUD_log (AUDIO_CAP, \"Could not initialize %s\\n\", typ);\n-\n- va_start (ap, fmt);\n- AUD_vlog (AUDIO_CAP, fmt, ap);\n- va_end (ap);\n-\n- coreaudio_logstatus (status);\n+ error_printf(\"coreaudio: Could not initialize %s: \", typ);\n+ va_start(ap, fmt);\n+ error_vprintf(fmt, ap);\n+ va_end(ap);\n+ coreaudio_logstatus(status);\n+ error_printf(\"\\n\");\n }\n \n #define coreaudio_playback_logerr(status, ...) \\\n coreaudio_logerr2(status, \"playback\", __VA_ARGS__)\n \n-static int coreaudio_buf_lock (coreaudioVoiceOut *core, const char *fn_name)\n+static int coreaudio_buf_lock(coreaudioVoiceOut *core, const char *fn_name)\n {\n int err;\n \n- err = pthread_mutex_lock (&core->buf_mutex);\n+ err = pthread_mutex_lock(&core->buf_mutex);\n if (err) {\n- dolog (\"Could not lock voice for %s\\nReason: %s\\n\",\n- fn_name, strerror (err));\n+ error_report(\"coreaudio: Could not lock voice for %s: %s\",\n+ fn_name, strerror(err));\n return -1;\n }\n return 0;\n }\n \n-static int coreaudio_buf_unlock (coreaudioVoiceOut *core, const char *fn_name)\n+static int coreaudio_buf_unlock(coreaudioVoiceOut *core, const char *fn_name)\n {\n int err;\n \n- err = pthread_mutex_unlock (&core->buf_mutex);\n+ err = pthread_mutex_unlock(&core->buf_mutex);\n if (err) {\n- dolog (\"Could not unlock voice for %s\\nReason: %s\\n\",\n- fn_name, strerror (err));\n+ error_report(\"coreaudio: Could not unlock voice for %s: %s\",\n+ fn_name, strerror(err));\n return -1;\n }\n return 0;\n@@ -378,12 +371,13 @@ static OSStatus init_out_device(coreaudioVoiceOut *core)\n \n status = coreaudio_get_voice(&core->outputDeviceID);\n if (status != kAudioHardwareNoError) {\n- coreaudio_playback_logerr (status,\n- \"Could not get default output Device\\n\");\n+ coreaudio_playback_logerr(status,\n+ \"Could not get default output device\");\n return status;\n }\n if (core->outputDeviceID == kAudioDeviceUnknown) {\n- dolog (\"Could not initialize playback - Unknown Audiodevice\\n\");\n+ error_report(\"coreaudio: Could not initialize playback: \"\n+ \"Unknown audio device\");\n return status;\n }\n \n@@ -394,17 +388,19 @@ static OSStatus init_out_device(coreaudioVoiceOut *core)\n return 0;\n }\n if (status != kAudioHardwareNoError) {\n- coreaudio_playback_logerr (status,\n- \"Could not get device buffer frame range\\n\");\n+ coreaudio_playback_logerr(status,\n+ \"Could not get device buffer frame range\");\n return status;\n }\n \n if (frameRange.mMinimum > core->frameSizeSetting) {\n core->audioDevicePropertyBufferFrameSize = (UInt32) frameRange.mMinimum;\n- dolog (\"warning: Upsizing Buffer Frames to %f\\n\", frameRange.mMinimum);\n+ warn_report(\"coreaudio: Upsizing buffer frames to %f\",\n+ frameRange.mMinimum);\n } else if (frameRange.mMaximum < core->frameSizeSetting) {\n core->audioDevicePropertyBufferFrameSize = (UInt32) frameRange.mMaximum;\n- dolog (\"warning: Downsizing Buffer Frames to %f\\n\", frameRange.mMaximum);\n+ warn_report(\"coreaudio: Downsizing buffer frames to %f\",\n+ frameRange.mMaximum);\n } else {\n core->audioDevicePropertyBufferFrameSize = core->frameSizeSetting;\n }\n@@ -416,9 +412,9 @@ static OSStatus init_out_device(coreaudioVoiceOut *core)\n return 0;\n }\n if (status != kAudioHardwareNoError) {\n- coreaudio_playback_logerr (status,\n- \"Could not set device buffer frame size %\" PRIu32 \"\\n\",\n- (uint32_t)core->audioDevicePropertyBufferFrameSize);\n+ coreaudio_playback_logerr(status,\n+ \"Could not set device buffer frame size %\" PRIu32,\n+ (uint32_t)core->audioDevicePropertyBufferFrameSize);\n return status;\n }\n \n@@ -429,8 +425,8 @@ static OSStatus init_out_device(coreaudioVoiceOut *core)\n return 0;\n }\n if (status != kAudioHardwareNoError) {\n- coreaudio_playback_logerr (status,\n- \"Could not get device buffer frame size\\n\");\n+ coreaudio_playback_logerr(status,\n+ \"Could not get device buffer frame size\");\n return status;\n }\n core->hw.samples = core->bufferCount * core->audioDevicePropertyBufferFrameSize;\n@@ -442,9 +438,9 @@ static OSStatus init_out_device(coreaudioVoiceOut *core)\n return 0;\n }\n if (status != kAudioHardwareNoError) {\n- coreaudio_playback_logerr (status,\n- \"Could not set samplerate %lf\\n\",\n- streamBasicDescription.mSampleRate);\n+ coreaudio_playback_logerr(status,\n+ \"Could not set samplerate %lf\",\n+ streamBasicDescription.mSampleRate);\n core->outputDeviceID = kAudioDeviceUnknown;\n return status;\n }\n@@ -468,7 +464,7 @@ static OSStatus init_out_device(coreaudioVoiceOut *core)\n return 0;\n }\n if (status != kAudioHardwareNoError || core->ioprocid == NULL) {\n- coreaudio_playback_logerr (status, \"Could not set IOProc\\n\");\n+ coreaudio_playback_logerr(status, \"Could not set IOProc\");\n core->outputDeviceID = kAudioDeviceUnknown;\n return status;\n }\n@@ -486,13 +482,13 @@ static void fini_out_device(coreaudioVoiceOut *core)\n if (status != kAudioHardwareBadObjectError) {\n if (status != kAudioHardwareNoError) {\n coreaudio_logerr(status,\n- \"Could not determine whether Device is playing\\n\");\n+ \"Could not determine whether device is playing\");\n }\n \n if (isrunning) {\n status = AudioDeviceStop(core->outputDeviceID, core->ioprocid);\n if (status != kAudioHardwareBadDeviceError && status != kAudioHardwareNoError) {\n- coreaudio_logerr(status, \"Could not stop playback\\n\");\n+ coreaudio_logerr(status, \"Could not stop playback\");\n }\n }\n }\n@@ -501,7 +497,7 @@ static void fini_out_device(coreaudioVoiceOut *core)\n status = AudioDeviceDestroyIOProcID(core->outputDeviceID,\n core->ioprocid);\n if (status != kAudioHardwareBadDeviceError && status != kAudioHardwareNoError) {\n- coreaudio_logerr(status, \"Could not remove IOProc\\n\");\n+ coreaudio_logerr(status, \"Could not remove IOProc\");\n }\n core->outputDeviceID = kAudioDeviceUnknown;\n }\n@@ -515,7 +511,7 @@ static void update_device_playback_state(coreaudioVoiceOut *core)\n if (status != kAudioHardwareNoError) {\n if (status != kAudioHardwareBadObjectError) {\n coreaudio_logerr(status,\n- \"Could not determine whether Device is playing\\n\");\n+ \"Could not determine whether device is playing\");\n }\n \n return;\n@@ -526,7 +522,7 @@ static void update_device_playback_state(coreaudioVoiceOut *core)\n if (!isrunning) {\n status = AudioDeviceStart(core->outputDeviceID, core->ioprocid);\n if (status != kAudioHardwareBadDeviceError && status != kAudioHardwareNoError) {\n- coreaudio_logerr (status, \"Could not resume playback\\n\");\n+ coreaudio_logerr(status, \"Could not resume playback\");\n }\n }\n } else {\n@@ -535,7 +531,7 @@ static void update_device_playback_state(coreaudioVoiceOut *core)\n status = AudioDeviceStop(core->outputDeviceID,\n core->ioprocid);\n if (status != kAudioHardwareBadDeviceError && status != kAudioHardwareNoError) {\n- coreaudio_logerr(status, \"Could not pause playback\\n\");\n+ coreaudio_logerr(status, \"Could not pause playback\");\n }\n }\n }\n@@ -576,7 +572,7 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as)\n /* create mutex */\n err = pthread_mutex_init(&core->buf_mutex, NULL);\n if (err) {\n- dolog(\"Could not create mutex\\nReason: %s\\n\", strerror (err));\n+ error_report(\"coreaudio: Could not create mutex: %s\", strerror(err));\n return -1;\n }\n \n@@ -594,8 +590,8 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as)\n &voice_addr, handle_voice_change,\n core);\n if (status != kAudioHardwareNoError) {\n- coreaudio_playback_logerr (status,\n- \"Could not listen to voice property change\\n\");\n+ coreaudio_playback_logerr(status,\n+ \"Could not listen to voice property change\");\n return -1;\n }\n \n@@ -606,7 +602,7 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as)\n core);\n if (status != kAudioHardwareNoError) {\n coreaudio_playback_logerr(status,\n- \"Could not remove voice property change listener\\n\");\n+ \"Could not remove voice property change listener\");\n }\n \n return -1;\n@@ -626,7 +622,7 @@ static void coreaudio_fini_out (HWVoiceOut *hw)\n handle_voice_change,\n core);\n if (status != kAudioHardwareNoError) {\n- coreaudio_logerr(status, \"Could not remove voice property change listener\\n\");\n+ coreaudio_logerr(status, \"Could not remove voice property change listener\");\n }\n \n fini_out_device(core);\n@@ -634,7 +630,7 @@ static void coreaudio_fini_out (HWVoiceOut *hw)\n /* destroy mutex */\n err = pthread_mutex_destroy(&core->buf_mutex);\n if (err) {\n- dolog(\"Could not destroy mutex\\nReason: %s\\n\", strerror (err));\n+ error_report(\"coreaudio: Could not destroy mutex: %s\", strerror(err));\n }\n }\n \n","prefixes":["60/85"]}