{"id":2196868,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196868/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-43-e676662e4514@redhat.com>","date":"2026-02-16T11:15:32","name":"[43/85] audio/spice: convert to QOM lifecycle methods","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"35e08b3994cc878608408f64759ba002629a5e16","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-43-e676662e4514@redhat.com/mbox/","series":[{"id":492294,"url":"http://patchwork.ozlabs.org/api/1.0/series/492294/?format=json","date":"2026-02-16T11:14:52","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492294/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196868/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=InubpNMf;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0rG72j1z1xwF\n\tfor ; Mon, 16 Feb 2026 22:27:58 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrwfX-0007rg-AB; Mon, 16 Feb 2026 06:21:35 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwbv-0006EF-V1\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:17:52 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwbq-00086x-5r\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:17:51 -0500","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-213-jmIuXMb8MmCISZFgiasbOQ-1; Mon,\n 16 Feb 2026 06:17:41 -0500","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 43D7119560AA; Mon, 16 Feb 2026 11:17:39 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id C96B119560A2; Mon, 16 Feb 2026 11:17:37 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240665;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ZAePRO9iX/CdNZl5mbtEzsh4UrYfxMJmJv42slqeaKE=;\n b=InubpNMfFFamqOdXQkfxHz9umZk4QQtbBKA0WJVjYB41+ichPJIq3pK9slcwqpoFeEBLLW\n TzvvX5F8SrBgtgd26XvM8G0wT1AW995Sm9oO9Ha+jTtaYR0b3WhQHqDAJe2XQvBA9a2QeN\n wcjywYgYAXx7XDeFrYrAjkm6jQ3X/50=","X-MC-Unique":"jmIuXMb8MmCISZFgiasbOQ-1","X-Mimecast-MFC-AGG-ID":"jmIuXMb8MmCISZFgiasbOQ_1771240659","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 16 Feb 2026 12:15:32 +0100","Subject":"[PATCH 43/85] audio/spice: convert to QOM lifecycle methods","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-43-e676662e4514@redhat.com>","References":"<20260216-audio-v1-0-e676662e4514@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-e676662e4514@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , Eduardo Habkost ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n John Snow , Cleber Rosa ,\n Christian Schoenebeck ,\n Akihiko Odaki ,\n Thomas Huth , Alexandre Ratchov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Manos Pitsidianakis ,\n Alistair Francis ,\n \"Edgar E. Iglesias\" ,\n Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= ,\n Mark Cave-Ayland ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2621;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=Rcs408lO9P4mK3uz8yvMkyVGqD72XWjzygJPEae432E=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxQAwF6m/TkCaYFng41JyP1I6mFplns1w39M\n VCyg9F1V7yJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UAAKCRDa6OEJdZac\n 5dXTD/4roKmuR4JVDbGSh1B2Tv7YYNc+wLiMg6Vo5Oum72fx4eaGMB/jDzjpWl1tcYyUeHZRydY\n yF5FSzdhdVz+gvs53HwXhwyKcbEt1jJPAim14RehF7e5Y2ZOp1VSQ1XS9VcdTUPvaw4BtmIMbUU\n LJCI2SLTzLYyt2/wgKhYmB3NmedVG3n1ljRyPSq7zF1gTjsct6X7d7jAW+qQd/sYDsgfK7ANrDG\n 7g/oaWYhLP6F7lscbZOrboROm1u4OQY0JaXruNETx6xb+DyJF4khxKvNL9z/rRkeI8v3eKqUXvr\n RkaTJM6WmWv4GSV0BVRHoo3IPz6hPBQ478s2nihRbNFAtf/7qhVHRV1jXk6SjlGbeRxEj6fmeVF\n 6iy2cdA48jsyGIFXYEaf/NDKr2nR7L6dSwvMCSv0dRNrcW+ux5BZjBdBvSxPPgMDJn6i5XW3UVw\n 3wMnVoB1guas3YAioQW4wb/pE7M0GzwktYauLXKk/I0UYvFJZ2yczpes1p3f3U0SOvvPLQ33/CY\n Z6xZo2JYiGEFGtkZiUPtpb2O++cSBT44eTn6Tu0mu8xMvuphALaC8lY8S67Q6sy3Q8j0aHB2QpC\n K/izWRigAhPbugB0kfMtLL1uKsxdK93BWkchDYQ0b3MAIuqKen/w8oaA9IftG/D3fXiIyv4t62x\n TczxZ1PJLLgvXzw==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Migrate the SPICE audio backend from the legacy driver init/fini\ncallbacks to proper QOM realize method.\n\nThe spice_audio_init() function is replaced with spice_audio_realize(),\nwhich validates that SPICE is enabled before delegating to the parent\nclass realize method. The empty spice_audio_fini() is removed as no\ncleanup is needed.\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Mark Cave-Ayland \n---\n audio/spiceaudio.c | 34 +++++++++++++++++-----------------\n 1 file changed, 17 insertions(+), 17 deletions(-)","diff":"diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c\nindex ad7cb69673b..953dbf6c308 100644\n--- a/audio/spiceaudio.c\n+++ b/audio/spiceaudio.c\n@@ -33,16 +33,33 @@\n #define TYPE_AUDIO_SPICE \"audio-spice\"\n OBJECT_DECLARE_SIMPLE_TYPE(AudioSpice, AUDIO_SPICE)\n \n+static AudioBackendClass *audio_spice_parent_class;\n+\n struct AudioSpice {\n AudioMixengBackend parent_obj;\n };\n \n static struct audio_driver spice_audio_driver;\n \n+static bool spice_audio_realize(AudioBackend *abe, Audiodev *dev, Error **errp)\n+{\n+ if (!using_spice) {\n+ error_setg(errp, \"Cannot use spice audio without -spice\");\n+ qapi_free_Audiodev(dev);\n+ return false;\n+ }\n+\n+ return audio_spice_parent_class->realize(abe, dev, errp);\n+}\n+\n static void audio_spice_class_init(ObjectClass *klass, const void *data)\n {\n+ AudioBackendClass *b = AUDIO_BACKEND_CLASS(klass);\n AudioMixengBackendClass *k = AUDIO_MIXENG_BACKEND_CLASS(klass);\n \n+ audio_spice_parent_class = AUDIO_BACKEND_CLASS(object_class_get_parent(klass));\n+\n+ b->realize = spice_audio_realize;\n k->driver = &spice_audio_driver;\n }\n \n@@ -89,21 +106,6 @@ static const SpiceRecordInterface record_sif = {\n .base.minor_version = SPICE_INTERFACE_RECORD_MINOR,\n };\n \n-static void *spice_audio_init(Audiodev *dev, Error **errp)\n-{\n- if (!using_spice) {\n- error_setg(errp, \"Cannot use spice audio without -spice\");\n- return NULL;\n- }\n-\n- return &spice_audio_init;\n-}\n-\n-static void spice_audio_fini (void *opaque)\n-{\n- /* nothing */\n-}\n-\n /* playback */\n \n static int line_out_init(HWVoiceOut *hw, struct audsettings *as,\n@@ -333,8 +335,6 @@ static struct audio_pcm_ops audio_callbacks = {\n \n static struct audio_driver spice_audio_driver = {\n .name = \"spice\",\n- .init = spice_audio_init,\n- .fini = spice_audio_fini,\n .pcm_ops = &audio_callbacks,\n .max_voices_out = 1,\n .max_voices_in = 1,\n","prefixes":["43/85"]}