{"id":2196859,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196859/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-77-e676662e4514@redhat.com>","date":"2026-02-16T11:16:06","name":"[77/85] audio: replace DEBUG_OUT with traces","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d2a2b2f09ea4c39e92bdba14d1017466454ade33","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-77-e676662e4514@redhat.com/mbox/","series":[{"id":492294,"url":"http://patchwork.ozlabs.org/api/1.0/series/492294/?format=json","date":"2026-02-16T11:14:52","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492294/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196859/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KDk73N0w;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0qV68TDz1xxy\n\tfor ; Mon, 16 Feb 2026 22:27:18 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrwfh-0000fr-S8; Mon, 16 Feb 2026 06:21:45 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwdQ-0008Kj-3t\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:19:25 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwdO-0008UU-J5\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:19:23 -0500","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-533-vPQv5zfANgG7zZ6iODK0HQ-1; Mon,\n 16 Feb 2026 06:19:17 -0500","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 911A2180047F; Mon, 16 Feb 2026 11:19:15 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id EE2E61800464; Mon, 16 Feb 2026 11:19:13 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240761;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=BB6jQvGRqbXD7hENVx2pNstNIc4pFnH7f/Xe+/sKYwo=;\n b=KDk73N0wRcuB5rHKrW+C2Im2WGKmYztpEaRaHhYvnDlEBdqo/kZYw/Zz4v/9WO7zs8QFT8\n 7hVJSzsCfm26zw3vYRoXngMCaDJWg6N23a+oqM0vpq7eXYHpXvLc8dyHQut6uK8v+sTwW2\n rPIKdkCFN95o461EV66oqGNQWYDgG3U=","X-MC-Unique":"vPQv5zfANgG7zZ6iODK0HQ-1","X-Mimecast-MFC-AGG-ID":"vPQv5zfANgG7zZ6iODK0HQ_1771240755","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 16 Feb 2026 12:16:06 +0100","Subject":"[PATCH 77/85] audio: replace DEBUG_OUT with traces","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-77-e676662e4514@redhat.com>","References":"<20260216-audio-v1-0-e676662e4514@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-e676662e4514@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , Eduardo Habkost ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n John Snow , Cleber Rosa ,\n Christian Schoenebeck ,\n Akihiko Odaki ,\n Thomas Huth , Alexandre Ratchov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Manos Pitsidianakis ,\n Alistair Francis ,\n \"Edgar E. Iglesias\" ,\n Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= ,\n Mark Cave-Ayland ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3777;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=b1klW4axY6twkEGfrheCi2WZdrVTpoIdzbMvZtSetFQ=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxSD1tB2iPbiDer/gUC7JJQHK122dd/DQiHS\n gGvw/JMRp2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UgAKCRDa6OEJdZac\n 5Qi4D/4kXQIy8DYZMN/lWGjcNjP2yxGx6bYOyUBlC6LUHkP6lmCwgKBMMJxvfkK52LPURJ76oAl\n doYlcUY3INlg0+gqnyafels7Du27ZnzlqbykSep+qMKAd5IT0A4vZzoyKogG8MWTmn+F0UUqlql\n RivjAWeT8DjNwFbNjUb+XU1Qr3KV092DKgjabnrW/B759kiskAA/e/HEz4B2i8/6i1+7tsBmaCX\n i7p2Dvu02Zin6B2O7pGq2TapCXQBdoaMV6NkqTTd4XpoUjlu6dAbgVw5u2KvkfT2xauUSl0y6TW\n HaTvsOB0ZCwc71ObqHWNYH+R8IBwyFenQf28NGrT/uhT5WACKHBywrYRLZH80iEvgKpw6JKMnuS\n EHilMeHUsB0Dh17FWNb3L1d2ddku3pCwB5a3D34EfnuG958UeKs4qNKgCXV2XdXrQexnqru8/oC\n fcRKLJ1cbNfeC8nqOefyAp1lbW38vQaaSveXukk6Z+ZIZMgQmWlI+MvbQbUxSiQLEikQVwOqDlR\n Nn6F+ehNer0rhvkCfIfwPwI7owWnHUpbx8pwYaMu19TInF3w75m0LJJHWz2OONGj4DO02aoFame\n gxl6N3oCnKaFHRIkIs2nlyeyMorEzPgmmtCi2AnaPemuNUzMJWNR9H23Fv5NKvu8ksrnlJmOuwn\n z189WHXkqsIdQ/g==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Marc-André Lureau \nReviewed-by: Mark Cave-Ayland \n---\n audio/audio-mixeng-be.c | 32 ++++++++------------------------\n audio/trace-events | 5 +++++\n 2 files changed, 13 insertions(+), 24 deletions(-)","diff":"diff --git a/audio/audio-mixeng-be.c b/audio/audio-mixeng-be.c\nindex 1963f3e5c79..3dd9d17dd25 100644\n--- a/audio/audio-mixeng-be.c\n+++ b/audio/audio-mixeng-be.c\n@@ -29,8 +29,6 @@\n #define AUDIO_CAP \"audio\"\n #include \"audio_int.h\"\n \n-/* #define DEBUG_OUT */\n-\n #define SW_NAME(sw) (sw)->name ? (sw)->name : \"unknown\"\n \n const struct mixeng_volume nominal_volume = {\n@@ -568,9 +566,7 @@ static size_t audio_pcm_sw_write(SWVoiceOut *sw, void *buf, size_t buf_len)\n }\n \n if (live == hw->mix_buf.size) {\n-#ifdef DEBUG_OUT\n- dolog (\"%s is full %zu\\n\", sw->name, live);\n-#endif\n+ trace_audio_out_full(sw->name, live);\n return 0;\n }\n \n@@ -618,15 +614,8 @@ static size_t audio_pcm_sw_write(SWVoiceOut *sw, void *buf, size_t buf_len)\n sw->resample_buf.pos = 0;\n }\n \n-#ifdef DEBUG_OUT\n- dolog (\n- \"%s: write size %zu written %zu total mixed %zu\\n\",\n- SW_NAME(sw),\n- buf_len / sw->info.bytes_per_frame,\n- total_in,\n- sw->total_hw_samples_mixed\n- );\n-#endif\n+ trace_audio_sw_write(SW_NAME(sw), buf_len / sw->info.bytes_per_frame,\n+ total_in, sw->total_hw_samples_mixed);\n \n return total_in * sw->info.bytes_per_frame;\n }\n@@ -900,10 +889,8 @@ static size_t audio_get_free(SWVoiceOut *sw)\n \n dead = sw->hw->mix_buf.size - live;\n \n-#ifdef DEBUG_OUT\n- dolog(\"%s: get_free live %zu dead %zu frontend frames %u\\n\",\n- SW_NAME(sw), live, dead, st_rate_frames_in(sw->rate, dead));\n-#endif\n+ trace_audio_get_free(SW_NAME(sw), live, dead,\n+ st_rate_frames_in(sw->rate, dead));\n \n return dead;\n }\n@@ -1058,9 +1045,8 @@ static void audio_run_out(AudioMixengBackend *s)\n \n if (hw->pending_disable && !nb_live) {\n SWVoiceCap *sc;\n-#ifdef DEBUG_OUT\n- dolog (\"Disabling voice\\n\");\n-#endif\n+\n+ trace_audio_out_disable();\n hw->enabled = false;\n hw->pending_disable = false;\n if (k->enable_out) {\n@@ -1089,9 +1075,7 @@ static void audio_run_out(AudioMixengBackend *s)\n hw->mix_buf.pos = 0;\n }\n \n-#ifdef DEBUG_OUT\n- dolog(\"played=%zu\\n\", played);\n-#endif\n+ trace_audio_out_played(played);\n \n if (played) {\n audio_capture_mix_and_clear (hw, prev_rpos, played);\ndiff --git a/audio/trace-events b/audio/trace-events\nindex 3f8ebf9c6cb..7a73d6eb84f 100644\n--- a/audio/trace-events\n+++ b/audio/trace-events\n@@ -65,6 +65,11 @@ audio_capture_attach(const char *name, bool active) \"capture %s active=%d\"\n audio_get_avail(const char *name, size_t live, uint32_t frontend_frames) \"%s: get_avail live %zu frontend frames %u\"\n audio_run_poll(const char *msg, int64_t elapsed_us) \"Elapsed since last %s: %\" PRId64 \" us\"\n audio_capture_free_sw(const char *name) \"freeing %s\"\n+audio_out_full(const char *name, size_t live) \"%s is full %zu\"\n+audio_sw_write(const char *name, size_t size, size_t written, size_t total_mixed) \"%s: write size %zu written %zu total mixed %zu\"\n+audio_get_free(const char *name, size_t live, size_t dead, uint32_t frontend_frames) \"%s: get_free live %zu dead %zu frontend frames %u\"\n+audio_out_disable(void) \"Disabling voice\"\n+audio_out_played(size_t played) \"played=%zu\"\n \n # audio_template.h\n audio_open_out(const char *name, int freq, int nchannels, int fmt) \"open %s, freq %d, nchannels %d, fmt %d\"\n","prefixes":["77/85"]}