{"id":2196858,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196858/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-71-e676662e4514@redhat.com>","date":"2026-02-16T11:16:00","name":"[71/85] audio/wav: replace custom logging with error_report","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3f761e42b27b44ab8d440511c4891679c5deef02","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-71-e676662e4514@redhat.com/mbox/","series":[{"id":492294,"url":"http://patchwork.ozlabs.org/api/1.0/series/492294/?format=json","date":"2026-02-16T11:14:52","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492294/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196858/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=I18eE5P0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0qV3H3Cz1xwF\n\tfor ; Mon, 16 Feb 2026 22:27:18 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrwfW-0007pL-TK; Mon, 16 Feb 2026 06:21:34 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwd9-0007Ur-5X\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:19:09 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwd7-0008R6-C7\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:19:06 -0500","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-457-wLzjMd9WOeuCX78ZAzILDg-1; Mon,\n 16 Feb 2026 06:19:00 -0500","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 24BAA1956089; Mon, 16 Feb 2026 11:18:58 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 29E7F30001A5; Mon, 16 Feb 2026 11:18:56 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240744;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=kcz5monBArNaXcY5PhEuW+EZzvnBJyzEr+NifJaMiTA=;\n b=I18eE5P0dTOHtgCARk8IHgIsw47vmnhku5Kc7JnFqud7AGjkew1MtEecUmKuIJ6FLVKDdm\n SmX7lp6T/9HApPpPt2M9dlyDoBLL5vt5aiTsKBUW40kjnUIw9fk74kCDXkeZb0U3s2jTDZ\n EhQR0StrH3QFK1ugCzd/Qa4xSt7vsqc=","X-MC-Unique":"wLzjMd9WOeuCX78ZAzILDg-1","X-Mimecast-MFC-AGG-ID":"wLzjMd9WOeuCX78ZAzILDg_1771240738","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 16 Feb 2026 12:16:00 +0100","Subject":"[PATCH 71/85] audio/wav: replace custom logging with error_report","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-71-e676662e4514@redhat.com>","References":"<20260216-audio-v1-0-e676662e4514@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-e676662e4514@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , Eduardo Habkost ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n John Snow , Cleber Rosa ,\n Christian Schoenebeck ,\n Akihiko Odaki ,\n Thomas Huth , Alexandre Ratchov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Manos Pitsidianakis ,\n Alistair Francis ,\n \"Edgar E. Iglesias\" ,\n Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= ,\n Thomas Huth ,\n Mark Cave-Ayland ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=3883;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=uy45aaxsrjikhNcoNvvFIYlxO1WkTxvpW/LgSnOpQeQ=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxRdF6doIYfytosh7z/TOgj7Eu7I/l0FEgOC\n OWyEbY3E0iJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UQAKCRDa6OEJdZac\n 5W1pD/4soLavWDJkIjW9wjtTAn9bFFjzpkpQvg+h/UkCj+CwRYP9f0ABzpzzvK4HJTji5IErsBq\n Cv+dYZem2stuwHwUe1EFktQY8EbQ/QK/kqB0rk7Owvn8RceUCp86sgYCIYS2Htyf/7Zdw+tfgiL\n jpPmGk2jU8RcFOUPqBEGBR+T0Xp1y82JAwP8pHSpNfeJyWs5QjYnNHR0uzXyJ4wfLQPHHFRl1hl\n TmP5fPtgFXJrl+nsbESW4cIKKnOGC7Omib/SitjBwGrfEIKJNzgzRxABSKZmq20CkMEvqjpjT8I\n V58YqecwLayd6LAup7KagI7NI2T45yKEk/J/64awhwg5xYIlVLnzmrmeCQ65apIWgcgne+5d8Du\n S9TWQ2fpZ54PegbRkddf07FcgEPSFvYp+GVyAgbbZHz41wzTZeuWGFgcg0XY6V2Cl4u/hzNK/67\n eNRlZvguytwYAt+R4ciluJ4qJT94ROktWWoZi1m83NX5LmC7N2ruQo2/aUb1ehNSjDUEZ04/99J\n xhzrd24T8aqQ2ZF+Pr7FCZ74U/mjh6/aQ7Y5VWRDYUfhlDilx66zZ4AdjkA8OtUzYMFFdUzGfqA\n 4Z87I8w5yrRi2uaw5ppeHGnKf3Lct4ysBmHMNDy+jT0TJ3+jzWtkn66yK666d8YvftCQBZDpmmv\n cKGDqaKhgfK1rGg==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Replace the custom audio logging infrastructure (dolog macro) with\nstandard QEMU error reporting (error_report).\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Thomas Huth \nReviewed-by: Mark Cave-Ayland \n---\n audio/wavaudio.c | 32 +++++++++++++-------------------\n 1 file changed, 13 insertions(+), 19 deletions(-)","diff":"diff --git a/audio/wavaudio.c b/audio/wavaudio.c\nindex ade8fd1d8c3..eed1e501af0 100644\n--- a/audio/wavaudio.c\n+++ b/audio/wavaudio.c\n@@ -24,10 +24,10 @@\n \n #include \"qemu/osdep.h\"\n #include \"qemu/module.h\"\n+#include \"qemu/error-report.h\"\n #include \"qemu/audio.h\"\n #include \"qom/object.h\"\n \n-#define AUDIO_CAP \"wav\"\n #include \"audio_int.h\"\n \n #define TYPE_AUDIO_WAV \"audio-wav\"\n@@ -51,8 +51,8 @@ static size_t wav_write_out(HWVoiceOut *hw, void *buf, size_t len)\n assert(bytes % hw->info.bytes_per_frame == 0);\n \n if (bytes && fwrite(buf, bytes, 1, wav->f) != 1) {\n- dolog(\"wav_write_out: fwrite of %\" PRId64 \" bytes failed\\nReason: %s\\n\",\n- bytes, strerror(errno));\n+ error_report(\"wav: fwrite of %\" PRId64 \" bytes failed: %s\",\n+ bytes, strerror(errno));\n }\n \n wav->total_samples += bytes / hw->info.bytes_per_frame;\n@@ -98,11 +98,11 @@ static int wav_init_out(HWVoiceOut *hw, struct audsettings *as)\n \n case AUDIO_FORMAT_S32:\n case AUDIO_FORMAT_U32:\n- dolog (\"WAVE files can not handle 32bit formats\\n\");\n+ error_report(\"wav: WAVE files cannot handle 32-bit formats\");\n return -1;\n \n case AUDIO_FORMAT_F32:\n- dolog(\"WAVE files can not handle float formats\\n\");\n+ error_report(\"wav: WAVE files cannot handle float formats\");\n return -1;\n \n default:\n@@ -122,14 +122,13 @@ static int wav_init_out(HWVoiceOut *hw, struct audsettings *as)\n \n wav->f = fopen(wav_path, \"wb\");\n if (!wav->f) {\n- dolog (\"Failed to open wave file `%s'\\nReason: %s\\n\",\n- wav_path, strerror(errno));\n+ error_report(\"wav: failed to open wave file '%s': %s\",\n+ wav_path, strerror(errno));\n return -1;\n }\n \n if (fwrite (hdr, sizeof (hdr), 1, wav->f) != 1) {\n- dolog (\"wav_init_out: failed to write header\\nReason: %s\\n\",\n- strerror(errno));\n+ error_report(\"wav: failed to write header: %s\", strerror(errno));\n return -1;\n }\n \n@@ -153,30 +152,25 @@ static void wav_fini_out (HWVoiceOut *hw)\n le_store (dlen, datalen, 4);\n \n if (fseek (wav->f, 4, SEEK_SET)) {\n- dolog (\"wav_fini_out: fseek to rlen failed\\nReason: %s\\n\",\n- strerror(errno));\n+ error_report(\"wav: fseek to rlen failed: %s\", strerror(errno));\n goto doclose;\n }\n if (fwrite (rlen, 4, 1, wav->f) != 1) {\n- dolog (\"wav_fini_out: failed to write rlen\\nReason: %s\\n\",\n- strerror (errno));\n+ error_report(\"wav: failed to write rlen: %s\", strerror(errno));\n goto doclose;\n }\n if (fseek (wav->f, 32, SEEK_CUR)) {\n- dolog (\"wav_fini_out: fseek to dlen failed\\nReason: %s\\n\",\n- strerror (errno));\n+ error_report(\"wav: fseek to dlen failed: %s\", strerror(errno));\n goto doclose;\n }\n if (fwrite (dlen, 4, 1, wav->f) != 1) {\n- dolog (\"wav_fini_out: failed to write dlen\\nReaons: %s\\n\",\n- strerror (errno));\n+ error_report(\"wav: failed to write dlen: %s\", strerror(errno));\n goto doclose;\n }\n \n doclose:\n if (fclose (wav->f)) {\n- dolog (\"wav_fini_out: fclose %p failed\\nReason: %s\\n\",\n- wav->f, strerror (errno));\n+ error_report(\"wav: fclose failed: %s\", strerror(errno));\n }\n wav->f = NULL;\n }\n","prefixes":["71/85"]}