{"id":2196851,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196851/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-49-e676662e4514@redhat.com>","date":"2026-02-16T11:15:38","name":"[49/85] audio/sdl: convert to QOM lifecycle methods","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0ea52469f865ce1e05ab5758644ae033ed66ccdc","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-49-e676662e4514@redhat.com/mbox/","series":[{"id":492294,"url":"http://patchwork.ozlabs.org/api/1.0/series/492294/?format=json","date":"2026-02-16T11:14:52","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492294/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196851/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=WfV4v4v8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0pR0V5dz1xwF\n\tfor ; Mon, 16 Feb 2026 22:26:23 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrwfb-0008Ue-Ok; Mon, 16 Feb 2026 06:21:39 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwc8-0006RL-0I\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:07 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwc6-0008An-5g\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:03 -0500","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-459-P-tWzq9TPfiVszLycTCsUA-1; Mon,\n 16 Feb 2026 06:17:57 -0500","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 5E8791800259; Mon, 16 Feb 2026 11:17:55 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 9FDFB30001A5; Mon, 16 Feb 2026 11:17:54 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240681;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=5Rp8fyVkH2hZh+mPHtPSd3g8yoblH6WdY9/V5EDNhAE=;\n b=WfV4v4v8Niw6d3blMMx0HcMqYe4o5d1b/OnIQ9KfhjsDO5rDvEdbjogCq5ogeYwbdlNn/w\n EMok9dP48pzXM/vlkovneo+1lVA66UemkaUEU11H70AYBZemtu3/dOtWtDpm7PHhu4MSv7\n niJNQ/LHBdw4Bz5K2brF3aWOozsW/gk=","X-MC-Unique":"P-tWzq9TPfiVszLycTCsUA-1","X-Mimecast-MFC-AGG-ID":"P-tWzq9TPfiVszLycTCsUA_1771240675","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 16 Feb 2026 12:15:38 +0100","Subject":"[PATCH 49/85] audio/sdl: convert to QOM lifecycle methods","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-49-e676662e4514@redhat.com>","References":"<20260216-audio-v1-0-e676662e4514@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-e676662e4514@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , Eduardo Habkost ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n John Snow , Cleber Rosa ,\n Christian Schoenebeck ,\n Akihiko Odaki ,\n Thomas Huth , Alexandre Ratchov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Manos Pitsidianakis ,\n Alistair Francis ,\n \"Edgar E. Iglesias\" ,\n Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= ,\n Mark Cave-Ayland ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=4088;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=Bi9IEy+nlgFFCt8QlBx2RYdWyux3lXAtO/gg3ozTayY=;\n b=owEBbAKT/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxQtE3m5hY51mQAQrSKdZIBcmYjmT5YyP8cp\n vUMuz6qBp6JAjIEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UAAKCRDa6OEJdZac\n 5ROQD/dzAu4kQRBZiOoqG5a4TEY5nm127pGZega2hSBFiRQ5Ep3ZEB96xPTxG+kJoi6VHCY/T9I\n P0JxTrt2PellSi0S5ZPNSE6w+hy2YdSgVTsq1dRLcoNBT4wix6puI7qRp/8xs5ksDvYeGB+77NP\n hJ49mk3KxmBClm1/nJzrdZoG1gff3cVoPMapiEo4CxA6BpNyiz0FXrU83O240Ww1Iu9yliK908P\n W4z70Y+vG+c65ZlyXgEKJKqJZBmYZ4HN8K2c8yrBzxSe3Qh+1UBtz8usuKC9VwAthWT0iB/qtWI\n tVNitn6TMUkr7+d7grRKcJCxiyfNmLmU7i81ctLXoAtKmqgoY5Js0ajXZxl75IHyP0PG4A4uesd\n eLUECuz2FuOFkA4rii9YbVLUtB9QBCkw5AxtS1imhNm8/B0sFxUxCkAHAmZUEdoEMsl/uDQ/tgX\n bZRn5UkR4QwjOiwME9j+IywHiLJKMWrN/Z5leTLj3tXHUYD4voY0hmlgsQjxqRN5AOJIxuR1ybg\n cZVtsini+XZklQPGJW+Ei1SjOdsNBmlnK/nCyPDEw+N9lNgFlBPo4eUv1TROTnbTxe5GlTgp94q\n e5cL85CnhCLssitegN/Bsl28ADaGJqfKGOkam+a6V6xHQHvcgfBC+IYN0yzteFim5DUe9GnewOB\n TfaORBqIzmdtT","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Migrate the SDL audio backend from the legacy driver init/fini\ncallbacks to proper QOM realize and finalize methods.\n\nThe sdl_audio_init() function is replaced with audio_sdl_realize(),\nwhich initializes the SDL audio subsystem before delegating to the\nparent class realize method. The sdl_audio_fini() is replaced with\naudio_sdl_finalize() to properly clean up the SDL audio subsystem.\n\nAccess to the Audiodev is now through hw->s->dev instead of the\ndrv_opaque pointer.\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Mark Cave-Ayland \n---\n audio/sdlaudio.c | 40 +++++++++++++++++++++++-----------------\n 1 file changed, 23 insertions(+), 17 deletions(-)","diff":"diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c\nindex a60b1629da0..0dfa3100828 100644\n--- a/audio/sdlaudio.c\n+++ b/audio/sdlaudio.c\n@@ -44,19 +44,14 @@\n #define TYPE_AUDIO_SDL \"audio-sdl\"\n OBJECT_DECLARE_SIMPLE_TYPE(AudioSdl, AUDIO_SDL)\n \n+static AudioBackendClass *audio_sdl_parent_class;\n+\n struct AudioSdl {\n AudioMixengBackend parent_obj;\n };\n \n static struct audio_driver sdl_audio_driver;\n \n-static void audio_sdl_class_init(ObjectClass *klass, const void *data)\n-{\n- AudioMixengBackendClass *k = AUDIO_MIXENG_BACKEND_CLASS(klass);\n-\n- k->driver = &sdl_audio_driver;\n-}\n-\n typedef struct SDLVoiceOut {\n HWVoiceOut hw;\n int exit;\n@@ -356,7 +351,7 @@ static int sdl_init_out(HWVoiceOut *hw, struct audsettings *as,\n SDLVoiceOut *sdl = (SDLVoiceOut *)hw;\n SDL_AudioSpec req, obt;\n int err;\n- Audiodev *dev = drv_opaque;\n+ Audiodev *dev = hw->s->dev;\n AudiodevSdlPerDirectionOptions *spdo = dev->u.sdl.out;\n struct audsettings obt_as;\n \n@@ -412,7 +407,7 @@ static int sdl_init_in(HWVoiceIn *hw, audsettings *as, void *drv_opaque)\n SDLVoiceIn *sdl = (SDLVoiceIn *)hw;\n SDL_AudioSpec req, obt;\n int err;\n- Audiodev *dev = drv_opaque;\n+ Audiodev *dev = hw->s->dev;\n AudiodevSdlPerDirectionOptions *spdo = dev->u.sdl.in;\n struct audsettings obt_as;\n \n@@ -459,19 +454,20 @@ static void sdl_enable_in(HWVoiceIn *hw, bool enable)\n SDL_PauseAudioDevice(sdl->devid, !enable);\n }\n \n-static void *sdl_audio_init(Audiodev *dev, Error **errp)\n+static bool audio_sdl_realize(AudioBackend *abe, Audiodev *dev, Error **errp)\n {\n- if (SDL_InitSubSystem (SDL_INIT_AUDIO)) {\n+ if (SDL_InitSubSystem(SDL_INIT_AUDIO)) {\n error_setg(errp, \"SDL failed to initialize audio subsystem\");\n- return NULL;\n+ qapi_free_Audiodev(dev);\n+ return false;\n }\n \n- return dev;\n+ return audio_sdl_parent_class->realize(abe, dev, errp);\n }\n \n-static void sdl_audio_fini (void *opaque)\n+static void audio_sdl_finalize(Object *obj)\n {\n- SDL_QuitSubSystem (SDL_INIT_AUDIO);\n+ SDL_QuitSubSystem(SDL_INIT_AUDIO);\n }\n \n static struct audio_pcm_ops sdl_pcm_ops = {\n@@ -499,8 +495,6 @@ static struct audio_pcm_ops sdl_pcm_ops = {\n \n static struct audio_driver sdl_audio_driver = {\n .name = \"sdl\",\n- .init = sdl_audio_init,\n- .fini = sdl_audio_fini,\n .pcm_ops = &sdl_pcm_ops,\n .max_voices_out = INT_MAX,\n .max_voices_in = INT_MAX,\n@@ -508,12 +502,24 @@ static struct audio_driver sdl_audio_driver = {\n .voice_size_in = sizeof(SDLVoiceIn),\n };\n \n+static void audio_sdl_class_init(ObjectClass *klass, const void *data)\n+{\n+ AudioBackendClass *b = AUDIO_BACKEND_CLASS(klass);\n+ AudioMixengBackendClass *k = AUDIO_MIXENG_BACKEND_CLASS(klass);\n+\n+ audio_sdl_parent_class = AUDIO_BACKEND_CLASS(object_class_get_parent(klass));\n+\n+ b->realize = audio_sdl_realize;\n+ k->driver = &sdl_audio_driver;\n+}\n+\n static const TypeInfo audio_types[] = {\n {\n .name = TYPE_AUDIO_SDL,\n .parent = TYPE_AUDIO_MIXENG_BACKEND,\n .instance_size = sizeof(AudioSdl),\n .class_init = audio_sdl_class_init,\n+ .instance_finalize = audio_sdl_finalize,\n },\n };\n \n","prefixes":["49/85"]}