{"id":2196843,"url":"http://patchwork.ozlabs.org/api/1.0/patches/2196843/?format=json","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.0/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260216-audio-v1-66-e676662e4514@redhat.com>","date":"2026-02-16T11:15:55","name":"[66/85] audio/pa: replace custom logging with report & trace","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b22369e11ecf83506984690533947a36a519a07e","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/1.0/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260216-audio-v1-66-e676662e4514@redhat.com/mbox/","series":[{"id":492294,"url":"http://patchwork.ozlabs.org/api/1.0/series/492294/?format=json","date":"2026-02-16T11:14:52","name":"audio: cleanups & add a manual test","version":1,"mbox":"http://patchwork.ozlabs.org/series/492294/mbox/"}],"check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2196843/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=QzA3BNd1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fF0p02THsz1xwF\n\tfor ; Mon, 16 Feb 2026 22:26:00 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1vrwfl-00013m-AY; Mon, 16 Feb 2026 06:21:49 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwcu-0007LB-66\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:56 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1vrwcr-0008OL-Gf\n for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:51 -0500","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-zJtL5P6jP1Csz4OKR2yq9Q-1; Mon,\n 16 Feb 2026 06:18:45 -0500","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id F396918005B7; Mon, 16 Feb 2026 11:18:43 +0000 (UTC)","from localhost (unknown [10.45.242.26])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 3E21530001B9; Mon, 16 Feb 2026 11:18:43 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1771240728;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=XVi8lBbZ0x6d3H1xMhZZ9DSsdXtKNj+ngko1jxe7z6A=;\n b=QzA3BNd1PQwOqe8LicCQnAz+j4PquGT/BRLddV4LWYmqhzy3srDe/nZxf9MVTIn66zBcD3\n vFxaHh9SyyneLh1DnkDovBnYrwWrz7Q9SFHkSutGenO4M0QIV1IalS0NCt6lkIkKkugBWC\n sEyv/SjVZJXmkzUUmwy2l2dm/f6ncLA=","X-MC-Unique":"zJtL5P6jP1Csz4OKR2yq9Q-1","X-Mimecast-MFC-AGG-ID":"zJtL5P6jP1Csz4OKR2yq9Q_1771240724","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Mon, 16 Feb 2026 12:15:55 +0100","Subject":"[PATCH 66/85] audio/pa: replace custom logging with report & trace","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260216-audio-v1-66-e676662e4514@redhat.com>","References":"<20260216-audio-v1-0-e676662e4514@redhat.com>","In-Reply-To":"<20260216-audio-v1-0-e676662e4514@redhat.com>","To":"qemu-devel@nongnu.org","Cc":"Gerd Hoffmann , Eduardo Habkost ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Phil?=\n\t=?utf-8?q?ippe_Mathieu-Daud=C3=A9?= ,\n John Snow , Cleber Rosa ,\n Christian Schoenebeck ,\n Akihiko Odaki ,\n Thomas Huth , Alexandre Ratchov ,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Manos Pitsidianakis ,\n Alistair Francis ,\n \"Edgar E. Iglesias\" ,\n Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?M?=\n\t=?utf-8?q?arc-Andr=C3=A9_Lureau?= ,\n Mark Cave-Ayland ","X-Developer-Signature":"v=1; a=openpgp-sha256; l=12351;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=JVY/WEAWBXacb1I5A+f54VMSEuURH3uia0ld/lulY3A=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxRy2drI2ApEGZky9utC6vxFX2Qq7hWFM0w1\n gQGbw0SCvSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UQAKCRDa6OEJdZac\n 5UDQD/48AuiOLZKP52JlrfEGLAKncJplORzeyFMSjsEljNCsEY7pGmUB2Bcxuv/54n0wFjdJK0J\n eWKKFtEyMKMUJGdcMKAzrpL1mCayluCXO6n58vJxFMN+VWhR6yz33Gtn9gKdDQ6rdcuzdIrpsrW\n lTUkjSRw74/Jx3bIIRwzSzv/fm69unL482SUJp0xuK1ug51cy7rJV9SynQsYo1m1WmlzdqzgxYB\n zCwRAzYkSyuNVk7QJZf9RstGDJK3DO/Q0IfKUD727aFukJgvfqkhSVfgk+cRL37wrvt5DC9My1f\n K6dBQrs9KdtW3R8OFxOD8WrDk7LuiRVWen552brdjOkixBiRwQM3vccTirhm6LoLtW0qwoKHlHA\n SiN2QjGnUkfgbEXJgdJrPCIY+bzWeY6UYxsxpVd772gevm1SnDNrG/gqJfPqMNDKQUHv+UsipXm\n 09a/6iWWrY8aKmo/iq+mjuiwt4T7M8+PD7gscF9Cwr0lOh2ph09fxhmGABXn9+WjIL2iPSl2Deq\n Duh7hrc8lutuORf/wc3E306CEJcUxNJkyVBV8wMs03x34fTjH1aH257eAup//OJNh7mTjlFqIar\n ZxxJPLxs+VAP2VzZu2NedpZYmuP57JHHP4kG5Boxo+epjdfqJkKecMhTvOMM1vwbgfPdRtS5mze\n RYpJOv2Ynod6oNQ==","X-Developer-Key":"i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Replace the custom audio logging infrastructure with standard QEMU\nerror reporting and tracing.\n\nqpa_conn_init() is called during audio_pa_realize() and already reports\nan error through Error *.\n\nSigned-off-by: Marc-André Lureau \nReviewed-by: Mark Cave-Ayland \n---\n audio/paaudio.c | 77 ++++++++++++++++++++++++++++-----------------------------\n 1 file changed, 38 insertions(+), 39 deletions(-)","diff":"diff --git a/audio/paaudio.c b/audio/paaudio.c\nindex b7826402e12..1501b26386a 100644\n--- a/audio/paaudio.c\n+++ b/audio/paaudio.c\n@@ -3,14 +3,13 @@\n #include \"qemu/osdep.h\"\n #include \"qemu/module.h\"\n #include \"qemu/audio.h\"\n+#include \"qemu/error-report.h\"\n #include \"qapi/error.h\"\n #include \"qom/object.h\"\n+#include \"audio_int.h\"\n \n #include \n \n-#define AUDIO_CAP \"pulseaudio\"\n-#include \"audio_int.h\"\n-\n #define TYPE_AUDIO_PA \"audio-pa\"\n OBJECT_DECLARE_SIMPLE_TYPE(AudioPa, AUDIO_PA)\n \n@@ -51,15 +50,16 @@ typedef struct {\n \n static void qpa_conn_fini(PAConnection *c);\n \n-static void G_GNUC_PRINTF (2, 3) qpa_logerr (int err, const char *fmt, ...)\n+static void G_GNUC_PRINTF(2, 3) qpa_logerr(int err, const char *fmt, ...)\n {\n va_list ap;\n \n- va_start (ap, fmt);\n- AUD_vlog (AUDIO_CAP, fmt, ap);\n- va_end (ap);\n+ error_printf(\"pulseaudio: \");\n+ va_start(ap, fmt);\n+ error_vprintf(fmt, ap);\n+ va_end(ap);\n \n- AUD_log (AUDIO_CAP, \"Reason: %s\\n\", pa_strerror (err));\n+ error_printf(\" Reason: %s\\n\", pa_strerror(err));\n }\n \n #ifndef PA_CONTEXT_IS_GOOD\n@@ -113,12 +113,12 @@ static void *qpa_get_buffer_in(HWVoiceIn *hw, size_t *size)\n pa_threaded_mainloop_lock(c->mainloop);\n \n CHECK_DEAD_GOTO(c, p->stream, unlock_and_fail,\n- \"pa_threaded_mainloop_lock failed\\n\");\n+ \"pa_threaded_mainloop_lock failed\");\n \n if (!p->read_length) {\n r = pa_stream_peek(p->stream, &p->read_data, &p->read_length);\n CHECK_SUCCESS_GOTO(c, r == 0, unlock_and_fail,\n- \"pa_stream_peek failed\\n\");\n+ \"pa_stream_peek failed\");\n }\n \n *size = MIN(p->read_length, *size);\n@@ -141,7 +141,7 @@ static void qpa_put_buffer_in(HWVoiceIn *hw, void *buf, size_t size)\n pa_threaded_mainloop_lock(c->mainloop);\n \n CHECK_DEAD_GOTO(c, p->stream, unlock,\n- \"pa_threaded_mainloop_lock failed\\n\");\n+ \"pa_threaded_mainloop_lock failed\");\n \n assert(buf == p->read_data && size <= p->read_length);\n \n@@ -150,7 +150,7 @@ static void qpa_put_buffer_in(HWVoiceIn *hw, void *buf, size_t size)\n \n if (size && !p->read_length) {\n r = pa_stream_drop(p->stream);\n- CHECK_SUCCESS_GOTO(c, r == 0, unlock, \"pa_stream_drop failed\\n\");\n+ CHECK_SUCCESS_GOTO(c, r == 0, unlock, \"pa_stream_drop failed\");\n }\n \n unlock:\n@@ -166,7 +166,7 @@ static size_t qpa_read(HWVoiceIn *hw, void *data, size_t length)\n pa_threaded_mainloop_lock(c->mainloop);\n \n CHECK_DEAD_GOTO(c, p->stream, unlock_and_fail,\n- \"pa_threaded_mainloop_lock failed\\n\");\n+ \"pa_threaded_mainloop_lock failed\");\n if (pa_stream_get_state(p->stream) != PA_STREAM_READY) {\n /* wait for stream to become ready */\n goto unlock;\n@@ -179,7 +179,7 @@ static size_t qpa_read(HWVoiceIn *hw, void *data, size_t length)\n if (!p->read_length) {\n r = pa_stream_peek(p->stream, &p->read_data, &p->read_length);\n CHECK_SUCCESS_GOTO(c, r == 0, unlock_and_fail,\n- \"pa_stream_peek failed\\n\");\n+ \"pa_stream_peek failed\");\n if (!p->read_length) {\n /* buffer is empty */\n break;\n@@ -196,7 +196,7 @@ static size_t qpa_read(HWVoiceIn *hw, void *data, size_t length)\n if (!p->read_length) {\n r = pa_stream_drop(p->stream);\n CHECK_SUCCESS_GOTO(c, r == 0, unlock_and_fail,\n- \"pa_stream_drop failed\\n\");\n+ \"pa_stream_drop failed\");\n }\n }\n \n@@ -218,7 +218,7 @@ static size_t qpa_buffer_get_free(HWVoiceOut *hw)\n pa_threaded_mainloop_lock(c->mainloop);\n \n CHECK_DEAD_GOTO(c, p->stream, unlock_and_fail,\n- \"pa_threaded_mainloop_lock failed\\n\");\n+ \"pa_threaded_mainloop_lock failed\");\n if (pa_stream_get_state(p->stream) != PA_STREAM_READY) {\n /* wait for stream to become ready */\n l = 0;\n@@ -227,7 +227,7 @@ static size_t qpa_buffer_get_free(HWVoiceOut *hw)\n \n l = pa_stream_writable_size(p->stream);\n CHECK_SUCCESS_GOTO(c, l != (size_t) -1, unlock_and_fail,\n- \"pa_stream_writable_size failed\\n\");\n+ \"pa_stream_writable_size failed\");\n \n unlock:\n pa_threaded_mainloop_unlock(c->mainloop);\n@@ -248,12 +248,12 @@ static void *qpa_get_buffer_out(HWVoiceOut *hw, size_t *size)\n pa_threaded_mainloop_lock(c->mainloop);\n \n CHECK_DEAD_GOTO(c, p->stream, unlock_and_fail,\n- \"pa_threaded_mainloop_lock failed\\n\");\n+ \"pa_threaded_mainloop_lock failed\");\n \n *size = -1;\n r = pa_stream_begin_write(p->stream, &ret, size);\n CHECK_SUCCESS_GOTO(c, r >= 0, unlock_and_fail,\n- \"pa_stream_begin_write failed\\n\");\n+ \"pa_stream_begin_write failed\");\n \n pa_threaded_mainloop_unlock(c->mainloop);\n return ret;\n@@ -273,10 +273,10 @@ static size_t qpa_put_buffer_out(HWVoiceOut *hw, void *data, size_t length)\n pa_threaded_mainloop_lock(c->mainloop);\n \n CHECK_DEAD_GOTO(c, p->stream, unlock_and_fail,\n- \"pa_threaded_mainloop_lock failed\\n\");\n+ \"pa_threaded_mainloop_lock failed\");\n \n r = pa_stream_write(p->stream, data, length, NULL, 0LL, PA_SEEK_RELATIVE);\n- CHECK_SUCCESS_GOTO(c, r >= 0, unlock_and_fail, \"pa_stream_write failed\\n\");\n+ CHECK_SUCCESS_GOTO(c, r >= 0, unlock_and_fail, \"pa_stream_write failed\");\n \n pa_threaded_mainloop_unlock(c->mainloop);\n return length;\n@@ -296,7 +296,7 @@ static size_t qpa_write(HWVoiceOut *hw, void *data, size_t length)\n pa_threaded_mainloop_lock(c->mainloop);\n \n CHECK_DEAD_GOTO(c, p->stream, unlock_and_fail,\n- \"pa_threaded_mainloop_lock failed\\n\");\n+ \"pa_threaded_mainloop_lock failed\");\n if (pa_stream_get_state(p->stream) != PA_STREAM_READY) {\n /* wait for stream to become ready */\n l = 0;\n@@ -306,14 +306,14 @@ static size_t qpa_write(HWVoiceOut *hw, void *data, size_t length)\n l = pa_stream_writable_size(p->stream);\n \n CHECK_SUCCESS_GOTO(c, l != (size_t) -1, unlock_and_fail,\n- \"pa_stream_writable_size failed\\n\");\n+ \"pa_stream_writable_size failed\");\n \n if (l > length) {\n l = length;\n }\n \n r = pa_stream_write(p->stream, data, l, NULL, 0LL, PA_SEEK_RELATIVE);\n- CHECK_SUCCESS_GOTO(c, r >= 0, unlock_and_fail, \"pa_stream_write failed\\n\");\n+ CHECK_SUCCESS_GOTO(c, r >= 0, unlock_and_fail, \"pa_stream_write failed\");\n \n unlock:\n pa_threaded_mainloop_unlock(c->mainloop);\n@@ -345,7 +345,7 @@ static pa_sample_format_t audfmt_to_pa(AudioFormat afmt, bool big_endian)\n format = big_endian ? PA_SAMPLE_FLOAT32BE : PA_SAMPLE_FLOAT32LE;\n break;\n default:\n- dolog (\"Internal logic error: Bad audio format %d\\n\", afmt);\n+ error_report(\"pulseaudio: Internal logic error: Bad audio format %d\", afmt);\n format = PA_SAMPLE_U8;\n break;\n }\n@@ -376,12 +376,12 @@ static AudioFormat pa_to_audfmt (pa_sample_format_t fmt, int *endianness)\n *endianness = 0;\n return AUDIO_FORMAT_F32;\n default:\n- dolog (\"Internal logic error: Bad pa_sample_format %d\\n\", fmt);\n+ error_report(\"pulseaudio: Internal logic error: Bad pa_sample_format %d\", fmt);\n return AUDIO_FORMAT_U8;\n }\n }\n \n-static void context_state_cb (pa_context *c, void *userdata)\n+static void context_state_cb(pa_context *c, void *userdata)\n {\n PAConnection *conn = userdata;\n \n@@ -473,7 +473,7 @@ static pa_stream *qpa_simple_new (\n break;\n \n default:\n- dolog(\"Internal error: unsupported channel count %d\\n\", ss->channels);\n+ error_report(\"pulseaudio: unsupported channel count %d\", ss->channels);\n goto fail;\n }\n \n@@ -553,7 +553,7 @@ static int qpa_init_out(HWVoiceOut *hw, struct audsettings *as)\n &error\n );\n if (!pa->stream) {\n- qpa_logerr (error, \"pa_simple_new for playback failed\\n\");\n+ qpa_logerr(error, \"pa_simple_new for playback failed\");\n goto fail1;\n }\n \n@@ -604,7 +604,7 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsettings *as)\n &error\n );\n if (!pa->stream) {\n- qpa_logerr (error, \"pa_simple_new for capture failed\\n\");\n+ qpa_logerr(error, \"pa_simple_new for capture failed\");\n goto fail1;\n }\n \n@@ -633,7 +633,7 @@ static void qpa_simple_disconnect(PAConnection *c, pa_stream *stream)\n \n err = pa_stream_disconnect(stream);\n if (err != 0) {\n- dolog(\"Failed to disconnect! err=%d\\n\", err);\n+ error_report(\"pulseaudio: Failed to disconnect! err=%d\", err);\n }\n pa_stream_unref(stream);\n }\n@@ -664,7 +664,7 @@ static void qpa_fini_in (HWVoiceIn *hw)\n int r = pa_stream_drop(pa->stream);\n if (r) {\n qpa_logerr(pa_context_errno(c->context),\n- \"pa_stream_drop failed\\n\");\n+ \"pa_stream_drop failed\");\n }\n pa->read_length = 0;\n }\n@@ -698,7 +698,7 @@ static void qpa_volume_out(HWVoiceOut *hw, Volume *vol)\n &v, NULL, NULL);\n if (!op) {\n qpa_logerr(pa_context_errno(c->context),\n- \"set_sink_input_volume() failed\\n\");\n+ \"set_sink_input_volume() failed\");\n } else {\n pa_operation_unref(op);\n }\n@@ -708,7 +708,7 @@ static void qpa_volume_out(HWVoiceOut *hw, Volume *vol)\n vol->mute, NULL, NULL);\n if (!op) {\n qpa_logerr(pa_context_errno(c->context),\n- \"set_sink_input_mute() failed\\n\");\n+ \"set_sink_input_mute() failed\");\n } else {\n pa_operation_unref(op);\n }\n@@ -740,7 +740,7 @@ static void qpa_volume_in(HWVoiceIn *hw, Volume *vol)\n &v, NULL, NULL);\n if (!op) {\n qpa_logerr(pa_context_errno(c->context),\n- \"set_source_output_volume() failed\\n\");\n+ \"set_source_output_volume() failed\");\n } else {\n pa_operation_unref(op);\n }\n@@ -750,7 +750,7 @@ static void qpa_volume_in(HWVoiceIn *hw, Volume *vol)\n vol->mute, NULL, NULL);\n if (!op) {\n qpa_logerr(pa_context_errno(c->context),\n- \"set_source_output_mute() failed\\n\");\n+ \"set_source_output_mute() failed\");\n } else {\n pa_operation_unref(op);\n }\n@@ -788,7 +788,7 @@ static void *qpa_conn_init(const char *server)\n \n if (pa_context_connect(c->context, server, 0, NULL) < 0) {\n qpa_logerr(pa_context_errno(c->context),\n- \"pa_context_connect() failed\\n\");\n+ \"pa_context_connect() failed\");\n goto fail;\n }\n \n@@ -809,7 +809,7 @@ static void *qpa_conn_init(const char *server)\n \n if (!PA_CONTEXT_IS_GOOD(state)) {\n qpa_logerr(pa_context_errno(c->context),\n- \"Wrong context state\\n\");\n+ \"Wrong context state\");\n goto unlock_and_fail;\n }\n \n@@ -823,7 +823,6 @@ static void *qpa_conn_init(const char *server)\n unlock_and_fail:\n pa_threaded_mainloop_unlock(c->mainloop);\n fail:\n- AUD_log (AUDIO_CAP, \"Failed to initialize PA context\");\n qpa_conn_fini(c);\n return NULL;\n }\n","prefixes":["66/85"]}